[jira] [Commented] (PHOENIX-7168) Remove shaded protobuf from shaded connector JARs
[ https://issues.apache.org/jira/browse/PHOENIX-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805114#comment-17805114 ] ASF GitHub Bot commented on PHOENIX-7168: - stoty closed pull request #128: PHOENIX-7168 Remove shaded protobuf from shaded connector JARs URL: https://github.com/apache/phoenix-connectors/pull/128 > Remove shaded protobuf from shaded connector JARs > - > > Key: PHOENIX-7168 > URL: https://issues.apache.org/jira/browse/PHOENIX-7168 > Project: Phoenix > Issue Type: Bug > Components: connectors, hive-connector, spark-connector >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Minor > > We redundantly add the relocated protobuf 2.5.0 classes to the shaded JARs. > It shouldn't cause iusses, as the relocation is identical to the one in > hbase-shaded-client and friends, but it's bad practice to duplicate classes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7168) Remove shaded protobuf from shaded connector JARs
[ https://issues.apache.org/jira/browse/PHOENIX-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805115#comment-17805115 ] ASF GitHub Bot commented on PHOENIX-7168: - stoty commented on PR #128: URL: https://github.com/apache/phoenix-connectors/pull/128#issuecomment-1884781181 merged manually > Remove shaded protobuf from shaded connector JARs > - > > Key: PHOENIX-7168 > URL: https://issues.apache.org/jira/browse/PHOENIX-7168 > Project: Phoenix > Issue Type: Bug > Components: connectors, hive-connector, spark-connector >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Minor > > We redundantly add the relocated protobuf 2.5.0 classes to the shaded JARs. > It shouldn't cause iusses, as the relocation is identical to the one in > hbase-shaded-client and friends, but it's bad practice to duplicate classes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7168) Remove shaded protobuf from shaded connector JARs
[ https://issues.apache.org/jira/browse/PHOENIX-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805004#comment-17805004 ] ASF GitHub Bot commented on PHOENIX-7168: - stoty commented on PR #128: URL: https://github.com/apache/phoenix-connectors/pull/128#issuecomment-1884347632 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 24s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 10m 15s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 7s | root in master failed. | | -1 :x: | compile | 0m 10s | phoenix5-hive-shaded in master failed. | | -1 :x: | compile | 0m 9s | phoenix5-spark3-shaded in master failed. | | -1 :x: | compile | 0m 7s | phoenix5-spark-shaded in master failed. | | -1 :x: | javadoc | 0m 6s | phoenix5-hive-shaded in master failed. | | -1 :x: | javadoc | 0m 5s | phoenix5-spark3-shaded in master failed. | | -1 :x: | javadoc | 0m 5s | phoenix5-spark-shaded in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 5s | root in the patch failed. | | -1 :x: | compile | 0m 6s | phoenix5-hive-shaded in the patch failed. | | -1 :x: | compile | 0m 5s | phoenix5-spark3-shaded in the patch failed. | | -1 :x: | compile | 0m 6s | phoenix5-spark-shaded in the patch failed. | | -1 :x: | javac | 0m 6s | phoenix5-hive-shaded in the patch failed. | | -1 :x: | javac | 0m 5s | phoenix5-spark3-shaded in the patch failed. | | -1 :x: | javac | 0m 6s | phoenix5-spark-shaded in the patch failed. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 0m 6s | phoenix5-hive-shaded in the patch failed. | | -1 :x: | javadoc | 0m 5s | phoenix5-spark3-shaded in the patch failed. | | -1 :x: | javadoc | 0m 6s | phoenix5-spark-shaded in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 6s | phoenix5-hive-shaded in the patch failed. | | -1 :x: | unit | 0m 5s | phoenix5-spark3-shaded in the patch failed. | | -1 :x: | unit | 0m 6s | phoenix5-spark-shaded in the patch failed. | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 16m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/128 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux a38f002ef13e 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / 60d4172 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-compile-phoenix5-hive-shaded.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3-shaded.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark-shaded.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-128/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive-shaded.txt | | javadoc |
[jira] [Commented] (PHOENIX-7168) Remove shaded protobuf from shaded connector JARs
[ https://issues.apache.org/jira/browse/PHOENIX-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804996#comment-17804996 ] ASF GitHub Bot commented on PHOENIX-7168: - stoty opened a new pull request, #128: URL: https://github.com/apache/phoenix-connectors/pull/128 (no comment) > Remove shaded protobuf from shaded connector JARs > - > > Key: PHOENIX-7168 > URL: https://issues.apache.org/jira/browse/PHOENIX-7168 > Project: Phoenix > Issue Type: Bug > Components: connectors, hive-connector, spark-connector >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Minor > > We redundantly add the relocated protobuf 2.5.0 classes to the shaded JARs. > It shouldn't cause iusses, as the relocation is identical to the one in > hbase-shaded-client and friends, but it's bad practice to duplicate classes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7168) Remove shaded protobuf from shaded connector JARs
[ https://issues.apache.org/jira/browse/PHOENIX-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804994#comment-17804994 ] ASF GitHub Bot commented on PHOENIX-7168: - stoty closed pull request #126: PHOENIX-7168 Remove shaded protobuf from shaded connector JARs URL: https://github.com/apache/phoenix-connectors/pull/126 > Remove shaded protobuf from shaded connector JARs > - > > Key: PHOENIX-7168 > URL: https://issues.apache.org/jira/browse/PHOENIX-7168 > Project: Phoenix > Issue Type: Bug > Components: connectors, hive-connector, spark-connector >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Minor > > We redundantly add the relocated protobuf 2.5.0 classes to the shaded JARs. > It shouldn't cause iusses, as the relocation is identical to the one in > hbase-shaded-client and friends, but it's bad practice to duplicate classes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7168) Remove shaded protobuf from shaded connector JARs
[ https://issues.apache.org/jira/browse/PHOENIX-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804993#comment-17804993 ] ASF GitHub Bot commented on PHOENIX-7168: - stoty commented on PR #126: URL: https://github.com/apache/phoenix-connectors/pull/126#issuecomment-1884328736 The last rebase seems to have killed github.com. I'm going to try and re-upload the patch in a new PR. > Remove shaded protobuf from shaded connector JARs > - > > Key: PHOENIX-7168 > URL: https://issues.apache.org/jira/browse/PHOENIX-7168 > Project: Phoenix > Issue Type: Bug > Components: connectors, hive-connector, spark-connector >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Minor > > We redundantly add the relocated protobuf 2.5.0 classes to the shaded JARs. > It shouldn't cause iusses, as the relocation is identical to the one in > hbase-shaded-client and friends, but it's bad practice to duplicate classes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7168) Remove shaded protobuf from shaded connector JARs
[ https://issues.apache.org/jira/browse/PHOENIX-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804346#comment-17804346 ] ASF GitHub Bot commented on PHOENIX-7168: - stoty commented on PR #126: URL: https://github.com/apache/phoenix-connectors/pull/126#issuecomment-1881245560 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m 20s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 10m 12s | Maven dependency ordering for branch | | -1 :x: | mvninstall | 0m 7s | root in master failed. | | -1 :x: | compile | 0m 10s | phoenix5-hive-shaded in master failed. | | -1 :x: | compile | 0m 8s | phoenix5-spark3-shaded in master failed. | | -1 :x: | compile | 0m 7s | phoenix5-spark-shaded in master failed. | | -1 :x: | javadoc | 0m 6s | phoenix5-hive-shaded in master failed. | | -1 :x: | javadoc | 0m 5s | phoenix5-spark3-shaded in master failed. | | -1 :x: | javadoc | 0m 6s | phoenix5-spark-shaded in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for patch | | -1 :x: | mvninstall | 0m 4s | root in the patch failed. | | -1 :x: | compile | 0m 6s | phoenix5-hive-shaded in the patch failed. | | -1 :x: | compile | 0m 5s | phoenix5-spark3-shaded in the patch failed. | | -1 :x: | compile | 0m 5s | phoenix5-spark-shaded in the patch failed. | | -1 :x: | javac | 0m 6s | phoenix5-hive-shaded in the patch failed. | | -1 :x: | javac | 0m 5s | phoenix5-spark3-shaded in the patch failed. | | -1 :x: | javac | 0m 5s | phoenix5-spark-shaded in the patch failed. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 3s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 0m 6s | phoenix5-hive-shaded in the patch failed. | | -1 :x: | javadoc | 0m 5s | phoenix5-spark3-shaded in the patch failed. | | -1 :x: | javadoc | 0m 5s | phoenix5-spark-shaded in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 0m 6s | phoenix5-hive-shaded in the patch failed. | | -1 :x: | unit | 0m 6s | phoenix5-spark3-shaded in the patch failed. | | -1 :x: | unit | 0m 5s | phoenix5-spark-shaded in the patch failed. | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 16m 13s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-126/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/126 | | Optional Tests | dupname asflicense javac javadoc unit xml compile | | uname | Linux ebe0f4e2 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-connectors-personality.sh | | git revision | master / 80abdb4 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | mvninstall | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-126/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-126/1/artifact/yetus-general-check/output/branch-compile-phoenix5-hive-shaded.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-126/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3-shaded.txt | | compile | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-126/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark-shaded.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-126/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive-shaded.txt | | javadoc |
[jira] [Commented] (PHOENIX-7168) Remove shaded protobuf from shaded connector JARs
[ https://issues.apache.org/jira/browse/PHOENIX-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804340#comment-17804340 ] ASF GitHub Bot commented on PHOENIX-7168: - stoty opened a new pull request, #126: URL: https://github.com/apache/phoenix-connectors/pull/126 (no comment) > Remove shaded protobuf from shaded connector JARs > - > > Key: PHOENIX-7168 > URL: https://issues.apache.org/jira/browse/PHOENIX-7168 > Project: Phoenix > Issue Type: Bug > Components: connectors, hive-connector, spark-connector >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Minor > > We redundantly add the relocated protobuf 2.5.0 classes to the shaded JARs. > It shouldn't cause iusses, as the relocation is identical to the one in > hbase-shaded-client and friends, but it's bad practice to duplicate classes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
