jpisaac commented on code in PR #1782:
URL: https://github.com/apache/phoenix/pull/1782#discussion_r1480802465
##
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##
@@ -1617,66 +1620,98 @@ private PTable getTableFromCells(List
tableCellList, List> allC
return builder.build();
}
+/**
+ * Method to return TTL value defined at current level ot up the Hierarchy
of the view.
Review Comment:
nit: typo "or"?
##
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java:
##
@@ -1617,66 +1620,98 @@ private PTable getTableFromCells(List
tableCellList, List> allC
return builder.build();
}
+/**
+ * Method to return TTL value defined at current level ot up the Hierarchy
of the view.
+ * @param viewKey Key of the view for which we have to find TTL
+ * @param clientTimeStamp Client TimeStamp
+ * @return TTL value for a given view, if nothing is defined anywhere then
return
+ * TTL_NOT_DEFINED(0).
+ * @throws IOException
+ * @throws SQLException
+ */
+
Review Comment:
nit: scanTTLFromParent should be called getTTLFromHierarchy WDT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
