[GitHub] [incubator-ponymail] mdtouha01813505613 removed a comment on issue #512: Bug: Spurious date check

2020-07-08 Thread GitBox


mdtouha01813505613 removed a comment on issue #512:
URL: 
https://github.com/apache/incubator-ponymail/issues/512#issuecomment-655270309


   islami bank bangladesh limited farmgate branch routing number 125261458 
account number 2050136020365860 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-ponymail] mdtouha01813505613 commented on issue #512: Bug: Spurious date check

2020-07-07 Thread GitBox


mdtouha01813505613 commented on issue #512:
URL: 
https://github.com/apache/incubator-ponymail/issues/512#issuecomment-655270309


   islami bank bangladesh limited farmgate branch routing number 125261458 
account number 2050136020365860 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-ponymail] gmcdonald commented on issue #516: Invalid mailing list address supplied

2020-06-11 Thread GitBox


gmcdonald commented on issue #516:
URL: 
https://github.com/apache/incubator-ponymail/issues/516#issuecomment-642855236


   For an actual reproducible example see this ticket:
   
   https://issues.apache.org/jira/browse/INFRA-20367
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-ponymail] gmcdonald opened a new issue #516: Invalid mailing list address supplied

2020-06-11 Thread GitBox


gmcdonald opened a new issue #516:
URL: https://github.com/apache/incubator-ponymail/issues/516







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-ponymail] sebbASF opened a new issue #515: Bug: stats.lua does not report if a list is unavailable

2020-05-30 Thread GitBox


sebbASF opened a new issue #515:
URL: https://github.com/apache/incubator-ponymail/issues/515


   stats.lua reports first and last dates as the current month if the list is 
missing or access is not granted.
   This is misleading; it should report an error



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [incubator-ponymail] rhenwood-arm commented on issue #514: mbox export via API not behaving as expected

2020-04-14 Thread GitBox
rhenwood-arm commented on issue #514: mbox export via API not behaving as 
expected
URL: 
https://github.com/apache/incubator-ponymail/issues/514#issuecomment-613660335
 
 
   ah! Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh closed issue #514: mbox export via API not behaving as expected

2020-04-14 Thread GitBox
Humbedooh closed issue #514: mbox export via API not behaving as expected
URL: https://github.com/apache/incubator-ponymail/issues/514
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #514: mbox export via API not behaving as expected

2020-04-14 Thread GitBox
Humbedooh commented on issue #514: mbox export via API not behaving as expected
URL: 
https://github.com/apache/incubator-ponymail/issues/514#issuecomment-613655648
 
 
   For that specific list, you would need 
https://lists.apache.org/api/mbox.lua?list=d...@accumulo.apache.org&date=2020-01
   That is, the domain and list part is one combined argument.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] rhenwood-arm opened a new issue #514: mbox export via API not behaving as expected

2020-04-14 Thread GitBox
rhenwood-arm opened a new issue #514: mbox export via API not behaving as 
expected
URL: https://github.com/apache/incubator-ponymail/issues/514
 
 
   Hi, 
   
   I'm trying to get an MBOX via the API and the file returned is zero bytes. 
Here is an example of the request I'm trying:
   
   
https://lists.apache.org/api/mbox.lua?list=dev&domain=accumulo.apache.org&date=2020-01


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] asfgit closed issue #396: Enh: add some debug output to import-mbox

2020-03-18 Thread GitBox
asfgit closed issue #396: Enh: add some debug output to import-mbox
URL: https://github.com/apache/incubator-ponymail/issues/396
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #513: Bug: cluster generator fails to parse non-ascii subject and sender

2020-03-16 Thread GitBox
sebbASF commented on issue #513: Bug: cluster generator fails to parse 
non-ascii subject and sender
URL: 
https://github.com/apache/incubator-ponymail/issues/513#issuecomment-599649246
 
 
   No, it's not possible to replace msg by msg_metadata, because that will 
change the output from the existing generators (at least with some input).
   
   I was thinking of adding  the metadata as another parameter.
   It would only be used by the new generator(s). 
   This would preserve the existing behaviour.
   
   As to canonicalisation, headers may be wrapped in transit.
   For maximum portability, they should be unwrapped before use.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #513: Bug: cluster generator fails to parse non-ascii subject and sender

2020-03-16 Thread GitBox
Humbedooh commented on issue #513: Bug: cluster generator fails to parse 
non-ascii subject and sender
URL: 
https://github.com/apache/incubator-ponymail/issues/513#issuecomment-599580254
 
 
   Let's bump the 'r' prefix then. I'd suggest moving to next char, 'v' :)
   So, am I understanding this right in that the generators should be passed 
msg_metadata instead of msg in the first variable slot, and that would address 
the main issue? If so, we'd probably be best off by accessing them with 
`msg.get('subject', '')` as they may not have been present in the email and 
this would avoid a key error.
   
   What do you mean by message-id being canonicalized?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #513: Bug: cluster generator fails to parse non-ascii subject and sender

2020-03-16 Thread GitBox
sebbASF opened a new issue #513: Bug: cluster generator fails to parse 
non-ascii subject and sender
URL: https://github.com/apache/incubator-ponymail/issues/513
 
 
   The cluster generator uses fields of the msg assuming that they will be 
strings.
   
   However that is not the case if non-ascii characters have been used.
   
   In such cases, code such as msg.get('subject') will return an 
email.header.Header object.
   This causes code such as bytes(subject, encoding = 'ascii') to fail with
   
   TypeError: encoding without a string argument
   
   In turn, this causes the archiver to revert to a very basic fallback mid:
   
   mid = hashlib.sha224(str("%s-%s" % (lid, 
msg_metadata['archived-at'])).encode('utf-8')).hexdigest() + "@" + (lid if lid 
else "none")
   
   **Unless archived-at is defined, this will be constant for a given list id**
   
   This is relatively easy to fix; the generator should use the msg_metadata 
dict which
   the archiver has already set up.
   
   HOWEVER, to ensure that it's possible to regenerate the same Permalinks, any 
fix MUST be implemented as a new generator type, with a new syntax (i.e. change 
the 'r' prefix).
   
   There are probably some other changes that need to be made to the cluster 
generator.
   For example, Message-Id should be canonicalised.
   
   Note that the fallback mid cannot be changed, as that would affect all the 
generators.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #398: Enh: 'cluster' generator ids are not sufficiently unique

2020-03-16 Thread GitBox
sebbASF commented on issue #398: Enh: 'cluster' generator ids are not 
sufficiently unique
URL: 
https://github.com/apache/incubator-ponymail/issues/398#issuecomment-599454812
 
 
   FTR: Message-Id is now included in the cluster algorithm; however 
unfortunately the value is not canonicalised first.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #512: Bug: Spurious date check

2020-03-15 Thread GitBox
sebbASF opened a new issue #512: Bug: Spurious date check
URL: https://github.com/apache/incubator-ponymail/issues/512
 
 
   The code at
   
https://github.com/apache/incubator-ponymail/blob/a65a09cceb17ce6877097856ae437ac977d00902/tools/list-lists.py#L67
   
   checks whether the date of the entry is less than 2 days in the future.
   
   There does not seem to be any reason for this.
   Either the reason should be documented, or the check should be dropped.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #511: Bug: should not generate invalid list ids

2020-01-20 Thread GitBox
sebbASF opened a new issue #511: Bug: should not generate invalid list ids
URL: https://github.com/apache/incubator-ponymail/issues/511
 
 
   Currently a list-Id header of the form:
   
   List-Id: "SpamAssassin Users" us...@spamassassin.apache.org
   
   is not parsed correctly, whereas the following are:
   
   List-Id: "SpamAssassin Users" 
   List-Id: 
   List-Id: us...@spamassassin.apache.org
   
   The descriptive phrase should be completely ignored when extracting the 
list-id


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #234: Bug: import/archive don't unfold headers before storage in ES

2020-01-19 Thread GitBox
sebbASF commented on issue #234: Bug: import/archive don't unfold headers 
before storage in ES
URL: 
https://github.com/apache/incubator-ponymail/issues/234#issuecomment-576067724
 
 
   When a line is folded, the MTA inserts CRLF followed by a single WSP; 
unfolding should be the reverse.
   Multiple WSP should be treated as a single WSP *when it separates tokens*
   
   The issue also affects Message-ID which can be wrapped within the value.
   
   Note that some MTAs may fold at 78 chars; some may fold at a longer line 
length.
   So the path that an email takes to the archiver may affect the raw layout.
   Potentially an email that is sent to multiple lists could travel by 
different routes to the lists and from the lists to the archiver. The headers 
(and body) may end up with different folds.
   
   Failure to unfold headers can also result in invalid Message-IDs being 
stored, for example:
   
   $ curl -s 
'https://lists.apache.org/api/thread.lua?id=4b36027f9230b84f388d719e684536a910b53c304b2c2b05f5efe0fe@1135257469@%3Cusers.continuum.apache.org%3E'
 | python3 -m json.tool | fgrep message
   "message-id": "\n
<0775dd7f2f88084aa05bcc79ef6f32532ea3a...@iblonce105.gb.ad.drkw.net>",
   
   $ curl -s 
'https://lists.apache.org/api/thread.lua?id=01e80b71b223b176e0c8af1efeab5be229719e398669419d46d18f53@1078215889@'
 | python3 -m json.tool | fgrep message
   "message-id": 
"",


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh opened a new issue #510: Encode thread URIs for permalinks

2019-12-02 Thread GitBox
Humbedooh opened a new issue #510: Encode thread URIs for permalinks
URL: https://github.com/apache/incubator-ponymail/issues/510
 
 
   URIs with <> in them can cause trouble with some URL parsers, thus the links 
to thread.html should make use of URI encoding when creating permalinks, to 
avoid this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #234: Bug: import/archive don't unfold headers before storage in ES

2019-09-14 Thread GitBox
sebbASF commented on issue #234: Bug: import/archive don't unfold headers 
before storage in ES
URL: 
https://github.com/apache/incubator-ponymail/issues/234#issuecomment-531464005
 
 
   Another header that should be unfolded is Subject:


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #509: Bug: multi-list search bookmark does not update list selection

2019-09-06 Thread GitBox
sebbASF opened a new issue #509: Bug: multi-list search bookmark does not 
update list selection
URL: https://github.com/apache/incubator-ponymail/issues/509
 
 
   Recipe:
   search single list
   https://lists.apache.org/list.html?d...@ponymail.apache.org:lte=1M:a
   Change search to all ponymail lists
   New URL is:
   https://lists.apache.org/list.html?*@ponymail.apache.org:lte=1M:a
   Paste that into a new page, and PM complains that the list is not found
   It also fails to update the search domain. This affects the display of list 
names in the results.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #388: Bug: search "All ponymail.a.o lists" does not show list ids if no search text provided

2019-09-06 Thread GitBox
sebbASF commented on issue #388: Bug: search "All ponymail.a.o lists" does not 
show list ids if no search text provided
URL: 
https://github.com/apache/incubator-ponymail/issues/388#issuecomment-528764619
 
 
   If the list view is changed to Flat, then the entries sometimes show the 
list name in 'Compact' mode, and sometimes don't.
   In flat/default mode, only the sender is shown


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] asfgit closed issue #508: Bug: only 12 months in a year

2019-08-30 Thread GitBox
asfgit closed issue #508: Bug: only 12 months in a year
URL: https://github.com/apache/incubator-ponymail/issues/508
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #508: Bug: only 12 months in a year

2019-08-30 Thread GitBox
sebbASF opened a new issue #508: Bug: only 12 months in a year
URL: https://github.com/apache/incubator-ponymail/issues/508
 
 
   There are only 12 months in a year, however the table in utils.lua has 14 
entries!
   
   This error seems to have been present since the start when the code was in 
stats.lua/mbox.lua


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] asfgit closed issue #507: Bug: wordcloud.js can overwrite document ids

2019-08-24 Thread GitBox
asfgit closed issue #507: Bug: wordcloud.js can overwrite document ids
URL: https://github.com/apache/incubator-ponymail/issues/507
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #507: Bug: wordcloud.js can overwrite document ids

2019-08-24 Thread GitBox
sebbASF opened a new issue #507: Bug: wordcloud.js can overwrite document ids
URL: https://github.com/apache/incubator-ponymail/issues/507
 
 
   The wordcloud.js wordCloud function currently sets the "id" attribute of the 
entries in the word cloud to distinguish them (v. fastIntersect). Such ids can 
clash with existing ids causing display problems. All ids need to be unique.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #471: Flagging Active and Inactive Mailing Lists

2019-08-21 Thread GitBox
sebbASF commented on issue #471: Flagging Active and Inactive Mailing Lists
URL: 
https://github.com/apache/incubator-ponymail/issues/471#issuecomment-523631039
 
 
   Regardless of how the list state is determined, there should be a way to 
record it, and for PM to take note of it in displays etc.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] asfgit closed issue #506: Enh: allow generator to be overridden for testing

2019-08-13 Thread GitBox
asfgit closed issue #506: Enh: allow generator to be overridden for testing
URL: https://github.com/apache/incubator-ponymail/issues/506
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #506: Enh: allow generator to be overridden for testing

2019-08-13 Thread GitBox
sebbASF opened a new issue #506: Enh: allow generator to be overridden for 
testing
URL: https://github.com/apache/incubator-ponymail/issues/506
 
 
   It would be useful to be able to override the generator for testing purposes


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] asfgit closed issue #505: Bug: generator.py does not include original medium generator

2019-08-12 Thread GitBox
asfgit closed issue #505: Bug: generator.py does not include original medium 
generator
URL: https://github.com/apache/incubator-ponymail/issues/505
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #505: Bug: generator.py does not include original medium generator

2019-08-12 Thread GitBox
sebbASF opened a new issue #505: Bug: generator.py does not include original 
medium generator
URL: https://github.com/apache/incubator-ponymail/issues/505
 
 
   The medium generator was originally committed in 
   
https://gitbox.apache.org/repos/asf?p=incubator-ponymail.git;a=commitdiff;h=aa989610
   This was used by lists.a.o (and possibly elsewhere) for a short while.
   
   It was subsequently updated in:
   
https://gitbox.apache.org/repos/asf?p=incubator-ponymail.git;a=commitdiff;h=4732d25f
   
   Restore access to the original algorithm.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] asfgit closed issue #504: Enh: move generator selection to generator.py

2019-08-12 Thread GitBox
asfgit closed issue #504: Enh: move generator selection to generator.py
URL: https://github.com/apache/incubator-ponymail/issues/504
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #504: Enh: move generator selection to generator.py

2019-08-12 Thread GitBox
sebbASF opened a new issue #504: Enh: move generator selection to generator.py
URL: https://github.com/apache/incubator-ponymail/issues/504
 
 
   Archiver generator selection currently relies on ensuring that the list of 
names in archiver.py agrees with the list of functions in generator.py.
   
   Both files have to be changed to add a new generator; this is inefficient 
and error-prone.
   
   Reduce the binding between the modules by doing the selection in 
generator.py.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #503: Enh: tool to fix up missing attachments

2019-08-11 Thread GitBox
sebbASF opened a new issue #503: Enh: tool to fix up missing attachments
URL: https://github.com/apache/incubator-ponymail/issues/503
 
 
   Further to #501 and #502, existing databases will generally need to be 
refreshed in order to recover the missing attachments. This cannot safely be 
done by reloading from the source, because that may change the Permalink, 
especially for earlier mails which may have used a different algorithm.
   
   The tool could reparse the source (from the raw mail) and generate an 
updated list of attachments. As a cross-check, any existing attachments should 
be found in the updated list; any missing ones can then be added.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #502: Bug: parser fails to detect inline attachments

2019-08-11 Thread GitBox
sebbASF commented on issue #502: Bug: parser fails to detect inline attachments
URL: 
https://github.com/apache/incubator-ponymail/issues/502#issuecomment-520233834
 
 
   The archiver code currently walks the message parts twice: in msgbody and 
msgfiles.
   
   This makes it harder to ensure all parts are accounted for exactly once.
   
   At present the methods each look for specific headers, which is how some 
parts have been missed.
   
   There will need to be some co-ordination between the two methods to avoid 
omissions and duplications (there's no point creating an attachment record for 
the main body).
   
   Alternatively, the parts could be walked once and allocated as body or 
attachment.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #502: Bug: parser fails to detect inline attachments

2019-08-11 Thread GitBox
sebbASF opened a new issue #502: Bug: parser fails to detect inline attachments
URL: https://github.com/apache/incubator-ponymail/issues/502
 
 
   The parser completely ignores inline attachments.
   For example, the message [1] includes a reference to an attachment, but it 
is not shown in the list view, only in the source view.
   
   Compare withe the mod_mbox version [2], which shows the attachment
   
   It might make sense to display the message structure in the same way as 
mod_mbox.
   This would also allow easy access to HTML alternatives, which are also 
currently hidden.
   
   [1] 
https://lists.apache.org/thread.html/918b4a61add01902e2dfbf1a17ba945b7d721e9cdf9d0235d374eb1d@1250786123@%3Cuser.zookeeper.apache.org%3E
   [2] 
http://mail-archives.apache.org/mod_mbox/zookeeper-user/200908.mbox/%3c4a8d7b4b.5020...@apache.org%3e


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] asfgit closed issue #501: Bug: parser fails to extract inline attachments

2019-08-08 Thread GitBox
asfgit closed issue #501: Bug: parser fails to extract inline attachments
URL: https://github.com/apache/incubator-ponymail/issues/501
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #501: Bug: parser fails to extract inline attachments

2019-08-08 Thread GitBox
sebbASF opened a new issue #501: Bug: parser fails to extract inline attachments
URL: https://github.com/apache/incubator-ponymail/issues/501
 
 
   See https://issues.apache.org/jira/browse/INFRA-18834


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh closed issue #500: lists.apache.org ponymail failing login using google oauth; failing with apache due to invalid username.

2019-07-26 Thread GitBox
Humbedooh closed issue #500: lists.apache.org ponymail failing login using 
google oauth; failing with apache due to invalid username.
URL: https://github.com/apache/incubator-ponymail/issues/500
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #500: lists.apache.org ponymail failing login using google oauth; failing with apache due to invalid username.

2019-07-24 Thread GitBox
sebbASF commented on issue #500: lists.apache.org ponymail failing login using 
google oauth; failing with apache due to invalid username.
URL: 
https://github.com/apache/incubator-ponymail/issues/500#issuecomment-514823197
 
 
   issues.apache.org currently has its own independent authentication scheme.
   
   PonyMail has two auth schemes: Google, and Apache.
   For Apache auth you need to be an Apache committer with an Apache user id.
   
   However, you don't need to use PonyMail in order to send an email to public 
ASF mailing lists, nor do you need to login to see the public lists.
   
   See http://jclouds.apache.org/
   in particular:
   http://jclouds.apache.org/community/
   and
   http://jclouds.apache.org/reference/report-a-bug/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] jcalcote commented on issue #500: lists.apache.org ponymail failing login using google oauth; failing with apache due to invalid username.

2019-07-24 Thread GitBox
jcalcote commented on issue #500: lists.apache.org ponymail failing login using 
google oauth; failing with apache due to invalid username.
URL: 
https://github.com/apache/incubator-ponymail/issues/500#issuecomment-514817948
 
 
   I used my email address to log into issues.apache.org. worked just fine.
   
   On Wed, Jul 24, 2019, 3:44 PM sebbASF  wrote:
   
   > Apache user ids do not have '.' in them (and are not email addresses), so
   > perhaps you are using the wrong login.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #500: lists.apache.org ponymail failing login using google oauth; failing with apache due to invalid username.

2019-07-24 Thread GitBox
sebbASF commented on issue #500: lists.apache.org ponymail failing login using 
google oauth; failing with apache due to invalid username.
URL: 
https://github.com/apache/incubator-ponymail/issues/500#issuecomment-514811433
 
 
   Apache user ids do not have '.' in them (and are not email addresses), so 
perhaps you are using the wrong login.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] jcalcote opened a new issue #500: lists.apache.org ponymail failing login using google oauth; failing with apache due to invalid username.

2019-07-24 Thread GitBox
jcalcote opened a new issue #500: lists.apache.org ponymail failing login using 
google oauth; failing with apache due to invalid username.
URL: https://github.com/apache/incubator-ponymail/issues/500
 
 
   
![image](https://user-images.githubusercontent.com/49394/61820068-87f26e80-ae11-11e9-97ce-4288e89cb9b8.png)
   
   
![image](https://user-images.githubusercontent.com/49394/61820142-aeb0a500-ae11-11e9-9140-de6ca69d0744.png)
   
   Login is failing using google oauth due to some back-end oauth issue. Login 
is failing using apache oauth because my apache username is my email address 
and ponymail seems to think usernames should not have dots, dashes, or at signs 
in them.
   
   I have no way to login now. Please help.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #499: AAA regression in notifications API

2019-07-22 Thread GitBox
sebbASF commented on issue #499: AAA regression in notifications API
URL: 
https://github.com/apache/incubator-ponymail/issues/499#issuecomment-513917244
 
 
   According to the  setup.py code, the notifications doc type is not set up 
with the list_raw attribute, which is presumably why the archiver does not try 
to populate it when saving the notifications.
   
   However, lists.a.o does populate the list_raw field for private emails 
(presumably the code that handles private mails is using a different version of 
the archiver).
   
   This may explain why the bug has only recently been noticed. (In my case, I 
only recently used the reply function for a public list reply)
   
   The simplest fix would be for notifications.lua to unconditionally populate 
list_raw from list.
   I don't see the point in checking to see if list_raw already exists.
   
   I'm not sure it's worth changing the notifications doc type to keep only a 
reference to the mbox document. That would mean fetching the mbox entry in 
order to check access.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF removed a comment on issue #499: AAA regression in notifications API

2019-07-22 Thread GitBox
sebbASF removed a comment on issue #499: AAA regression in notifications API
URL: 
https://github.com/apache/incubator-ponymail/issues/499#issuecomment-513545429
 
 
   AFAICT list_raw is used in several places other than notifications.
   If the field is not present in some entries, then every access will 
potentially need to allow for this.
   
   Seems to me the obvious fix is for list_raw always to be present
It seems a fundamental part of the schema design.
   
   This will require existing databases to be fixed, but that is a once-off.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #499: AAA regression in notifications API

2019-07-21 Thread GitBox
sebbASF commented on issue #499: AAA regression in notifications API
URL: 
https://github.com/apache/incubator-ponymail/issues/499#issuecomment-513545429
 
 
   AFAICT list_raw is used in several places other than notifications.
   If the field is not present in some entries, then every access will 
potentially need to allow for this.
   
   Seems to me the obvious fix is for list_raw always to be present
It seems a fundamental part of the schema design.
   
   This will require existing databases to be fixed, but that is a once-off.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh opened a new issue #499: AAA regression in notifications API

2019-07-21 Thread GitBox
Humbedooh opened a new issue #499: AAA regression in notifications API
URL: https://github.com/apache/incubator-ponymail/issues/499
 
 
   notifications.lua looks for notifications, and if AAA is enabled, tries to 
parse list-id which requires a `list_raw` element present. As that isn't set in 
archiver.py, it causes a nil error.
   
   Three possible ways of fixing:
   - fall back to using the `list` element if no list_raw exists (easiest, and 
best for backwards compat)
   - have archiver also add a `list_raw` to notifications
   - don't copy the email into the notifications db, but rather have a 
reference to the mbox document
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #498: 404 on private list link should prompt login

2019-07-20 Thread GitBox
sebbASF commented on issue #498: 404 on private list link should prompt login
URL: 
https://github.com/apache/incubator-ponymail/issues/498#issuecomment-513494202
 
 
   In the case of a non-public list, the user does get a prompt regarding 
login, e.g.
   
   https://lists.apache.org/list.html?erew...@apache.org
   
   The same message is printed for lists that don't exist (as in the example) 
or lists that exist, but are private.
   
   At present non-public thread links don't produce any output.
   Seems to me it would be better if they behaved like the list URL


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] igalic opened a new issue #498: 404 on private list link should prompt login

2019-07-20 Thread GitBox
igalic opened a new issue #498: 404 on private list link should prompt login
URL: https://github.com/apache/incubator-ponymail/issues/498
 
 
   when clicking on a link that leads to a private list's email, Pony mail 
shows a 404
   
   now, i don't know if it's a breach of data disclosure, but it could also 
prompt for a login — especially, if a session only expired, rather than never 
existed.
   
   alternatively, the login form could be integrated into the site's base 
template, and so, show up everywhere.
   
   though that might require to rethink the design of the login: e.g.: how to 
choose between different authentication providers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #497: In single-thread view, nesting is at most two

2019-07-15 Thread GitBox
Humbedooh commented on issue #497: In single-thread view, nesting is at most two
URL: 
https://github.com/apache/incubator-ponymail/issues/497#issuecomment-511350292
 
 
   ^- It works okay because I asked for the above to be applied as a test. So 
the fix works. I'll hammer out a proper patch once I'm done ferrying to this 
island I'm going to :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #497: In single-thread view, nesting is at most two

2019-07-15 Thread GitBox
sebbASF commented on issue #497: In single-thread view, nesting is at most two
URL: 
https://github.com/apache/incubator-ponymail/issues/497#issuecomment-511350045
 
 
   Works OK for me, see attached screenshot of thread.html
   
   
![ThreadMode](https://user-images.githubusercontent.com/16689231/61210200-a6f74f00-a6f3-11e9-9447-131c64774661.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #497: In single-thread view, nesting is at most two

2019-07-15 Thread GitBox
Humbedooh commented on issue #497: In single-thread view, nesting is at most two
URL: 
https://github.com/apache/incubator-ponymail/issues/497#issuecomment-511350012
 
 
   pesudo-fix for thread.lua:
   
   ~~~ lua
   local direct_ref = true -- direct reference or not?
   local xemid = pdoc['message-id'] -- exact email id or parent
   if doc.references and #doc.references >= #xemid and 
doc.references:sub(-#xemid) ~= xemid and doc['in-reply-to'] ~= xemid then -- if 
it has "references" but doesn't match exactly, disregard
   direct_ref = false
   end
   ~~~
   
   Then in the iteration, we'd check if `direct_ref` is true or false, and only 
add/account for if true.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #497: In single-thread view, nesting is at most two

2019-07-15 Thread GitBox
Humbedooh commented on issue #497: In single-thread view, nesting is at most two
URL: 
https://github.com/apache/incubator-ponymail/issues/497#issuecomment-511349375
 
 
   Looks like a bug in the nesting algorithm. It makes the mistake of finding 
children that are not direct descendants and adding them as direct ones. This 
should be fixed by checking the `references` header, and only filing direct 
matches (where `references` has the original message-id as the *last* value) as 
descendants, then letting those kids get their own accordingly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] jbapple opened a new issue #497: In single-thread view, nesting is at most two

2019-07-14 Thread GitBox
jbapple opened a new issue #497: In single-thread view, nesting is at most two
URL: https://github.com/apache/incubator-ponymail/issues/497
 
 
   Some time in the last few months, single-thread view stopped nesting deeper 
than two, for me, whether logged in or not, on all browsers I use, including 
various Chromes.
   
   Here is an example thread:
   
   
https://lists.apache.org/thread.html/04b9a8a156939adae1aa4cf2d4e3abd2137f541cbf92ade6d775dc06@%3Cdev.parquet.apache.org%3E
   
   When viewing this thread in the multi-thread view 
https://lists.apache.org/list.html?d...@parquet.apache.org, nesting works 
properly, showing many levels of depth by use of the colored bars on the 
left-hand side.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh closed issue #496: Composer uses wrong From: header format

2019-07-09 Thread GitBox
Humbedooh closed issue #496: Composer uses wrong From: header format
URL: https://github.com/apache/incubator-ponymail/issues/496
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh opened a new issue #496: Composer uses wrong From: header format

2019-07-08 Thread GitBox
Humbedooh opened a new issue #496: Composer uses wrong From: header format
URL: https://github.com/apache/incubator-ponymail/issues/496
 
 
   The composer app should refrain from using the `"Foo Bar" ` 
format, as the quotes are bad. It should instead use `Foo Bar` 
only. I'll get a fix sent in unless someone beats me to it :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] wrowe opened a new issue #495: Confusing date entry dialog box

2019-06-06 Thread GitBox
wrowe opened a new issue #495: Confusing date entry dialog box
URL: https://github.com/apache/incubator-ponymail/issues/495
 
 
   There is no prompt for manually-entered date fields in the dialog box for 
date-ranges. A caption below the dialog button suggesting -mm-dd format 
would be very helpful.
   ![Screenshot from 2019-06-06 
09-12-54](https://user-images.githubusercontent.com/84146/59039991-73dfb700-883b-11e9-923b-2efa1d0727a0.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #494: Enh: improve search capabilities

2019-05-30 Thread GitBox
sebbASF opened a new issue #494: Enh: improve search capabilities
URL: https://github.com/apache/incubator-ponymail/issues/494
 
 
   Search is currently fairly basic.
   For example an attempt to search for @apr returns results for apr as well
   
   It should be possible to search for matches of different types (exact, 
substring, RE...) on various fields (subject, headers, body etc)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] deki opened a new issue #493: From header not always RFC 5322 compliant

2019-05-24 Thread GitBox
deki opened a new issue #493: From header not always RFC 5322 compliant
URL: https://github.com/apache/incubator-ponymail/issues/493
 
 
   The From header is missing double quotes in some cases. See 
https://github.com/k9mail/k-9/issues/4064#issuecomment-495324315 for a detailed 
explanation and 
https://lists.apache.org/api/source.lua/6e04ab58b0323afabc240255bd3420adf38c9e9bc7bf988947a61f23@%3Cdev.cxf.apache.org%3E
 for a sample email.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] wohali opened a new issue #492: Add support for list FAQs/rules

2019-05-23 Thread GitBox
wohali opened a new issue #492: Add support for list FAQs/rules
URL: https://github.com/apache/incubator-ponymail/issues/492
 
 
   As Pony Mail becomes the first destination for people interacting with 
Apache mailing lists, it also should provide easy access to list rules and FAQs.
   
   This information could be displayed in a right-hand sidebar, or in the title 
area.
   
   Inspiration for this enhancement request comes from sites such as Reddit, 
where subreddit rules are commonly displayed prominently on the right-hand side.
   
   Ideally, these could be customized by the list moderators via HTML snippets 
stored in a repository to which Pony mail has access.
   
   2 examples follow. The first has custom HTML. The second is mainly text, 
with some simple inline markup (could be Markdown/Asciidoc)
   
   ![Reddit "Ask Historians" page with FAQ 
link](https://user-images.githubusercontent.com/112292/58291328-0e93bc80-7d8b-11e9-8ab6-663289cb1ed3.png)
   
   ![MWSnap 2019-05-23, 
18_46_56](https://user-images.githubusercontent.com/112292/58291431-603c4700-7d8b-11e9-9d8b-fe2898da41c3.png)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #490: Bug: setup.py fails to find formatflowed and certifi even though they are installed

2019-04-26 Thread GitBox
Humbedooh commented on issue #490: Bug: setup.py fails to find formatflowed and 
certifi even though they are installed
URL: 
https://github.com/apache/incubator-ponymail/issues/490#issuecomment-487236688
 
 
   I figured it out :D It's an (obvious) issue with iterating over a list while 
also removing items from it. Fix incoming


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #490: Bug: setup.py fails to find formatflowed and certifi even though they are installed

2019-04-26 Thread GitBox
Humbedooh commented on issue #490: Bug: setup.py fails to find formatflowed and 
certifi even though they are installed
URL: 
https://github.com/apache/incubator-ponymail/issues/490#issuecomment-487236123
 
 
   that would mean breaking at one module at a time, and only being sure of 
that one missing. the find_spec meant we could look for multiple and return a 
list of the missing. I'll look into other methods.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #490: Bug: setup.py fails to find formatflowed and certifi even though they are installed

2019-04-26 Thread GitBox
sebbASF commented on issue #490: Bug: setup.py fails to find formatflowed and 
certifi even though they are installed
URL: 
https://github.com/apache/incubator-ponymail/issues/490#issuecomment-487234689
 
 
   Why not just use import and catch the errors?
   This will mean importing modules that are not needed by setup, but does that 
matter?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #457: Bug: install.py uses deprecated method and Python2 - is it needed?

2019-04-26 Thread GitBox
sebbASF commented on issue #457: Bug: install.py uses deprecated method and 
Python2 - is it needed?
URL: 
https://github.com/apache/incubator-ponymail/issues/457#issuecomment-487234146
 
 
   I think the script should be deleted


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] asfgit closed issue #491: Bug: copy-list.py --target does not work

2019-04-26 Thread GitBox
asfgit closed issue #491: Bug: copy-list.py --target does not work
URL: https://github.com/apache/incubator-ponymail/issues/491
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #491: Bug: copy-list.py --target does not work

2019-04-26 Thread GitBox
sebbASF opened a new issue #491: Bug: copy-list.py --target does not work
URL: https://github.com/apache/incubator-ponymail/issues/491
 
 
   The fix for #450 broke the copy of the source document


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #490: Bug: setup.py fails to find formatflowed and certifi even though they are installed

2019-04-26 Thread GitBox
Humbedooh commented on issue #490: Bug: setup.py fails to find formatflowed and 
certifi even though they are installed
URL: 
https://github.com/apache/incubator-ponymail/issues/490#issuecomment-487230404
 
 
   That is not ideal - what other options do we have for checking if a package 
can be loaded, short of 'import'?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #490: Bug: setup.py fails to find formatflowed and certifi even though they are installed

2019-04-26 Thread GitBox
sebbASF commented on issue #490: Bug: setup.py fails to find formatflowed and 
certifi even though they are installed
URL: 
https://github.com/apache/incubator-ponymail/issues/490#issuecomment-487230096
 
 
   It looks like importlib.util.find_spec() does not scan for packages the same 
way as import.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF opened a new issue #490: Bug: setup.py fails to find formatflowed and certifi even though they are installed

2019-04-26 Thread GitBox
sebbASF opened a new issue #490: Bug: setup.py fails to find formatflowed and 
certifi even though they are installed
URL: https://github.com/apache/incubator-ponymail/issues/490
 
 
   setup.py fails for me with Python 3.7 on macOS.
   It says:
   
   It looks like you need to install some python modules first
   The following packages are required: 
- formatflowed
- certifi
   You may use your package manager, or run the following command:
   pip3 install formatflowed certifi
   
   However the following commands don't report an error:
   
   $ python3 -m certifi
   /usr/local/lib/python3.7/site-packages/certifi/cacert.pem
   $ python3 -m formatflowed
   
   Furthermore, if I comment out the sys.exit(-1) the tool completes 
successfully.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh closed issue #489: Errors with Elasticsearch 5.x

2019-04-26 Thread GitBox
Humbedooh closed issue #489: Errors with Elasticsearch 5.x
URL: https://github.com/apache/incubator-ponymail/issues/489
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #489: Errors with Elasticsearch 5.x

2019-04-26 Thread GitBox
Humbedooh commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-487067885
 
 
   Great, I'm going to close this as fixed then.
   Later on, we'll look into enabling support for 6.x/7.x, which requires a bit 
of rewriting and detecting when it's a >= 6.x system (since doc_type went away)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] BigBlueHat commented on issue #468: Working on *just* the UX?

2019-04-26 Thread GitBox
BigBlueHat commented on issue #468: Working on *just* the UX?
URL: 
https://github.com/apache/incubator-ponymail/issues/468#issuecomment-487052443
 
 
   > I agree, and there is some work in progress on porting it all to python, 
with an OpenAPI specification instead, but work is progressing very slowly on 
that front.
   
   Where's that work happening? If ever I find time, I might put some of it 
here. 😉 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] ilgrosso commented on issue #489: Errors with Elasticsearch 5.x

2019-04-26 Thread GitBox
ilgrosso commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486976683
 
 
   @Humbedooh with last changes, this command:
   
   ```python3 edit-list.py --delete --source "idal2.tirasa.net"```
   
   works fine, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #468: Working on *just* the UX?

2019-04-25 Thread GitBox
Humbedooh commented on issue #468: Working on *just* the UX?
URL: 
https://github.com/apache/incubator-ponymail/issues/468#issuecomment-486783210
 
 
   I agree, and there is some work in progress on porting it all to python, 
with an OpenAPI specification instead, but work is progressing very slowly on 
that front.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] BigBlueHat commented on issue #468: Working on *just* the UX?

2019-04-25 Thread GitBox
BigBlueHat commented on issue #468: Working on *just* the UX?
URL: 
https://github.com/apache/incubator-ponymail/issues/468#issuecomment-486780226
 
 
   @Humbedooh actually, thanks to [this infra 
ticket](https://issues.apache.org/jira/browse/INFRA-15587), I probably have 
what I need from the CORS side of things (at least for this running instance).
   
   The next step (using option A above) would be build a simple/alternate UX 
that uses that API and is built as a "standalone" web app (which could run on a 
different server/host, but still serve the same data).
   
   The goal was to make UX iteration simpler/faster by separating it from 
server-side concerns using the API as the "glue" between them. 😃 
   
   So, I suppose this is partly possible already, and would just need a 👍 and a 
more "visible" (via API docs or similar) API.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #486: Enh: store message arrival time for use in sorting

2019-04-25 Thread GitBox
sebbASF commented on issue #486: Enh: store message arrival time for use in 
sorting
URL: 
https://github.com/apache/incubator-ponymail/issues/486#issuecomment-486746164
 
 
   I don't think the discrepancy needs to be displayed.
   Just sorting by arrival time would help to show which messages have arrived 
recently.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #469: Bug: Javascript URLs must always use URL_BASE

2019-04-25 Thread GitBox
Humbedooh commented on issue #469: Bug: Javascript URLs must always use URL_BASE
URL: 
https://github.com/apache/incubator-ponymail/issues/469#issuecomment-486744992
 
 
   sorry, wrong PR number in that commit. it is for #465 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #471: Flagging Active and Inactive Mailing Lists

2019-04-25 Thread GitBox
sebbASF commented on issue #471: Flagging Active and Inactive Mailing Lists
URL: 
https://github.com/apache/incubator-ponymail/issues/471#issuecomment-486742980
 
 
   I agree that list activity cannot be used to determine whether a list is 
still active or not.
   Some lists have very little activity, and a list with recent activity may 
have been closed down.
   
   There may be other reasons for disallowing posting, e.g. for list archives 
that are aliases.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #468: Working on *just* the UX?

2019-04-25 Thread GitBox
Humbedooh commented on issue #468: Working on *just* the UX?
URL: 
https://github.com/apache/incubator-ponymail/issues/468#issuecomment-486739449
 
 
   You can use remote API calls, if CORS allows. I would suggest setting up a 
proxy at home that tweaks CORS to allow for credentials if needed, I don't 
think it's gonna happen on lists.a.o :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #471: Flagging Active and Inactive Mailing Lists

2019-04-25 Thread GitBox
Humbedooh commented on issue #471: Flagging Active and Inactive Mailing Lists
URL: 
https://github.com/apache/incubator-ponymail/issues/471#issuecomment-486736853
 
 
   There isn't really a way for PM to know if a list is active or inactive 
other than whether it is getting emails. We *could* have some sort of tests for 
activity and suggest that a list *may* be inactive if below a certain 
threshold, but doing more than that would require either manual intervention 
(perhaps a CLI script to mark lists?) or tying it into the mailing list service 
itself.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #487: Bug: drop 'archived-at' header generation

2019-04-25 Thread GitBox
sebbASF commented on issue #487: Bug: drop 'archived-at' header generation
URL: 
https://github.com/apache/incubator-ponymail/issues/487#issuecomment-486736028
 
 
   No, I think Ponymail should not change the emails that it stores.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #474: Bug: plain text mails lose spacing and alignment

2019-04-25 Thread GitBox
Humbedooh commented on issue #474: Bug: plain text mails lose spacing and 
alignment
URL: 
https://github.com/apache/incubator-ponymail/issues/474#issuecomment-486736043
 
 
   Pony Mail uses the Hack monospace font, which should take spacing into 
account. Can you share an email where this causes issues? Is it a width issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #476: Issues with display of binary data in mails

2019-04-25 Thread GitBox
Humbedooh commented on issue #476: Issues with display of binary data in mails
URL: 
https://github.com/apache/incubator-ponymail/issues/476#issuecomment-486735605
 
 
   Has this issue been addressed sufficiently? :) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #480: Add support for Twitter Cards and Open Grapf metadata

2019-04-25 Thread GitBox
Humbedooh commented on issue #480: Add support for Twitter Cards and Open Grapf 
metadata
URL: 
https://github.com/apache/incubator-ponymail/issues/480#issuecomment-486735398
 
 
   I think we can, currently, display a generic card and metadata, but not 
specific to the email, as that is JS powered - I am not sure how the 
twitter/ogp handlers would parse that. Going forward, we could move towards a 
scripted page instead of a static html, for handling threads, I guess?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #486: Enh: store message arrival time for use in sorting

2019-04-25 Thread GitBox
Humbedooh commented on issue #486: Enh: store message arrival time for use in 
sorting
URL: 
https://github.com/apache/incubator-ponymail/issues/486#issuecomment-486734759
 
 
   that is typically what archived-at is for, with most MTAs (postfix et al) 
storing that as the email gets punted to the archiver. While I am in favor of 
keeping a separate record of this, I wonder how we would display the 
discrepancy in the UI?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #487: Bug: drop 'archived-at' header generation

2019-04-25 Thread GitBox
Humbedooh commented on issue #487: Bug: drop 'archived-at' header generation
URL: 
https://github.com/apache/incubator-ponymail/issues/487#issuecomment-486733807
 
 
   Would it make more sense to prefix it with 'X-' (thus X-Archived-At) and 
have Pony Mail disregard X-* when digesting the email, going forward? I think 
this could solve some other theoretical inconsistencies in emails depending on 
the path they took.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #489: Errors with Elasticsearch 5.x

2019-04-25 Thread GitBox
Humbedooh commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486712204
 
 
   I've added the scan_and_scroll type (while keeping the original scan as it 
was), and revamped edit-lists.py by spliting the process into distinct 
functions. @ilgrosso can you please test that this works on your system? It 
works on mine, but I was only testing with a handful of emails.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #489: Errors with Elasticsearch 5.x

2019-04-25 Thread GitBox
sebbASF commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486588658
 
 
   Good idea to create an iterator.
   
   As with any API change, I think it would be better to change the method 
name. This makes it easier to update the callers (and more obvious when all 
callers has been found/fixed), and means it is possible to directly test the 
new behaviour against the old.
   
   It's also kinder to 3rd parties who may have written their own scripts using 
elastic.py.
   We should deprecate the existing method in favour of the new one.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #489: Errors with Elasticsearch 5.x

2019-04-24 Thread GitBox
Humbedooh commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486490116
 
 
   so, in elastic.py I'd propose the following:
   
   ~~~ diff
   diff --git a/tools/elastic.py b/tools/elastic.py
   index 897cb64..8152922 100755
   --- a/tools/elastic.py
   +++ b/tools/elastic.py
   @@ -109,14 +109,27 @@ class Elastic:
)

def scan(self, doc_type='mbox', scroll='3m', size = 100, **kwargs):
   -return self.es.search(
   +""" Run a backwards compatible scan/scroll, passing an iterator
   +that returns one page of hits per iteration. This
   +incorporates es.scoll for continuous iteration, and thus the
   +scroll() does NOT need to be called at all by the calling
   +process. """
   +results = self.es.search(
index=self.dbname,
doc_type=doc_type,
   -search_type = 'scan',
size = size,
scroll = scroll,
**kwargs
)
   +sid = results['_scroll_id']
   +scroll_size = results['hits']['total']
   +if results['hits'].get('hits', []):
   +yield results
   +while (scroll_size > 0):
   +results = self.scroll(scroll_id = sid, scroll = scroll)
   +sid = results['_scroll_id']
   +scroll_size = len(results['hits']['hits'])
   +yield results

def get(self, **kwargs):
return self.es.get(index=self.dbname, **kwargs)
   ~~~
   
   And then in edit-lists.py, we change it to:
   
   ~~~ python
   query = ...
   for page in es.scan(body = query):
   proposed_changes = process_hits(page, args, dbname) # Split into 
separate function
   ~~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #489: Errors with Elasticsearch 5.x

2019-04-24 Thread GitBox
Humbedooh commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486488076
 
 
   Hmm yeah, what if I just turn scan() into an iterator instead? then I can do:
   
   for results in es.scan(blabla):
   process_results(results)
   
   and it would process for each scroll batch...and also work with older ES 
versions


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #489: Errors with Elasticsearch 5.x

2019-04-24 Thread GitBox
sebbASF commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486485045
 
 
   Why not take the same approach as the Lua code?
   That does not need to check the ES version, but the API is a bit different 
so it uses a new name.
   Makes it easier to migrate if the existing API is not changed.
   Also easier to maintain if Lua and Python take the same approach.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #489: Errors with Elasticsearch 5.x

2019-04-24 Thread GitBox
Humbedooh commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486481452
 
 
   for the second bit (which is rewriting edit-lists to support the two 
different ways of returning scrolling results), I am reworking edit-lists 
entirely, splitting it into a main, options and process_hits function, to avoid 
code duplication.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #489: Errors with Elasticsearch 5.x

2019-04-24 Thread GitBox
Humbedooh commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486481263
 
 
   The first bit can be addressed with this snippet, which I intend to commit 
shortly...
   There will be some other future changes, as I am aware we need to switch 
away from doc_types altogether for newer ESes
   ~~~ diff
   diff --git a/tools/elastic.py b/tools/elastic.py
   index 897cb64..4f7517c 100755
   --- a/tools/elastic.py
   +++ b/tools/elastic.py
   @@ -109,14 +109,24 @@ class Elastic:
)

def scan(self, doc_type='mbox', scroll='3m', size = 100, **kwargs):
   -return self.es.search(
   -index=self.dbname,
   -doc_type=doc_type,
   -search_type = 'scan',
   -size = size,
   -scroll = scroll,
   -**kwargs
   -)
   +""" Call the scan API, passing on the search type if needed 
(ES<=2.x) """
   +if self.engineMajor() <= 2:
   +return self.es.search(
   +index=self.dbname,
   +doc_type=doc_type,
   +search_type = 'scan',
   +size = size,
   +scroll = scroll,
   +**kwargs
   +)
   +else:
   +return self.es.search(
   +index=self.dbname,
   +doc_type=doc_type,
   +size = size,
   +scroll = scroll,
   +**kwargs
   +)

def get(self, **kwargs):
return self.es.get(index=self.dbname, **kwargs)
   ~~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #489: Errors with Elasticsearch 5.x

2019-04-24 Thread GitBox
sebbASF commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486478295
 
 
   This was fixed in the LUA code: see #344, but has yet to be fixed in all the 
python tools


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] Humbedooh commented on issue #489: Errors with Elasticsearch 5.x

2019-04-24 Thread GitBox
Humbedooh commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-486476641
 
 
   works with anything <= 2 in major versions yes. What we need to do here is 
detect the major engine version, and if <= 2, then pass the scan_type, 
otherwise not, and then wrap the processing into a function that can work with 
either outputs (earlier versions will not return results on first scan, later 
versions will).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #489: Errors with Elasticsearch 5.x

2019-04-05 Thread GitBox
sebbASF commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-480193299
 
 
   Yes, they will have been documented as having been removed in a later 
(major) version.
   I think you will find that scan works fine in all ES 2.x versions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] ilgrosso commented on issue #489: Errors with Elasticsearch 5.x

2019-04-05 Thread GitBox
ilgrosso commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-480187772
 
 
   About the docs, you're right.
   But the exception above says: `'illegal_argument_exception', 'No search type 
for [scan]'`, which does not look like deprecation to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #489: Errors with Elasticsearch 5.x

2019-04-05 Thread GitBox
sebbASF commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-480187036
 
 
   Deprecated, not removed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] ilgrosso commented on issue #489: Errors with Elasticsearch 5.x

2019-04-04 Thread GitBox
ilgrosso commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-480162345
 
 
   It seems `scan`, `count` and others were [removed since ES 
2.1](https://www.elastic.co/guide/en/elasticsearch/reference/2.1/breaking_21_search_changes.html).


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] sebbASF commented on issue #489: Errors with Elasticsearch 5.x

2019-04-04 Thread GitBox
sebbASF commented on issue #489: Errors with Elasticsearch 5.x
URL: 
https://github.com/apache/incubator-ponymail/issues/489#issuecomment-479981955
 
 
   This is because ES 5 no longer supports scan.
   
   ES scan is also used in other tools: copy-list.py, missing.py and nullfav.py


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-ponymail] ilgrosso opened a new issue #489: Errors with Elasticsearch 5.x

2019-04-04 Thread GitBox
ilgrosso opened a new issue #489: Errors with Elasticsearch 5.x
URL: https://github.com/apache/incubator-ponymail/issues/489
 
 
   I initially tried with ES 6.x, but I wasn't able to update index creation 
correctly, so I reverted to ES 5.x, with which everything seems to work except 
for the following.
   
   When running
   
   ```
   python3 edit-list.py --delete --source "idal2.tirasa.net"
   ```
   
   I receive the following error: 
   ```
   Beginning list edit:
 - List ID: 
 - Action: Delete emails (sources will be kept!)
   Updating docs...
   Traceback (most recent call last):
 File "edit-list.py", line 180, in 
   terms
 File "/var/www/ponymail-src/tools/elastic.py", line 96, in search
   **kwargs
 File 
"/usr/local/lib/python3.6/dist-packages/elasticsearch/client/utils.py", line 
76, in _wrapped
   return func(*args, params=params, **kwargs)
 File 
"/usr/local/lib/python3.6/dist-packages/elasticsearch/client/__init__.py", line 
660, in search
   doc_type, '_search'), params=params, body=body)
 File "/usr/local/lib/python3.6/dist-packages/elasticsearch/transport.py", 
line 318, in perform_request
   status, headers_response, data = connection.perform_request(method, url, 
params, body, headers=headers, ignore=ignore, timeout=timeout)
 File 
"/usr/local/lib/python3.6/dist-packages/elasticsearch/connection/http_urllib3.py",
 line 186, in perform_request
   self._raise_error(response.status, raw_data)
 File 
"/usr/local/lib/python3.6/dist-packages/elasticsearch/connection/base.py", line 
125, in _raise_error
   raise HTTP_EXCEPTIONS.get(status_code, TransportError)(status_code, 
error_message, additional_info)
   elasticsearch.exceptions.RequestError: RequestError(400, 
'illegal_argument_exception', 'No search type for [scan]')
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


  1   2   3   4   >