[jira] [Commented] (RATIS-305) Replace the reinitialize() API with some group management APIs
[
https://issues.apache.org/jira/browse/RATIS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603817#comment-16603817
]
Hadoop QA commented on RATIS-305:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
51s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 14 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 24s{color} | {color:orange} root: The patch generated 143 new + 717
unchanged - 52 fixed = 860 total (was 769) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 10m 19s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 21m 19s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-09-05
|
| JIRA Issue | RATIS-305 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12938390/r305_20180904.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux ad930be2a944 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / acd507e |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/324/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/324/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/324/testReport/ |
| modules | C: ratis-proto-shaded ratis-common ratis-client ratis-server
ratis-grpc ratis-netty ratis-hadoop ratis-examples U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/324/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Replace the reinitialize() API with some group management APIs
> --
>
> Key: RATI
[jira] [Commented] (RATIS-305) Replace the reinitialize() API with some group management APIs
[
https://issues.apache.org/jira/browse/RATIS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603806#comment-16603806
]
Hadoop QA commented on RATIS-305:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 11m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 14 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 23s{color} | {color:orange} root: The patch generated 143 new + 718
unchanged - 52 fixed = 861 total (was 770) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 41s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 16s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-09-05
|
| JIRA Issue | RATIS-305 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12938390/r305_20180904.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 2767a1de224a 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / acd507e |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/323/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/323/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/323/testReport/ |
| modules | C: ratis-proto-shaded ratis-common ratis-client ratis-server
ratis-grpc ratis-netty ratis-hadoop ratis-examples U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/323/console |
| Powered by | Apac
[jira] [Commented] (RATIS-309) Add client api's to add/remove peers from a raft group.
[ https://issues.apache.org/jira/browse/RATIS-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603749#comment-16603749 ] Tsz Wo Nicholas Sze commented on RATIS-309: --- Hi [~msingh], we may use RaftClient.setConfiguration(..) to change peers in a group. See also RaftReconfigurationBaseTest. > Add client api's to add/remove peers from a raft group. > --- > > Key: RATIS-309 > URL: https://issues.apache.org/jira/browse/RATIS-309 > Project: Ratis > Issue Type: Bug > Components: server >Reporter: Mukul Kumar Singh >Assignee: Tsz Wo Nicholas Sze >Priority: Major > > Even though Ratis server provides api's to add remove peers from a raft > server, there are no client side api's to let us do the same. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-305) Replace the reinitialize() API with some group management APIs
[ https://issues.apache.org/jira/browse/RATIS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603746#comment-16603746 ] Tsz Wo Nicholas Sze commented on RATIS-305: --- r305_20180904.patch: 1st patch. > Replace the reinitialize() API with some group management APIs > -- > > Key: RATIS-305 > URL: https://issues.apache.org/jira/browse/RATIS-305 > Project: Ratis > Issue Type: Sub-task > Components: client, server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Labels: ozone > Attachments: r305_20180904.patch > > > After RATIS-300, multiple RaftServerImpl objects is supported in a > RaftServerProxy object. We need some group management APIs for client to > add/remove groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-305) Replace the reinitialize() API with some group management APIs
[ https://issues.apache.org/jira/browse/RATIS-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-305: -- Attachment: r305_20180904.patch > Replace the reinitialize() API with some group management APIs > -- > > Key: RATIS-305 > URL: https://issues.apache.org/jira/browse/RATIS-305 > Project: Ratis > Issue Type: Sub-task > Components: client, server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > Labels: ozone > Attachments: r305_20180904.patch > > > After RATIS-300, multiple RaftServerImpl objects is supported in a > RaftServerProxy object. We need some group management APIs for client to > add/remove groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-212) Fix typo in RaftAsyncTests
[
https://issues.apache.org/jira/browse/RATIS-212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603500#comment-16603500
]
Jitendra Nath Pandey commented on RATIS-212:
[~Ganti], do you plan to provide a patch for this?
> Fix typo in RaftAsyncTests
> --
>
> Key: RATIS-212
> URL: https://issues.apache.org/jira/browse/RATIS-212
> Project: Ratis
> Issue Type: Improvement
> Components: test
>Reporter: Jakob Homan
>Assignee: Yashwanth
>Priority: Trivial
> Labels: newbie
>
> {noformat}
> @Test
> public void testStaleReadAsync() throws Exception {
> final int numMesssages = 10;
> final CLUSTER cluster = getFactory().newCluster(NUM_SERVERS,
> properties);{noformat}
> Too many s's in numMesssages. This is a starter task for [~ganti], who is
> not showing up in the assignee section.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-303) TestRaftStateMachineException is failing with NullPointerException
[
https://issues.apache.org/jira/browse/RATIS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602673#comment-16602673
]
Shashikant Banerjee commented on RATIS-303:
---
Thanks [~msingh], for the review. patch v1 addresses your review comments.
> TestRaftStateMachineException is failing with NullPointerException
> --
>
> Key: RATIS-303
> URL: https://issues.apache.org/jira/browse/RATIS-303
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Shashikant Banerjee
>Priority: Major
> Labels: ozone
> Fix For: 0.3.0
>
> Attachments: RATIS-303.01.patch
>
>
> TestRaftStateMachineException is failing with the following exception
> {code}
> [ERROR]
> testRetryOnExceptionDuringReplication[2](org.apache.ratis.statemachine.TestRaftStateMachineException)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.ratis.statemachine.TestRaftStateMachineException.testRetryOnExceptionDuringReplication(TestRaftStateMachineException.java:139)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RATIS-303) TestRaftStateMachineException is failing with NullPointerException
[
https://issues.apache.org/jira/browse/RATIS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shashikant Banerjee updated RATIS-303:
--
Attachment: RATIS-303.01.patch
> TestRaftStateMachineException is failing with NullPointerException
> --
>
> Key: RATIS-303
> URL: https://issues.apache.org/jira/browse/RATIS-303
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Shashikant Banerjee
>Priority: Major
> Labels: ozone
> Fix For: 0.3.0
>
> Attachments: RATIS-303.01.patch
>
>
> TestRaftStateMachineException is failing with the following exception
> {code}
> [ERROR]
> testRetryOnExceptionDuringReplication[2](org.apache.ratis.statemachine.TestRaftStateMachineException)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.ratis.statemachine.TestRaftStateMachineException.testRetryOnExceptionDuringReplication(TestRaftStateMachineException.java:139)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (RATIS-303) TestRaftStateMachineException is failing with NullPointerException
[
https://issues.apache.org/jira/browse/RATIS-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shashikant Banerjee updated RATIS-303:
--
Attachment: (was: RATIS-303.00.patch)
> TestRaftStateMachineException is failing with NullPointerException
> --
>
> Key: RATIS-303
> URL: https://issues.apache.org/jira/browse/RATIS-303
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Shashikant Banerjee
>Priority: Major
> Labels: ozone
> Fix For: 0.3.0
>
> Attachments: RATIS-303.01.patch
>
>
> TestRaftStateMachineException is failing with the following exception
> {code}
> [ERROR]
> testRetryOnExceptionDuringReplication[2](org.apache.ratis.statemachine.TestRaftStateMachineException)
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.ratis.statemachine.TestRaftStateMachineException.testRetryOnExceptionDuringReplication(TestRaftStateMachineException.java:139)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-310) Add support for Retry Policy in Ratis
[ https://issues.apache.org/jira/browse/RATIS-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602671#comment-16602671 ] Shashikant Banerjee commented on RATIS-310: --- Thanks [~msingh], for the review. Patch v1 addresses your review comments. > Add support for Retry Policy in Ratis > - > > Key: RATIS-310 > URL: https://issues.apache.org/jira/browse/RATIS-310 > Project: Ratis > Issue Type: Bug >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee >Priority: Major > Labels: ozone > Attachments: RATIS-310.01.patch > > > Currently, ratis retries indefinitely if a client request fails. This Jira > aims to add retryPolicy in Ratis which : > 1) Adds a policy to retry with a fixed count and with fixed sleep interval > 2) Default policy is set to RETRY_FOREVER -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-310) Add support for Retry Policy in Ratis
[ https://issues.apache.org/jira/browse/RATIS-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-310: -- Attachment: RATIS-310.01.patch > Add support for Retry Policy in Ratis > - > > Key: RATIS-310 > URL: https://issues.apache.org/jira/browse/RATIS-310 > Project: Ratis > Issue Type: Bug >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee >Priority: Major > Labels: ozone > Attachments: RATIS-310.01.patch > > > Currently, ratis retries indefinitely if a client request fails. This Jira > aims to add retryPolicy in Ratis which : > 1) Adds a policy to retry with a fixed count and with fixed sleep interval > 2) Default policy is set to RETRY_FOREVER -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-310) Add support for Retry Policy in Ratis
[ https://issues.apache.org/jira/browse/RATIS-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shashikant Banerjee updated RATIS-310: -- Attachment: (was: RATIS-310.00.patch) > Add support for Retry Policy in Ratis > - > > Key: RATIS-310 > URL: https://issues.apache.org/jira/browse/RATIS-310 > Project: Ratis > Issue Type: Bug >Reporter: Shashikant Banerjee >Assignee: Shashikant Banerjee >Priority: Major > Labels: ozone > Attachments: RATIS-310.01.patch > > > Currently, ratis retries indefinitely if a client request fails. This Jira > aims to add retryPolicy in Ratis which : > 1) Adds a policy to retry with a fixed count and with fixed sleep interval > 2) Default policy is set to RETRY_FOREVER -- This message was sent by Atlassian JIRA (v7.6.3#76005)
