[jira] [Created] (RATIS-351) Wrong specifier is used for Preconditions.assertTrue of GrpcLogAppender#onSuccess

2018-10-12 Thread Ted Yu (JIRA)
Ted Yu created RATIS-351:


 Summary: Wrong specifier is used for Preconditions.assertTrue of 
GrpcLogAppender#onSuccess
 Key: RATIS-351
 URL: https://issues.apache.org/jira/browse/RATIS-351
 Project: Ratis
  Issue Type: Bug
Reporter: Ted Yu


Here is related code:
{code}
  Preconditions.assertTrue(!request.hasPreviousLog() ||
  lastIndex == request.getPreviousLog().getIndex(),
  "reply's next index is %s, request's previous is %s",
  replyNextIndex, request.getPreviousLog());
{code}
The '%s' seems to be wrong.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (RATIS-350) Restore interrupt status upon catching InterruptedException

2018-10-12 Thread Ted Yu (JIRA)
Ted Yu created RATIS-350:


 Summary: Restore interrupt status upon catching 
InterruptedException
 Key: RATIS-350
 URL: https://issues.apache.org/jira/browse/RATIS-350
 Project: Ratis
  Issue Type: Improvement
Reporter: Ted Yu


The following example comes from GrpcLogAppender#mayWait :
{code}
  } catch(InterruptedException ie) {
LOG.warn(this + ": Wait interrupted by " + ie);
  }
{code}
The interrupt status should be restored before returning.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)