[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log
[ https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653070#comment-16653070 ] Tsz Wo Nicholas Sze commented on RATIS-341: --- I see the problem now: it should reply appendEntries with the nextIndex of the given entries (if it is non-empty) but not nextIndex of the log. > Raft log index on the follower should be applied to state machine only after > writing the log > > > Key: RATIS-341 > URL: https://issues.apache.org/jira/browse/RATIS-341 > Project: Ratis > Issue Type: Bug > Components: server >Affects Versions: 0.3.0 >Reporter: Mukul Kumar Singh >Assignee: Mukul Kumar Singh >Priority: Major > Fix For: 0.3.0 > > Attachments: RATIS-341.003.patch, RATIS-341.003_committed.patch > > > In follower, RaftServerImpl#appendEntriesAsync, entries should only be > applied to state machine > only after writing the log to the state machine. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-342) Move logservice protocol buffers to ratis-logservice module
[ https://issues.apache.org/jira/browse/RATIS-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653065#comment-16653065 ] Janos Gub commented on RATIS-342: - [~elserj] Actually that was with patch v0, the new one (v1) just fixes the whitespace issue. I am not sure what to do with the javadoc warnings as those come from the generated protobuf code. > Move logservice protocol buffers to ratis-logservice module > --- > > Key: RATIS-342 > URL: https://issues.apache.org/jira/browse/RATIS-342 > Project: Ratis > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Janos Gub >Priority: Major > Labels: newbie > Attachments: RATIS-342.2.patch, RATIS-342.patch > > > Let's try to keep all of the logservice "code" in one place, thus keeping > everything in one jar. > We should be able to copy the relevant maven plugin configuration from > ratis-proto into ratis-logservice to compile the protobuf spec files into > java code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-253) Segmented Raft log rolls over segment frequently
[
https://issues.apache.org/jira/browse/RATIS-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652997#comment-16652997
]
Tsz Wo Nicholas Sze commented on RATIS-253:
---
The formula is to calculate the LogEntryProto size after stateMachineData is
removed so that we may implement as below. TestRestartRaftPeer can pass with
it.
{code}
static long getEntrySize(LogEntryProto entry) {
final int serialized =
ProtoUtils.removeStateMachineData(entry).getSerializedSize();
return serialized + CodedOutputStream.computeUInt32SizeNoTag(serialized) +
4;
}
{code}
However, the above method may unnecessarily copy data. Since we are going to
refactor LogEntryProto (RATIS-353), let use it as a workaround. We will
improve it in RATIS-353 or its subtasks.
> Segmented Raft log rolls over segment frequently
>
>
> Key: RATIS-253
> URL: https://issues.apache.org/jira/browse/RATIS-253
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.2.0
>Reporter: Mukul Kumar Singh
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Labels: ozone
> Fix For: 0.3.0
>
> Attachments: RATIS-253.patch
>
>
> With statemachine implementation which abstract out the state machine data
> from the append entries, frequent log rollovers can be observed.
> Looking into the code, this seems to be because of 2 reasons.
> a) LogSegment#append, updates the total size. However the size which needs to
> be considered should not include the statemachine data.
> b) Also SegmentRaftLog#isSegmentFull also considers the total proto object.
> Here too, only the entry to be written to the log should be considered.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-253) Segmented Raft log rolls over segment frequently
[ https://issues.apache.org/jira/browse/RATIS-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652991#comment-16652991 ] Tsz Wo Nicholas Sze commented on RATIS-253: --- This probably is the cause of the bug in the formula -- In ProtoUtils.removeStateMachineData(..), it also calls setStateMachineDataAttached(..) and setSerializedProtobufSize(..). The formula only subtracts the stateMachineData size but not adds the size for serializedProtobufSize. Let me see if I could fix it. > Segmented Raft log rolls over segment frequently > > > Key: RATIS-253 > URL: https://issues.apache.org/jira/browse/RATIS-253 > Project: Ratis > Issue Type: Bug > Components: server >Affects Versions: 0.2.0 >Reporter: Mukul Kumar Singh >Assignee: Rajeshbabu Chintaguntla >Priority: Major > Labels: ozone > Fix For: 0.3.0 > > Attachments: RATIS-253.patch > > > With statemachine implementation which abstract out the state machine data > from the append entries, frequent log rollovers can be observed. > Looking into the code, this seems to be because of 2 reasons. > a) LogSegment#append, updates the total size. However the size which needs to > be considered should not include the statemachine data. > b) Also SegmentRaftLog#isSegmentFull also considers the total proto object. > Here too, only the entry to be written to the log should be considered. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-274) Read/Write-path of log stream state machine
[
https://issues.apache.org/jira/browse/RATIS-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652660#comment-16652660
]
Ted Yu commented on RATIS-274:
--
{code}
+ public ByteBuffer readNext() throws IOException {
+int num = 1;
+RaftClientReply reply =
+raftClient.sendReadOnly(Message.valueOf(LogServiceProtoUtil
+.toReadLogRequestProto(parent.getName(), currentRecordId, num)
{code}
It seems num is not modified within the method. It can be hardcoded directly.
{code}
+proto.getLogRecord(0);
{code}
The above line can be removed.
{code}
+if (proto.hasException()) {
+ LogServiceException e = proto.getException();
+ throw new IOException(e.getErrorMsg());
{code}
It would be better to wrap IOE around the exception, e, so that we have more
clue as for the cause.
It seems the body of the two {{readNext}} methods can be unified - they look
mostly the same.
{code}
+currentRecordId+= numRecords;
+List ret = new ArrayList();
+int n = proto.getLogRecordCount();
{code}
Should we check n == numRecords ?
{code}
+ public Collection getRecordListeners() {
+return listeners;
{code}
I think returning unmodifiable collection would be better.
{code}
+ List listeners;
{code}
If order of listeners is not important, Set can be used.
> Read/Write-path of log stream state machine
> ---
>
> Key: RATIS-274
> URL: https://issues.apache.org/jira/browse/RATIS-274
> Project: Ratis
> Issue Type: Sub-task
> Components: LogService
>Reporter: Josh Elser
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: RATIS-274-v1.patch, RATIS-274-v2.patch
>
>
> Implement the ability to read/write data to a log stream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[
https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652182#comment-16652182
]
Hadoop QA commented on RATIS-354:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
4s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 33s{color} | {color:orange} root: The patch generated 86 new + 1242
unchanged - 126 fixed = 1328 total (was 1368) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 31s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerSlownessDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-16
|
| JIRA Issue | RATIS-354 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944179/r354_20181017b.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux e0c5ae0df6da 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 940a169 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/400/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/400/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/400/testReport/ |
| modules | C: ratis-proto ratis-common ratis-server ratis-grpc ratis-examples
ratis-logservice U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/400/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Remove LeaderNoOp and rename SMLogEntryProto
>
>
> Key: RATIS-354
> URL: https://issues.apache.org/jira/browse/RATIS-354
> Project: Ratis
> Issu
[jira] [Commented] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652134#comment-16652134 ] Tsz Wo Nicholas Sze commented on RATIS-354: --- r354_20181017b.patch: fixes a bug introduced by RATIS-332. > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181017b.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-354: -- Attachment: r354_20181017b.patch > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181017b.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-354: -- Attachment: (was: r354_20181017.patch) > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181017b.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-253) Segmented Raft log rolls over segment frequently
[
https://issues.apache.org/jira/browse/RATIS-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652113#comment-16652113
]
Tsz Wo Nicholas Sze commented on RATIS-253:
---
[~rajeshbabu], just found that TestRestartRaftPeer failed after this commit
(6369d4e65eb3d733d101786b6c79ca600bdace77). If I reset the head to right
before this (2ce10dc1a88b7657c7d63e02774459afd8724c4d), the test can pass.
{code}
commit 6369d4e65eb3d733d101786b6c79ca600bdace77 (HEAD -> master)
Author: Tsz Wo Nicholas Sze
Date: Tue Sep 11 12:03:57 2018 -0700
RATIS-253. Segmented Raft log rolls over segment frequently. Contributed
by Rajeshbabu Chintaguntla
commit 2ce10dc1a88b7657c7d63e02774459afd8724c4d
Author: Tsz Wo Nicholas Sze
Date: Tue Sep 11 11:04:22 2018 -0700
RATIS-310. Add support for Retry Policy in Ratis. Contributed by
Shashikant Banerjee
{code}
Could you take a look?
> Segmented Raft log rolls over segment frequently
>
>
> Key: RATIS-253
> URL: https://issues.apache.org/jira/browse/RATIS-253
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.2.0
>Reporter: Mukul Kumar Singh
>Assignee: Rajeshbabu Chintaguntla
>Priority: Major
> Labels: ozone
> Fix For: 0.3.0
>
> Attachments: RATIS-253.patch
>
>
> With statemachine implementation which abstract out the state machine data
> from the append entries, frequent log rollovers can be observed.
> Looking into the code, this seems to be because of 2 reasons.
> a) LogSegment#append, updates the total size. However the size which needs to
> be considered should not include the statemachine data.
> b) Also SegmentRaftLog#isSegmentFull also considers the total proto object.
> Here too, only the entry to be written to the log should be considered.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log
[
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652071#comment-16652071
]
Tsz Wo Nicholas Sze commented on RATIS-341:
---
[~msingh], just found that TestBatchAppend failed with gRPC after the commit of
this (c3845bc3f3044f513347d8fec220e4e289a0ea5b). If I reset the head to right
before this (b0dc99205ff6394f4f7698b443a5b2989947bcf5), the test can pass.
{code}
commit c3845bc3f3044f513347d8fec220e4e289a0ea5b
Author: Tsz Wo Nicholas Sze
Date: Sun Oct 7 05:34:53 2018 +0800
RATIS-341. Raft log index on the follower should be applied to state
machine only after writing the log. Contributed by Mukul Kumar Singh
commit b0dc99205ff6394f4f7698b443a5b2989947bcf5
Author: Tsz Wo Nicholas Sze
Date: Sat Oct 6 08:25:41 2018 +0800
RATIS-340. org.apache.hadoop.ipc.protobuf is shaded to
org.apache.ratis.shaded.*.
{code}
Could you take a look?
> Raft log index on the follower should be applied to state machine only after
> writing the log
>
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
> Issue Type: Bug
> Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.003.patch, RATIS-341.003_committed.patch
>
>
> In follower, RaftServerImpl#appendEntriesAsync, entries should only be
> applied to state machine
> only after writing the log to the state machine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652052#comment-16652052 ] Tsz Wo Nicholas Sze commented on RATIS-354: --- > All tests have passed in my machine. It is not true. Some example tests have failed, although they does not seem related to the patch. > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181017.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[
https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652048#comment-16652048
]
Hadoop QA commented on RATIS-354:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 33s{color} | {color:orange} root: The patch generated 86 new + 1242
unchanged - 126 fixed = 1328 total (was 1368) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 1s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.netty.TestRaftWithNetty |
| | ratis.grpc.TestRaftWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-16
|
| JIRA Issue | RATIS-354 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944166/r354_20181017.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux f30f6d11170e 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 940a169 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/399/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/399/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/399/testReport/ |
| modules | C: ratis-proto ratis-common ratis-server ratis-grpc ratis-examples
ratis-logservice U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/399/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Remove LeaderNoOp and rename SMLogEntryProto
>
>
> Key: RATIS-354
> URL: https://issues.apache.org/jira/browse/RATIS-354
> Proj
[jira] [Commented] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652011#comment-16652011 ] Tsz Wo Nicholas Sze commented on RATIS-354: --- r354_20181017.patch: fixes test failures. All tests have passed in my machine. > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181017.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-354: -- Attachment: r354_20181017.patch > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181017.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-354: -- Attachment: (was: r354_20181016.patch) > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181017.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-342) Move logservice protocol buffers to ratis-logservice module
[ https://issues.apache.org/jira/browse/RATIS-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651965#comment-16651965 ] Josh Elser commented on RATIS-342: -- [~gubjanos], actually, if you have the time, would you mind replacing the tabs with spaces (see the QA run above). I can always fix that on commit too :) > Move logservice protocol buffers to ratis-logservice module > --- > > Key: RATIS-342 > URL: https://issues.apache.org/jira/browse/RATIS-342 > Project: Ratis > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Janos Gub >Priority: Major > Labels: newbie > Attachments: RATIS-342.2.patch, RATIS-342.patch > > > Let's try to keep all of the logservice "code" in one place, thus keeping > everything in one jar. > We should be able to copy the relevant maven plugin configuration from > ratis-proto into ratis-logservice to compile the protobuf spec files into > java code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-342) Move logservice protocol buffers to ratis-logservice module
[ https://issues.apache.org/jira/browse/RATIS-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651962#comment-16651962 ] Josh Elser commented on RATIS-342: -- Thanks for the patch, [~gubjanos]! Looks straightforward to me. There's a big patch from [~vrodionov] close over on RATIS-274. Assuming that one is coming in today, I might hold off on merging this until we get that one in (your patch is a much easier rebase :)) > Move logservice protocol buffers to ratis-logservice module > --- > > Key: RATIS-342 > URL: https://issues.apache.org/jira/browse/RATIS-342 > Project: Ratis > Issue Type: Sub-task >Reporter: Josh Elser >Assignee: Janos Gub >Priority: Major > Labels: newbie > Attachments: RATIS-342.2.patch, RATIS-342.patch > > > Let's try to keep all of the logservice "code" in one place, thus keeping > everything in one jar. > We should be able to copy the relevant maven plugin configuration from > ratis-proto into ratis-logservice to compile the protobuf spec files into > java code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[
https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651446#comment-16651446
]
Hadoop QA commented on RATIS-354:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
23s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
32s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 27s{color} | {color:orange} root: The patch generated 86 new + 959 unchanged
- 126 fixed = 1045 total (was 1085) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 21m 21s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
9s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 5s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftAsyncWithGrpc |
| | ratis.grpc.TestRaftWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-16
|
| JIRA Issue | RATIS-354 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944075/r354_20181016.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 143bc33c713c 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 940a169 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/398/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/398/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/398/testReport/ |
| modules | C: ratis-proto ratis-common ratis-server ratis-grpc ratis-examples
ratis-logservice U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/398/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Remove LeaderNoOp and rename SMLogEntryProto
>
>
> Key: RATIS-354
> URL: https://issues.apache.org/jira/browse/RATIS-354
> Pr
[jira] [Updated] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-354: -- Description: - Remove LeaderNoOp – it is not used. - Rename SMLogEntryProto to StateMachineLogEntryProto. -* As well rename the 'data' field to 'logData'. was: - Remove LeaderNoOp – it is not used. - Rename SMLogEntryProto to StateMachineLogEntryProto. > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181016.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-354: -- Attachment: r354_20181016.patch > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181016.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651298#comment-16651298 ] Tsz Wo Nicholas Sze commented on RATIS-354: --- r354_20181016.patch: 1st patch. > Remove LeaderNoOp and rename SMLogEntryProto > > > Key: RATIS-354 > URL: https://issues.apache.org/jira/browse/RATIS-354 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r354_20181016.patch > > > - Remove LeaderNoOp – it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > -* As well rename the 'data' field to 'logData'. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RATIS-354) Remove LeaderNoOp and rename SMLogEntryProto
Tsz Wo Nicholas Sze created RATIS-354: - Summary: Remove LeaderNoOp and rename SMLogEntryProto Key: RATIS-354 URL: https://issues.apache.org/jira/browse/RATIS-354 Project: Ratis Issue Type: Sub-task Components: server Reporter: Tsz Wo Nicholas Sze Assignee: Tsz Wo Nicholas Sze - Remove LeaderNoOp – it is not used. - Rename SMLogEntryProto to StateMachineLogEntryProto. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-353) Refactor LogEntryProto
[ https://issues.apache.org/jira/browse/RATIS-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16651296#comment-16651296 ] Tsz Wo Nicholas Sze commented on RATIS-353: --- The patch is huge (> 100kB). Will separate it into some subtasks. > Refactor LogEntryProto > -- > > Key: RATIS-353 > URL: https://issues.apache.org/jira/browse/RATIS-353 > Project: Ratis > Issue Type: Improvement > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Major > > We propose some refactoring on LogEntryProto: > - Remove LeaderNoOp -- it is not used. > - Rename SMLogEntryProto to StateMachineLogEntryProto. > - Move clientId and callId from LogEntryProto to StateMachineLogEntryProto. > - Adds StateMachineEntryProto for stateMachineData. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
