[jira] [Commented] (RATIS-381) RaftTestUtil.waitForLeader should not return null
[
https://issues.apache.org/jira/browse/RATIS-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672539#comment-16672539
]
Hadoop QA commented on RATIS-381:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 46s{color}
| {color:red} root generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0)
{color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 16s{color} | {color:orange} root: The patch generated 43 new + 137 unchanged
- 11 fixed = 180 total (was 148) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 20s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 6m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-11-02
|
| JIRA Issue | RATIS-381 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946536/r381_20181101b.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux f897c67ccd75 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 27c2dfe |
| Default Java | 1.8.0_181 |
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/483/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/483/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/483/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/483/testReport/ |
| modules | C: ratis-common ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/483/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> RaftTestUtil.waitForLeader should not return null
> -
>
> Key: RATIS-381
> URL: https://issues.apache.org/jira/browse/RATIS-381
> Project: Ratis
> Issue Type: Improvement
> Components: test
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo
[jira] [Created] (RATIS-388) Remove the deprecated attempt(..) methods from JavaUtils
Tsz Wo Nicholas Sze created RATIS-388: - Summary: Remove the deprecated attempt(..) methods from JavaUtils Key: RATIS-388 URL: https://issues.apache.org/jira/browse/RATIS-388 Project: Ratis Issue Type: Improvement Components: util, test Reporter: Tsz Wo Nicholas Sze The attempt(..) methods with long sleepMs parameter were deprecated by RATIS-381. Let's remove them and use the ones with TimeDuration sleepTime parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-381) RaftTestUtil.waitForLeader should not return null
[ https://issues.apache.org/jira/browse/RATIS-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672493#comment-16672493 ] Tsz Wo Nicholas Sze commented on RATIS-381: --- bq. -1 unit0m 18s root in the patch failed. Some Jenkins machine do not work well. The unit tests even can be started to run; see https://builds.apache.org/job/PreCommit-RATIS-Build/482/artifact/out/patch-unit-root.txt All tests passed in my machine locally. bq. -1 javac 0m 46s root generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0) The new javac warnings are due to deprecation of some API. Will fix them separately. > RaftTestUtil.waitForLeader should not return null > - > > Key: RATIS-381 > URL: https://issues.apache.org/jira/browse/RATIS-381 > Project: Ratis > Issue Type: Improvement > Components: test >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r381_20181101b.patch > > > Some tests may fail with NullPointerException since > RaftTestUtil.waitForLeader(..) may return null (and the tests do not check > for null) when leader elections take a long time. > It seems RaftTestUtil.waitForLeader(..) better waits for a longer period and, > if there is a no leader, throw an exception with some descriptive error > message, instead of returning null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-381) RaftTestUtil.waitForLeader should not return null
[
https://issues.apache.org/jira/browse/RATIS-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672485#comment-16672485
]
Hadoop QA commented on RATIS-381:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 46s{color}
| {color:red} root generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0)
{color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 17s{color} | {color:orange} root: The patch generated 43 new + 137 unchanged
- 11 fixed = 180 total (was 148) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 18s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
6s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 6m 1s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-11-02
|
| JIRA Issue | RATIS-381 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946536/r381_20181101b.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux 7d44f54c9fef 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 27c2dfe |
| Default Java | 1.8.0_181 |
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/482/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/482/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/482/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/482/testReport/ |
| modules | C: ratis-common ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/482/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> RaftTestUtil.waitForLeader should not return null
> -
>
> Key: RATIS-381
> URL: https://issues.apache.org/jira/browse/RATIS-381
> Project: Ratis
> Issue Type: Improvement
> Components: test
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo
[jira] [Commented] (RATIS-383) Shade native library tcnative for grpc/netty in Ratis-Thirdparty
[ https://issues.apache.org/jira/browse/RATIS-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672354#comment-16672354 ] ASF GitHub Bot commented on RATIS-383: -- joshelser commented on issue #1: RATIS-383. Shade native library tcnative for grpc/netty in Ratis-Thir… URL: https://github.com/apache/incubator-ratis-thirdparty/pull/1#issuecomment-435218036 > I have a prototype in ozone datanode container service (GRPC) with mTLS that works with this change. Otherwise, tcnative will not be linked properly (missing the shaded prefix). That's awesome. Thanks @xiaoyuyao! Is this something simple that you can give me instructions to validate? There is an 0.1.0 rc1 VOTE on-going now. Should we get this fix (validated by your test) into this release? Or can we wait for it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shade native library tcnative for grpc/netty in Ratis-Thirdparty > > > Key: RATIS-383 > URL: https://issues.apache.org/jira/browse/RATIS-383 > Project: Ratis > Issue Type: Bug > Components: security >Reporter: Mukul Kumar Singh >Assignee: Xiaoyu Yao >Priority: Major > Labels: ozone > Attachments: RATIS-383.001.patch > > > RATIS-246 discusses making GRPC endpoint secure with mTLS. This jira is > needed as GRPC/netty has dependency on tcnative jar/libraries that need to be > shaded in Ratis-Thirdparty. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-383) Shade native library tcnative for grpc/netty in Ratis-Thirdparty
[ https://issues.apache.org/jira/browse/RATIS-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672351#comment-16672351 ] ASF GitHub Bot commented on RATIS-383: -- xiaoyuyao commented on issue #1: RATIS-383. Shade native library tcnative for grpc/netty in Ratis-Thir… URL: https://github.com/apache/incubator-ratis-thirdparty/pull/1#issuecomment-435217679 I have a prototype in ozone datanode container service (GRPC) with mTLS that works with this change. Otherwise, tcnative will not be linked properly (missing the shaded prefix). I will attach a patch to https://issues.apache.org/jira/browse/RATIS-246 along with a unit test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shade native library tcnative for grpc/netty in Ratis-Thirdparty > > > Key: RATIS-383 > URL: https://issues.apache.org/jira/browse/RATIS-383 > Project: Ratis > Issue Type: Bug > Components: security >Reporter: Mukul Kumar Singh >Assignee: Xiaoyu Yao >Priority: Major > Labels: ozone > Attachments: RATIS-383.001.patch > > > RATIS-246 discusses making GRPC endpoint secure with mTLS. This jira is > needed as GRPC/netty has dependency on tcnative jar/libraries that need to be > shaded in Ratis-Thirdparty. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-383) Shade native library tcnative for grpc/netty in Ratis-Thirdparty
[ https://issues.apache.org/jira/browse/RATIS-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672312#comment-16672312 ] ASF GitHub Bot commented on RATIS-383: -- joshelser commented on issue #1: RATIS-383. Shade native library tcnative for grpc/netty in Ratis-Thir… URL: https://github.com/apache/incubator-ratis-thirdparty/pull/1#issuecomment-435214506 Thanks for putting this together @xiaoyuyao. When I was putting this together, I had concerns as to how the tcnative stuff worked, but, frankly, didn't know how to even go about verifying it. While I can look at your patch and understand the changes you've made, I still don't know how to say if they'll work as expected. Can you enlighten me? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Shade native library tcnative for grpc/netty in Ratis-Thirdparty > > > Key: RATIS-383 > URL: https://issues.apache.org/jira/browse/RATIS-383 > Project: Ratis > Issue Type: Bug > Components: security >Reporter: Mukul Kumar Singh >Assignee: Xiaoyu Yao >Priority: Major > Labels: ozone > Attachments: RATIS-383.001.patch > > > RATIS-246 discusses making GRPC endpoint secure with mTLS. This jira is > needed as GRPC/netty has dependency on tcnative jar/libraries that need to be > shaded in Ratis-Thirdparty. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-381) RaftTestUtil.waitForLeader should not return null
[
https://issues.apache.org/jira/browse/RATIS-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672034#comment-16672034
]
Hadoop QA commented on RATIS-381:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
2s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
53s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 53s{color}
| {color:red} root generated 25 new + 94 unchanged - 0 fixed = 119 total (was
94) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 16s{color} | {color:orange} root: The patch generated 43 new + 134 unchanged
- 11 fixed = 177 total (was 145) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 5m 44s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 2s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-11-01
|
| JIRA Issue | RATIS-381 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946536/r381_20181101b.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux 3eb4c0c79b97 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 1d2ebee |
| Default Java | 1.8.0_181 |
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/481/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/481/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/481/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/481/testReport/ |
| modules | C: ratis-common ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/481/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> RaftTestUtil.waitForLeader should not return null
> -
>
> Key: RATIS-381
> URL:
[jira] [Commented] (RATIS-262) Fix compilation warning and deprecated api usage
[
https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672025#comment-16672025
]
Jitendra Nath Pandey commented on RATIS-262:
+1, thanks for the patch [~szetszwo].
> Fix compilation warning and deprecated api usage
>
>
> Key: RATIS-262
> URL: https://issues.apache.org/jira/browse/RATIS-262
> Project: Ratis
> Issue Type: Bug
> Components: build
>Reporter: Elek, Marton
>Assignee: Tsz Wo Nicholas Sze
>Priority: Minor
> Attachments: r262_20181021.patch
>
>
> During the 0.2.0-rc2 vote [~khmarbaise] wrote the following comment:
> {quote}
> so far so good and got several messages about deprecated calls and things
> like this:
>
> INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @
> ratis-server ---
> [INFO] Compiling 55 source files to
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/target/classes
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[48,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[57,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[67,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[85,26]
> [try] auto-closeable resource writeLock is never referenced in body of
> corresponding try statement
>
> which are not really a problem...can be fixed in the next release...
> {quote}
> Would be great to fix them long-term.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (RATIS-387) Create interactive demo client
Josh Elser created RATIS-387:
Summary: Create interactive demo client
Key: RATIS-387
URL: https://issues.apache.org/jira/browse/RATIS-387
Project: Ratis
Issue Type: Sub-task
Reporter: Josh Elser
I've been thinking about how to give a "compelling" demo for the LogService. I
keep coming back to a simple shell that could be used to do simple things like
create, read, and write to a log.
I am thinking something like:
{code}
> create 'log1'
> put 'log1' 'a'
> put 'log1' 'b'
> put 'log1' 'c'
> read 'log1'
['a', 'b', 'c']
> delete 'log'
{code}
Users would provide the location of the MetaData service to this shell.
Everything else should be auto-magic (in the final version, anyways).
I think this compliments the docker infra work that [~rajeshbabu] is working on.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-381) RaftTestUtil.waitForLeader should not return null
[
https://issues.apache.org/jira/browse/RATIS-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671755#comment-16671755
]
Hadoop QA commented on RATIS-381:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 10 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 46s{color}
| {color:red} root generated 25 new + 94 unchanged - 0 fixed = 119 total (was
94) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 16s{color} | {color:orange} root: The patch generated 43 new + 134 unchanged
- 11 fixed = 177 total (was 145) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 18s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 6m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-11-01
|
| JIRA Issue | RATIS-381 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12946536/r381_20181101b.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile |
| uname | Linux 3f33398f2334 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 1d2ebee |
| Default Java | 1.8.0_181 |
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/480/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/480/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/480/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/480/testReport/ |
| modules | C: ratis-common ratis-server ratis-grpc U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/480/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> RaftTestUtil.waitForLeader should not return null
> -
>
> Key: RATIS-381
> URL: https://issues.apache.org/jira/browse/RATIS-381
> Project: Ratis
> Issue Type: Improvement
> Components: test
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo
[jira] [Updated] (RATIS-381) RaftTestUtil.waitForLeader should not return null
[ https://issues.apache.org/jira/browse/RATIS-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-381: -- Attachment: r381_20181101b.patch > RaftTestUtil.waitForLeader should not return null > - > > Key: RATIS-381 > URL: https://issues.apache.org/jira/browse/RATIS-381 > Project: Ratis > Issue Type: Improvement > Components: test >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r381_20181101b.patch > > > Some tests may fail with NullPointerException since > RaftTestUtil.waitForLeader(..) may return null (and the tests do not check > for null) when leader elections take a long time. > It seems RaftTestUtil.waitForLeader(..) better waits for a longer period and, > if there is a no leader, throw an exception with some descriptive error > message, instead of returning null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RATIS-381) RaftTestUtil.waitForLeader should not return null
[ https://issues.apache.org/jira/browse/RATIS-381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated RATIS-381: -- Attachment: (was: r381_20181101.patch) > RaftTestUtil.waitForLeader should not return null > - > > Key: RATIS-381 > URL: https://issues.apache.org/jira/browse/RATIS-381 > Project: Ratis > Issue Type: Improvement > Components: test >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r381_20181101b.patch > > > Some tests may fail with NullPointerException since > RaftTestUtil.waitForLeader(..) may return null (and the tests do not check > for null) when leader elections take a long time. > It seems RaftTestUtil.waitForLeader(..) better waits for a longer period and, > if there is a no leader, throw an exception with some descriptive error > message, instead of returning null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-381) RaftTestUtil.waitForLeader should not return null
[ https://issues.apache.org/jira/browse/RATIS-381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16671497#comment-16671497 ] Tsz Wo Nicholas Sze commented on RATIS-381: --- r381_20181101b.patch: fixes test failures. > RaftTestUtil.waitForLeader should not return null > - > > Key: RATIS-381 > URL: https://issues.apache.org/jira/browse/RATIS-381 > Project: Ratis > Issue Type: Improvement > Components: test >Reporter: Tsz Wo Nicholas Sze >Assignee: Tsz Wo Nicholas Sze >Priority: Minor > Attachments: r381_20181101b.patch > > > Some tests may fail with NullPointerException since > RaftTestUtil.waitForLeader(..) may return null (and the tests do not check > for null) when leader elections take a long time. > It seems RaftTestUtil.waitForLeader(..) better waits for a longer period and, > if there is a no leader, throw an exception with some descriptive error > message, instead of returning null. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (RATIS-386) Raft Client Async API's should honor Retry Policy
Shashikant Banerjee created RATIS-386: - Summary: Raft Client Async API's should honor Retry Policy Key: RATIS-386 URL: https://issues.apache.org/jira/browse/RATIS-386 Project: Ratis Issue Type: Improvement Components: client Affects Versions: 0.3.0 Reporter: Shashikant Banerjee Assignee: Shashikant Banerjee Fix For: 0.3.0 Raft client sync Api has support for retry policies. Similarly, for Async API's including watch Api, support for Retry Policy is required. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
