[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-22 Thread Hadoop QA (Jira)


[ 
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089915#comment-17089915
 ] 

Hadoop QA commented on RATIS-850:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
42s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 33m 18s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
20s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 44m 25s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.TestLogServiceWithNetty |
|   | ratis.logservice.server.TestMetaServer |
|   | ratis.grpc.TestRaftWithGrpc |
|   | ratis.grpc.TestRaftStateMachineExceptionWithGrpc |
|   | ratis.grpc.TestRaftServerWithGrpc |
|   | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
|   | ratis.server.raftlog.TestRaftLogMetrics |
|   | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
|   | ratis.netty.TestRaftSnapshotWithNetty |
|   | ratis.grpc.TestRaftAsyncWithGrpc |
|   | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
|   | ratis.grpc.TestInstallSnapshotNotificationWithGrpc |
|   | ratis.server.simulation.TestRaftWithSimulatedRpc |
|   | ratis.examples.filestore.TestFileStoreWithGrpc |
|   | ratis.examples.filestore.TestFileStoreWithNetty |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 Image:yetus/ratis:date2020-04-22 |
| JIRA Issue | RATIS-850 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13000871/RATIS-850.003.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
checkstyle  compile  |
| uname | Linux 63177a4fb3b2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 
08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / 64586b1 |
| maven | version: Apache Maven 3.6.3 
(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Default Java | 1.8.0_242 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1304/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1304/testReport/ |
| Max. process+thread count | 1207 (vs. ulimit of 5000) |
| modules | C: ratis-server U: ratis-server |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1304/console |
| Powered 

[jira] [Updated] (RATIS-850) Allow log purge up to snapshot index

2020-04-22 Thread Hanisha Koneru (Jira)


 [ 
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hanisha Koneru updated RATIS-850:
-
Attachment: RATIS-850.003.patch

> Allow log purge up to snapshot index
> 
>
> Key: RATIS-850
> URL: https://issues.apache.org/jira/browse/RATIS-850
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: RATIS-850.001.patch, RATIS-850.002.patch, 
> RATIS-850.003.patch
>
>
> Ratis logs are purged only up to the least commit index on all the peers. But 
> if one peer is down, it stop log purging on all the peers. If the Ratis 
> server takes snapshots, then we can purge logs up to the snapshot index even 
> if some peer has not committed up to that index. When the peer rejoins the 
> ring, instead of ratis logs, it can get the snapshot to catch up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-22 Thread Hanisha Koneru (Jira)


[ 
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089870#comment-17089870
 ] 

Hanisha Koneru commented on RATIS-850:
--

Snapshots are a function of the StateMachine. So they should ideally be kept 
independent from RaftServer logs. 
But I see your point. Let's purge upto snapshotIndex, if 
PURGE_UPTO_SNAPSHOT_INDEX is set to true, irrespective of commitIndex. I will 
update the patch.

> Allow log purge up to snapshot index
> 
>
> Key: RATIS-850
> URL: https://issues.apache.org/jira/browse/RATIS-850
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: RATIS-850.001.patch, RATIS-850.002.patch
>
>
> Ratis logs are purged only up to the least commit index on all the peers. But 
> if one peer is down, it stop log purging on all the peers. If the Ratis 
> server takes snapshots, then we can purge logs up to the snapshot index even 
> if some peer has not committed up to that index. When the peer rejoins the 
> ring, instead of ratis logs, it can get the snapshot to catch up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (RATIS-876) Introduce max timeout in RequestTypeDependentRetryPolicy

2020-04-22 Thread Lokesh Jain (Jira)
Lokesh Jain created RATIS-876:
-

 Summary: Introduce max timeout in RequestTypeDependentRetryPolicy
 Key: RATIS-876
 URL: https://issues.apache.org/jira/browse/RATIS-876
 Project: Ratis
  Issue Type: Bug
Reporter: Lokesh Jain
Assignee: Lokesh Jain


This Jira aims to add a max timeout in RequestTypeDependentRetryPolicy. If a 
timeout of 1 minute is configured then all retries after 1 minute of request 
creation will fail.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (RATIS-841) Remove unnecessary exception checks in OrderedAsync#sendRequest

2020-04-22 Thread Hadoop QA (Jira)


[ 
https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089543#comment-17089543
 ] 

Hadoop QA commented on RATIS-841:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  2m 
14s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
 3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m  8s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
22s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 32m 41s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.simulation.TestRaftWithSimulatedRpc |
|   | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
|   | ratis.grpc.TestRaftSnapshotWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 Image:yetus/ratis:date2020-04-22 |
| JIRA Issue | RATIS-841 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13000821/RATIS-841.002.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
checkstyle  compile  |
| uname | Linux e76b40d448bb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / c2e855d |
| maven | version: Apache Maven 3.6.3 
(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Default Java | 1.8.0_242 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1302/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1302/testReport/ |
| Max. process+thread count | 2863 (vs. ulimit of 5000) |
| modules | C: ratis-client U: ratis-client |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1302/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Remove unnecessary exception checks in OrderedAsync#sendRequest
> ---
>
> Key: RATIS-841
> URL: https://issues.apache.org/jira/browse/RATIS-841
> Project: Ratis
>  Issue Type: Bug
>  Components: client
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Attachments: RATIS-841.001.patch, RATIS-841.002.patch
>
>
> OrderedAsync#sendRequest does not require 

[jira] [Resolved] (RATIS-875) Bump the copyright year in the NOTICE of thirdparty

2020-04-22 Thread Mukul Kumar Singh (Jira)


 [ 
https://issues.apache.org/jira/browse/RATIS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mukul Kumar Singh resolved RATIS-875.
-
Resolution: Fixed

I have merged this to Ratis thirdparty master.

> Bump the copyright year in the NOTICE of thirdparty
> ---
>
> Key: RATIS-875
> URL: https://issues.apache.org/jira/browse/RATIS-875
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Marton Elek
>Assignee: Marton Elek
>Priority: Trivial
>
> Reported by [~arp]  during a 0.4.0 rc vote.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (RATIS-841) Remove unnecessary exception checks in OrderedAsync#sendRequest

2020-04-22 Thread Lokesh Jain (Jira)


[ 
https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089518#comment-17089518
 ] 

Lokesh Jain commented on RATIS-841:
---

Uploaded rebased v2 patch.

> Remove unnecessary exception checks in OrderedAsync#sendRequest
> ---
>
> Key: RATIS-841
> URL: https://issues.apache.org/jira/browse/RATIS-841
> Project: Ratis
>  Issue Type: Bug
>  Components: client
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Attachments: RATIS-841.001.patch, RATIS-841.002.patch
>
>
> OrderedAsync#sendRequest does not require exception checks for 
> NotLeaderException as RafClientReply is already checked for these exceptions 
> in GrpcClientProtocolClient$AsyncStreamObservers.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RATIS-841) Remove unnecessary exception checks in OrderedAsync#sendRequest

2020-04-22 Thread Lokesh Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lokesh Jain updated RATIS-841:
--
Attachment: RATIS-841.002.patch

> Remove unnecessary exception checks in OrderedAsync#sendRequest
> ---
>
> Key: RATIS-841
> URL: https://issues.apache.org/jira/browse/RATIS-841
> Project: Ratis
>  Issue Type: Bug
>  Components: client
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Attachments: RATIS-841.001.patch, RATIS-841.002.patch
>
>
> OrderedAsync#sendRequest does not require exception checks for 
> NotLeaderException as RafClientReply is already checked for these exceptions 
> in GrpcClientProtocolClient$AsyncStreamObservers.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (RATIS-853) Unordered Client request should not sleep when NotLeaderException provides leader information

2020-04-22 Thread Hadoop QA (Jira)


[ 
https://issues.apache.org/jira/browse/RATIS-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089505#comment-17089505
 ] 

Hadoop QA commented on RATIS-853:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 4s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
51s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 22m 49s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
21s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 34m 17s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.grpc.TestRaftAsyncWithGrpc |
|   | ratis.grpc.TestRaftSnapshotWithGrpc |
|   | ratis.grpc.TestWatchRequestWithGrpc |
|   | ratis.server.simulation.TestServerRestartWithSimulatedRpc |
|   | ratis.netty.TestRaftReconfigurationWithNetty |
|   | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
|   | ratis.netty.TestRaftSnapshotWithNetty |
|   | ratis.examples.filestore.TestFileStoreWithNetty |
|   | ratis.examples.arithmetic.TestArithmeticLogDump |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 Image:yetus/ratis:date2020-04-22 |
| JIRA Issue | RATIS-853 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/13000811/RATIS-853.003.patch |
| Optional Tests |  dupname  asflicense  javac  javadoc  unit  findbugs  
checkstyle  compile  |
| uname | Linux e2074e2c21d7 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / c2e855d |
| maven | version: Apache Maven 3.6.3 
(cecedd343002696d0abb50b32b541b8a6ba2883f) |
| Default Java | 1.8.0_242 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1301/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1301/testReport/ |
| Max. process+thread count | 1805 (vs. ulimit of 5000) |
| modules | C: ratis-client U: ratis-client |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/1301/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> Unordered Client request should not sleep when NotLeaderException provides 
> leader information
> -
>
> Key: RATIS-853

[jira] [Created] (RATIS-875) Bump the copyright year in the NOTICE of thirdparty

2020-04-22 Thread Marton Elek (Jira)
Marton Elek created RATIS-875:
-

 Summary: Bump the copyright year in the NOTICE of thirdparty
 Key: RATIS-875
 URL: https://issues.apache.org/jira/browse/RATIS-875
 Project: Ratis
  Issue Type: Improvement
Reporter: Marton Elek
Assignee: Marton Elek


Reported by [~arp]  during a 0.4.0 rc vote.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (RATIS-853) Unordered Client request should not sleep when NotLeaderException provides leader information

2020-04-22 Thread Lokesh Jain (Jira)


 [ 
https://issues.apache.org/jira/browse/RATIS-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lokesh Jain updated RATIS-853:
--
Attachment: RATIS-853.003.patch

> Unordered Client request should not sleep when NotLeaderException provides 
> leader information
> -
>
> Key: RATIS-853
> URL: https://issues.apache.org/jira/browse/RATIS-853
> Project: Ratis
>  Issue Type: Bug
>  Components: client
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Attachments: RATIS-853.001.patch, RATIS-853.002.patch, 
> RATIS-853.003.patch
>
>
> When NotLeaderException provides leader information, the client request 
> should be retried immediately on the suggested leader. Currently Unordered 
> requests in raft client use the default policy to determine sleep time and 
> thus may sleep even if NotLeaderException provides leader information.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (RATIS-850) Allow log purge up to snapshot index

2020-04-22 Thread Lokesh Jain (Jira)


[ 
https://issues.apache.org/jira/browse/RATIS-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089316#comment-17089316
 ] 

Lokesh Jain commented on RATIS-850:
---

[~hanishakoneru] I agree. What I am wondering is if deleting till 
minCommitIndex could lead to problems. Lets suppose the server deletes log 
entries for which a snapshot has not yet been taken. Now when the server needs 
to take a snapshot it will not find these entries. The snapshot implementation 
should not be dependent on these log entries. I am just thinking if this could 
lead to bugs in the future and we should add some documentation regarding the 
ratis property.

> Allow log purge up to snapshot index
> 
>
> Key: RATIS-850
> URL: https://issues.apache.org/jira/browse/RATIS-850
> Project: Ratis
>  Issue Type: Improvement
>Reporter: Hanisha Koneru
>Assignee: Hanisha Koneru
>Priority: Major
> Attachments: RATIS-850.001.patch, RATIS-850.002.patch
>
>
> Ratis logs are purged only up to the least commit index on all the peers. But 
> if one peer is down, it stop log purging on all the peers. If the Ratis 
> server takes snapshots, then we can purge logs up to the snapshot index even 
> if some peer has not committed up to that index. When the peer rejoins the 
> ring, instead of ratis logs, it can get the snapshot to catch up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)