[ https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659241#comment-16659241 ]
Rajeshbabu Chintaguntla edited comment on RATIS-334 at 10/22/18 6:01 PM: ------------------------------------------------------------------------- [~sergey.soldatov] I have gone through the patch. Overall it looks good. What do you think of making APIs in LogService like createLog to createLogStream etc. as they are same as LogServiceClient APIs? As of now you are writing the log registration, ping requests in the meta state machine. I have one doubt that you still need to write the logic to rebuild the map of logname to peers by reading the snapshot right on recovery? or it will be handled by Ratis automatically? was (Author: rajeshbabu): [~sergey.soldatov] I have gone through the patch. Overall it looks good. What do you think of making APIs in LogService like createLog to createLogStream etc. as they are same as LogServiceClient APIs? As of now you are writing the log registration, ping requests in the meta state machine. I have one dount that you still need to write the logic to rebuild the map of logname to peers by reading the snapshot right on recovery? or it will be handled by Ratis automatically? > Implement server membership for LogService Metadata Service > ----------------------------------------------------------- > > Key: RATIS-334 > URL: https://issues.apache.org/jira/browse/RATIS-334 > Project: Ratis > Issue Type: Sub-task > Reporter: Josh Elser > Assignee: Sergey Soldatov > Priority: Major > Attachments: RATIS-334-v1.patch, RATIS-334-v3.patch, > RATIS-334-wip.patch > > > Half of the Metadata Service for managing LogStreams. > RATIS-279 is handling the "DDL" operations, and Rajesh suggested that we spin > out management of the servers which are available to back these LogStreams in > a second task. This is it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)