[jira] [Commented] (RATIS-262) Fix compilation warning and deprecated api usage
[
https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672025#comment-16672025
]
Jitendra Nath Pandey commented on RATIS-262:
+1, thanks for the patch [~szetszwo].
> Fix compilation warning and deprecated api usage
>
>
> Key: RATIS-262
> URL: https://issues.apache.org/jira/browse/RATIS-262
> Project: Ratis
> Issue Type: Bug
> Components: build
>Reporter: Elek, Marton
>Assignee: Tsz Wo Nicholas Sze
>Priority: Minor
> Attachments: r262_20181021.patch
>
>
> During the 0.2.0-rc2 vote [~khmarbaise] wrote the following comment:
> {quote}
> so far so good and got several messages about deprecated calls and things
> like this:
>
> INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @
> ratis-server ---
> [INFO] Compiling 55 source files to
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/target/classes
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[48,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[57,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[67,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[85,26]
> [try] auto-closeable resource writeLock is never referenced in body of
> corresponding try statement
>
> which are not really a problem...can be fixed in the next release...
> {quote}
> Would be great to fix them long-term.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-262) Fix compilation warning and deprecated api usage
[
https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658201#comment-16658201
]
Hadoop QA commented on RATIS-262:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} root generated 0 new + 0 unchanged - 99 fixed = 0
total (was 99) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 22s{color} | {color:orange} root: The patch generated 4 new + 417 unchanged
- 1 fixed = 421 total (was 418) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 24m
20s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 47s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-21
|
| JIRA Issue | RATIS-262 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944883/r262_20181021.patch |
| Optional Tests | asflicense javac javadoc unit xml compile findbugs
checkstyle |
| uname | Linux 4d58c2e6a678 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 60d0bc1 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/421/artifact/out/diff-checkstyle-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/421/testReport/ |
| modules | C: ratis-common ratis-server ratis-grpc ratis-hadoop ratis-examples
. U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/421/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Fix compilation warning and deprecated api usage
>
>
> Key: RATIS-262
> URL: https://issues.apache.org/jira/browse/RATIS-262
> Project: Ratis
> Issue Type: Bug
> Components: build
>Reporter: Elek, Marton
>Assignee: Tsz Wo Nicholas Sze
>
[jira] [Commented] (RATIS-262) Fix compilation warning and deprecated api usage
[
https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658158#comment-16658158
]
Hadoop QA commented on RATIS-262:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
33s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
34s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
44s{color} | {color:green} root generated 0 new + 0 unchanged - 99 fixed = 0
total (was 99) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 17s{color} | {color:orange} root: The patch generated 4 new + 417 unchanged
- 1 fixed = 421 total (was 418) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
28s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 48s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 25s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerSlownessDetection |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-21
|
| JIRA Issue | RATIS-262 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944883/r262_20181021.patch |
| Optional Tests | asflicense javac javadoc unit xml compile findbugs
checkstyle |
| uname | Linux 61a7773908ed 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 60d0bc1 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/420/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/420/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/420/testReport/ |
| modules | C: ratis-common ratis-server ratis-grpc ratis-hadoop ratis-examples
. U: . |
|
[jira] [Commented] (RATIS-262) Fix compilation warning and deprecated api usage
[
https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658122#comment-16658122
]
Tsz Wo Nicholas Sze commented on RATIS-262:
---
r262_20181021.patch: updated with trunk.
> Fix compilation warning and deprecated api usage
>
>
> Key: RATIS-262
> URL: https://issues.apache.org/jira/browse/RATIS-262
> Project: Ratis
> Issue Type: Bug
> Components: build
>Reporter: Elek, Marton
>Assignee: Tsz Wo Nicholas Sze
>Priority: Minor
> Attachments: r262_20181021.patch
>
>
> During the 0.2.0-rc2 vote [~khmarbaise] wrote the following comment:
> {quote}
> so far so good and got several messages about deprecated calls and things
> like this:
>
> INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @
> ratis-server ---
> [INFO] Compiling 55 source files to
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/target/classes
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[48,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[57,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[67,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[85,26]
> [try] auto-closeable resource writeLock is never referenced in body of
> corresponding try statement
>
> which are not really a problem...can be fixed in the next release...
> {quote}
> Would be great to fix them long-term.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-262) Fix compilation warning and deprecated api usage
[
https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640652#comment-16640652
]
Hadoop QA commented on RATIS-262:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
38s{color} | {color:green} root generated 0 new + 0 unchanged - 92 fixed = 0
total (was 92) {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 18s{color} | {color:orange} root: The patch generated 4 new + 418 unchanged
- 1 fixed = 422 total (was 419) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 6m 55s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 10s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-06
|
| JIRA Issue | RATIS-262 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12942666/r262_20181006.patch |
| Optional Tests | asflicense javac javadoc unit xml compile findbugs
checkstyle |
| uname | Linux eb70a8dd8029 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / b0dc992 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/378/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/378/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/378/testReport/ |
| modules | C: ratis-common ratis-server ratis-grpc ratis-hadoop ratis-examples
. U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/378/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> Fix compilation warning and deprecated api usage
>
>
> Key: RATIS-262
> URL: https://
[jira] [Commented] (RATIS-262) Fix compilation warning and deprecated api usage
[
https://issues.apache.org/jira/browse/RATIS-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640643#comment-16640643
]
Tsz Wo Nicholas Sze commented on RATIS-262:
---
r262_20181006.patch: fix/suppress warnings.
There should be no more warnings shown after the patch.
> Fix compilation warning and deprecated api usage
>
>
> Key: RATIS-262
> URL: https://issues.apache.org/jira/browse/RATIS-262
> Project: Ratis
> Issue Type: Bug
> Components: build
>Reporter: Elek, Marton
>Priority: Minor
> Attachments: r262_20181006.patch
>
>
> During the 0.2.0-rc2 vote [~khmarbaise] wrote the following comment:
> {quote}
> so far so good and got several messages about deprecated calls and things
> like this:
>
> INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @
> ratis-server ---
> [INFO] Compiling 55 source files to
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/target/classes
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[48,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[57,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[67,26]
> [try] auto-closeable resource readLock is never referenced in body of
> corresponding try statement
> [WARNING]
> /Users/kama/Downloads/ratis-incubating-0.2.0/ratis-server/src/main/java/org/apache/ratis/server/storage/MemoryRaftLog.java:[85,26]
> [try] auto-closeable resource writeLock is never referenced in body of
> corresponding try statement
>
> which are not really a problem...can be fixed in the next release...
> {quote}
> Would be great to fix them long-term.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
