[jira] [Commented] (RATIS-318) Ratis is leaking managed channel

2018-09-26 Thread Shashikant Banerjee (JIRA)


[ 
https://issues.apache.org/jira/browse/RATIS-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628882#comment-16628882
 ] 

Shashikant Banerjee commented on RATIS-318:
---

[~szetszwo], I think the issue is with closing of the xceiverClients in Ozone. 
Same issue exist with XceiverClientGrpc as well . Resolving it here.
{code:java}
Sep 26, 2018 8:11:01 PM 
org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference
 cleanQueue
SEVERE: *~*~*~ Channel ManagedChannelImpl{logId=136, target=192.168.1.2:50712} 
was not shutdown properly!!! ~*~*~*
Make sure to call shutdown()/shutdownNow() and wait until awaitTermination() 
returns true.
java.lang.RuntimeException: ManagedChannel allocation site
at 
org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.(ManagedChannelOrphanWrapper.java:103)
at 
org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper.(ManagedChannelOrphanWrapper.java:53)
at 
org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper.(ManagedChannelOrphanWrapper.java:44)
at 
org.apache.ratis.shaded.io.grpc.internal.AbstractManagedChannelImplBuilder.build(AbstractManagedChannelImplBuilder.java:410)
at 
org.apache.hadoop.hdds.scm.XceiverClientGrpc.connect(XceiverClientGrpc.java:92)
at 
org.apache.hadoop.hdds.scm.XceiverClientManager$2.call(XceiverClientManager.java:159)
at 
org.apache.hadoop.hdds.scm.XceiverClientManager$2.call(XceiverClientManager.java:144)
at 
com.google.common.cache.LocalCache$LocalManualCache$1.load(LocalCache.java:4767)
at 
com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3568)
at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2350)
at 
com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2313)
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2228)
at com.google.common.cache.LocalCache.get(LocalCache.java:3965)
at com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4764)
at 
org.apache.hadoop.hdds.scm.XceiverClientManager.getClient(XceiverClientManager.java:143)
at 
org.apache.hadoop.hdds.scm.XceiverClientManager.acquireClient(XceiverClientManager.java:122)
at 
org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.checkKeyLocationInfo(ChunkGroupOutputStream.java:192)
at 
org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.addPreallocateBlocks(ChunkGroupOutputStream.java:180)
at org.apache.hadoop.ozone.client.rpc.RpcClient.createKey(RpcClient.java:472)
at org.apache.hadoop.ozone.client.OzoneBucket.createKey(OzoneBucket.java:262)
at 
org.apache.hadoop.ozone.freon.RandomKeyGenerator$OfflineProcessor.run(RandomKeyGenerator.java:601)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:266)
at java.util.concurrent.FutureTask.run(FutureTask.java)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748){code}

> Ratis is leaking managed channel
> 
>
> Key: RATIS-318
> URL: https://issues.apache.org/jira/browse/RATIS-318
> Project: Ratis
>  Issue Type: Bug
>  Components: client
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Shashikant Banerjee
>Priority: Major
> Fix For: 0.3.0
>
>
> TestDataValidate in Ozone throws the following exception.
> {code}
> java.lang.RuntimeException: ManagedChannel allocation site
> at 
> org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.(ManagedChannelOrphanWrapper.java:103)
> at 
> org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper.(ManagedChannelOrphanWrapper.java:53)
> at 
> org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper.(ManagedChannelOrphanWrapper.java:44)
> at 
> org.apache.ratis.shaded.io.grpc.internal.AbstractManagedChannelImplBuilder.build(AbstractManagedChannelImplBuilder.java:410)
> at 
> org.apache.ratis.grpc.client.RaftClientProtocolClient.(RaftClientProtocolClient.java:80)
> at 
> org.apache.ratis.grpc.client.GrpcClientRpc.lambda$new$0(GrpcClientRpc.java:56)
> at 
> org.apache.ratis.util.PeerProxyMap$PeerAndProxy.lambda$getProxy$0(PeerProxyMap.java:55)
> at 
> org.apache.ratis.util.LifeCycle.startAndTransition(LifeCycle.java:182)
> at 
> org.apache.ratis.util.PeerProxyMap$PeerAndProxy.getProxy(PeerProxyMap.java:54)
> at org.apache.ratis.util.PeerProxyMap.getProxy(PeerProxyMap.java:101)
> at 
> org.apache.ratis.grpc.client.GrpcClientRpc.sendRequest(GrpcClientRpc.java:78)
> 

[jira] [Commented] (RATIS-318) Ratis is leaking managed channel

2018-09-25 Thread Tsz Wo Nicholas Sze (JIRA)


[ 
https://issues.apache.org/jira/browse/RATIS-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628043#comment-16628043
 ] 

Tsz Wo Nicholas Sze commented on RATIS-318:
---

- How many Ratis clients are created in the test?
- Are you sure that the Ratis clients are closed ?

> Ratis is leaking managed channel
> 
>
> Key: RATIS-318
> URL: https://issues.apache.org/jira/browse/RATIS-318
> Project: Ratis
>  Issue Type: Bug
>  Components: client
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Shashikant Banerjee
>Priority: Major
> Fix For: 0.3.0
>
>
> TestDataValidate in Ozone throws the following exception.
> {code}
> java.lang.RuntimeException: ManagedChannel allocation site
> at 
> org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.(ManagedChannelOrphanWrapper.java:103)
> at 
> org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper.(ManagedChannelOrphanWrapper.java:53)
> at 
> org.apache.ratis.shaded.io.grpc.internal.ManagedChannelOrphanWrapper.(ManagedChannelOrphanWrapper.java:44)
> at 
> org.apache.ratis.shaded.io.grpc.internal.AbstractManagedChannelImplBuilder.build(AbstractManagedChannelImplBuilder.java:410)
> at 
> org.apache.ratis.grpc.client.RaftClientProtocolClient.(RaftClientProtocolClient.java:80)
> at 
> org.apache.ratis.grpc.client.GrpcClientRpc.lambda$new$0(GrpcClientRpc.java:56)
> at 
> org.apache.ratis.util.PeerProxyMap$PeerAndProxy.lambda$getProxy$0(PeerProxyMap.java:55)
> at 
> org.apache.ratis.util.LifeCycle.startAndTransition(LifeCycle.java:182)
> at 
> org.apache.ratis.util.PeerProxyMap$PeerAndProxy.getProxy(PeerProxyMap.java:54)
> at org.apache.ratis.util.PeerProxyMap.getProxy(PeerProxyMap.java:101)
> at 
> org.apache.ratis.grpc.client.GrpcClientRpc.sendRequest(GrpcClientRpc.java:78)
> at 
> org.apache.ratis.client.impl.RaftClientImpl.sendRequest(RaftClientImpl.java:313)
> at 
> org.apache.ratis.client.impl.RaftClientImpl.sendRequestWithRetry(RaftClientImpl.java:268)
> at 
> org.apache.ratis.client.impl.RaftClientImpl.send(RaftClientImpl.java:197)
> at 
> org.apache.ratis.client.impl.RaftClientImpl.send(RaftClientImpl.java:178)
> at org.apache.ratis.client.RaftClient.send(RaftClient.java:82)
> at 
> org.apache.hadoop.hdds.scm.XceiverClientRatis.sendRequest(XceiverClientRatis.java:193)
> at 
> org.apache.hadoop.hdds.scm.XceiverClientRatis.sendCommand(XceiverClientRatis.java:210)
> at 
> org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls.createContainer(ContainerProtocolCalls.java:297)
> at 
> org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.checkKeyLocationInfo(ChunkGroupOutputStream.java:197)
> at 
> org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.addPreallocateBlocks(ChunkGroupOutputStream.java:180)
> at 
> org.apache.hadoop.ozone.client.rpc.RpcClient.createKey(RpcClient.java:472)
> at 
> org.apache.hadoop.ozone.client.OzoneBucket.createKey(OzoneBucket.java:245)
> at 
> org.apache.hadoop.ozone.freon.RandomKeyGenerator$OfflineProcessor.run(RandomKeyGenerator.java:601)
> at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)