[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659076#comment-16659076 ] Tsz Wo Nicholas Sze commented on RATIS-338: --- The failed tests do not seem related. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Fix For: 0.3.0 > > Attachments: RATIS-338-v5.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659064#comment-16659064
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 31s{color} | {color:orange} root: The patch generated 153 new + 1167
unchanged - 72 fixed = 1320 total (was 1239) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 17m 48s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 0s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.TestRaftServerLeaderElectionTimeout |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-338 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945012/RATIS-338-v5.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 32ec28ef4876 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / ce78399 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/434/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/434/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/434/testReport/ |
| modules | C: ratis-proto ratis-common ratis-client ratis-server ratis-grpc
ratis-netty ratis-hadoop U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/434/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> ServerInformationReply should include multiple groups
> --
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659059#comment-16659059 ] Tsz Wo Nicholas Sze commented on RATIS-338: --- +1 the v5 patch looks good. Thanks [~sergey.soldatov]. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v5.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658954#comment-16658954
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 8m
5s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 37s{color} | {color:orange} root: The patch generated 158 new + 1169
unchanged - 73 fixed = 1327 total (was 1242) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 7s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 42m 40s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftExceptionWithSimulation |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-22
|
| JIRA Issue | RATIS-338 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944668/RATIS-338-v4.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 3c295f28c0a5 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / ce78399 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/431/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/431/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/431/testReport/ |
| modules | C: ratis-proto ratis-common ratis-client ratis-server ratis-grpc
ratis-netty ratis-hadoop U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/431/console |
| Powered by | Apac
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658909#comment-16658909 ] Sergey Soldatov commented on RATIS-338: --- [~szetszwo] addressed all 3 bullets in v5. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v4.patch, RATIS-338-v5.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657852#comment-16657852
]
Tsz Wo Nicholas Sze commented on RATIS-338:
---
[~sergey.soldatov], thanks for the update. The patch looks good. Just some
minor comments:
- Let's consistently use "Info" instead of "Information" in the names. (I
don't mind if you want to use "Information" instead of "Info".)
- In RaftClient.getGroupInformation, please move the server parameter to the
end, i.e.
{code}
RaftClientReply getGroupInformation(RaftGroupId group, RaftPeerId server)
throws IOException;
{code}
It is consistent with groupAdd/Remove.
- The indentation is off -- we use 2-space indent and 4-space for continuation
indent.
> ServerInformationReply should include multiple groups
> -
>
> Key: RATIS-338
> URL: https://issues.apache.org/jira/browse/RATIS-338
> Project: Ratis
> Issue Type: Sub-task
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Sergey Soldatov
>Priority: Major
> Attachments: RATIS-338-v4.patch
>
>
> ServerInformationReply currently only returns information of a particular
> group. It should return informations of all the groups.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656697#comment-16656697
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 5m
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
52s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 37s{color} | {color:orange} root: The patch generated 158 new + 1166
unchanged - 73 fixed = 1324 total (was 1239) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 11m 52s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 11s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.TestRaftServerSlownessDetection |
| | ratis.server.TestRaftLogMetrics |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-19
|
| JIRA Issue | RATIS-338 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12944668/RATIS-338-v4.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 26a6d5ee75b0 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 4bd32cd |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/413/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/413/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/413/testReport/ |
| modules | C: ratis-proto ratis-common ratis-client ratis-server ratis-grpc
ratis-netty ratis-hadoop U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/413/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> ServerInformationReply should include multiple groups
>
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656350#comment-16656350 ] Tsz Wo Nicholas Sze commented on RATIS-338: --- I am also not sure why. It always picks up the earliest but not the latest patch. We delete the earlier patches as a work around. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v1.patch, RATIS-338-v2.patch, > RATIS-338-v4.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656347#comment-16656347 ] Sergey Soldatov commented on RATIS-338: --- Looks like there are problems with Yetus? Why it's trying to apply v1 patch if the most recent is v4? > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v1.patch, RATIS-338-v2.patch, > RATIS-338-v4.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656339#comment-16656339
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} RATIS-338 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.5.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | RATIS-338 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12942777/RATIS-338-v1.patch |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/412/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> ServerInformationReply should include multiple groups
> -
>
> Key: RATIS-338
> URL: https://issues.apache.org/jira/browse/RATIS-338
> Project: Ratis
> Issue Type: Sub-task
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Sergey Soldatov
>Priority: Major
> Attachments: RATIS-338-v1.patch, RATIS-338-v2.patch,
> RATIS-338-v4.patch
>
>
> ServerInformationReply currently only returns information of a particular
> group. It should return informations of all the groups.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656336#comment-16656336 ] Sergey Soldatov commented on RATIS-338: --- [~szetszwo] v4 is the patch implements the second approach. There are 2 separated calls: groupList and groupInformation. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v1.patch, RATIS-338-v2.patch, > RATIS-338-v4.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646013#comment-16646013 ] Tsz Wo Nicholas Sze commented on RATIS-338: --- > ... does getGroupInfo would require a parameter (groupId) or it will use the > group that the client has (so we would have to change the client group all > the time if we want to receive all groups)? We can add a group id parameter. If the parameter is missing, use the client group. > Do you think it may be useful if we allow creating a client without the > group, but with a peer as the param? Yes, it is useful for group management related call. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v1.patch, RATIS-338-v2.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646007#comment-16646007 ] Sergey Soldatov commented on RATIS-338: --- [~szetszwo] in the second does getGroupInfo would require a parameter (groupId) or it will use the group that the client has (so we would have to change the client group all the time if we want to receive all groups)? Also, at the moment the client requires a group to be provided. For system calls such as getGroupIds it's definitely not required since we are querying for a high-level information about the multi-raft server. Do you think it may be useful if we allow creating a client without the group, but with a peer as the param? > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v1.patch, RATIS-338-v2.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645937#comment-16645937 ] Tsz Wo Nicholas Sze commented on RATIS-338: --- bq. The only thing I'm not sure about is the whether we may have a special handling for exceptions in the reply code. I.e. if we are unable to get information about one of few groups. How we should handler that. This is really a good question. It seems that it may not be a good idea to include all groups in a single reply. We have two options: # Include all groups in a ServerInformationReply returned by AdminProtocol.getInfo(..) as suggested in the JIRA. # Replace AdminProtocol.getInfo(..) with two methods GroupInfoReply getGroupInfo(..) and List getGroupIds(..). For #1, the getInfo(..) becomes heavy if there are many groups. If an application only wants to get the info of a group, it still has to get all group infos. Also, as mentioned by [~sergey.soldatov], it is troublesome to handle the exceptions from some of the groups. In #2, both methods are lightweight. getGroupIds(..) can return the keys from the RaftServerProxy.ImplMap so that it won't has exception. getGroupInfo(..) just returns the info of a group. It can throws exception if it fails. How about we implement #2? > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v1.patch, RATIS-338-v2.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642584#comment-16642584
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 25s{color} | {color:orange} root: The patch generated 27 new + 642 unchanged
- 21 fixed = 669 total (was 663) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 2s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 50s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.simulation.TestRaftExceptionWithSimulation |
| | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-08
|
| JIRA Issue | RATIS-338 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12942777/RATIS-338-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux d9249084b7bf 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 737db65 |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/390/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/390/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/390/testReport/ |
| modules | C: ratis-proto ratis-common ratis-client ratis-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/390/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> ServerInformationReply should include multiple groups
> ---
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[ https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642451#comment-16642451 ] Sergey Soldatov commented on RATIS-338: --- [~szetszwo] Yep, here is the second attempt. The only thing I'm not sure about is the whether we may have a special handling for exceptions in the reply code. I.e. if we are unable to get information about one of few groups. How we should handler that. > ServerInformationReply should include multiple groups > - > > Key: RATIS-338 > URL: https://issues.apache.org/jira/browse/RATIS-338 > Project: Ratis > Issue Type: Sub-task > Components: server >Reporter: Tsz Wo Nicholas Sze >Assignee: Sergey Soldatov >Priority: Major > Attachments: RATIS-338-v1.patch, RATIS-338-v2.patch > > > ServerInformationReply currently only returns information of a particular > group. It should return informations of all the groups. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641436#comment-16641436
]
Tsz Wo Nicholas Sze commented on RATIS-338:
---
Thanks [~sergey.soldatov] for working on this.
role, isRaftStorageHealthy and commitInfos could also be different in
individual groups. Thus, the new proto should look like:
{code}
message GroupInfoProto {
RaftGroupProto group = 1;
RoleInfoProto role = 2;
bool isRaftStorageHealthy = 3;
repeated CommitInfoProto commitInfos = 4;
}
message ServerInformationReplyProto {
RaftRpcReplyProto rpcReply = 1;
repeated GroupInfoProto groupInfos = 2;
}
{code}
> ServerInformationReply should include multiple groups
> -
>
> Key: RATIS-338
> URL: https://issues.apache.org/jira/browse/RATIS-338
> Project: Ratis
> Issue Type: Sub-task
> Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Sergey Soldatov
>Priority: Major
> Attachments: RATIS-338-v1.patch
>
>
> ServerInformationReply currently only returns information of a particular
> group. It should return informations of all the groups.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-338) ServerInformationReply should include multiple groups
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641430#comment-16641430
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m
24s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
18s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 24s{color} | {color:orange} root: The patch generated 27 new + 657 unchanged
- 21 fixed = 684 total (was 678) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 11m 55s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
| | ratis.TestRaftServerSlownessDetection |
| | ratis.server.simulation.TestRaftWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-08
|
| JIRA Issue | RATIS-338 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12942777/RATIS-338-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 0f67c4fca6d9 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / c3845bc |
| Default Java | 1.8.0_181 |
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/386/artifact/out/diff-checkstyle-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/386/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/386/testReport/ |
| modules | C: ratis-proto ratis-common ratis-client ratis-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/386/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> ServerInformationReply should include multiple groups
> ---
