[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-17 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653089#comment-16653089
 ] 

Tsz Wo Nicholas Sze commented on RATIS-341:
---

Filed RATIS-355 for the bug.

> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.003.patch, RATIS-341.003_committed.patch
>
>
> In follower, RaftServerImpl#appendEntriesAsync, entries should only be 
> applied to state machine
> only after writing the log to the state machine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-16 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652071#comment-16652071
 ] 

Tsz Wo Nicholas Sze commented on RATIS-341:
---

[~msingh], just found that TestBatchAppend failed with gRPC after the commit of 
this (c3845bc3f3044f513347d8fec220e4e289a0ea5b).  If I reset the head to right 
before this (b0dc99205ff6394f4f7698b443a5b2989947bcf5), the test can pass.

{code}
commit c3845bc3f3044f513347d8fec220e4e289a0ea5b
Author: Tsz Wo Nicholas Sze 
Date:   Sun Oct 7 05:34:53 2018 +0800

RATIS-341. Raft log index on the follower should be applied to state 
machine only after writing the log.  Contributed by Mukul Kumar Singh

commit b0dc99205ff6394f4f7698b443a5b2989947bcf5
Author: Tsz Wo Nicholas Sze 
Date:   Sat Oct 6 08:25:41 2018 +0800

RATIS-340. org.apache.hadoop.ipc.protobuf is shaded to 
org.apache.ratis.shaded.*.
{code}

Could you take a look?

> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.003.patch, RATIS-341.003_committed.patch
>
>
> In follower, RaftServerImpl#appendEntriesAsync, entries should only be 
> applied to state machine
> only after writing the log to the state machine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640878#comment-16640878
 ] 

Tsz Wo Nicholas Sze commented on RATIS-341:
---

+1 the 003 patch looks good except that the logAppendEntries(..) should be 
called outside the synchronized-block and some indentations are off.

I will fix them when committing the patch.

> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.003.patch
>
>
> In follower, RaftServerImpl#appendEntriesAsync, entries should only be 
> applied to state machine
> only after writing the log to the state machine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640847#comment-16640847
 ] 

Hadoop QA commented on RATIS-341:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 24s{color} | {color:orange} root: The patch generated 10 new + 807 unchanged 
- 6 fixed = 817 total (was 813) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  6m 50s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 6s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 12m 10s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.server.simulation.TestRaftWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-06 
|
| JIRA Issue | RATIS-341 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12942684/RATIS-341.003.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  checkstyle  
compile  cc  |
| uname | Linux 206c8e3d4553 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / b0dc992 |
| Default Java | 1.8.0_181 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-RATIS-Build/381/artifact/out/diff-checkstyle-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/381/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/381/testReport/ |
| modules | C: ratis-proto ratis-server ratis-grpc U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/381/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Raft log index on the follower should be applied to state machine only after 
> writing the log
>

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Mukul Kumar Singh (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640793#comment-16640793
 ] 

Mukul Kumar Singh commented on RATIS-341:
-

Thanks for the review [~szetszwo]. Patch  v3 fixes the review comments.

> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.003.patch
>
>
> In follower, RaftServerImpl#appendEntriesAsync, entries should only be 
> applied to state machine
> only after writing the log to the state machine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640661#comment-16640661
 ] 

Tsz Wo Nicholas Sze commented on RATIS-341:
---

>  ..., why do we need to change LeaderState?

In the Raft protocol, leader should send the leader commit index to followers 
so that we should not change LeaderState.  However, I agree that if a follower 
does not have the log flushed, the follower should not update the commit index. 
 Otherwise, it will violate the invariant
{code}
flushedIndex >= commitIndex
{code}
How about changing RaftLog as below?
{code}
@@ -94,8 +94,9 @@ public abstract class RaftLog implements Closeable {
 // paper for details.
 final TermIndex entry = getTermIndex(majorityIndex);
 if (entry != null && entry.getTerm() == currentTerm) {
-  LOG.debug("{}: Updating lastCommitted to {}", selfId, majorityIndex);
-  lastCommitted.set(majorityIndex);
+  final long commitIndex = Math.min(majorityIndex, 
getLatestFlushedIndex());
+  LOG.debug("{}: Updating lastCommitted to {}", selfId, commitIndex);
+  lastCommitted.set(commitIndex);
   return true;
 }
   }
{code}


> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.002.patch
>
>
> In follower, RaftServerImpl#appendEntriesAsync, entries should only be 
> applied to state machine
> only after writing the log to the state machine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Mukul Kumar Singh (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640653#comment-16640653
 ] 

Mukul Kumar Singh commented on RATIS-341:
-

Thanks for the review [~szetszwo]. The changes in leader state are needed for a 
slow follower.

For a slow node which is catching up, the commit index send along with the 
append request can be beyond the log indexes sent to the follower.


> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.002.patch
>
>
> In follower, RaftServerImpl#appendEntriesAsync, entries should only be 
> applied to state machine
> only after writing the log to the state machine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640648#comment-16640648
 ] 

Tsz Wo Nicholas Sze commented on RATIS-341:
---

The change in RaftServerImpl looks good.  However, why do we need to change 
LeaderState?

> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.002.patch
>
>
> In follower, RaftServerImpl#appendEntriesAsync, entries should only be 
> applied to state machine
> only after writing the log to the state machine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-06 Thread Shashikant Banerjee (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640631#comment-16640631
 ] 

Shashikant Banerjee commented on RATIS-341:
---

Thanks [~msingh] for the patch and offline discussion. I am +1 on this.

> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.002.patch
>
>
> In follower, RaftServerImpl#appendEntriesAsync, entries should only be 
> applied to state machine
> only after writing the log to the state machine.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-05 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639876#comment-16639876
 ] 

Hadoop QA commented on RATIS-341:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  3m 
54s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 21s{color} | {color:orange} root: The patch generated 5 new + 571 unchanged 
- 1 fixed = 576 total (was 572) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 15m 19s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 59s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
|   | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
|   | ratis.TestRaftServerSlownessDetection |
|   | ratis.server.simulation.TestRaftWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-05 
|
| JIRA Issue | RATIS-341 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12942559/RATIS-341.002.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  checkstyle  
compile  |
| uname | Linux 79f1c5e6ee19 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10 
07:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / bbfb875 |
| Default Java | 1.8.0_181 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-RATIS-Build/376/artifact/out/diff-checkstyle-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/376/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/376/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/376/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-05 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639863#comment-16639863
 ] 

Hadoop QA commented on RATIS-341:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 25s{color} | {color:orange} root: The patch generated 5 new + 571 unchanged 
- 1 fixed = 576 total (was 572) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  8m 37s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 33s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerSlownessDetection |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-05 
|
| JIRA Issue | RATIS-341 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12942559/RATIS-341.002.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  checkstyle  
compile  |
| uname | Linux 7209db1b0147 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / bbfb875 |
| Default Java | 1.8.0_181 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-RATIS-Build/375/artifact/out/diff-checkstyle-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/375/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/375/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/375/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Raft log index on the follower should be applied to state machine only after 
> writing the log
> 
>
> Key: RATIS-341
> URL: https://issues.apache.org/jira/browse/RATIS-341
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Affects Versions: 0.3.0
>Reporter: Mukul Kumar Singh
>Assignee: Mukul Kumar Singh
>Priority: Major
> Fix For: 0.3.0
>
> Attachments: RATIS-341.002.patch
>
>
> In follower,

[jira] [Commented] (RATIS-341) Raft log index on the follower should be applied to state machine only after writing the log

2018-10-05 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639725#comment-16639725
 ] 

Hadoop QA commented on RATIS-341:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
23s{color} | {color:green} root: The patch generated 0 new + 571 unchanged - 1 
fixed = 571 total (was 572) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 19m 49s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 8s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m  5s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.statemachine.TestStateMachine |
|   | ratis.server.simulation.TestRaftExceptionWithSimulation |
|   | ratis.server.simulation.TestRaftReconfigurationWithSimulatedRpc |
|   | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc |
|   | ratis.server.simulation.TestRaftWithSimulatedRpc |
|   | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
|   | ratis.TestRaftServerSlownessDetection |
|   | ratis.server.simulation.TestRetryCacheWithSimulatedRpc |
|   | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
|   | ratis.server.simulation.TestGroupManagementWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-05 
|
| JIRA Issue | RATIS-341 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12942543/RATIS-341.001.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  checkstyle  
compile  |
| uname | Linux fcccde8e5872 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / bbfb875 |
| Default Java | 1.8.0_181 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/374/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/374/testReport/ |
| modules | C: ratis-server U: ratis-server |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/374/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Raft log index on the follower should be applied to state machine only after 
> writing the log
>