[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665572#comment-16665572
]
Josh Elser commented on RATIS-369:
--
v6 Applies cleanly for me.
Are all of the tests in {{LogServiceReadWriteBase}} intended to be commented
out?
> LogService read/write path (phase 2: more UTs, etc)
> ---
>
> Key: RATIS-369
> URL: https://issues.apache.org/jira/browse/RATIS-369
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: RATIS-369-v5.patch, RATIS-369-v6.patch
>
>
> Polish implementation, implement some missing features, add more UTs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1666#comment-1666 ] Josh Elser commented on RATIS-369: -- Looking at it, Vlad. Thanks! > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v5.patch, RATIS-369-v6.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665530#comment-16665530 ] Vladimir Rodionov commented on RATIS-369: - TestMetaServer now passes (after v6) > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v5.patch, RATIS-369-v6.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665529#comment-16665529 ] Vladimir Rodionov commented on RATIS-369: - The last patch applies cleanly to the master, but the patch is missing new UTs (cant add them) and dummy folder is still hanging. > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v5.patch, RATIS-369-v6.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665501#comment-16665501 ] Josh Elser commented on RATIS-369: -- That's really weird. I'm about half way through your patch. I have another chunk of time now to work on this right now. Will power through it. Hopefully, it's not your hard drive :( > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v5.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665497#comment-16665497 ] Vladimir Rodionov commented on RATIS-369: - [~elserj], I have never had this problem before with git. It just went crazy. I am loosing new files when create a patch and can't delete dummy folder. > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v5.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665365#comment-16665365 ] Josh Elser commented on RATIS-369: -- I'm taking a look at v5. Let me see if I can fix it up. > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v5.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664826#comment-16664826
]
Hadoop QA commented on RATIS-369:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s{color}
| {color:red} RATIS-369 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.5.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | RATIS-369 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945285/RATIS-369-v1.patch |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/461/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> LogService read/write path (phase 2: more UTs, etc)
> ---
>
> Key: RATIS-369
> URL: https://issues.apache.org/jira/browse/RATIS-369
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: RATIS-369-v1.patch, RATIS-369-v2.patch,
> RATIS-369-v5.patch
>
>
> Polish implementation, implement some missing features, add more UTs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664620#comment-16664620 ] Vladimir Rodionov commented on RATIS-369: - Some weird things are happening with my local setup (git). I managed to get the patch, which is OK, but requires some final touches: # dummy package has to be cleared and deleted (I CAN NOT do this, I do not know why) # One UT gone missing (new one, I do not know why again), but I will add it later after this patch is committed. > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v1.patch, RATIS-369-v2.patch, > RATIS-369-v5.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664517#comment-16664517 ] Vladimir Rodionov commented on RATIS-369: - Hmm, will take a look. > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v1.patch, RATIS-369-v2.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664510#comment-16664510
]
Hadoop QA commented on RATIS-369:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 3s{color}
| {color:red} RATIS-369 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.5.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | RATIS-369 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945285/RATIS-369-v1.patch |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/460/console |
| Powered by | Apache Yetus 0.5.0 http://yetus.apache.org |
This message was automatically generated.
> LogService read/write path (phase 2: more UTs, etc)
> ---
>
> Key: RATIS-369
> URL: https://issues.apache.org/jira/browse/RATIS-369
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: RATIS-369-v1.patch, RATIS-369-v2.patch
>
>
> Polish implementation, implement some missing features, add more UTs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664385#comment-16664385 ] Vladimir Rodionov commented on RATIS-369: - v2. Rebased to RATIS-334. Did some refactoring: removed factory and LogService. Tests are disabled. I want [~sergey.soldatov] to enable MetaServer test first. I will open open JIRA for unit tests. > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v1.patch, RATIS-369-v2.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663015#comment-16663015 ] Josh Elser commented on RATIS-369: -- Hahah. Thanks Vlad! :) > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v1.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663004#comment-16663004
]
Vladimir Rodionov commented on RATIS-369:
-
{quote}
What's the UNDEFINED for?
{quote}
Binary logic meets tertiary logic :) Will remove it.
> LogService read/write path (phase 2: more UTs, etc)
> ---
>
> Key: RATIS-369
> URL: https://issues.apache.org/jira/browse/RATIS-369
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: RATIS-369-v1.patch
>
>
> Polish implementation, implement some missing features, add more UTs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663001#comment-16663001
]
Vladimir Rodionov commented on RATIS-369:
-
{quote}
Do we want Test in the file name? We don't want to run this class directly,
right?
{quote}
Yeah, will fix it.
> LogService read/write path (phase 2: more UTs, etc)
> ---
>
> Key: RATIS-369
> URL: https://issues.apache.org/jira/browse/RATIS-369
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: RATIS-369-v1.patch
>
>
> Polish implementation, implement some missing features, add more UTs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662999#comment-16662999
]
Josh Elser commented on RATIS-369:
--
bq. Hmm, this is what I usually try to avoid : working on a same (almost) code
in parallel. Rebasing RATIS-369 on top of RATIS-334 is harder than rewriting
patch from scratch.
I'm sorry, Vlad. I don't know of a better way to do this while we get it off
the ground other than having one person do everything (which we don't have the
time to allow). Really sorry if there's extra pain now. I hope it's brief.
Some general comments from your v1
{code:java}
+ public static enum State {
+OPEN, CLOSED, UNDEFINED
+ }{code}
What's the {{UNDEFINED}} for?
{code:java}
diff --git
a/ratis-logservice/src/test/java/org/apache/ratis/logservice/LogServiceBaseTest.java
b/ratis-logservice/src/test/java/org/apache/ratis/logservice/TestLogServiceAPIBase.java
similarity index 95%
rename from
ratis-logservice/src/test/java/org/apache/ratis/logservice/LogServiceBaseTest.java
rename to
ratis-logservice/src/test/java/org/apache/ratis/logservice/TestLogServiceAPIBase.java
index 82553511..346bf68f 100644
---
a/ratis-logservice/src/test/java/org/apache/ratis/logservice/LogServiceBaseTest.java
+++
b/ratis-logservice/src/test/java/org/apache/ratis/logservice/TestLogServiceAPIBase.java
@@ -39,10 +39,10 @@ import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public abstract class LogServiceBaseTest
+public abstract class TestLogServiceAPIBase
extends BaseTest
implements MiniRaftCluster.Factory.Get {
- public static final Logger LOG =
LoggerFactory.getLogger(LogServiceBaseTest.class);
+ public static final Logger LOG =
LoggerFactory.getLogger(TestLogServiceAPIBase.class);{code}
Do we want {{Test}} in the file name? We don't want to run this class directly,
right?
> LogService read/write path (phase 2: more UTs, etc)
> ---
>
> Key: RATIS-369
> URL: https://issues.apache.org/jira/browse/RATIS-369
> Project: Ratis
> Issue Type: Sub-task
>Reporter: Vladimir Rodionov
>Assignee: Vladimir Rodionov
>Priority: Major
> Attachments: RATIS-369-v1.patch
>
>
> Polish implementation, implement some missing features, add more UTs
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662997#comment-16662997 ] Vladimir Rodionov commented on RATIS-369: - Hmm, this is what I usually try to avoid : working on a same (almost) code in parallel. Rebasing RATIS-369 on top of RATIS-334 is harder than rewriting patch from scratch. > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v1.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662988#comment-16662988 ] Josh Elser commented on RATIS-369: -- [~vrodionov], you should be good to rebase this on top of Sergey's latest. > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v1.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661890#comment-16661890 ] Sergey Soldatov commented on RATIS-369: --- Why do we need the snapshot support? In theory, that would purge the log cache as well as the log itself and that's definitely not the thing we want. Another thing that we need to think about is the ratis client retries. If the execution of the query takes longer than 3 seconds it would send the same query again. > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v1.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661425#comment-16661425
]
Hadoop QA commented on RATIS-369:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 11 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 44s{color}
| {color:red} root generated 2 new + 95 unchanged - 4 fixed = 97 total (was 99)
{color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 19s{color} | {color:orange} root: The patch generated 90 new + 357 unchanged
- 147 fixed = 447 total (was 504) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch 9 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 42s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 16s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.TestRaftServerLeaderElectionTimeout |
| | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-23
|
| JIRA Issue | RATIS-369 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12945285/RATIS-369-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs checkstyle
compile cc |
| uname | Linux 1d3cdf60a8bf 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14
08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / aa38160 |
| Default Java | 1.8.0_181 |
| javac |
https://builds.apache.org/job/PreCommit-RATIS-Build/447/artifact/out/diff-compile-javac-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-RATIS-Build/447/artifact/out/diff-checkstyle-root.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-RATIS-Build/447/artifact/out/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-RATIS-Build/447/artifact/out/whitespace-tabs.txt
|
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/447/artifact/out/
[jira] [Commented] (RATIS-369) LogService read/write path (phase 2: more UTs, etc)
[ https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661406#comment-16661406 ] Vladimir Rodionov commented on RATIS-369: - Patch v1. Code clean up, some missing API fixed, UTs. cc: [~elserj], [~sergey soldatov] > LogService read/write path (phase 2: more UTs, etc) > --- > > Key: RATIS-369 > URL: https://issues.apache.org/jira/browse/RATIS-369 > Project: Ratis > Issue Type: Sub-task >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Attachments: RATIS-369-v1.patch > > > Polish implementation, implement some missing features, add more UTs -- This message was sent by Atlassian JIRA (v7.6.3#76005)
