[jira] [Commented] (RATIS-379) Allow writing state machine data to be sync'ed with writing raft log

2018-10-29 Thread Jitendra Nath Pandey (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668139#comment-16668139
 ] 

Jitendra Nath Pandey commented on RATIS-379:


I see, thanks for clarification.

+1 for the latest patch.

> Allow writing state machine data to be sync'ed with writing raft log
> 
>
> Key: RATIS-379
> URL: https://issues.apache.org/jira/browse/RATIS-379
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r379_20181030.patch
>
>
> Currently, writing state machine data and writing raft log are both 
> asynchronous so that they can be completed in any order.  In some 
> applications such as Ozone, it is hard to handle the case that writing raft 
> log has succeeded but state machine data has failed.
> In this JIRA, we provide an option to allow writing state machine data to be 
> synchronized with writing raft log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-379) Allow writing state machine data to be sync'ed with writing raft log

2018-10-29 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668137#comment-16668137
 ] 

Tsz Wo Nicholas Sze commented on RATIS-379:
---

The future in flushWrites() is returned by 
stateMachine.flushStateMachineData(..).  It is different than 
stateMachineFuture which is returned by stateMachine.writeStateMachineData(..).

> Allow writing state machine data to be sync'ed with writing raft log
> 
>
> Key: RATIS-379
> URL: https://issues.apache.org/jira/browse/RATIS-379
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r379_20181030.patch
>
>
> Currently, writing state machine data and writing raft log are both 
> asynchronous so that they can be completed in any order.  In some 
> applications such as Ozone, it is hard to handle the case that writing raft 
> log has succeeded but state machine data has failed.
> In this JIRA, we provide an option to allow writing state machine data to be 
> synchronized with writing raft log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-379) Allow writing state machine data to be sync'ed with writing raft log

2018-10-29 Thread Jitendra Nath Pandey (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667590#comment-16667590
 ] 

Jitendra Nath Pandey commented on RATIS-379:


Call to {{getFromFuture}} is no longer needed in flushWrites, because it is 
already called in {{execute}} however it should return immediately.

> Allow writing state machine data to be sync'ed with writing raft log
> 
>
> Key: RATIS-379
> URL: https://issues.apache.org/jira/browse/RATIS-379
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r379_20181030.patch
>
>
> Currently, writing state machine data and writing raft log are both 
> asynchronous so that they can be completed in any order.  In some 
> applications such as Ozone, it is hard to handle the case that writing raft 
> log has succeeded but state machine data has failed.
> In this JIRA, we provide an option to allow writing state machine data to be 
> synchronized with writing raft log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-379) Allow writing state machine data to be sync'ed with writing raft log

2018-10-29 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667547#comment-16667547
 ] 

Hadoop QA commented on RATIS-379:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  4m  
3s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 3 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
23s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
37s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 22s{color} | {color:orange} root: The patch generated 61 new + 569 unchanged 
- 19 fixed = 630 total (was 588) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  5m  5s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 29s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
ratis.server.simulation.TestServerRestartWithSimulatedRpc |
|   | ratis.server.simulation.TestRaftWithSimulatedRpc |
|   | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-29 
|
| JIRA Issue | RATIS-379 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12946073/r379_20181030.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  checkstyle  
compile  |
| uname | Linux 90b577817c3c 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / 4d723a2 |
| Default Java | 1.8.0_181 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-RATIS-Build/475/artifact/out/diff-checkstyle-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/475/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/475/testReport/ |
| modules | C: ratis-common ratis-server U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/475/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Allow writing state machine data to be sync'ed with writing raft log
> 
>
> Key: RATIS-379
> URL: https://issues.apache.org/jira/browse/RATIS-379
> Project: Ratis
>

[jira] [Commented] (RATIS-379) Allow writing state machine data to be sync'ed with writing raft log

2018-10-29 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667505#comment-16667505
 ] 

Tsz Wo Nicholas Sze commented on RATIS-379:
---

r379_20181030.patch: adds a test.

> Allow writing state machine data to be sync'ed with writing raft log
> 
>
> Key: RATIS-379
> URL: https://issues.apache.org/jira/browse/RATIS-379
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r379_20181030.patch
>
>
> Currently, writing state machine data and writing raft log are both 
> asynchronous so that they can be completed in any order.  In some 
> applications such as Ozone, it is hard to handle the case that writing raft 
> log has succeeded but state machine data has failed.
> In this JIRA, we provide an option to allow writing state machine data to be 
> synchronized with writing raft log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (RATIS-379) Allow writing state machine data to be sync'ed with writing raft log

2018-10-29 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667139#comment-16667139
 ] 

Hadoop QA commented on RATIS-379:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m  
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m 44s{color} 
| {color:red} root generated 1 new + 94 unchanged - 0 fixed = 95 total (was 94) 
{color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 18s{color} | {color:orange} root: The patch generated 25 new + 340 unchanged 
- 0 fixed = 365 total (was 340) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  2m 49s{color} 
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 7s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}  8m 27s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-10-29 
|
| JIRA Issue | RATIS-379 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12946036/r379_20181029.patch |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  checkstyle  
compile  |
| uname | Linux 0ff15dfc71cb 4.4.0-134-generic #160~14.04.1-Ubuntu SMP Fri Aug 
17 11:07:07 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
 |
| git revision | master / 4d723a2 |
| Default Java | 1.8.0_181 |
| javac | 
https://builds.apache.org/job/PreCommit-RATIS-Build/474/artifact/out/diff-compile-javac-root.txt
 |
| checkstyle | 
https://builds.apache.org/job/PreCommit-RATIS-Build/474/artifact/out/diff-checkstyle-root.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-RATIS-Build/474/artifact/out/patch-unit-root.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-RATIS-Build/474/testReport/ |
| modules | C: ratis-common ratis-server U: . |
| Console output | 
https://builds.apache.org/job/PreCommit-RATIS-Build/474/console |
| Powered by | Apache Yetus 0.5.0   http://yetus.apache.org |


This message was automatically generated.



> Allow writing state machine data to be sync'ed with writing raft log
> 
>
> Key: RATIS-379
> URL: https://issues.apache.org/jira/browse/RAT

[jira] [Commented] (RATIS-379) Allow writing state machine data to be sync'ed with writing raft log

2018-10-29 Thread Tsz Wo Nicholas Sze (JIRA) 


[ 
https://issues.apache.org/jira/browse/RATIS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667074#comment-16667074
 ] 

Tsz Wo Nicholas Sze commented on RATIS-379:
---

r379_20181029.patch: waits for writing state machine data before writing raft 
log.

> Allow writing state machine data to be sync'ed with writing raft log
> 
>
> Key: RATIS-379
> URL: https://issues.apache.org/jira/browse/RATIS-379
> Project: Ratis
>  Issue Type: Improvement
>  Components: server
>Reporter: Tsz Wo Nicholas Sze
>Assignee: Tsz Wo Nicholas Sze
>Priority: Major
> Attachments: r379_20181029.patch
>
>
> Currently, writing state machine data and writing raft log are both 
> asynchronous so that they can be completed in any order.  In some 
> applications such as Ozone, it is hard to handle the case that writing raft 
> log has succeeded but state machine data has failed.
> In this JIRA, we provide an option to allow writing state machine data to be 
> synchronized with writing raft log.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)