[jira] [Commented] (RATIS-659) StateMachineUpdater#stopAndJoin might not take snapshot due to race condition

2019-09-03 Thread Lokesh Jain (Jira)


[ 
https://issues.apache.org/jira/browse/RATIS-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921231#comment-16921231
 ] 

Lokesh Jain commented on RATIS-659:
---

[~szetszwo] Thanks for reviewing and committing the patch!

> StateMachineUpdater#stopAndJoin might not take snapshot due to race condition
> -
>
> Key: RATIS-659
> URL: https://issues.apache.org/jira/browse/RATIS-659
> Project: Ratis
>  Issue Type: Bug
>  Components: server
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Fix For: 0.4.0
>
> Attachments: RATIS-659.001.patch
>
>
> StateMachineUpdater might not take snapshot during close. This might happen 
> if the StateMachineUpdater#stopAndJoin is called right after the snapshot 
> check in StateMachineUpdater:156-162.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)


[jira] [Commented] (RATIS-659) StateMachineUpdater#stopAndJoin might not take snapshot due to race condition

2019-08-30 Thread Tsz Wo Nicholas Sze (Jira)


[ 
https://issues.apache.org/jira/browse/RATIS-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919833#comment-16919833
 ] 

Tsz Wo Nicholas Sze commented on RATIS-659:
---

Good catch on the bug!

+1 patch looks good. 

> StateMachineUpdater#stopAndJoin might not take snapshot due to race condition
> -
>
> Key: RATIS-659
> URL: https://issues.apache.org/jira/browse/RATIS-659
> Project: Ratis
>  Issue Type: Bug
>Reporter: Lokesh Jain
>Assignee: Lokesh Jain
>Priority: Major
> Attachments: RATIS-659.001.patch
>
>
> StateMachineUpdater might not take snapshot during close. This might happen 
> if the StateMachineUpdater#stopAndJoin is called right after the snapshot 
> check in StateMachineUpdater:156-162.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)