[jira] [Updated] (RATIS-145) (git)ignore dependency-reduced-pom.xml
[
https://issues.apache.org/jira/browse/RATIS-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elek, Marton updated RATIS-145:
---
Attachment: RATIS-145.002.patch
Thx the feedback [~szetszwo]
1. Yes, the rat plugin checked the gitignore file only the (sub)project
.gitignore file. In the meantime I found a (maybe) better solution in the
hadoop source tree: with an additional plugin execution they added the apache
licence to the reduced pom. So even if the reduced pom is used by any maven
magic, the licence header will be there. I modifed the patch to use this
approach (but kept the reduced pom in the gitignore file, too).
2. I also copied the clean plugin execution from other shaded projects to the
ratis-examples (together with the profile definition) as you suggested.
> (git)ignore dependency-reduced-pom.xml
> --
>
> Key: RATIS-145
> URL: https://issues.apache.org/jira/browse/RATIS-145
> Project: Ratis
> Issue Type: Bug
>Reporter: Elek, Marton
>Assignee: Elek, Marton
> Attachments: RATIS-145.001.patch, RATIS-145.002.patch
>
>
> Latest nighliy build is failed with asflicense check:
> https://builds.apache.org/job/ratis-qbt-master-java8-linux-x86/18/artifact/out/patch-asflicense-problems.txt
> {code}
> Lines that start with ? in the ASF License report indicate files that do
> not have an Apache license header:
> !? /testptch/ratis/ratis-examples/dependency-reduced-pom.xml
> {code}
> The trivial fix is to add dependency-reduced-pom.xml to the .gitignore file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (RATIS-145) (git)ignore dependency-reduced-pom.xml
[
https://issues.apache.org/jira/browse/RATIS-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elek, Marton updated RATIS-145:
---
Attachment: RATIS-145-HDFS-7240.002.patch
> (git)ignore dependency-reduced-pom.xml
> --
>
> Key: RATIS-145
> URL: https://issues.apache.org/jira/browse/RATIS-145
> Project: Ratis
> Issue Type: Bug
>Reporter: Elek, Marton
>Assignee: Elek, Marton
> Attachments: RATIS-145.001.patch
>
>
> Latest nighliy build is failed with asflicense check:
> https://builds.apache.org/job/ratis-qbt-master-java8-linux-x86/18/artifact/out/patch-asflicense-problems.txt
> {code}
> Lines that start with ? in the ASF License report indicate files that do
> not have an Apache license header:
> !? /testptch/ratis/ratis-examples/dependency-reduced-pom.xml
> {code}
> The trivial fix is to add dependency-reduced-pom.xml to the .gitignore file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (RATIS-145) (git)ignore dependency-reduced-pom.xml
[
https://issues.apache.org/jira/browse/RATIS-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elek, Marton updated RATIS-145:
---
Attachment: (was: RATIS-145-HDFS-7240.002.patch)
> (git)ignore dependency-reduced-pom.xml
> --
>
> Key: RATIS-145
> URL: https://issues.apache.org/jira/browse/RATIS-145
> Project: Ratis
> Issue Type: Bug
>Reporter: Elek, Marton
>Assignee: Elek, Marton
> Attachments: RATIS-145.001.patch
>
>
> Latest nighliy build is failed with asflicense check:
> https://builds.apache.org/job/ratis-qbt-master-java8-linux-x86/18/artifact/out/patch-asflicense-problems.txt
> {code}
> Lines that start with ? in the ASF License report indicate files that do
> not have an Apache license header:
> !? /testptch/ratis/ratis-examples/dependency-reduced-pom.xml
> {code}
> The trivial fix is to add dependency-reduced-pom.xml to the .gitignore file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (RATIS-145) (git)ignore dependency-reduced-pom.xml
[
https://issues.apache.org/jira/browse/RATIS-145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elek, Marton updated RATIS-145:
---
Attachment: RATIS-145.001.patch
> (git)ignore dependency-reduced-pom.xml
> --
>
> Key: RATIS-145
> URL: https://issues.apache.org/jira/browse/RATIS-145
> Project: Ratis
> Issue Type: Bug
>Reporter: Elek, Marton
>Assignee: Elek, Marton
> Attachments: RATIS-145.001.patch
>
>
> Latest nighliy build is failed with asflicense check:
> https://builds.apache.org/job/ratis-qbt-master-java8-linux-x86/18/artifact/out/patch-asflicense-problems.txt
> {code}
> Lines that start with ? in the ASF License report indicate files that do
> not have an Apache license header:
> !? /testptch/ratis/ratis-examples/dependency-reduced-pom.xml
> {code}
> The trivial fix is to add dependency-reduced-pom.xml to the .gitignore file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
