[jira] [Updated] (SENTRY-2081) Automate the generation LICENSE.txt based on distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Resolution: Fixed Status: Resolved (was: Patch Available) > Automate the generation LICENSE.txt based on distributed jars > - > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Fix For: 2.0.0, 2.1.0 > > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch, > SENTRY-2081.008.patch, SENTRY-2081.009.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. > we need to make sure that the license file is generated with sentry is built > based on the jar that it is distributing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2084) Exclude javax.jms:jms from sentry distribution
[
https://issues.apache.org/jira/browse/SENTRY-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275381#comment-16275381
]
Hadoop QA commented on SENTRY-2084:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12900305/SENTRY-2084.001.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3554/console
This message is automatically generated.
> Exclude javax.jms:jms from sentry distribution
> --
>
> Key: SENTRY-2084
> URL: https://issues.apache.org/jira/browse/SENTRY-2084
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 2.0.0, 2.1.0
>Reporter: kalyan kumar kalvagadda
>Assignee: kalyan kumar kalvagadda
> Fix For: 2.0.0, 2.1.0
>
> Attachments: SENTRY-2084.001.patch
>
>
> we need to stop distributing jms artifact with group id: javax.jms as these
> no valid valid license information available for this jar and secondly it is
> a transitive dependency which sentry is not dependent on.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Automate the generation LICENSE.txt based on distributed jars
[
https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275313#comment-16275313
]
Hadoop QA commented on SENTRY-2081:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12900301/SENTRY-2081.009.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3553/console
This message is automatically generated.
> Automate the generation LICENSE.txt based on distributed jars
> -
>
> Key: SENTRY-2081
> URL: https://issues.apache.org/jira/browse/SENTRY-2081
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 2.0.0, 2.1.0
>Reporter: kalyan kumar kalvagadda
>Assignee: kalyan kumar kalvagadda
> Fix For: 2.0.0, 2.1.0
>
> Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch,
> SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch,
> SENTRY-2081.008.patch, SENTRY-2081.009.patch
>
>
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update
> the LICENSE.txt file with license information of all the jars that sentry is
> distributing along with the pointer to the LICENSE files of the dependencies.
> we need to make sure that the license file is generated with sentry is built
> based on the jar that it is distributing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SENTRY-2076) Some test artifacts are not defined at test scope
[ https://issues.apache.org/jira/browse/SENTRY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2076: Affects Version/s: 2.1.0 2.0.0 > Some test artifacts are not defined at test scope > - > > Key: SENTRY-2076 > URL: https://issues.apache.org/jira/browse/SENTRY-2076 > Project: Sentry > Issue Type: Improvement >Affects Versions: 2.0.0, 2.1.0 >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Minor > Fix For: 2.0.0, 2.1.0 > > Attachments: SENTRY-2076.patch > > > Some test artifacts in Sentry are not defined in test scope. This means that > they get included in the distribution lib directory incorrectly. With the > attached patch, the following jars no longer appear in the distribution lib: > Only in lib/: junit4-ant-2.5.3.jar > Only in lib/: lucene-test-framework-7.1.0.jar > Only in lib/: mockito-all-1.8.5.jar > Only in lib/: randomizedtesting-runner-2.5.3.jar > Only in lib/: solr-test-framework-7.1.0.jar -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2076) Some test artifacts are not defined at test scope
[ https://issues.apache.org/jira/browse/SENTRY-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2076: Fix Version/s: 2.1.0 > Some test artifacts are not defined at test scope > - > > Key: SENTRY-2076 > URL: https://issues.apache.org/jira/browse/SENTRY-2076 > Project: Sentry > Issue Type: Improvement >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Minor > Fix For: 2.0.0, 2.1.0 > > Attachments: SENTRY-2076.patch > > > Some test artifacts in Sentry are not defined in test scope. This means that > they get included in the distribution lib directory incorrectly. With the > attached patch, the following jars no longer appear in the distribution lib: > Only in lib/: junit4-ant-2.5.3.jar > Only in lib/: lucene-test-framework-7.1.0.jar > Only in lib/: mockito-all-1.8.5.jar > Only in lib/: randomizedtesting-runner-2.5.3.jar > Only in lib/: solr-test-framework-7.1.0.jar -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2085) Sentry error handling exposes SentryGroupNotFoundException externally
[ https://issues.apache.org/jira/browse/SENTRY-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach Amsden updated SENTRY-2085: Attachment: SENTRY-2085.001.patch > Sentry error handling exposes SentryGroupNotFoundException externally > - > > Key: SENTRY-2085 > URL: https://issues.apache.org/jira/browse/SENTRY-2085 > Project: Sentry > Issue Type: Bug >Affects Versions: 2.1.0 >Reporter: Zach Amsden > Attachments: SENTRY-2085.001.patch > > > The fix for SENTRY-769 allowed better differentiation of Sentry errors but > also unnecessarily leaked exceptions outside of well defined API components. > This happens because the exception chosen, SentryGroupNotFoundException was > created of a subclass of RuntimeError, allowing it to propagate past API > boundaries without 'throws' or 'catch' clauses. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2082) Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist
[
https://issues.apache.org/jira/browse/SENTRY-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
kalyan kumar kalvagadda updated SENTRY-2082:
Fix Version/s: 2.1.0
> Exclude javax.servlet-3.0.0.v201112011016.jar from Sentry dist
> --
>
> Key: SENTRY-2082
> URL: https://issues.apache.org/jira/browse/SENTRY-2082
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 2.0.0
>Reporter: Sergio Peña
>Assignee: Sergio Peña
>Priority: Blocker
> Fix For: 2.0.0, 2.1.0
>
> Attachments: SENTRY-2082.1.patch, SENTRY-2082.1.patch
>
>
> The javax.servlet-3.0.0.v201112011016.jar transitive dependency is causing
> some error exceptions on the Sentry 2.0 distribution in some Mac environments.
> {noformat}
> 17/11/29 10:13:25 ERROR thrift.SentryService: Error starting server
> java.lang.SecurityException: class "javax.servlet.DispatcherType"'s signer
> information does not match signer information of other classes in the same
> package
> at java.lang.ClassLoader.checkCerts(ClassLoader.java:898)
> at java.lang.ClassLoader.preDefineClass(ClassLoader.java:668)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:761)
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
> at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at
> org.apache.sentry.service.thrift.SentryService.startSentryWebServer(SentryService.java:422)
> at
> org.apache.sentry.service.thrift.SentryService.runServer(SentryService.java:268)
> at
> org.apache.sentry.service.thrift.SentryService.call(SentryService.java:198)
> at
> org.apache.sentry.service.thrift.SentryService.call(SentryService.java:76)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Exception in thread "main" java.util.concurrent.ExecutionException:
> java.lang.Exception: Error starting server
> at java.util.concurrent.FutureTask.report(FutureTask.java:122)
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
> at
> org.apache.sentry.service.thrift.SentryService$CommandImpl.run(SentryService.java:591)
> at org.apache.sentry.SentryMain.main(SentryMain.java:122)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.apache.hadoop.util.RunJar.run(RunJar.java:234)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:148)
> Caused by: java.lang.Exception: Error starting server
> at
> org.apache.sentry.service.thrift.SentryService.call(SentryService.java:202)
> at
> org.apache.sentry.service.thrift.SentryService.call(SentryService.java:76)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.SecurityException: class
> "javax.servlet.DispatcherType"'s signer information does not match signer
> information of other classes in the same package
> at java.lang.ClassLoader.checkCerts(ClassLoader.java:898)
> at java.lang.ClassLoader.preDefineClass(ClassLoader.java:668)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:761)
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
> at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
> at java.net.URLClassLoader$1.r
[jira] [Updated] (SENTRY-2079) Sentry HA leader monitor does not work due to a mix of curator versions in the classpath
[ https://issues.apache.org/jira/browse/SENTRY-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2079: Fix Version/s: 2.1.0 > Sentry HA leader monitor does not work due to a mix of curator versions in > the classpath > > > Key: SENTRY-2079 > URL: https://issues.apache.org/jira/browse/SENTRY-2079 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: Sergio Peña >Assignee: Sergio Peña >Priority: Blocker > Fix For: 2.0.0, 2.1.0 > > Attachments: SENTRY-2079.1.patch > > > While testing Sentry 2.0, I couldn't enable HA mode because connections to > Zookeeper were stuck due to a mix of Apache curator dependencies > (curator-client-2.8.0 and curator-client-2.11.1). > We need to exclude the old curator dependencies and also shade the curator > jars so that it does not affect other components. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Automate the generation LICENSE.txt based on distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Fix Version/s: 2.1.0 2.0.0 > Automate the generation LICENSE.txt based on distributed jars > - > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Fix For: 2.0.0, 2.1.0 > > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch, > SENTRY-2081.008.patch, SENTRY-2081.009.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. > we need to make sure that the license file is generated with sentry is built > based on the jar that it is distributing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2084) Exclude javax.jms:jms from sentry distribution
[ https://issues.apache.org/jira/browse/SENTRY-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2084: Resolution: Fixed Fix Version/s: 2.1.0 2.0.0 Status: Resolved (was: Patch Available) > Exclude javax.jms:jms from sentry distribution > -- > > Key: SENTRY-2084 > URL: https://issues.apache.org/jira/browse/SENTRY-2084 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Fix For: 2.0.0, 2.1.0 > > Attachments: SENTRY-2084.001.patch > > > we need to stop distributing jms artifact with group id: javax.jms as these > no valid valid license information available for this jar and secondly it is > a transitive dependency which sentry is not dependent on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SENTRY-2085) Sentry error handling exposes SentryGroupNotFoundException externally
Zach Amsden created SENTRY-2085: --- Summary: Sentry error handling exposes SentryGroupNotFoundException externally Key: SENTRY-2085 URL: https://issues.apache.org/jira/browse/SENTRY-2085 Project: Sentry Issue Type: Bug Affects Versions: 2.1.0 Reporter: Zach Amsden The fix for SENTRY-769 allowed better differentiation of Sentry errors but also unnecessarily leaked exceptions outside of well defined API components. This happens because the exception chosen, SentryGroupNotFoundException was created of a subclass of RuntimeError, allowing it to propagate past API boundaries without 'throws' or 'catch' clauses. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Automate the generation LICENSE.txt based on distributed jars
[
https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275210#comment-16275210
]
Hadoop QA commented on SENTRY-2081:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12900279/SENTRY-2081.007.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3550/console
This message is automatically generated.
> Automate the generation LICENSE.txt based on distributed jars
> -
>
> Key: SENTRY-2081
> URL: https://issues.apache.org/jira/browse/SENTRY-2081
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 2.0.0, 2.1.0
>Reporter: kalyan kumar kalvagadda
>Assignee: kalyan kumar kalvagadda
> Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch,
> SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch,
> SENTRY-2081.008.patch, SENTRY-2081.009.patch
>
>
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update
> the LICENSE.txt file with license information of all the jars that sentry is
> distributing along with the pointer to the LICENSE files of the dependencies.
> we need to make sure that the license file is generated with sentry is built
> based on the jar that it is distributing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SENTRY-2084) Exclude javax.jms:jms from sentry distribution
[ https://issues.apache.org/jira/browse/SENTRY-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2084: Status: Patch Available (was: In Progress) > Exclude javax.jms:jms from sentry distribution > -- > > Key: SENTRY-2084 > URL: https://issues.apache.org/jira/browse/SENTRY-2084 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2084.001.patch > > > we need to stop distributing jms artifact with group id: javax.jms as these > no valid valid license information available for this jar and secondly it is > a transitive dependency which sentry is not dependent on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Automate the generation LICENSE.txt based on distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Description: As per https://www.apache.org/dev/licensing-howto.html , sentry should update the LICENSE.txt file with license information of all the jars that sentry is distributing along with the pointer to the LICENSE files of the dependencies. we need to make sure that the license file is generated with sentry is built based on the jar that it is distributing. was:As per https://www.apache.org/dev/licensing-howto.html , sentry should update the LICENSE.txt file with license information of all the jars that sentry is distributing along with the pointer to the LICENSE files of the dependencies. > Automate the generation LICENSE.txt based on distributed jars > - > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch, > SENTRY-2081.008.patch, SENTRY-2081.009.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. > we need to make sure that the license file is generated with sentry is built > based on the jar that it is distributing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Automate the generation LICENSE.txt based on distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Summary: Automate the generation LICENSE.txt based on distributed jars (was: Update the LICENSE.txt with the license information of distributed jars) > Automate the generation LICENSE.txt based on distributed jars > - > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch, > SENTRY-2081.008.patch, SENTRY-2081.009.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2084) Exclude javax.jms:jms from sentry distribution
[ https://issues.apache.org/jira/browse/SENTRY-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2084: Attachment: SENTRY-2084.001.patch > Exclude javax.jms:jms from sentry distribution > -- > > Key: SENTRY-2084 > URL: https://issues.apache.org/jira/browse/SENTRY-2084 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2084.001.patch > > > we need to stop distributing jms artifact with group id: javax.jms as these > no valid valid license information available for this jar and secondly it is > a transitive dependency which sentry is not dependent on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[
https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275160#comment-16275160
]
Hadoop QA commented on SENTRY-2081:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12900284/SENTRY-2081.008.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3552/console
This message is automatically generated.
> Update the LICENSE.txt with the license information of distributed jars
> ---
>
> Key: SENTRY-2081
> URL: https://issues.apache.org/jira/browse/SENTRY-2081
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 2.0.0, 2.1.0
>Reporter: kalyan kumar kalvagadda
>Assignee: kalyan kumar kalvagadda
> Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch,
> SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch,
> SENTRY-2081.008.patch, SENTRY-2081.009.patch
>
>
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update
> the LICENSE.txt file with license information of all the jars that sentry is
> distributing along with the pointer to the LICENSE files of the dependencies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (SENTRY-2084) Exclude javax.jms:jms from sentry distribution
kalyan kumar kalvagadda created SENTRY-2084: --- Summary: Exclude javax.jms:jms from sentry distribution Key: SENTRY-2084 URL: https://issues.apache.org/jira/browse/SENTRY-2084 Project: Sentry Issue Type: Bug Components: Sentry Affects Versions: 2.0.0, 2.1.0 Reporter: kalyan kumar kalvagadda Assignee: kalyan kumar kalvagadda we need to stop distributing jms artifact with group id: javax.jms as these no valid valid license information available for this jar and secondly it is a transitive dependency which sentry is not dependent on. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: SENTRY-2081.009.patch > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch, > SENTRY-2081.008.patch, SENTRY-2081.009.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-1572) SentryMain() shouldn't dynamically load tool class
[
https://issues.apache.org/jira/browse/SENTRY-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275118#comment-16275118
]
Hadoop QA commented on SENTRY-1572:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12900280/SENTRY-1572.001.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3551/console
This message is automatically generated.
> SentryMain() shouldn't dynamically load tool class
> --
>
> Key: SENTRY-1572
> URL: https://issues.apache.org/jira/browse/SENTRY-1572
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
>Reporter: Alexander Kolbasov
>Assignee: Xinran Tinney
> Labels: bite-sized, newbie
> Attachments: SENTRY-1572.001.patch
>
>
> TheSentryMain class currently works by mapping the command name to a Java
> class that is then dynamically loaded:
> {code}
> String commandName = commandLine.getOptionValue(COMMAND);
> String commandClazz = COMMANDS.get(commandName);
> Object command;
> try {
> command = Class.forName(commandClazz.trim()).newInstance();
> } catch (Exception e) {
> String msg = "Could not create instance of " + commandClazz + " for
> command " + commandName;
> throw new IllegalStateException(msg, e);
> }
> if (!(command instanceof Command)) {
> String msg = "Command " + command.getClass().getName() + " is not an
> instance of "
> + Command.class.getName();
> throw new IllegalStateException(msg);
> }
> ((Command)command).run(commandLine.getArgs());
> }
> {code}
> This ia too complicated and causes subtle problems at runtime. Instead it
> should just create a new instance of appropriate class and call it directly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Assigned] (SENTRY-1200) Add basic ACL support for Admin-only to the debug webpage
[ https://issues.apache.org/jira/browse/SENTRY-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liam Sargent reassigned SENTRY-1200: Assignee: Liam Sargent > Add basic ACL support for Admin-only to the debug webpage > - > > Key: SENTRY-1200 > URL: https://issues.apache.org/jira/browse/SENTRY-1200 > Project: Sentry > Issue Type: Improvement >Reporter: Li Li >Assignee: Liam Sargent > Fix For: 2.1.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SENTRY-1049) Use existing validators in hive shell. Automatically for external generic services?
[ https://issues.apache.org/jira/browse/SENTRY-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liam Sargent reassigned SENTRY-1049: Assignee: Liam Sargent > Use existing validators in hive shell. Automatically for external generic > services? > > > Key: SENTRY-1049 > URL: https://issues.apache.org/jira/browse/SENTRY-1049 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 1.7.0 >Reporter: Gregory Chanan >Assignee: Liam Sargent > Fix For: 2.1.0 > > > SENTRY-1047 uses the existing validators for the Solr Shell. We should do > two things in addition to this: > 1) Update the hive shell to use the existing validators > 2) Figure out how arbitrary external generic services can apply their > validations. Can we do that automatically? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-1049) Use existing validators in hive shell. Automatically for external generic services?
[ https://issues.apache.org/jira/browse/SENTRY-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275101#comment-16275101 ] Liam Sargent commented on SENTRY-1049: -- I would like to take this on. Assigning to myself. > Use existing validators in hive shell. Automatically for external generic > services? > > > Key: SENTRY-1049 > URL: https://issues.apache.org/jira/browse/SENTRY-1049 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 1.7.0 >Reporter: Gregory Chanan > Fix For: 2.1.0 > > > SENTRY-1047 uses the existing validators for the Solr Shell. We should do > two things in addition to this: > 1) Update the hive shell to use the existing validators > 2) Figure out how arbitrary external generic services can apply their > validations. Can we do that automatically? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SENTRY-2083) Add more test cases for policy processor
Na Li created SENTRY-2083: - Summary: Add more test cases for policy processor Key: SENTRY-2083 URL: https://issues.apache.org/jira/browse/SENTRY-2083 Project: Sentry Issue Type: Task Components: Sentry Affects Versions: 2.0.0 Reporter: Na Li Assignee: Na Li We need to add more testing cases for policy store processor -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: SENTRY-2081.008.patch > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch, > SENTRY-2081.008.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274965#comment-16274965 ] kalyan kumar kalvagadda commented on SENTRY-2081: - [~akolb] I have submitted new patch which documents the process. > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274833#comment-16274833 ] kalyan kumar kalvagadda edited comment on SENTRY-2081 at 12/1/17 8:57 PM: -- [~akolb] I will update the title and description based on how our discussion ends up. Let me clarify couple of things here. # license-maven-plugin does not generate the license data in the format we should be reporting. we need to change that data to the format mentioned in https://www.apache.org/dev/licensing-howto.html . # jar's reported same license differently. we need to streamline them. For example jars having apache 2.0 licensing reported as below ## Apache License, Version 2.0 ## Apache Public License 2.0 ## Apache 2 ## Apache License Version 2 ## Apache License Version 2.0 ## Apache Software License - Version 2.0 ## Apache v2 ## Apache 2.0 ## Apache_2_0_license This change set combines all of together. we have the change ready and is reviewed, Is there a reason not to commit it for sentry 2.0? I'm working on adding a README_license file in the root directory with the required information. My patch is just to add that data. I will have the patch ready today. was (Author: kkalyan): [~akolb] I will update the title and description based on how on discussion end up. Let me clarify couple of things here. # license-maven-plugin does not generate the license data in the format we should be reporting. we need to change that data to the format mentioned in https://www.apache.org/dev/licensing-howto.html . # jar's reported same license differently. we need to streamline them. For example jars having apache 2.0 licensing reported as below ## Apache License, Version 2.0 ## Apache Public License 2.0 ## Apache 2 ## Apache License Version 2 ## Apache License Version 2.0 ## Apache Software License - Version 2.0 ## Apache v2 ## Apache 2.0 ## Apache_2_0_license This change set combines all of together. we have the change ready and is reviewed, Is there a reason not to commit it for sentry 2.0? I'm working on adding a README_license file in the root directory with the required information. My patch is just to add that data. I will have the patch ready today. > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: SENTRY-2081.007.patch > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch, SENTRY-2081.007.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-1572) SentryMain() shouldn't dynamically load tool class
[
https://issues.apache.org/jira/browse/SENTRY-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xinran Tinney updated SENTRY-1572:
--
Attachment: SENTRY-1572.001.patch
> SentryMain() shouldn't dynamically load tool class
> --
>
> Key: SENTRY-1572
> URL: https://issues.apache.org/jira/browse/SENTRY-1572
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
>Reporter: Alexander Kolbasov
>Assignee: Xinran Tinney
> Labels: bite-sized, newbie
> Attachments: SENTRY-1572.001.patch
>
>
> TheSentryMain class currently works by mapping the command name to a Java
> class that is then dynamically loaded:
> {code}
> String commandName = commandLine.getOptionValue(COMMAND);
> String commandClazz = COMMANDS.get(commandName);
> Object command;
> try {
> command = Class.forName(commandClazz.trim()).newInstance();
> } catch (Exception e) {
> String msg = "Could not create instance of " + commandClazz + " for
> command " + commandName;
> throw new IllegalStateException(msg, e);
> }
> if (!(command instanceof Command)) {
> String msg = "Command " + command.getClass().getName() + " is not an
> instance of "
> + Command.class.getName();
> throw new IllegalStateException(msg);
> }
> ((Command)command).run(commandLine.getArgs());
> }
> {code}
> This ia too complicated and causes subtle problems at runtime. Instead it
> should just create a new instance of appropriate class and call it directly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SENTRY-1572) SentryMain() shouldn't dynamically load tool class
[
https://issues.apache.org/jira/browse/SENTRY-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xinran Tinney updated SENTRY-1572:
--
Status: Patch Available (was: In Progress)
> SentryMain() shouldn't dynamically load tool class
> --
>
> Key: SENTRY-1572
> URL: https://issues.apache.org/jira/browse/SENTRY-1572
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
>Reporter: Alexander Kolbasov
>Assignee: Xinran Tinney
> Labels: bite-sized, newbie
> Attachments: SENTRY-1572.001.patch
>
>
> TheSentryMain class currently works by mapping the command name to a Java
> class that is then dynamically loaded:
> {code}
> String commandName = commandLine.getOptionValue(COMMAND);
> String commandClazz = COMMANDS.get(commandName);
> Object command;
> try {
> command = Class.forName(commandClazz.trim()).newInstance();
> } catch (Exception e) {
> String msg = "Could not create instance of " + commandClazz + " for
> command " + commandName;
> throw new IllegalStateException(msg, e);
> }
> if (!(command instanceof Command)) {
> String msg = "Command " + command.getClass().getName() + " is not an
> instance of "
> + Command.class.getName();
> throw new IllegalStateException(msg);
> }
> ((Command)command).run(commandLine.getArgs());
> }
> {code}
> This ia too complicated and causes subtle problems at runtime. Instead it
> should just create a new instance of appropriate class and call it directly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[
https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274878#comment-16274878
]
Hadoop QA commented on SENTRY-2081:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12900257/SENTRY-2081.006.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3549/console
This message is automatically generated.
> Update the LICENSE.txt with the license information of distributed jars
> ---
>
> Key: SENTRY-2081
> URL: https://issues.apache.org/jira/browse/SENTRY-2081
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 2.0.0, 2.1.0
>Reporter: kalyan kumar kalvagadda
>Assignee: kalyan kumar kalvagadda
> Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch,
> SENTRY-2081.005.patch, SENTRY-2081.006.patch
>
>
> As per https://www.apache.org/dev/licensing-howto.html , sentry should update
> the LICENSE.txt file with license information of all the jars that sentry is
> distributing along with the pointer to the LICENSE files of the dependencies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274833#comment-16274833 ] kalyan kumar kalvagadda commented on SENTRY-2081: - [~akolb] I will update the title and description based on how on discussion end up. Let me clarify couple of things here. # license-maven-plugin does not generate the license data in the format we should be reporting. we need to change that data to the format mentioned in https://www.apache.org/dev/licensing-howto.html . # jar's reported same license differently. we need to streamline them. For example jars having apache 2.0 licensing reported as below ## Apache License, Version 2.0 ## Apache Public License 2.0 ## Apache 2 ## Apache License Version 2 ## Apache License Version 2.0 ## Apache Software License - Version 2.0 ## Apache v2 ## Apache 2.0 ## Apache_2_0_license This change set combines all of together. we have the change ready and is reviewed, Is there a reason not to commit it for sentry 2.0? I'm working on adding a README_license file in the root directory with the required information. My patch is just to add that data. I will have the patch ready today. > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274771#comment-16274771 ] Alexander Kolbasov commented on SENTRY-2081: The synopsis and description of this issue are misleading - they should refer to and describe the automated update process. This would be a valid description if you are just updating the license file. So please update both accordingly. - What is the material difference in the resulting license file - did the automated generator discovered a lot of mismatches? - Automating the license file generation is a good idea, but do we necessarily want to do it in 2.0? We can just update the license file as needed in 2.0 and introduce the automation in 2.1. Looks like 2.0 is otherwise ready. - Have you documented the process for adding new libraries to Sentry? If not, how do you plan to document it - in the pom file, in the wiki, both? > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Kolbasov updated SENTRY-2081: --- Affects Version/s: 2.1.0 > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0, 2.1.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274732#comment-16274732 ] Colm O hEigeartaigh commented on SENTRY-2081: - LGTM +1. > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: SENTRY-2081.006.patch > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Status: Patch Available (was: Open) > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch, SENTRY-2081.006.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274703#comment-16274703 ] kalyan kumar kalvagadda commented on SENTRY-2081: - I will the comments on root LICENSE stuff. Regarding the Unknown_license, I made sure that there are no org.restlet are listed in CDDL_1.0 and Eclipse Public License-1. I will additional checks to avoid it. > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274690#comment-16274690 ] Colm O hEigeartaigh commented on SENTRY-2081: - Minor quibble: Replace "`For details" with "For details" in the root LICENSE. Also add some "" into the root LICENSE to make it clear the difference between the different dependency license references. In the generated LICENSE.txt you can remove the "Unknown license" part for Restlet: The binary distribution of this product bundles these dependencies under the a "Unknown license" license For details, see the associated license in licenses/Unknown_license.txt: * org.restlet (org.restlet.jee:org.restlet:2.3.0 - no url defined) * org.restlet.ext.servlet (org.restlet.jee:org.restlet.ext.servlet:2.3.0 - no url defined) Restlet is Apache licensed so we can just exclude it. > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274677#comment-16274677 ] kalyan kumar kalvagadda commented on SENTRY-2081: - [~coheig] It was added because of some change committed as part of SENTRY-2079 , sergio fixed it this morning. I fixed the patch now > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: (was: SENTRY-2081.004.patch) > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: SENTRY-2081.005.patch > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.005.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274666#comment-16274666 ] Colm O hEigeartaigh commented on SENTRY-2081: - I think the latest patch erroneously includes changes to the dependency reduced pom: error: sentry-provider/sentry-provider-db/dependency-reduced-pom.xml: No such file or directory > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.004.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: SENTRY-2081.004.patch > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch, > SENTRY-2081.004.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (SENTRY-1813) LeaderStatusMonitor could get into limbo state upon ZK connection loss
[
https://issues.apache.org/jira/browse/SENTRY-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Na Li resolved SENTRY-1813.
---
Resolution: Duplicate
Fix Version/s: (was: 2.1.0)
2.0.0
> LeaderStatusMonitor could get into limbo state upon ZK connection loss
> --
>
> Key: SENTRY-1813
> URL: https://issues.apache.org/jira/browse/SENTRY-1813
> Project: Sentry
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Vamsee Yarlagadda
>Assignee: Vamsee Yarlagadda
> Fix For: 2.0.0
>
> Attachments: Screenshot.png
>
>
> I noticed that during failover testing, if there was a connection loss with
> ZK to the sentry servers, the one who is currently the leader gets into a
> limbo state as it interrupts the Curator-LeaderSelector thread which no
> longer gets revived in the running Sentry process (unless the process is
> restarted).
> Relevant code under LeaderStatusMonitor
> http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5.1/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatusMonitor.java#L243-L246
> {code}
>try {
> isLeader = true;
> // Wait until we are interrupted or receive a signal
> cond.await();
> } catch (InterruptedException ignored) {
> Thread.currentThread().interrupt();
> LOG.info("LeaderStatusMonitor: interrupted");
> } finally {
> isLeader = false;
> lock.unlock();
> LOG.info("LeaderStatusMonitor: becoming standby");
> }
> {code}
> I realized even upon the loss of ZK connection, curator framework raises an
> Interrupted Exception in LeaderStausMonitor which attempts to call interrupt
> on Thread.currentThread which is essentially *Curator-LeaderSelector* thread.
>
> So if the LeaderSelector thread is interrupted, this particular Sentry server
> loses the capability of participating in a leader election in the future. And
> if this happens to all the sentry servers in the cluster, any further loss
> could get into a limbo state.
> And during this state, Sentry no longer reads events from HMS and thereby
> users can no longer be able to issue DDL statements like CREATE etc. However
> GRANT, REVOKE still work as they don't go through HMSFollower.
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274558#comment-16274558 ] kalyan kumar kalvagadda commented on SENTRY-2081: - [~akolb] Just to be clear on the changes. we could have added license information statically in License.txt but it had to manually updated and maintained. Using license-maven-plugin, updating license information is automated. when ever new code brings in new jars that we distribute, the LICENSE.txt generated in sentry-dist/target would be updated automatically with the latest. There would be manual work only when when sentry starts using jar's which are not licensed by either of the below. # BSD 2 clause # BSD License # CDDL 1.0 # CDDL 1.1 # CDDL 2 # Eclipse_Public_License-1 # MIT_License # Mozilla Public License Version 1.1 # Public_Domain # Apache # The BSD 3 Clause > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274431#comment-16274431 ] kalyan kumar kalvagadda edited comment on SENTRY-2081 at 12/1/17 2:09 PM: -- [~coheig] Rebased the patch addressing review comments. Additionally this patch makes sure that sentry doesn't distribute artifact javax.jms:jms as license information for this not available. was (Author: kkalyan): Rebased the patch addressing review comments. Additionally this patch makes sure that sentry doesn't distribute artifact javax.jms:jms as license information for this not available. > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: SENTRY-2081.003.patch > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: (was: SENTRY-2081.003.patch) > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274431#comment-16274431 ] kalyan kumar kalvagadda commented on SENTRY-2081: - Rebased the patch addressing review comments. Additionally this patch makes sure that sentry doesn't distribute artifact javax.jms:jms as license information for this not available. > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kalyan kumar kalvagadda updated SENTRY-2081: Attachment: SENTRY-2081.003.patch > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch, SENTRY-2081.003.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-2081) Update the LICENSE.txt with the license information of distributed jars
[ https://issues.apache.org/jira/browse/SENTRY-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274202#comment-16274202 ] Colm O hEigeartaigh commented on SENTRY-2081: - The patch doesn't apply with the latest changes on master on branch-2.0... You don't need to include the following licenses in src/main/resources/licenses: The_Apache_Software_License,_Version_1_1.txt the apache software license, version 2.0 - license-2.0.txt The_Apache_Software_License,_Version_2_0.txt Apache_2_0_license.txt > Update the LICENSE.txt with the license information of distributed jars > --- > > Key: SENTRY-2081 > URL: https://issues.apache.org/jira/browse/SENTRY-2081 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 2.0.0 >Reporter: kalyan kumar kalvagadda >Assignee: kalyan kumar kalvagadda > Attachments: SENTRY-2081.001.patch > > > As per https://www.apache.org/dev/licensing-howto.html , sentry should update > the LICENSE.txt file with license information of all the jars that sentry is > distributing along with the pointer to the LICENSE files of the dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
