[jira] [Assigned] (SENTRY-1558) Implement functionality to show groups for a given role
[
https://issues.apache.org/jira/browse/SENTRY-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned SENTRY-1558:
-
Assignee: (was: Jan Hentschel)
> Implement functionality to show groups for a given role
> ---
>
> Key: SENTRY-1558
> URL: https://issues.apache.org/jira/browse/SENTRY-1558
> Project: Sentry
> Issue Type: New Feature
>Reporter: Jan Hentschel
>Priority: Major
>
> Sentry allows to list the roles for a given group via
> {code:sql}
> SHOW ROLE GRANT GROUP ;
> {code}
> There should be also a way to show the groups for a given role. Currently it
> seems that this is only possible by directly querying the Sentry database.
> This functionality should be provided out-of-the-box similar to the statement
> above.
> The functionality could look similar to the following statement
> {code:sql}
> SHOW GROUP GRANT ROLE ;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-1558) Implement functionality to show groups for a given role
[
https://issues.apache.org/jira/browse/SENTRY-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375554#comment-16375554
]
Jan Hentschel commented on SENTRY-1558:
---
[~moist] I know that Hive doesn't support that. Currently it only seems to be
possible by querying the Sentry database directly. Because it seems to be a
common use case it should be provided by Sentry out-of-the-box without going
against the Sentry database.
> Implement functionality to show groups for a given role
> ---
>
> Key: SENTRY-1558
> URL: https://issues.apache.org/jira/browse/SENTRY-1558
> Project: Sentry
> Issue Type: New Feature
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Major
>
> Sentry allows to list the roles for a given group via
> {code:sql}
> SHOW ROLE GRANT GROUP ;
> {code}
> There should be also a way to show the groups for a given role. Currently it
> seems that this is only possible by directly querying the Sentry database.
> This functionality should be provided out-of-the-box similar to the statement
> above.
> The functionality could look similar to the following statement
> {code:sql}
> SHOW GROUP GRANT ROLE ;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SENTRY-1921) Make SentryServiceFactory.create static and all calling instances use the static call
[ https://issues.apache.org/jira/browse/SENTRY-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-1921: -- Status: Patch Available (was: In Progress) > Make SentryServiceFactory.create static and all calling instances use the > static call > - > > Key: SENTRY-1921 > URL: https://issues.apache.org/jira/browse/SENTRY-1921 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.0 >Reporter: Brian Towles >Assignee: Jan Hentschel >Priority: Minor > Attachments: SENTRY-1921.001.patch > > > The SentryServiceFactory.create call is not a static and all the references > to the factory end up creating a new instance of the factory. This should > be turned into a static call. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-1921) Make SentryServiceFactory.create static and all calling instances use the static call
[ https://issues.apache.org/jira/browse/SENTRY-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-1921: -- Attachment: SENTRY-1921.001.patch > Make SentryServiceFactory.create static and all calling instances use the > static call > - > > Key: SENTRY-1921 > URL: https://issues.apache.org/jira/browse/SENTRY-1921 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.0 >Reporter: Brian Towles >Assignee: Jan Hentschel >Priority: Minor > Attachments: SENTRY-1921.001.patch > > > The SentryServiceFactory.create call is not a static and all the references > to the factory end up creating a new instance of the factory. This should > be turned into a static call. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SENTRY-1921) Make SentryServiceFactory.create static and all calling instances use the static call
[ https://issues.apache.org/jira/browse/SENTRY-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel reassigned SENTRY-1921: - Assignee: Jan Hentschel > Make SentryServiceFactory.create static and all calling instances use the > static call > - > > Key: SENTRY-1921 > URL: https://issues.apache.org/jira/browse/SENTRY-1921 > Project: Sentry > Issue Type: Improvement > Components: Service >Affects Versions: 2.0.0 >Reporter: Brian Towles >Assignee: Jan Hentschel >Priority: Minor > > The SentryServiceFactory.create call is not a static and all the references > to the factory end up creating a new instance of the factory. This should > be turned into a static call. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SENTRY-378) Clean up the usage of SentryAccessDeniedException
[ https://issues.apache.org/jira/browse/SENTRY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-378: - Attachment: SENTRY-378.003.patch > Clean up the usage of SentryAccessDeniedException > - > > Key: SENTRY-378 > URL: https://issues.apache.org/jira/browse/SENTRY-378 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Sravya Tirukkovalur >Assignee: Jan Hentschel >Priority: Minor > Fix For: 2.0.0 > > Attachments: SENTRY-378.001.patch, SENTRY-378.002.patch, > SENTRY-378.002.patch, SENTRY-378.003.patch > > > SentryAccessDeniedException is mostly used when user does is not part of > sentry admin group, but is trying to create role, grant role or grant > privilege. Although I see that it is also used else where, there is scope > for some clean up. For example: > SentryStore.getMSentryVersion() -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-1558) Implement functionality to show groups for a given role
[
https://issues.apache.org/jira/browse/SENTRY-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16072382#comment-16072382
]
Jan Hentschel commented on SENTRY-1558:
---
[~bmedalen] Still working on it. I hadn't had time lately to bring this one on
the road.
> Implement functionality to show groups for a given role
> ---
>
> Key: SENTRY-1558
> URL: https://issues.apache.org/jira/browse/SENTRY-1558
> Project: Sentry
> Issue Type: New Feature
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>
> Sentry allows to list the roles for a given group via
> {code:sql}
> SHOW ROLE GRANT GROUP ;
> {code}
> There should be also a way to show the groups for a given role. Currently it
> seems that this is only possible by directly querying the Sentry database.
> This functionality should be provided out-of-the-box similar to the statement
> above.
> The functionality could look similar to the following statement
> {code:sql}
> SHOW GROUP GRANT ROLE ;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (SENTRY-1742) Upgrade to Maven surefire plugin v2.2
[ https://issues.apache.org/jira/browse/SENTRY-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-1742: -- Status: Patch Available (was: In Progress) > Upgrade to Maven surefire plugin v2.2 > - > > Key: SENTRY-1742 > URL: https://issues.apache.org/jira/browse/SENTRY-1742 > Project: Sentry > Issue Type: Improvement > Components: Sentry >Affects Versions: 1.8.0 >Reporter: Alexander Kolbasov >Assignee: Jan Hentschel > Attachments: SENTRY-1742.001.patch > > > There is 2.2 version of the Surefire plugin, we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SENTRY-1742) Upgrade to Maven surefire plugin v2.2
[ https://issues.apache.org/jira/browse/SENTRY-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-1742: -- Attachment: SENTRY-1742.001.patch > Upgrade to Maven surefire plugin v2.2 > - > > Key: SENTRY-1742 > URL: https://issues.apache.org/jira/browse/SENTRY-1742 > Project: Sentry > Issue Type: Improvement > Components: Sentry >Affects Versions: 1.8.0 >Reporter: Alexander Kolbasov >Assignee: Jan Hentschel > Attachments: SENTRY-1742.001.patch > > > There is 2.2 version of the Surefire plugin, we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SENTRY-1742) Upgrade to Maven surefire plugin v2.2
[ https://issues.apache.org/jira/browse/SENTRY-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel reassigned SENTRY-1742: - Assignee: Jan Hentschel > Upgrade to Maven surefire plugin v2.2 > - > > Key: SENTRY-1742 > URL: https://issues.apache.org/jira/browse/SENTRY-1742 > Project: Sentry > Issue Type: Improvement > Components: Sentry >Affects Versions: 1.8.0 >Reporter: Alexander Kolbasov >Assignee: Jan Hentschel > > There is 2.2 version of the Surefire plugin, we should upgrade. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (SENTRY-1724) Remove old PoolClientInvocationHandler
[ https://issues.apache.org/jira/browse/SENTRY-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved SENTRY-1724. --- Resolution: Duplicate > Remove old PoolClientInvocationHandler > -- > > Key: SENTRY-1724 > URL: https://issues.apache.org/jira/browse/SENTRY-1724 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Jan Hentschel > Fix For: sentry-ha-redesign > > > Old PoolClientInvocationHandler is no longer supported and should be removed, -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1724) Remove old PoolClientInvocationHandler
[ https://issues.apache.org/jira/browse/SENTRY-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990369#comment-15990369 ] Jan Hentschel commented on SENTRY-1724: --- [~akolb] Ok, then let's close this one with a link to this ticket. > Remove old PoolClientInvocationHandler > -- > > Key: SENTRY-1724 > URL: https://issues.apache.org/jira/browse/SENTRY-1724 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Jan Hentschel > Fix For: sentry-ha-redesign > > > Old PoolClientInvocationHandler is no longer supported and should be removed, -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SENTRY-1724) Remove old PoolClientInvocationHandler
[ https://issues.apache.org/jira/browse/SENTRY-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel reassigned SENTRY-1724: - Assignee: Jan Hentschel > Remove old PoolClientInvocationHandler > -- > > Key: SENTRY-1724 > URL: https://issues.apache.org/jira/browse/SENTRY-1724 > Project: Sentry > Issue Type: Sub-task > Components: Sentry >Affects Versions: sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: Jan Hentschel > Fix For: sentry-ha-redesign > > > Old PoolClientInvocationHandler is no longer supported and should be removed, -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SENTRY-378) Clean up the usage of SentryAccessDeniedException
[ https://issues.apache.org/jira/browse/SENTRY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-378: - Attachment: SENTRY-378.002.patch > Clean up the usage of SentryAccessDeniedException > - > > Key: SENTRY-378 > URL: https://issues.apache.org/jira/browse/SENTRY-378 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Sravya Tirukkovalur >Assignee: Jan Hentschel >Priority: Minor > Fix For: 1.8.0 > > Attachments: SENTRY-378.001.patch, SENTRY-378.002.patch, > SENTRY-378.002.patch > > > SentryAccessDeniedException is mostly used when user does is not part of > sentry admin group, but is trying to create role, grant role or grant > privilege. Although I see that it is also used else where, there is scope > for some clean up. For example: > SentryStore.getMSentryVersion() -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SENTRY-1660) Useless code in ResourceAuthorizationProvider
[
https://issues.apache.org/jira/browse/SENTRY-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955203#comment-15955203
]
Jan Hentschel commented on SENTRY-1660:
---
[~akolb] I reviewed the code snippets you mentioned above. They seem to do
nearly the same. Some of the stuff around the actions was moved out to the
*buildPermissions* methods. It doesn't seem to be something obvious. What do
you think in which direction the bug goes?
> Useless code in ResourceAuthorizationProvider
> -
>
> Key: SENTRY-1660
> URL: https://issues.apache.org/jira/browse/SENTRY-1660
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1660.001.patch
>
>
> The ResourceAuthorizationProvider class has the following code:
> {code}
> Set hierarchy = new HashSet();
> for (Authorizable authorizable : authorizables) {
> hierarchy.add(KV_JOINER.join(authorizable.getTypeName(),
> authorizable.getName()));
> }
> {code}
> The {{hierarchy}} variable is never used afterwords, so this code is
> completely useless.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-378) Clean up the usage of SentryAccessDeniedException
[ https://issues.apache.org/jira/browse/SENTRY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955156#comment-15955156 ] Jan Hentschel commented on SENTRY-378: -- The test failure seem to be unrelated to the actual change. Locally the test passes. > Clean up the usage of SentryAccessDeniedException > - > > Key: SENTRY-378 > URL: https://issues.apache.org/jira/browse/SENTRY-378 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Sravya Tirukkovalur >Assignee: Jan Hentschel >Priority: Minor > Fix For: 1.8.0 > > Attachments: SENTRY-378.001.patch, SENTRY-378.002.patch > > > SentryAccessDeniedException is mostly used when user does is not part of > sentry admin group, but is trying to create role, grant role or grant > privilege. Although I see that it is also used else where, there is scope > for some clean up. For example: > SentryStore.getMSentryVersion() -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SENTRY-1680) MetastoreCacheInitializer is lo longer used and should be removed
[
https://issues.apache.org/jira/browse/SENTRY-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1680:
--
Attachment: SENTRY-1680.002-sentry-ha-redesign.patch
Addressed the error when applying the patch.
> MetastoreCacheInitializer is lo longer used and should be removed
> -
>
> Key: SENTRY-1680
> URL: https://issues.apache.org/jira/browse/SENTRY-1680
> Project: Sentry
> Issue Type: Sub-task
> Components: Sentry
>Affects Versions: sentry-ha-redesign
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
> Labels: bite-sized, newbie
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1680.001-sentry-ha-redesign.patch,
> SENTRY-1680.002-sentry-ha-redesign.patch
>
>
> The {{MetastoreCacheInitializer}} class is not used since SENTRY-1613 and
> should be removed, together with its tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1680) MetastoreCacheInitializer is lo longer used and should be removed
[
https://issues.apache.org/jira/browse/SENTRY-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1680:
--
Status: Patch Available (was: In Progress)
> MetastoreCacheInitializer is lo longer used and should be removed
> -
>
> Key: SENTRY-1680
> URL: https://issues.apache.org/jira/browse/SENTRY-1680
> Project: Sentry
> Issue Type: Sub-task
> Components: Sentry
>Affects Versions: sentry-ha-redesign
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
> Labels: bite-sized, newbie
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1680.001-sentry-ha-redesign.patch
>
>
> The {{MetastoreCacheInitializer}} class is not used since SENTRY-1613 and
> should be removed, together with its tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1680) MetastoreCacheInitializer is lo longer used and should be removed
[
https://issues.apache.org/jira/browse/SENTRY-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1680:
--
Attachment: SENTRY-1680.001-sentry-ha-redesign.patch
> MetastoreCacheInitializer is lo longer used and should be removed
> -
>
> Key: SENTRY-1680
> URL: https://issues.apache.org/jira/browse/SENTRY-1680
> Project: Sentry
> Issue Type: Sub-task
> Components: Sentry
>Affects Versions: sentry-ha-redesign
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
> Labels: bite-sized, newbie
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1680.001-sentry-ha-redesign.patch
>
>
> The {{MetastoreCacheInitializer}} class is not used since SENTRY-1613 and
> should be removed, together with its tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (SENTRY-1680) MetastoreCacheInitializer is lo longer used and should be removed
[
https://issues.apache.org/jira/browse/SENTRY-1680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned SENTRY-1680:
-
Assignee: Jan Hentschel
> MetastoreCacheInitializer is lo longer used and should be removed
> -
>
> Key: SENTRY-1680
> URL: https://issues.apache.org/jira/browse/SENTRY-1680
> Project: Sentry
> Issue Type: Sub-task
> Components: Sentry
>Affects Versions: sentry-ha-redesign
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
> Labels: bite-sized, newbie
> Fix For: sentry-ha-redesign
>
>
> The {{MetastoreCacheInitializer}} class is not used since SENTRY-1613 and
> should be removed, together with its tests.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1660) Useless code in ResourceAuthorizationProvider
[
https://issues.apache.org/jira/browse/SENTRY-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939988#comment-15939988
]
Jan Hentschel commented on SENTRY-1660:
---
[~akolb] The last QA run was successfully and it seemed to me that there are no
additional changes needed.
> Useless code in ResourceAuthorizationProvider
> -
>
> Key: SENTRY-1660
> URL: https://issues.apache.org/jira/browse/SENTRY-1660
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1660.001.patch
>
>
> The ResourceAuthorizationProvider class has the following code:
> {code}
> Set hierarchy = new HashSet();
> for (Authorizable authorizable : authorizables) {
> hierarchy.add(KV_JOINER.join(authorizable.getTypeName(),
> authorizable.getName()));
> }
> {code}
> The {{hierarchy}} variable is never used afterwords, so this code is
> completely useless.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1660) Useless code in ResourceAuthorizationProvider
[
https://issues.apache.org/jira/browse/SENTRY-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926787#comment-15926787
]
Jan Hentschel commented on SENTRY-1660:
---
How can I resubmit a patch? Just attaching the same patch a second time?
> Useless code in ResourceAuthorizationProvider
> -
>
> Key: SENTRY-1660
> URL: https://issues.apache.org/jira/browse/SENTRY-1660
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1660.001.patch
>
>
> The ResourceAuthorizationProvider class has the following code:
> {code}
> Set hierarchy = new HashSet();
> for (Authorizable authorizable : authorizables) {
> hierarchy.add(KV_JOINER.join(authorizable.getTypeName(),
> authorizable.getName()));
> }
> {code}
> The {{hierarchy}} variable is never used afterwords, so this code is
> completely useless.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1658) Null pointer derefeence in SentryShellHive
[
https://issues.apache.org/jira/browse/SENTRY-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1658:
--
Status: Patch Available (was: In Progress)
> Null pointer derefeence in SentryShellHive
> --
>
> Key: SENTRY-1658
> URL: https://issues.apache.org/jira/browse/SENTRY-1658
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1658.001.patch
>
>
> In SentryShellHive.java there is the following code:
> {code}
> public static void main(String[] args) throws Exception {
> SentryShellHive sentryShell = new SentryShellHive();
> try {
> sentryShell.executeShell(args);
> } catch (Exception e) {
> LOGGER.error(e.getMessage(), e);
> Throwable current = e;
> // find the first printable message;
> while (current != null && current.getMessage() == null) {
> current = current.getCause();
> }
> // current can be null here
>System.out.println("The operation failed." +
> (current.getMessage() == null ? "" : " Message: " +
> current.getMessage()));
> }
> }
> {code}
> Note that current can be null when we call getMessage()
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1658) Null pointer derefeence in SentryShellHive
[
https://issues.apache.org/jira/browse/SENTRY-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1658:
--
Attachment: SENTRY-1658.001.patch
> Null pointer derefeence in SentryShellHive
> --
>
> Key: SENTRY-1658
> URL: https://issues.apache.org/jira/browse/SENTRY-1658
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1658.001.patch
>
>
> In SentryShellHive.java there is the following code:
> {code}
> public static void main(String[] args) throws Exception {
> SentryShellHive sentryShell = new SentryShellHive();
> try {
> sentryShell.executeShell(args);
> } catch (Exception e) {
> LOGGER.error(e.getMessage(), e);
> Throwable current = e;
> // find the first printable message;
> while (current != null && current.getMessage() == null) {
> current = current.getCause();
> }
> // current can be null here
>System.out.println("The operation failed." +
> (current.getMessage() == null ? "" : " Message: " +
> current.getMessage()));
> }
> }
> {code}
> Note that current can be null when we call getMessage()
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (SENTRY-1658) Null pointer derefeence in SentryShellHive
[
https://issues.apache.org/jira/browse/SENTRY-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned SENTRY-1658:
-
Assignee: Jan Hentschel
> Null pointer derefeence in SentryShellHive
> --
>
> Key: SENTRY-1658
> URL: https://issues.apache.org/jira/browse/SENTRY-1658
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
>
> In SentryShellHive.java there is the following code:
> {code}
> public static void main(String[] args) throws Exception {
> SentryShellHive sentryShell = new SentryShellHive();
> try {
> sentryShell.executeShell(args);
> } catch (Exception e) {
> LOGGER.error(e.getMessage(), e);
> Throwable current = e;
> // find the first printable message;
> while (current != null && current.getMessage() == null) {
> current = current.getCause();
> }
> // current can be null here
>System.out.println("The operation failed." +
> (current.getMessage() == null ? "" : " Message: " +
> current.getMessage()));
> }
> }
> {code}
> Note that current can be null when we call getMessage()
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1657) Possible null-pointer dereference in SentryMain
[
https://issues.apache.org/jira/browse/SENTRY-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926622#comment-15926622
]
Jan Hentschel commented on SENTRY-1657:
---
[~akolb] Can *commandClazz* really be null in the try-block? If *commandClazz*
is null in the if-statement it will go to the *printHelp* method which exits
with a 1 code.
{code:java}
private static void printHelp(Options options, String msg) {
String sentry = "sentry";
if (msg != null) {
sentry = msg + sentry;
}
(new HelpFormatter()).printHelp(sentry, options);
System.exit(1);
}
{code}
> Possible null-pointer dereference in SentryMain
> ---
>
> Key: SENTRY-1657
> URL: https://issues.apache.org/jira/browse/SENTRY-1657
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Priority: Minor
> Labels: bite-sized, newbie
>
> In SentryMain.java there is the following code:
> {code}
> String commandClazz = COMMANDS.get(commandName);
> if (commandClazz == null) { // may be null here
> printHelp(options, "Unknown command " + commandName + "\n");
> }
> Object command;
> try {
> command = Class.forName(commandClazz.trim()).newInstance(); //
> dereference null here
> ...
> {code}
> Note that commandClazz may be null and yet be dereferenced.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1663) UpdateableAuthzPermissions has mutable static fields
[
https://issues.apache.org/jira/browse/SENTRY-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1663:
--
Status: Patch Available (was: In Progress)
> UpdateableAuthzPermissions has mutable static fields
>
>
> Key: SENTRY-1663
> URL: https://issues.apache.org/jira/browse/SENTRY-1663
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1663.001.patch
>
>
> UpdateableAuthzPermissions has the following code:
> {code}
> public static final Map ACTION_MAPPING = new
> HashMap();
>
> static {
> ACTION_MAPPING.put("ALL", FsAction.ALL);
> ACTION_MAPPING.put("*", FsAction.ALL);
> ACTION_MAPPING.put("SELECT", FsAction.READ_EXECUTE);
> ACTION_MAPPING.put("select", FsAction.READ_EXECUTE);
> ACTION_MAPPING.put("INSERT", FsAction.WRITE_EXECUTE);
> ACTION_MAPPING.put("insert", FsAction.WRITE_EXECUTE);
> }
> {code}
> It should use ImmutableMap instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1663) UpdateableAuthzPermissions has mutable static fields
[
https://issues.apache.org/jira/browse/SENTRY-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1663:
--
Attachment: SENTRY-1663.001.patch
> UpdateableAuthzPermissions has mutable static fields
>
>
> Key: SENTRY-1663
> URL: https://issues.apache.org/jira/browse/SENTRY-1663
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1663.001.patch
>
>
> UpdateableAuthzPermissions has the following code:
> {code}
> public static final Map ACTION_MAPPING = new
> HashMap();
>
> static {
> ACTION_MAPPING.put("ALL", FsAction.ALL);
> ACTION_MAPPING.put("*", FsAction.ALL);
> ACTION_MAPPING.put("SELECT", FsAction.READ_EXECUTE);
> ACTION_MAPPING.put("select", FsAction.READ_EXECUTE);
> ACTION_MAPPING.put("INSERT", FsAction.WRITE_EXECUTE);
> ACTION_MAPPING.put("insert", FsAction.WRITE_EXECUTE);
> }
> {code}
> It should use ImmutableMap instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (SENTRY-1663) UpdateableAuthzPermissions has mutable static fields
[
https://issues.apache.org/jira/browse/SENTRY-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned SENTRY-1663:
-
Assignee: Jan Hentschel
> UpdateableAuthzPermissions has mutable static fields
>
>
> Key: SENTRY-1663
> URL: https://issues.apache.org/jira/browse/SENTRY-1663
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
>
> UpdateableAuthzPermissions has the following code:
> {code}
> public static final Map ACTION_MAPPING = new
> HashMap();
>
> static {
> ACTION_MAPPING.put("ALL", FsAction.ALL);
> ACTION_MAPPING.put("*", FsAction.ALL);
> ACTION_MAPPING.put("SELECT", FsAction.READ_EXECUTE);
> ACTION_MAPPING.put("select", FsAction.READ_EXECUTE);
> ACTION_MAPPING.put("INSERT", FsAction.WRITE_EXECUTE);
> ACTION_MAPPING.put("insert", FsAction.WRITE_EXECUTE);
> }
> {code}
> It should use ImmutableMap instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1660) Useless code in ResourceAuthorizationProvider
[
https://issues.apache.org/jira/browse/SENTRY-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925927#comment-15925927
]
Jan Hentschel commented on SENTRY-1660:
---
The test failure seems to be unrelated to the actual change.
{code}
java.io.IOException: HADOOP_HOME or hadoop.home.dir are not set.
{code}
> Useless code in ResourceAuthorizationProvider
> -
>
> Key: SENTRY-1660
> URL: https://issues.apache.org/jira/browse/SENTRY-1660
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1660.001.patch
>
>
> The ResourceAuthorizationProvider class has the following code:
> {code}
> Set hierarchy = new HashSet();
> for (Authorizable authorizable : authorizables) {
> hierarchy.add(KV_JOINER.join(authorizable.getTypeName(),
> authorizable.getName()));
> }
> {code}
> The {{hierarchy}} variable is never used afterwords, so this code is
> completely useless.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1660) Useless code in ResourceAuthorizationProvider
[
https://issues.apache.org/jira/browse/SENTRY-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1660:
--
Attachment: SENTRY-1660.001.patch
> Useless code in ResourceAuthorizationProvider
> -
>
> Key: SENTRY-1660
> URL: https://issues.apache.org/jira/browse/SENTRY-1660
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1660.001.patch
>
>
> The ResourceAuthorizationProvider class has the following code:
> {code}
> Set hierarchy = new HashSet();
> for (Authorizable authorizable : authorizables) {
> hierarchy.add(KV_JOINER.join(authorizable.getTypeName(),
> authorizable.getName()));
> }
> {code}
> The {{hierarchy}} variable is never used afterwords, so this code is
> completely useless.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1660) Useless code in ResourceAuthorizationProvider
[
https://issues.apache.org/jira/browse/SENTRY-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1660:
--
Status: Patch Available (was: In Progress)
> Useless code in ResourceAuthorizationProvider
> -
>
> Key: SENTRY-1660
> URL: https://issues.apache.org/jira/browse/SENTRY-1660
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1660.001.patch
>
>
> The ResourceAuthorizationProvider class has the following code:
> {code}
> Set hierarchy = new HashSet();
> for (Authorizable authorizable : authorizables) {
> hierarchy.add(KV_JOINER.join(authorizable.getTypeName(),
> authorizable.getName()));
> }
> {code}
> The {{hierarchy}} variable is never used afterwords, so this code is
> completely useless.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (SENTRY-1660) Useless code in ResourceAuthorizationProvider
[
https://issues.apache.org/jira/browse/SENTRY-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned SENTRY-1660:
-
Assignee: Jan Hentschel
> Useless code in ResourceAuthorizationProvider
> -
>
> Key: SENTRY-1660
> URL: https://issues.apache.org/jira/browse/SENTRY-1660
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
>Affects Versions: 1.8.0
>Reporter: Alexander Kolbasov
>Assignee: Jan Hentschel
>Priority: Minor
> Labels: bite-sized, newbie
>
> The ResourceAuthorizationProvider class has the following code:
> {code}
> Set hierarchy = new HashSet();
> for (Authorizable authorizable : authorizables) {
> hierarchy.add(KV_JOINER.join(authorizable.getTypeName(),
> authorizable.getName()));
> }
> {code}
> The {{hierarchy}} variable is never used afterwords, so this code is
> completely useless.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-378) Clean up the usage of SentryAccessDeniedException
[ https://issues.apache.org/jira/browse/SENTRY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-378: - Attachment: SENTRY-378.002.patch > Clean up the usage of SentryAccessDeniedException > - > > Key: SENTRY-378 > URL: https://issues.apache.org/jira/browse/SENTRY-378 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Sravya Tirukkovalur >Assignee: Jan Hentschel >Priority: Minor > Fix For: 1.8.0 > > Attachments: SENTRY-378.001.patch, SENTRY-378.002.patch > > > SentryAccessDeniedException is mostly used when user does is not part of > sentry admin group, but is trying to create role, grant role or grant > privilege. Although I see that it is also used else where, there is scope > for some clean up. For example: > SentryStore.getMSentryVersion() -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SENTRY-1513) Avoid two splits in PathsUpdate.java
[
https://issues.apache.org/jira/browse/SENTRY-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned SENTRY-1513:
-
Assignee: Jan Hentschel
> Avoid two splits in PathsUpdate.java
>
>
> Key: SENTRY-1513
> URL: https://issues.apache.org/jira/browse/SENTRY-1513
> Project: Sentry
> Issue Type: Improvement
>Reporter: Sravya Tirukkovalur
>Assignee: Jan Hentschel
>Priority: Trivial
> Labels: newbie
> Attachments: SENTRY-1513.001.patch, SENTRY-1513.002.patch
>
>
> {code}
> if(uriPath.split("^/").length < 2) {
> throw new SentryMalformedPathException("Path part of uri does
> not seem right, was expecting a non empty path" +
> ": path = " + uriPath + ", uri=" + uri);
> }
> return Lists.newArrayList(uriPath.split("^/")[1].split("/"));
> {code}
> Also, correct the spelling in the same file
> URIs with non hdfs *schemee* will just be ignore
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1513) Avoid two splits in PathsUpdate.java
[
https://issues.apache.org/jira/browse/SENTRY-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1513:
--
Status: Patch Available (was: In Progress)
> Avoid two splits in PathsUpdate.java
>
>
> Key: SENTRY-1513
> URL: https://issues.apache.org/jira/browse/SENTRY-1513
> Project: Sentry
> Issue Type: Improvement
>Reporter: Sravya Tirukkovalur
>Assignee: Jan Hentschel
>Priority: Trivial
> Labels: newbie
> Attachments: SENTRY-1513.001.patch, SENTRY-1513.002.patch
>
>
> {code}
> if(uriPath.split("^/").length < 2) {
> throw new SentryMalformedPathException("Path part of uri does
> not seem right, was expecting a non empty path" +
> ": path = " + uriPath + ", uri=" + uri);
> }
> return Lists.newArrayList(uriPath.split("^/")[1].split("/"));
> {code}
> Also, correct the spelling in the same file
> URIs with non hdfs *schemee* will just be ignore
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-378) Clean up the usage of SentryAccessDeniedException
[ https://issues.apache.org/jira/browse/SENTRY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-378: - Status: Patch Available (was: In Progress) > Clean up the usage of SentryAccessDeniedException > - > > Key: SENTRY-378 > URL: https://issues.apache.org/jira/browse/SENTRY-378 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Sravya Tirukkovalur >Assignee: Jan Hentschel >Priority: Minor > Fix For: 1.8.0 > > Attachments: SENTRY-378.001.patch > > > SentryAccessDeniedException is mostly used when user does is not part of > sentry admin group, but is trying to create role, grant role or grant > privilege. Although I see that it is also used else where, there is scope > for some clean up. For example: > SentryStore.getMSentryVersion() -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SENTRY-378) Clean up the usage of SentryAccessDeniedException
[ https://issues.apache.org/jira/browse/SENTRY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel reassigned SENTRY-378: Assignee: Jan Hentschel > Clean up the usage of SentryAccessDeniedException > - > > Key: SENTRY-378 > URL: https://issues.apache.org/jira/browse/SENTRY-378 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Sravya Tirukkovalur >Assignee: Jan Hentschel >Priority: Minor > Fix For: 1.8.0 > > Attachments: SENTRY-378.001.patch > > > SentryAccessDeniedException is mostly used when user does is not part of > sentry admin group, but is trying to create role, grant role or grant > privilege. Although I see that it is also used else where, there is scope > for some clean up. For example: > SentryStore.getMSentryVersion() -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SENTRY-845) TestColumnEndToEnd.java might need to be renamed to TestDbColumnEndToEnd.java
[ https://issues.apache.org/jira/browse/SENTRY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-845: - Status: Patch Available (was: In Progress) > TestColumnEndToEnd.java might need to be renamed to TestDbColumnEndToEnd.java > - > > Key: SENTRY-845 > URL: https://issues.apache.org/jira/browse/SENTRY-845 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.5.1 >Reporter: Anne Yu >Assignee: Jan Hentschel > Attachments: SENTRY-845.001.patch > > > TestColumnEndToEnd.java locates in the org.apache.sentry.tests.e2e.dbprovider > test package, seems it is meant to just run with sentry service, may need to > rename to stick to current naming conventions. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (SENTRY-1117) solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
[
https://issues.apache.org/jira/browse/SENTRY-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1117:
--
Status: Patch Available (was: In Progress)
> solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
> --
>
> Key: SENTRY-1117
> URL: https://issues.apache.org/jira/browse/SENTRY-1117
> Project: Sentry
> Issue Type: Task
> Components: Solr Plugin
>Reporter: Gregory Chanan
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: SENTRY-1117.001.patch,
> SENTRY-1117.001-sentry-ha-redesign.patch
>
>
> This specification is inconsistent with the sentry-hdfs plugin:
> {code}
> ~/workspace/incubator-sentry8/sentry-hdfs$ ls
> pom.xml sentry-hdfs-dist sentry-hdfs-service
> sentry-hdfs-common sentry-hdfs-namenode-plugin target
> {code}
> {code}
> :~/workspace/incubator-sentry8/sentry-solr$ ls
> pom.xml solr-sentry-core solr-sentry-handlers target
> {code}
> i.e. solr-sentry-core and solr-sentry-handlers should be sentry-solr-core and
> sentry-solr-handlers, respectively.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Assigned] (SENTRY-845) TestColumnEndToEnd.java might need to be renamed to TestDbColumnEndToEnd.java
[ https://issues.apache.org/jira/browse/SENTRY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel reassigned SENTRY-845: Assignee: Jan Hentschel > TestColumnEndToEnd.java might need to be renamed to TestDbColumnEndToEnd.java > - > > Key: SENTRY-845 > URL: https://issues.apache.org/jira/browse/SENTRY-845 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.5.1 >Reporter: Anne Yu >Assignee: Jan Hentschel > Attachments: SENTRY-845.001.patch > > > TestColumnEndToEnd.java locates in the org.apache.sentry.tests.e2e.dbprovider > test package, seems it is meant to just run with sentry service, may need to > rename to stick to current naming conventions. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SENTRY-1117) solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
[
https://issues.apache.org/jira/browse/SENTRY-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned SENTRY-1117:
-
Assignee: Jan Hentschel
> solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
> --
>
> Key: SENTRY-1117
> URL: https://issues.apache.org/jira/browse/SENTRY-1117
> Project: Sentry
> Issue Type: Task
> Components: Solr Plugin
>Reporter: Gregory Chanan
>Assignee: Jan Hentschel
>Priority: Minor
> Attachments: SENTRY-1117.001.patch,
> SENTRY-1117.001-sentry-ha-redesign.patch
>
>
> This specification is inconsistent with the sentry-hdfs plugin:
> {code}
> ~/workspace/incubator-sentry8/sentry-hdfs$ ls
> pom.xml sentry-hdfs-dist sentry-hdfs-service
> sentry-hdfs-common sentry-hdfs-namenode-plugin target
> {code}
> {code}
> :~/workspace/incubator-sentry8/sentry-solr$ ls
> pom.xml solr-sentry-core solr-sentry-handlers target
> {code}
> i.e. solr-sentry-core and solr-sentry-handlers should be sentry-solr-core and
> sentry-solr-handlers, respectively.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1305) Remove API PrivilegeCache.listPrivileges(Set groups, Set users, ActiveRoleSet roleSet) in Sentry 2.0 release
[ https://issues.apache.org/jira/browse/SENTRY-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-1305: -- Status: Patch Available (was: In Progress) > Remove API PrivilegeCache.listPrivileges(Set groups, Set > users, ActiveRoleSet roleSet) in Sentry 2.0 release > > > Key: SENTRY-1305 > URL: https://issues.apache.org/jira/browse/SENTRY-1305 > Project: Sentry > Issue Type: Improvement > Components: Sentry >Reporter: Hao Hao >Assignee: Jan Hentschel > Attachments: SENTRY-1305.001.patch > > > Sentry-1291 has deprecated API PrivilegeCache.listPrivileges(Set > groups, Set users, ActiveRoleSet roleSet). We may want to remove it > in Sentry 2.0 release. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SENTRY-1305) Remove API PrivilegeCache.listPrivileges(Set groups, Set users, ActiveRoleSet roleSet) in Sentry 2.0 release
[ https://issues.apache.org/jira/browse/SENTRY-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel reassigned SENTRY-1305: - Assignee: Jan Hentschel > Remove API PrivilegeCache.listPrivileges(Set groups, Set > users, ActiveRoleSet roleSet) in Sentry 2.0 release > > > Key: SENTRY-1305 > URL: https://issues.apache.org/jira/browse/SENTRY-1305 > Project: Sentry > Issue Type: Improvement > Components: Sentry >Reporter: Hao Hao >Assignee: Jan Hentschel > Attachments: SENTRY-1305.001.patch > > > Sentry-1291 has deprecated API PrivilegeCache.listPrivileges(Set > groups, Set users, ActiveRoleSet roleSet). We may want to remove it > in Sentry 2.0 release. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Assigned] (SENTRY-1558) Implement functionality to show groups for a given role
[
https://issues.apache.org/jira/browse/SENTRY-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel reassigned SENTRY-1558:
-
Assignee: Jan Hentschel
> Implement functionality to show groups for a given role
> ---
>
> Key: SENTRY-1558
> URL: https://issues.apache.org/jira/browse/SENTRY-1558
> Project: Sentry
> Issue Type: New Feature
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>
> Sentry allows to list the roles for a given group via
> {code:sql}
> SHOW ROLE GRANT GROUP ;
> {code}
> There should be also a way to show the groups for a given role. Currently it
> seems that this is only possible by directly querying the Sentry database.
> This functionality should be provided out-of-the-box similar to the statement
> above.
> The functionality could look similar to the following statement
> {code:sql}
> SHOW GROUP GRANT ROLE ;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (SENTRY-1513) Avoid two splits in PathsUpdate.java
[
https://issues.apache.org/jira/browse/SENTRY-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1513:
--
Attachment: SENTRY-1513.002.patch
Added new patch which incorporates the feedback from the review.
> Avoid two splits in PathsUpdate.java
>
>
> Key: SENTRY-1513
> URL: https://issues.apache.org/jira/browse/SENTRY-1513
> Project: Sentry
> Issue Type: Improvement
>Reporter: Sravya Tirukkovalur
>Priority: Trivial
> Labels: newbie
> Attachments: SENTRY-1513.001.patch, SENTRY-1513.002.patch
>
>
> {code}
> if(uriPath.split("^/").length < 2) {
> throw new SentryMalformedPathException("Path part of uri does
> not seem right, was expecting a non empty path" +
> ": path = " + uriPath + ", uri=" + uri);
> }
> return Lists.newArrayList(uriPath.split("^/")[1].split("/"));
> {code}
> Also, correct the spelling in the same file
> URIs with non hdfs *schemee* will just be ignore
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SENTRY-1513) Avoid two splits in PathsUpdate.java
[
https://issues.apache.org/jira/browse/SENTRY-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1513:
--
Attachment: SENTRY-1513.001.patch
Added a patch which changes the way the split works when parsing a path and
corrected a spelling in PathsUpdate.
> Avoid two splits in PathsUpdate.java
>
>
> Key: SENTRY-1513
> URL: https://issues.apache.org/jira/browse/SENTRY-1513
> Project: Sentry
> Issue Type: Improvement
>Reporter: Sravya Tirukkovalur
>Priority: Trivial
> Labels: newbie
> Attachments: SENTRY-1513.001.patch
>
>
> {code}
> if(uriPath.split("^/").length < 2) {
> throw new SentryMalformedPathException("Path part of uri does
> not seem right, was expecting a non empty path" +
> ": path = " + uriPath + ", uri=" + uri);
> }
> return Lists.newArrayList(uriPath.split("^/")[1].split("/"));
> {code}
> Also, correct the spelling in the same file
> URIs with non hdfs *schemee* will just be ignore
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SENTRY-378) Clean up the usage of SentryAccessDeniedException
[ https://issues.apache.org/jira/browse/SENTRY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-378: - Attachment: SENTRY-378.001.patch Added a patch which changes the usages of SentryAccessDeniedException to SentryConfigurationException when retrieving Sentry version information in SentryStore. > Clean up the usage of SentryAccessDeniedException > - > > Key: SENTRY-378 > URL: https://issues.apache.org/jira/browse/SENTRY-378 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.4.0 >Reporter: Sravya Tirukkovalur >Priority: Minor > Fix For: 1.8.0 > > Attachments: SENTRY-378.001.patch > > > SentryAccessDeniedException is mostly used when user does is not part of > sentry admin group, but is trying to create role, grant role or grant > privilege. Although I see that it is also used else where, there is scope > for some clean up. For example: > SentryStore.getMSentryVersion() -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SENTRY-1558) Implement functionality to show groups for a given role
[
https://issues.apache.org/jira/browse/SENTRY-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15731437#comment-15731437
]
Jan Hentschel commented on SENTRY-1558:
---
I would like to work on this one. Could someone please assign this ticket to me?
> Implement functionality to show groups for a given role
> ---
>
> Key: SENTRY-1558
> URL: https://issues.apache.org/jira/browse/SENTRY-1558
> Project: Sentry
> Issue Type: New Feature
>Reporter: Jan Hentschel
>
> Sentry allows to list the roles for a given group via
> {code:sql}
> SHOW ROLE GRANT GROUP ;
> {code}
> There should be also a way to show the groups for a given role. Currently it
> seems that this is only possible by directly querying the Sentry database.
> This functionality should be provided out-of-the-box similar to the statement
> above.
> The functionality could look similar to the following statement
> {code:sql}
> SHOW GROUP GRANT ROLE ;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SENTRY-1558) Implement functionality to show groups for a given role
Jan Hentschel created SENTRY-1558:
-
Summary: Implement functionality to show groups for a given role
Key: SENTRY-1558
URL: https://issues.apache.org/jira/browse/SENTRY-1558
Project: Sentry
Issue Type: New Feature
Reporter: Jan Hentschel
Sentry allows to list the roles for a given group via
{code:sql}
SHOW ROLE GRANT GROUP ;
{code}
There should be also a way to show the groups for a given role. Currently it
seems that this is only possible by directly querying the Sentry database. This
functionality should be provided out-of-the-box similar to the statement above.
The functionality could look similar to the following statement
{code:sql}
SHOW GROUP GRANT ROLE ;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SENTRY-845) TestColumnEndToEnd.java might need to be renamed to TestDbColumnEndToEnd.java
[ https://issues.apache.org/jira/browse/SENTRY-845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-845: - Attachment: SENTRY-845.001.patch Added a patch which renames TestColumnEndToEnd to TestDbColumnEndToEnd. > TestColumnEndToEnd.java might need to be renamed to TestDbColumnEndToEnd.java > - > > Key: SENTRY-845 > URL: https://issues.apache.org/jira/browse/SENTRY-845 > Project: Sentry > Issue Type: Improvement >Affects Versions: 1.5.1 >Reporter: Anne Yu > Attachments: SENTRY-845.001.patch > > > TestColumnEndToEnd.java locates in the org.apache.sentry.tests.e2e.dbprovider > test package, seems it is meant to just run with sentry service, may need to > rename to stick to current naming conventions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SENTRY-1117) solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
[
https://issues.apache.org/jira/browse/SENTRY-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1117:
--
Attachment: SENTRY-1117.001-sentry-ha-redesign.patch
Added a patch targeting the sentry-ha-redesign branch.
> solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
> --
>
> Key: SENTRY-1117
> URL: https://issues.apache.org/jira/browse/SENTRY-1117
> Project: Sentry
> Issue Type: Task
> Components: Solr Plugin
>Reporter: Gregory Chanan
>Priority: Minor
> Attachments: SENTRY-1117.001-sentry-ha-redesign.patch,
> SENTRY-1117.001.patch
>
>
> This specification is inconsistent with the sentry-hdfs plugin:
> {code}
> ~/workspace/incubator-sentry8/sentry-hdfs$ ls
> pom.xml sentry-hdfs-dist sentry-hdfs-service
> sentry-hdfs-common sentry-hdfs-namenode-plugin target
> {code}
> {code}
> :~/workspace/incubator-sentry8/sentry-solr$ ls
> pom.xml solr-sentry-core solr-sentry-handlers target
> {code}
> i.e. solr-sentry-core and solr-sentry-handlers should be sentry-solr-core and
> sentry-solr-handlers, respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SENTRY-1527) Adjusting package name in solr-sentry-handlers and solr-sentry-core
Jan Hentschel created SENTRY-1527: - Summary: Adjusting package name in solr-sentry-handlers and solr-sentry-core Key: SENTRY-1527 URL: https://issues.apache.org/jira/browse/SENTRY-1527 Project: Sentry Issue Type: Task Components: Solr Plugin Reporter: Jan Hentschel Priority: Minor Currently the main package name of the solr-sentry-handlers and solr-sentry-core modules are org.apache.solr. I think that this should be changed to org.apache.sentry.solr to be consistent with the other plugins. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SENTRY-1117) solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
[
https://issues.apache.org/jira/browse/SENTRY-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666541#comment-15666541
]
Jan Hentschel commented on SENTRY-1117:
---
[~akolb] I will give it a try and if it works attach a patch targeting the
sentry-ha-redesign branch.
> solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
> --
>
> Key: SENTRY-1117
> URL: https://issues.apache.org/jira/browse/SENTRY-1117
> Project: Sentry
> Issue Type: Task
> Components: Solr Plugin
>Reporter: Gregory Chanan
>Priority: Minor
> Attachments: SENTRY-1117.001.patch
>
>
> This specification is inconsistent with the sentry-hdfs plugin:
> {code}
> ~/workspace/incubator-sentry8/sentry-hdfs$ ls
> pom.xml sentry-hdfs-dist sentry-hdfs-service
> sentry-hdfs-common sentry-hdfs-namenode-plugin target
> {code}
> {code}
> :~/workspace/incubator-sentry8/sentry-solr$ ls
> pom.xml solr-sentry-core solr-sentry-handlers target
> {code}
> i.e. solr-sentry-core and solr-sentry-handlers should be sentry-solr-core and
> sentry-solr-handlers, respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SENTRY-1305) Remove API PrivilegeCache.listPrivileges(Set groups, Set users, ActiveRoleSet roleSet) in Sentry 2.0 release
[ https://issues.apache.org/jira/browse/SENTRY-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15666515#comment-15666515 ] Jan Hentschel commented on SENTRY-1305: --- Only the method implementations of the interface in SimplePrivilegeCache and PrivilegeCacheTestImpl, which I also removed in the patch. There were no consumers of these implementations in the code base. > Remove API PrivilegeCache.listPrivileges(Set groups, Set > users, ActiveRoleSet roleSet) in Sentry 2.0 release > > > Key: SENTRY-1305 > URL: https://issues.apache.org/jira/browse/SENTRY-1305 > Project: Sentry > Issue Type: Improvement > Components: Sentry >Reporter: Hao Hao > Attachments: SENTRY-1305.001.patch > > > Sentry-1291 has deprecated API PrivilegeCache.listPrivileges(Set > groups, Set users, ActiveRoleSet roleSet). We may want to remove it > in Sentry 2.0 release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SENTRY-1305) Remove API PrivilegeCache.listPrivileges(Set groups, Set users, ActiveRoleSet roleSet) in Sentry 2.0 release
[ https://issues.apache.org/jira/browse/SENTRY-1305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated SENTRY-1305: -- Attachment: SENTRY-1305.001.patch Added patch which removes the appropriate method. > Remove API PrivilegeCache.listPrivileges(Set groups, Set > users, ActiveRoleSet roleSet) in Sentry 2.0 release > > > Key: SENTRY-1305 > URL: https://issues.apache.org/jira/browse/SENTRY-1305 > Project: Sentry > Issue Type: Improvement > Components: Sentry >Reporter: Hao Hao > Attachments: SENTRY-1305.001.patch > > > Sentry-1291 has deprecated API PrivilegeCache.listPrivileges(Set > groups, Set users, ActiveRoleSet roleSet). We may want to remove it > in Sentry 2.0 release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SENTRY-1501) SentryStore shouldn't synchronize openTransaction() and commitUpdateTransaction()
[
https://issues.apache.org/jira/browse/SENTRY-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15661315#comment-15661315
]
Jan Hentschel commented on SENTRY-1501:
---
Is this still an issues? As far as I see, the mentioned code was removed as
part of SENTRY-1205 and SENTRY-1512.
> SentryStore shouldn't synchronize openTransaction() and
> commitUpdateTransaction()
> -
>
> Key: SENTRY-1501
> URL: https://issues.apache.org/jira/browse/SENTRY-1501
> Project: Sentry
> Issue Type: Improvement
> Components: Sentry
>Affects Versions: 1.7.0, sentry-ha-redesign
>Reporter: Alexander Kolbasov
>
> SentryStore.openTransaction() is synchronized for no reason - the peristence
> manager factory is thread-safe.
> The synchronization here doesn't make any sense at all:
> {code}
> /**
>* Synchronized due to sequence id generation
>*/
> public synchronized CommitContext
> commitUpdateTransaction(PersistenceManager pm) {
> commitTransaction(pm);
> return new CommitContext(SERVER_UUID, incrementGetSequenceId());
> }
> /**
>* Increments commitSequenceId which should not be modified outside
>* this method.
>*
>* @return sequence id
>*/
> private synchronized long incrementGetSequenceId() {
> return ++commitSequenceId;
> }
> {code}
> Note that incrementGetSequenceId() is synchronized so there is no need to
> synchronize commitUpdateTransaction(). More over, there is no need to
> synchronize incrementGetSequenceId(), it can just use atomic for the index.
> And I think that handling of this atomic should be moved to the CommitContext
> instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (SENTRY-1117) solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
[
https://issues.apache.org/jira/browse/SENTRY-1117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated SENTRY-1117:
--
Attachment: SENTRY-1117.001.patch
Added patch which renames solr-sentry-handlers and solr-sentry-core.
> solr-sentry-handlers and solr-sentry-core should be renamed to sentry-solr
> --
>
> Key: SENTRY-1117
> URL: https://issues.apache.org/jira/browse/SENTRY-1117
> Project: Sentry
> Issue Type: Task
> Components: Solr Plugin
>Reporter: Gregory Chanan
>Priority: Minor
> Attachments: SENTRY-1117.001.patch
>
>
> This specification is inconsistent with the sentry-hdfs plugin:
> {code}
> ~/workspace/incubator-sentry8/sentry-hdfs$ ls
> pom.xml sentry-hdfs-dist sentry-hdfs-service
> sentry-hdfs-common sentry-hdfs-namenode-plugin target
> {code}
> {code}
> :~/workspace/incubator-sentry8/sentry-solr$ ls
> pom.xml solr-sentry-core solr-sentry-handlers target
> {code}
> i.e. solr-sentry-core and solr-sentry-handlers should be sentry-solr-core and
> sentry-solr-handlers, respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
