[jira] [Comment Edited] (SENTRY-1547) It is possible to create a privilege with all empty fields
[ https://issues.apache.org/jira/browse/SENTRY-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749648#comment-15749648 ] kalyan kumar kalvagadda edited comment on SENTRY-1547 at 12/14/16 10:07 PM: SENTRY-1547.001.patch I had to take a different approach in solving the issue based on the review comments. I have added validation logic in SentryPolicyStoreProcessor enforcing the mandatory fields like server_name and action to be present in privilege/privileges added. was (Author: kkalyan): SENTRY-1547.001.patch > It is possible to create a privilege with all empty fields > -- > > Key: SENTRY-1547 > URL: https://issues.apache.org/jira/browse/SENTRY-1547 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 1.8.0, sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: kalyan kumar kalvagadda >Priority: Minor > Labels: bite-sized > Attachments: SENTRY-1547.001.patch, SENTRY-1547.002.patch > > > It is possible (at least by sending Thrift message) to create privilege with > everything set to __NULL__ which is a pretty useless privilege. We should > check that at least some fields are set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (SENTRY-1547) It is possible to create a privilege with all empty fields
[ https://issues.apache.org/jira/browse/SENTRY-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15726616#comment-15726616 ] kalyan kumar kalvagadda edited comment on SENTRY-1547 at 12/6/16 8:30 PM: -- SENTRY-1547.001.patch I have added code so that sentry server could validate the TSentryPrivilege object constructed from the Thrift message received client. If the validation is failed exception is raised and appropriate error is message is sent. was (Author: kkalyan): I have added code so that sentry server could validate the TSentryPrivilege object constructed from the Thrift message received client. If the validation is failed exception is raised and appropriate error is message is sent. > It is possible to create a privilege with all empty fields > -- > > Key: SENTRY-1547 > URL: https://issues.apache.org/jira/browse/SENTRY-1547 > Project: Sentry > Issue Type: Bug > Components: Sentry >Affects Versions: 1.8.0, sentry-ha-redesign >Reporter: Alexander Kolbasov >Assignee: kalyan kumar kalvagadda >Priority: Minor > Labels: bite-sized > > It is possible (at least by sending Thrift message) to create privilege with > everything set to __NULL__ which is a pretty useless privilege. We should > check that at least some fields are set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
