[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963266#comment-15963266
]
Mathew Crocker commented on SENTRY-1626:
+1 not really specific to sentry ha, we should move it out. still a valid
ticket to be addressed later.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Bug
> Components: Hdfs Plugin
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Attachments: SENTRY-1626.000-sentry-ha-redesign.patch
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963256#comment-15963256
]
Alexander Kolbasov commented on SENTRY-1626:
I suggest postponing this one and doing it consistently for all tables at some
later time.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1626.000-sentry-ha-redesign.patch
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951777#comment-15951777
]
Alexander Kolbasov commented on SENTRY-1626:
One thing to consider is whether it is worth changing the date handling for
*new* tables that are introduced with Sentry HA.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1626.000-sentry-ha-redesign.patch
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951368#comment-15951368
]
Lei (Eddy) Xu commented on SENTRY-1626:
---
[~akolb] yea, I agree that we should clean this when the things are settled.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1626.000-sentry-ha-redesign.patch
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951265#comment-15951265
]
Alexander Kolbasov commented on SENTRY-1626:
I think that the whole date thing is a bit of a mess but it doesn't look like
we *have* to do it now - this can be delayed for the future work.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1626.000-sentry-ha-redesign.patch
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951262#comment-15951262
]
Alexander Kolbasov commented on SENTRY-1626:
How would this work for upgrades? Are we going to change the schema for
existing columns? This will make things backwards incompatible - for example we
wouldn't be able to downgrade the version.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1626.000-sentry-ha-redesign.patch
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946263#comment-15946263
]
kalyan kumar kalvagadda commented on SENTRY-1626:
-
I will review the patch.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1626.000-sentry-ha-redesign.patch
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15946062#comment-15946062
]
Hadoop QA commented on SENTRY-1626:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12860944/SENTRY-1626.000-sentry-ha-redesign.patch
against sentry-ha-redesign.
{color:red}Overall:{color} -1 due to 3 errors
{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.persistent.TestSentryStore
{color:red}ERROR:{color} Failed:
org.apache.sentry.provider.db.service.persistent.TestSentryStore
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2457/console
This message is automatically generated.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
> Attachments: SENTRY-1626.000-sentry-ha-redesign.patch
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928608#comment-15928608
]
kalyan kumar kalvagadda commented on SENTRY-1626:
-
Yes, if we need to use timestamp of database server, we need to update the sql
scripts and JDO definition.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925249#comment-15925249
]
Alexander Kolbasov commented on SENTRY-1626:
I don't think that we actually use these time for anything, so they are
probably most useful for debugging.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SENTRY-1626) Tables contain createTime should either remove it or update the time using SQL
[
https://issues.apache.org/jira/browse/SENTRY-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883669#comment-15883669
]
Alexander Kolbasov commented on SENTRY-1626:
It is interesting to know how is this used - may be for ayditing? I agree that
using DB for creation times is cleaner.
> Tables contain createTime should either remove it or update the time using SQL
> --
>
> Key: SENTRY-1626
> URL: https://issues.apache.org/jira/browse/SENTRY-1626
> Project: Sentry
> Issue Type: Sub-task
> Components: Hdfs Plugin
>Affects Versions: sentry-ha-redesign
>Reporter: Lei (Eddy) Xu
>Assignee: Lei (Eddy) Xu
>Priority: Minor
> Fix For: sentry-ha-redesign
>
>
> Most of the table in Sentry contains createTime, e.g {{MSentryRole}},
> {{MSentryGroup}}, {{MSentryPermChange}}, {{MSentryPrivilege}},
> {{MAuthzPathsMapping}} and {{MSentryPathChange}}. Even though it is not used,
> it may be error-prone for future.
> The time between leader and standby servers might be different, so that after
> a failover, the newly elected leader might write changes with older
> {{createdTime}}.
> We can either remove this field, or update the time based in the database.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
