[jira] [Commented] (SENTRY-1693) HMSFollower should handle adding a view with empty path.
[
https://issues.apache.org/jira/browse/SENTRY-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063596#comment-16063596
]
Na Li commented on SENTRY-1693:
---
the current behavior of HMSFollower is that when the location is null, the
event is skipped and error message is logged. It does not throw exception any
more.
if ((oldDbName == null) ||
(oldTableName == null) ||
(newDbName == null) ||
(newTableName == null) ||
(oldLocation == null) ||
(newLocation == null)) {
isNotificationProcessingSkipped = true;
LOGGER.error(String.format("Alter table event " +
"has incomplete information. oldDbName = %s, oldTableName =
%s, oldLocation = %s, " +
"newDbName = %s, newTableName = %s, newLocation = %s",
StringUtils.defaultIfBlank(oldDbName, "null"),
StringUtils.defaultIfBlank(oldTableName, "null"),
StringUtils.defaultIfBlank(oldLocation, "null"),
StringUtils.defaultIfBlank(newDbName, "null"),
StringUtils.defaultIfBlank(newTableName, "null"),
StringUtils.defaultIfBlank(newLocation, "null")));
break;
> HMSFollower should handle adding a view with empty path.
> -
>
> Key: SENTRY-1693
> URL: https://issues.apache.org/jira/browse/SENTRY-1693
> Project: Sentry
> Issue Type: Sub-task
>Affects Versions: sentry-ha-redesign
>Reporter: kalyan kumar kalvagadda
>Assignee: Na Li
>Priority: Critical
> Fix For: sentry-ha-redesign
>
>
> When a view is created in Hive, notification log generated would have empty
> path. HMS Follower throws an exception on such notifications. HMS Follower
> doesn't update the notification-id and will continue getting same
> notification again and again. As a result HMS will not be able to process
> subsequent notifications.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (SENTRY-1693) HMSFollower should handle adding a view with empty path.
[ https://issues.apache.org/jira/browse/SENTRY-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063396#comment-16063396 ] Alexander Kolbasov commented on SENTRY-1693: [~lina.li] Thank you for the clarification. What is the current behavior when HMSFollower encounters a view with an empty path? > HMSFollower should handle adding a view with empty path. > - > > Key: SENTRY-1693 > URL: https://issues.apache.org/jira/browse/SENTRY-1693 > Project: Sentry > Issue Type: Sub-task >Affects Versions: sentry-ha-redesign >Reporter: kalyan kumar kalvagadda >Assignee: Na Li >Priority: Critical > Fix For: sentry-ha-redesign > > > When a view is created in Hive, notification log generated would have empty > path. HMS Follower throws an exception on such notifications. HMS Follower > doesn't update the notification-id and will continue getting same > notification again and again. As a result HMS will not be able to process > subsequent notifications. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-1693) HMSFollower should handle adding a view with empty path.
[ https://issues.apache.org/jira/browse/SENTRY-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063390#comment-16063390 ] Na Li commented on SENTRY-1693: --- The problem of this issue is "HMSFollower gets stuck once it fails to process a notification event". The view event has empty path, and there is nothing HMSFollower should do for this event. Since Sentry cannot tell if the event is for view or table, it considers empty path a failure. The initial behavior is that "HMS Follower throws an exception on such notifications. HMS Follower doesn't update the notification-id and will continue getting same notification again and again. As a result HMS will not be able to process subsequent notifications.", in other words, "HMSFollower gets stuck once it fails to process a notification event". So this issue is a specific scenario where "HMSFollower gets stuck once it fails to process a notification event". Fixing Sentry-1752 fixes the problem of this issue. > HMSFollower should handle adding a view with empty path. > - > > Key: SENTRY-1693 > URL: https://issues.apache.org/jira/browse/SENTRY-1693 > Project: Sentry > Issue Type: Sub-task >Affects Versions: sentry-ha-redesign >Reporter: kalyan kumar kalvagadda >Assignee: Na Li >Priority: Critical > Fix For: sentry-ha-redesign > > > When a view is created in Hive, notification log generated would have empty > path. HMS Follower throws an exception on such notifications. HMS Follower > doesn't update the notification-id and will continue getting same > notification again and again. As a result HMS will not be able to process > subsequent notifications. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SENTRY-1693) HMSFollower should handle adding a view with empty path.
[ https://issues.apache.org/jira/browse/SENTRY-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063363#comment-16063363 ] Alexander Kolbasov commented on SENTRY-1693: I don't see how this is a duplicate of SENTRY-1752. [~lina.li] can you clarify? > HMSFollower should handle adding a view with empty path. > - > > Key: SENTRY-1693 > URL: https://issues.apache.org/jira/browse/SENTRY-1693 > Project: Sentry > Issue Type: Sub-task >Affects Versions: sentry-ha-redesign >Reporter: kalyan kumar kalvagadda >Assignee: Na Li >Priority: Critical > Fix For: sentry-ha-redesign > > > When a view is created in Hive, notification log generated would have empty > path. HMS Follower throws an exception on such notifications. HMS Follower > doesn't update the notification-id and will continue getting same > notification again and again. As a result HMS will not be able to process > subsequent notifications. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
