[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420523#comment-16420523
]
kalyan kumar kalvagadda commented on SENTRY-2144:
-
[~LinaAtAustin] Please consider renaming the jira as it is confusing.
A table can be moved from one database to another using "alter table" command.
Idea of this jira is make sure that sentry handles it properly.
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch, SENTRY-2144.002.patch,
> SENTRY-2144.003.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390603#comment-16390603
]
Hadoop QA commented on SENTRY-2144:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12913464/SENTRY-2144.003.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3688/console
This message is automatically generated.
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch, SENTRY-2144.002.patch,
> SENTRY-2144.003.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390357#comment-16390357
]
Na Li commented on SENTRY-2144:
---
[~akolb] based on HIVE-4847, the command to change database name is "ALTER
DATABASE dbname RENAME TO newdbname;"
so alter table should not be used for changing database name. Should I remove
the "rename database" section in FullUpdateModifier.alterTable?
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch, SENTRY-2144.002.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390323#comment-16390323
]
Hadoop QA commented on SENTRY-2144:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12913425/SENTRY-2144.002.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3687/console
This message is automatically generated.
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch, SENTRY-2144.002.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374949#comment-16374949
]
Na Li commented on SENTRY-2144:
---
[~akolb] I will write test case to check table rename across database on full
update.
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374860#comment-16374860
]
Alexander Kolbasov commented on SENTRY-2144:
You also need to check the code in {{FullUpdateModifier}}.
There is a unit test for it - {{TestFullUpdateModifier}} - it should be easy to
add a test and see whether it works correctly or not.
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374622#comment-16374622
]
Na Li commented on SENTRY-2144:
---
[~akolb] the example command to alter table name across database is "*ALTER
TABLE DB2.table1 RENAME TO DB1.table1_new*. just put database name in front of
the table name.
changing table name across database is in the added test case
testRenameTablesCrossDB. It means hive command supports that.
in
[https://www.cloudera.com/documentation/cdh/5-0-x/Impala/Installing-and-Using-Impala/ciiu_alter_table.html,]
impala supports that
{code:java}
use d2;
-- Move table from another database to the current one.
alter table d1.mobile rename to mobile;{code}
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374176#comment-16374176
]
Hadoop QA commented on SENTRY-2144:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12911679/SENTRY-2144.001.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3674/console
This message is automatically generated.
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374030#comment-16374030
]
Alexander Kolbasov commented on SENTRY-2144:
Note that if this is, indeed, an issue you also need to verify that it is
handled during taking full snapshot from HMS when there is reconciliation code
for new events that appeared during snapshot creation.
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SENTRY-2144) Table Rename should allow database name change
[
https://issues.apache.org/jira/browse/SENTRY-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374027#comment-16374027
]
Alexander Kolbasov commented on SENTRY-2144:
* How would it be possible to have ALTER TABLE event that changes both database
name and table name?
* Can you show some example?
* Did you see this actually happening?
* Do you have a test case that demonstrates the problem?
> Table Rename should allow database name change
> --
>
> Key: SENTRY-2144
> URL: https://issues.apache.org/jira/browse/SENTRY-2144
> Project: Sentry
> Issue Type: Bug
>Reporter: Na Li
>Assignee: Na Li
>Priority: Major
> Attachments: SENTRY-2144.001.patch
>
>
> Right now, when renaming a table, if the database changes, the privileges
> will be moved to the wrong table.
> For example, original table is db1.tbl1, and user changes to db2.tbl2.
> *Expected behavior*:
> The privileges associated with db1.tbl1 should be removed from db1.tbl1, and
> added to *{color:#205081}db2{color}*.tbl2.
> *Actual behavior*:
> The privileges associated with db1.tbl1 is removed from db1.tbl1, and added
> to {color:red}*db1*{color}.tbl2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
