[
https://issues.apache.org/jira/browse/SENTRY-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006963#comment-17006963
]
Hadoop QA commented on SENTRY-2462:
---
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12948875/SENTRY-2462.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} failed to apply patch (exit code 1):
error: git apply: bad git-diff - inconsistent old filename on line 891
error: patch failed: sentry-dist/src/license/THIRD-PARTY.properties:8
Falling back to three-way merge...
Applied patch to 'sentry-dist/src/license/THIRD-PARTY.properties' with
conflicts.
error: patch failed: sentry-dist/src/main/assembly/bin.xml:49
error: repository lacks the necessary blob to fall back on 3-way merge.
error: sentry-dist/src/main/assembly/bin.xml: patch does not apply
error: patch failed:
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java:35
Falling back to three-way merge...
Applied patch to
'sentry-service/sentry-service-metrics/src/main/java/org/apache/sentry/service/metrics/SentryMetrics.java'
with conflicts.
error: patch failed:
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java:31
Falling back to three-way merge...
Applied patch to
'sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java'
with conflicts.
error: patch failed:
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java:19
error: repository lacks the necessary blob to fall back on 3-way merge.
error:
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java:
patch does not apply
error: patch failed:
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java:17
Falling back to three-way merge...
Applied patch to
'sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/FullUpdateInitializer.java'
with conflicts.
error: patch failed:
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java:18
Falling back to three-way merge...
Applied patch to
'sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java'
with conflicts.
error: patch failed:
sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java:23
Falling back to three-way merge...
Applied patch to
'sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java'
cleanly.
error: patch failed: sentry-thirdparty/pom.xml:1
error: sentry-thirdparty/pom.xml: patch does not apply
error: patch failed: sentry-thirdparty/sentry-shaded/pom.xml:1
error: sentry-thirdparty/sentry-shaded/pom.xml: patch does not apply
error: git diff header lacks filename information when removing 2 leading
pathname components (line 5)
The patch does not appear to apply with p0, p1, or p2
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/4472/console
This message is automatically generated.
> Seperate Metrics into sub module in order to remove circular dependencies
> -
>
> Key: SENTRY-2462
> URL: https://issues.apache.org/jira/browse/SENTRY-2462
> Project: Sentry
> Issue Type: Improvement
> Components: Service
>Affects Versions: 2.0.1
>Reporter: Brian Towles
>Assignee: Brian Towles
>Priority: Major
> Fix For: 2.3.0
>
> Attachments: SENTRY-2462.001.patch
>
>
> The metrics subsystem currently resides in the sentry-service-server. So any
> other module that needs to use it has to depend on sentry-service-server
> which is causing circular dependencies when trying to add modules used by
> sentry-service-server.
>
> This will create a sentry-service-metrics that will house and wrap all the
> metrics needs for the server. It will need to use SENTRY-2458 as a base to
> segment out the web presentation components of the metrics. It will also
> allow for the centralization of the roll up and shading of the codehale
> metrics package to happen in one sub module rather then split over two.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
