[jira] [Commented] (SCB-607) Support printing invocation context in access log
[
https://issues.apache.org/jira/browse/SCB-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490318#comment-16490318
]
ASF GitHub Bot commented on SCB-607:
liubao68 commented on a change in pull request #727: [SCB-607] Accesslog
support invocation context item
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/727#discussion_r190804024
##
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
##
@@ -249,4 +265,21 @@ protected void onExecuteHttpServerFiltersFinish(Response
response, Throwable e)
invocation.onFinish(response);
}
}
+
+ public void setAfterCreateInvocationHandler(
+ AfterCreateInvocationHandler afterCreateInvocationHandler) {
+this.afterCreateInvocationHandler = afterCreateInvocationHandler;
+ }
+
+ /**
+ * After the {@link AbstractRestInvocation#invocation} is instantiated, the
{@link AbstractRestInvocation#invocation}
+ * will be passed into {@link
AfterCreateInvocationHandler#handle(Invocation)} so that users can do something
with it.
+ */
+ public static interface AfterCreateInvocationHandler {
+/**
+ * @see AfterCreateInvocationHandler
+ * @param invocation {@link AbstractRestInvocation#invocation}
Review comment:
This document refers itself, and can be deleted
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support printing invocation context in access log
> -
>
> Key: SCB-607
> URL: https://issues.apache.org/jira/browse/SCB-607
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Java-Chassis
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> Add a new access log item to print specific invocation context content.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-615) fix typos in EventScanner
[ https://issues.apache.org/jira/browse/SCB-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490315#comment-16490315 ] ASF GitHub Bot commented on SCB-615: eric-lee-ltk opened a new pull request #193: SCB-615 fix typos in EventScanner URL: https://github.com/apache/incubator-servicecomb-saga/pull/193 Signed-off-by: Eric Lee Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > fix typos in EventScanner > - > > Key: SCB-615 > URL: https://issues.apache.org/jira/browse/SCB-615 > Project: Apache ServiceComb > Issue Type: Bug > Components: Saga >Affects Versions: saga-0.2.0 >Reporter: Eric Lee >Assignee: Eric Lee >Priority: Major > Fix For: saga-0.2.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-615) fix typos in EventScanner
Eric Lee created SCB-615: Summary: fix typos in EventScanner Key: SCB-615 URL: https://issues.apache.org/jira/browse/SCB-615 Project: Apache ServiceComb Issue Type: Bug Components: Saga Affects Versions: saga-0.2.0 Reporter: Eric Lee Assignee: Eric Lee Fix For: saga-0.2.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-585) Add ServiceComb-java-chassis reference guide to project
[ https://issues.apache.org/jira/browse/SCB-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490179#comment-16490179 ] ASF GitHub Bot commented on SCB-585: liubao68 closed pull request #1: [SCB-585]add README.md for this project URL: https://github.com/apache/incubator-servicecomb-docs/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md new file mode 100644 index 000..06095de --- /dev/null +++ b/README.md @@ -0,0 +1,5 @@ +# ServiceComb Documents +This project hosts ServiceComb documents, please check individual sub folders for details. + +# ServiceComb资料开发项目 +本项目是ServiceComb各个组件的开发文档源码，请查看各个子目录获取详细的说明。 diff --git a/java-chassis-reference/README.md b/java-chassis-reference/README.md new file mode 100644 index 000..98ba558 --- /dev/null +++ b/java-chassis-reference/README.md @@ -0,0 +1,33 @@ + +## 本项目是servicecomb-java-chassis开发指南。 + +* [访问地址](https://huaweicse.github.io/servicecomb-java-chassis-doc)（临时） + +* 编辑 + 1. Fork本项目代码 + 2. 方式一：直接编辑md源码 + 3. 方式二：下载[GitBook Editor](https://legacy.gitbook.com/editor)编辑 + 4. 提交PR + +* 发布/查看 + 1. 参考[GitBook安装指南](https://github.com/GitbookIO/gitbook/blob/master/docs/setup.md),安装gitbook + 2. 发布：gitbook build . ../docs + 3. 本地查看：gitbook serve . ../docs + +## This project is the servicecomb-java-chassis developers guide + +* [Web address](https://huaweicse.github.io/servicecomb-java-chassis-doc)(temporary) + +* Submit PR + 1. Fork this project + 2. Edit md source file, or + 3. Edit using [GitBook Editor](https://legacy.gitbook.com/editor) + 4. Submit PR + +* Publish + 1. see [GitBook installation guide](https://github.com/GitbookIO/gitbook/blob/master/docs/setup.md) + 2. publish using command：gitbook build . ../docs + 3. for local reading：gitbook serve . ../docs + + + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add ServiceComb-java-chassis reference guide to project > --- > > Key: SCB-585 > URL: https://issues.apache.org/jira/browse/SCB-585 > Project: Apache ServiceComb > Issue Type: Improvement >Reporter: liubao >Assignee: liubao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-589) allow consumer upgrade before producer
[ https://issues.apache.org/jira/browse/SCB-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490144#comment-16490144 ] ASF GitHub Bot commented on SCB-589: wujimin opened a new pull request #728: [SCB-589] Consumer producer upgrade unordered URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/728 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge 2.consumer microserviceMeta will not save in microserviceMetaManager any more, just like edge, use appManager; and change consumer default versionRule from latest to all 3.allow consumer schema set or method set bigger than contract 4.protobuf dynamic class created in microservice classloader integration test case: 1.start old producer 2.start new consumer, which have new schems or new method belongs to old schema features about old producer no problem 3.start new producer not restart consumer, features about new producer become no problem All commits are logically related, difficult to split to subtasks please review commits one by one. there is no automatic integration test case, because need a controller to do this, our integration test not support this now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > allow consumer upgrade before producer > -- > > Key: SCB-589 > URL: https://issues.apache.org/jira/browse/SCB-589 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > > 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge > 2.consumer microserviceMeta will not save in microserviceMetaManager any > more, just like edge, use appManager; and change consumer default versionRule > from latest to all > 3.allow consumer schema set or method set bigger than contract > 4.protobuf dynamic class created in microservice classloader > 5.seems that can delete MicroserviceMetaManager > 6.edge remains task should be finished: > https://issues.apache.org/jira/browse/SCB-279 > > jackson hold classes by a LRU map, will not always hold class, so there is no > big problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-74) POJO static method is export as an operation
[
https://issues.apache.org/jira/browse/SCB-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490091#comment-16490091
]
Zheng Feng commented on SCB-74:
---
It looks like out of date. Can you provide the test of the singleton POJO ?
> POJO static method is export as an operation
>
>
> Key: SCB-74
> URL: https://issues.apache.org/jira/browse/SCB-74
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: Bo Li
>Priority: Major
> Labels: newbie
>
> When using @rpcschema to expose a singleton POJO as schema interface, then
> call the public method of the class which the method belong to, exception
> occurs as follow:
> {code}
> Exception in thread "main" java.lang.NullPointerException
> at
> io.servicecomb.swagger.generator.core.utils.ClassUtils.getOrCreateClass(ClassUtils.java:135)
> at
> io.servicecomb.swagger.converter.model.ModelImplConverter.doConvert(ModelImplConverter.java:55)
> at
> io.servicecomb.swagger.converter.AbstractConverter.convert(AbstractConverter.java:42)
> at
> io.servicecomb.swagger.converter.ConverterMgr.findJavaType(ConverterMgr.java:188)
> at
> io.servicecomb.swagger.converter.ConverterMgr.findByRef(ConverterMgr.java:196)
> at
> io.servicecomb.swagger.converter.property.RefPropertyConverter.doConvert(RefPropertyConverter.java:30)
> at
> io.servicecomb.swagger.converter.AbstractConverter.convert(AbstractConverter.java:42)
> at
> io.servicecomb.swagger.converter.ConverterMgr.findJavaType(ConverterMgr.java:188)
> at
> io.servicecomb.swagger.generator.core.utils.ClassUtils.createInterface(ClassUtils.java:252)
> at
> io.servicecomb.swagger.generator.core.utils.ClassUtils.getOrCreateInterface(ClassUtils.java:237)
> at io.servicecomb.core.definition.SchemaMeta.(SchemaMeta.java:65)
> at
> io.servicecomb.core.definition.loader.SchemaLoader.registerSchema(SchemaLoader.java:92)
> at
> io.servicecomb.core.definition.schema.ConsumerSchemaFactory.createSchema(ConsumerSchemaFactory.java:132)
> at
> io.servicecomb.core.definition.schema.ConsumerSchemaFactory.createSchema(ConsumerSchemaFactory.java:33)
> at
> io.servicecomb.core.definition.schema.AbstractSchemaFactory.getOrCreateSchema(AbstractSchemaFactory.java:59)
> at
> io.servicecomb.core.definition.schema.ConsumerSchemaFactory.getOrCreateConsumerSchema(ConsumerSchemaFactory.java:122)
> at
> io.servicecomb.core.definition.schema.ConsumerSchemaFactory.getOrCreateMicroserviceMeta(ConsumerSchemaFactory.java:78)
> at
> io.servicecomb.core.provider.consumer.ReferenceConfig.(ReferenceConfig.java:35)
> at
> io.servicecomb.core.provider.consumer.ConsumerProviderManager.getReferenceConfig(ConsumerProviderManager.java:82)
> at
> io.servicecomb.core.provider.consumer.ReferenceConfigUtils.getForInvoke(ReferenceConfigUtils.java:42)
> at io.servicecomb.provider.pojo.Invoker.prepare(Invoker.java:59)
> at io.servicecomb.provider.pojo.Invoker.invoke(Invoker.java:81)
> at com.sun.proxy.$Proxy17.selectByPrimaryKey(Unknown Source)
> at com.ceewa.cloud.consumer.DubboxConsumer.testMycat(DubboxConsumer.java:49)
> at com.ceewa.cloud.consumer.DubboxConsumer.main(DubboxConsumer.java:38)
> {code}
> Problem is fixed after adding {code}@apioperation(value = "getInstance is not
> an endpoint", hidden = true){code} tag for method getInstance, is there any
> good suggestions for that question?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SCB-614) enhance SCBEngine
[ https://issues.apache.org/jira/browse/SCB-614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin updated SCB-614: Description: change related instances from bean to normal pojo only compatible related beans will be retained SCBEngine need not depend on spring context, it's better to not depeond on spring jar > enhance SCBEngine > - > > Key: SCB-614 > URL: https://issues.apache.org/jira/browse/SCB-614 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Priority: Major > > change related instances from bean to normal pojo > only compatible related beans will be retained > SCBEngine need not depend on spring context, it's better to not depeond on > spring jar -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-613) delete useless EndpointsCache related classs
wujimin created SCB-613: --- Summary: delete useless EndpointsCache related classs Key: SCB-613 URL: https://issues.apache.org/jira/browse/SCB-613 Project: Apache ServiceComb Issue Type: Task Components: Java-Chassis Reporter: wujimin org.apache.servicecomb.core.endpoint.EndpointsCache org.apache.servicecomb.core.endpoint.AbstractEndpointsCache org.apache.servicecomb.serviceregistry.cache.InstanceCacheManager#getOrCreate org.apache.servicecomb.serviceregistry.cache.InstanceCache -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-614) enhance SCBEngine
wujimin created SCB-614: --- Summary: enhance SCBEngine Key: SCB-614 URL: https://issues.apache.org/jira/browse/SCB-614 Project: Apache ServiceComb Issue Type: Task Components: Java-Chassis Reporter: wujimin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-612) delete useless MicroserviceMetaManager
wujimin created SCB-612: --- Summary: delete useless MicroserviceMetaManager Key: SCB-612 URL: https://issues.apache.org/jira/browse/SCB-612 Project: Apache ServiceComb Issue Type: Task Components: Java-Chassis Reporter: wujimin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-589) allow consumer upgrade before producer
[ https://issues.apache.org/jira/browse/SCB-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin updated SCB-589: Description: 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge 2.consumer microserviceMeta will not save in microserviceMetaManager any more, just like edge, use appManager; and change consumer default versionRule from latest to all 3.allow consumer schema set or method set bigger than contract 4.protobuf dynamic class created in microservice classloader 5.seems that can delete MicroserviceMetaManager 6.edge remains task should be finished: https://issues.apache.org/jira/browse/SCB-279 jackson hold classes by a LRU map, will not always hold class, so there is no big problems. was: 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge 2.consumer microserviceMeta will not save in microserviceMetaManager any more, just like edge, use appManager 3.allow consumer schema set or method set bigger than contract 4.protobuf dynamic class created in microservice classloader 5.seems that can delete MicroserviceMetaManager 6.change consumer default versionRule from latest to all 7.edge remains task should be finished: https://issues.apache.org/jira/browse/SCB-279 how jackson to process same name class but belongs to different classloader, if classloader unloaded, will jackson still hold the classes? > allow consumer upgrade before producer > -- > > Key: SCB-589 > URL: https://issues.apache.org/jira/browse/SCB-589 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > > 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge > 2.consumer microserviceMeta will not save in microserviceMetaManager any > more, just like edge, use appManager; and change consumer default versionRule > from latest to all > 3.allow consumer schema set or method set bigger than contract > 4.protobuf dynamic class created in microservice classloader > 5.seems that can delete MicroserviceMetaManager > 6.edge remains task should be finished: > https://issues.apache.org/jira/browse/SCB-279 > > jackson hold classes by a LRU map, will not always hold class, so there is no > big problems. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-611) Provide a default Edge service dispatcher to make developer edge easy
[ https://issues.apache.org/jira/browse/SCB-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-611: - Fix Version/s: java-chassis-1.0.0-m2 > Provide a default Edge service dispatcher to make developer edge easy > - > > Key: SCB-611 > URL: https://issues.apache.org/jira/browse/SCB-611 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > Currently, writing a edge service must implement an AbstractEdgeDispatcher, > this code is a bit complicated to beginners. We need to provide a default > implementation and to let users use it easily. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-609) News of the LC3 Co-Located Event Linked to The Wrong Page
[ https://issues.apache.org/jira/browse/SCB-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489015#comment-16489015 ] ASF GitHub Bot commented on SCB-609: WillemJiang closed pull request #94: [SCB-609] Fix bug of reference from chinese home page to blog of Apache Service… URL: https://github.com/apache/incubator-servicecomb-website/pull/94 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/_pages/cn/home.md b/_pages/cn/home.md index ae9830c..0cc7aed 100644 --- a/_pages/cn/home.md +++ b/_pages/cn/home.md @@ -22,7 +22,7 @@ intro: - 微服务 Meetup：Apache ServiceComb (incubating) Day + 微服务 Meetup：Apache ServiceComb (incubating) Day ServiceComb 第一个Apache孵化版本发布了！ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > News of the LC3 Co-Located Event Linked to The Wrong Page > - > > Key: SCB-609 > URL: https://issues.apache.org/jira/browse/SCB-609 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-607) Support printing invocation context in access log
[ https://issues.apache.org/jira/browse/SCB-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489001#comment-16489001 ] ASF GitHub Bot commented on SCB-607: coveralls commented on issue #727: [SCB-607] Accesslog support invocation context item URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/727#issuecomment-391718562 [](https://coveralls.io/builds/17147271) Coverage increased (+0.009%) to 87.5% when pulling **80f4e3362664f6598efcb30728cd16d56bb37a1e on yhs0092:accesslog_support_invocation_context_item** into **f1415fe328c321fcd82c81cacb11166571d8a172 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support printing invocation context in access log > - > > Key: SCB-607 > URL: https://issues.apache.org/jira/browse/SCB-607 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > Add a new access log item to print specific invocation context content. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-607) Support printing invocation context in access log
[ https://issues.apache.org/jira/browse/SCB-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488949#comment-16488949 ] ASF GitHub Bot commented on SCB-607: yhs0092 opened a new pull request #727: [SCB-607] Accesslog support invocation context item URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/727 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- See details in [SCB-607](https://issues.apache.org/jira/browse/SCB-607) - set Invocation into RoutingContext - add an AccessLogItem to get content from invocation context This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support printing invocation context in access log > - > > Key: SCB-607 > URL: https://issues.apache.org/jira/browse/SCB-607 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > Add a new access log item to print specific invocation context content. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-611) Provide a default Edge service dispatcher to make developer edge easy
[ https://issues.apache.org/jira/browse/SCB-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488938#comment-16488938 ] ASF GitHub Bot commented on SCB-611: liubao68 opened a new pull request #726: [SCB-611]Provide a default Dispatcher to make user using edge service easier URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/726 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Provide a default Edge service dispatcher to make developer edge easy > - > > Key: SCB-611 > URL: https://issues.apache.org/jira/browse/SCB-611 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > > Currently, writing a edge service must implement an AbstractEdgeDispatcher, > this code is a bit complicated to beginners. We need to provide a default > implementation and to let users use it easily. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-611) Provide a default Edge service dispatcher to make developer edge easy
liubao created SCB-611: -- Summary: Provide a default Edge service dispatcher to make developer edge easy Key: SCB-611 URL: https://issues.apache.org/jira/browse/SCB-611 Project: Apache ServiceComb Issue Type: New Feature Reporter: liubao Assignee: liubao Currently, writing a edge service must implement an AbstractEdgeDispatcher, this code is a bit complicated to beginners. We need to provide a default implementation and to let users use it easily. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-607) Support printing invocation context in access log
[ https://issues.apache.org/jira/browse/SCB-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488892#comment-16488892 ] YaoHaishi commented on SCB-607: --- To accomplish this issue, we need to achieve two subtask: # set Invocation into RoutingContext # add an AccessLogItem to get content from invocation context As when the RestProducerInvocation and EdgeInvocation is created, the Invocation is not instantiated yet. While when the Invocation is created, the code has run into AbstractRestInvocation and the RoutingContext cannot be touched directly. To achieve the subtask 1, I choose to define an AfterCreateInvocationHandler to set Invocation into RoutingContext, because I guess this may be the most flexible design. > Support printing invocation context in access log > - > > Key: SCB-607 > URL: https://issues.apache.org/jira/browse/SCB-607 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Java-Chassis >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > > Add a new access log item to print specific invocation context content. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-610) Improvement Blog of easy-build-microservice-system-part-II
[ https://issues.apache.org/jira/browse/SCB-610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhinan Lin updated SCB-610: --- Description: I have gone through the Blog of easy-build-microservice-system-part-II [1], in order to promote the community, create some improvement suggestion I wished here. # I find that there is no place to describe how easily can be by using scaffold. we can describe it by comparing to the old way. For example, if we using the old way, we should first write the POM.xml, and then , something like this, Or the readers will get no feeling about what we want to express. # How about changing title of the blog to “Easy Micro Service Series: 5 minutes to Implement customer relationship management”， in Chinese, 轻松微服务系列：5分钟实现客户关系管理, to make title more clear and less confuse. [1] [http://servicecomb.incubator.apache.org/cn/docs/easy-build-microservice-system-part-II/|http://example.com/] was: I have gone through the Blog of easy-build-microservice-system-part-II [1], in order to promote the community, create some improvement suggestion I wished here. # I find that there is no place to describe how easily can be by using scaffold. we can describe it by comparing to the old way. For example, if we using the old way, we should first write the POM.xml, and then , something like this, Or the readers will get no feeling about what we want to express. # How about to “Easy Micro Service Series: 5 minutes to Implement customer relationship management”， in Chinese, 轻松微服务系列：5分钟实现客户关系管理, to make title more clear and less confuse. [1] [http://servicecomb.incubator.apache.org/cn/docs/easy-build-microservice-system-part-II/|http://example.com] > Improvement Blog of easy-build-microservice-system-part-II > -- > > Key: SCB-610 > URL: https://issues.apache.org/jira/browse/SCB-610 > Project: Apache ServiceComb > Issue Type: Wish > Components: website >Reporter: Zhinan Lin >Priority: Major > Original Estimate: 0.5h > Remaining Estimate: 0.5h > > I have gone through the Blog of easy-build-microservice-system-part-II [1], > in order to promote the community, create some improvement suggestion I > wished here. > # I find that there is no place to describe how easily can be by using > scaffold. we can describe it by comparing to the old way. For example, if we > using the old way, we should first write the POM.xml, and then , > something like this, Or the readers will get no feeling about what we want to > express. > # How about changing title of the blog to “Easy Micro Service Series: 5 > minutes to Implement customer relationship management”， in Chinese, > 轻松微服务系列：5分钟实现客户关系管理, to make title more clear and less confuse. > > [1] > [http://servicecomb.incubator.apache.org/cn/docs/easy-build-microservice-system-part-II/|http://example.com/] > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-610) Improvement Blog of easy-build-microservice-system-part-II
Zhinan Lin created SCB-610: -- Summary: Improvement Blog of easy-build-microservice-system-part-II Key: SCB-610 URL: https://issues.apache.org/jira/browse/SCB-610 Project: Apache ServiceComb Issue Type: Wish Components: website Reporter: Zhinan Lin I have gone through the Blog of easy-build-microservice-system-part-II [1], in order to promote the community, create some improvement suggestion I wished here. # I find that there is no place to describe how easily can be by using scaffold. we can describe it by comparing to the old way. For example, if we using the old way, we should first write the POM.xml, and then , something like this, Or the readers will get no feeling about what we want to express. # How about to “Easy Micro Service Series: 5 minutes to Implement customer relationship management”， in Chinese, 轻松微服务系列：5分钟实现客户关系管理, to make title more clear and less confuse. [1] [http://servicecomb.incubator.apache.org/cn/docs/easy-build-microservice-system-part-II/|http://example.com] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-599) Service registry failed when service before Service Center start
[ https://issues.apache.org/jira/browse/SCB-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] laijianbin closed SCB-599. -- Resolution: Fixed > Service registry failed when service before Service Center start > > > Key: SCB-599 > URL: https://issues.apache.org/jira/browse/SCB-599 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: laijianbin >Assignee: laijianbin >Priority: Major > Fix For: java-chassis-1.0.0-m2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-609) News of the LC3 Co-Located Event Linked to The Wrong Page
[ https://issues.apache.org/jira/browse/SCB-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16488717#comment-16488717 ] ASF GitHub Bot commented on SCB-609: zenlinTechnofreak opened a new pull request #94: [SCB-609] Fix bug of reference from chinese home page to blog of Apache Service… URL: https://github.com/apache/incubator-servicecomb-website/pull/94 …Comb (incubating) Day Signed-off-by: linzhinan This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > News of the LC3 Co-Located Event Linked to The Wrong Page > - > > Key: SCB-609 > URL: https://issues.apache.org/jira/browse/SCB-609 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-609) News of the LC3 Co-Located Event Linked to The Wrong Page
Zhinan Lin created SCB-609: -- Summary: News of the LC3 Co-Located Event Linked to The Wrong Page Key: SCB-609 URL: https://issues.apache.org/jira/browse/SCB-609 Project: Apache ServiceComb Issue Type: Bug Components: website Reporter: Zhinan Lin Assignee: Zhinan Lin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-589) allow consumer upgrade before producer
[ https://issues.apache.org/jira/browse/SCB-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin updated SCB-589: Description: 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge 2.consumer microserviceMeta will not save in microserviceMetaManager any more, just like edge, use appManager 3.allow consumer schema set or method set bigger than contract 4.protobuf dynamic class created in microservice classloader 5.seems that can delete MicroserviceMetaManager 6.change consumer default versionRule from latest to all 7.edge remains task should be finished: https://issues.apache.org/jira/browse/SCB-279 how jackson to process same name class but belongs to different classloader, if classloader unloaded, will jackson still hold the classes? was: 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge 2.consumer microserviceMeta will not save in microserviceMetaManager any more, just like edge, use appManager 3.allow consumer schema set or method set bigger than contract 4.protobuf dynamic class created in microservice classloader 5.seems that can delete MicroserviceMetaManager 6.edge remains task should be finished: https://issues.apache.org/jira/browse/SCB-279 how jackson to process same name class but belongs to different classloader, if classloader unloaded, will jackson still hold the classes? > allow consumer upgrade before producer > -- > > Key: SCB-589 > URL: https://issues.apache.org/jira/browse/SCB-589 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > > 1.normal consumer use PrivateMicroserviceClassLoaderFactory, just like edge > 2.consumer microserviceMeta will not save in microserviceMetaManager any > more, just like edge, use appManager > 3.allow consumer schema set or method set bigger than contract > 4.protobuf dynamic class created in microservice classloader > 5.seems that can delete MicroserviceMetaManager > 6.change consumer default versionRule from latest to all > 7.edge remains task should be finished: > https://issues.apache.org/jira/browse/SCB-279 > > how jackson to process same name class but belongs to different classloader, > if classloader unloaded, will jackson still hold the classes? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
