[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701598#comment-16701598 ] ASF GitHub Bot commented on SCB-1032: - coveralls edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440688511 [](https://coveralls.io/builds/20331757) Coverage decreased (-0.1%) to 61.513% when pulling **bd1dc98e9a26cd4400c0e3c26a845e13c5374653 on little-cui:gzip** into **6a7379a35f939a2af837878d3aa61a8856c04ac4 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[
https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701597#comment-16701597
]
ASF GitHub Bot commented on SCB-1032:
-
asifdxtreme closed pull request #496: SCB-1032 Support compress the response
URL: https://github.com/apache/servicecomb-service-center/pull/496
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/glide.yaml b/glide.yaml
index 16133dc5..21b66d67 100644
--- a/glide.yaml
+++ b/glide.yaml
@@ -289,6 +289,9 @@ import:
- package: github.com/natefinch/lumberjack
version: a96e63847dc3c67d17befa69c303767e2f84e54f
repo: https://github.com/natefinch/lumberjack
+- package: github.com/NYTimes/gziphandler
+ version: 253f1acb9d9f896d86c313a3dc994c0b114f0e12
+ repo: https://github.com/NYTimes/gziphandler
# k8s 1.10.4 deps
- package: k8s.io/client-go
diff --git a/go.mod b/go.mod
index bf3d4b3f..238ba934 100644
--- a/go.mod
+++ b/go.mod
@@ -16,6 +16,7 @@ replace (
)
require (
+ github.com/NYTimes/gziphandler v1.0.2-0.20180820182813-253f1acb9d9f
github.com/Shopify/sarama v1.18.0 // indirect
github.com/apache/thrift v0.0.0-20180125231006-3d556248a8b9 // indirect
github.com/astaxie/beego v1.8.0
diff --git a/pkg/client/sc/config.go b/pkg/client/sc/config.go
index 128df5c9..1a8e4bb9 100644
--- a/pkg/client/sc/config.go
+++ b/pkg/client/sc/config.go
@@ -43,5 +43,6 @@ func (cfg *Config) Merge() rest.URLClientOption {
if cfg.RequestTimeout == 0 {
cfg.RequestTimeout = defaultRequestTimeout
}
+ cfg.Compressed = true
return cfg.URLClientOption
}
diff --git a/pkg/rest/client.go b/pkg/rest/client.go
index 4a2d2f61..82506378 100644
--- a/pkg/rest/client.go
+++ b/pkg/rest/client.go
@@ -17,12 +17,15 @@ package rest
import (
"bytes"
+ "compress/gzip"
"crypto/tls"
"errors"
"fmt"
"github.com/apache/servicecomb-service-center/pkg/tlsutil"
"github.com/apache/servicecomb-service-center/pkg/util"
"golang.org/x/net/context"
+ "io"
+ "io/ioutil"
"net/http"
"net/url"
"os"
@@ -57,6 +60,24 @@ type URLClientOption struct {
ConnsPerHost int
}
+type gzipBodyReader struct {
+ *gzip.Reader
+ Body io.ReadCloser
+}
+
+func (w *gzipBodyReader) Close() error {
+ w.Reader.Close()
+ return w.Body.Close()
+}
+
+func NewGZipBodyReader(body io.ReadCloser) (io.ReadCloser, error) {
+ reader, err := gzip.NewReader(body)
+ if err != nil {
+ return nil, err
+ }
+ return &gzipBodyReader{reader, body}, nil
+}
+
type URLClient struct {
*http.Client
@@ -76,18 +97,18 @@ func (client *URLClient) HttpDoWithContext(ctx
context.Context, method string, r
headers = make(http.Header)
}
- if _, ok := headers["Host"]; !ok {
+ if _, ok := headers[HEADER_HOST]; !ok {
parsedURL, err := url.Parse(rawURL)
if err != nil {
return nil, err
}
- headers.Set("Host", parsedURL.Host)
+ headers.Set(HEADER_HOST, parsedURL.Host)
}
- if _, ok := headers["Accept"]; !ok {
- headers.Set("Accept", "*/*")
+ if _, ok := headers[HEADER_ACCEPT]; !ok {
+ headers.Set(HEADER_ACCEPT, ACCEPT_ANY)
}
- if _, ok := headers["Accept-Encoding"]; !ok && client.Cfg.Compressed {
- headers.Set("Accept-Encoding", "deflate, gzip")
+ if _, ok := headers[HEADER_ACCEPT_ENCODING]; !ok &&
client.Cfg.Compressed {
+ headers.Set(HEADER_ACCEPT_ENCODING, "deflate, gzip")
}
req, err := http.NewRequest(method, rawURL, bytes.NewBuffer(body))
@@ -101,6 +122,16 @@ func (client *URLClient) HttpDoWithContext(ctx
context.Context, method string, r
if err != nil {
return nil, err
}
+ switch resp.Header.Get(HEADER_CONTENT_ENCODING) {
+ case "gzip":
+ reader, err := NewGZipBodyReader(resp.Body)
+ if err != nil {
+ io.Copy(ioutil.Discard, resp.Body)
+ resp.Body.Close()
+ return nil, err
+ }
+ resp.Body = reader
+ }
if os.Getenv("DEBUG_MODE") == "1" {
fmt.Println("--- BEGIN ---")
diff --git a/pkg/rest/common.go b/pkg/rest/common.go
index 71858388..1d99ffc7 100644
--- a/pkg/rest/common.go
+++ b/pkg/rest/common.go
@@ -36,12 +36,14 @@ const (
HEADER_RESPONSE_STATUS = "X-Response-Status"
HEADER_ALLOW= "Allow"
+
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701572#comment-16701572 ] ASF GitHub Bot commented on SCB-1032: - little-cui commented on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-442374745 @asifdxtreme DONE! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698428#comment-16698428 ] ASF GitHub Bot commented on SCB-1032: - coveralls edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440688511 [](https://coveralls.io/builds/20283016) Coverage decreased (-0.2%) to 61.616% when pulling **ab475ada118df92d28b6abb0ca6e9880a8de1886 on little-cui:gzip** into **7aceab7f2ccb804089627bfdb82e7d7a62ab259a on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698425#comment-16698425 ] ASF GitHub Bot commented on SCB-1032: - codecov-io edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440691271 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=h1) Report > Merging [#496](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/7aceab7f2ccb804089627bfdb82e7d7a62ab259a?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #496 +/- ## == + Coverage 59.25% 59.26% +0.01% == Files 166 166 Lines 1388013880 == + Hits 8224 8226 +2 + Misses 5074 5072 -2 Partials 582 582 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <0%> (ø)` | :arrow_up: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.6% <0%> (-0.34%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.95% <0%> (+0.55%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <0%> (+2.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=footer). Last update [7aceab7...ab475ad](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696672#comment-16696672 ] ASF GitHub Bot commented on SCB-1032: - codecov-io edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440691271 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=h1) Report > Merging [#496](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #496 +/- ## === Coverage 59.25% 59.25% === Files 166 166 Lines 1388013880 === Hits 8225 8225 Misses 5072 5072 Partials 583 583 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <0%> (ø)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.93% <0%> (+0.33%)` | :arrow_up: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=footer). Last update [4942829...32d0e20](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695615#comment-16695615 ] ASF GitHub Bot commented on SCB-1032: - codecov-io edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440691271 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=h1) Report > Merging [#496](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr&el=desc) will **increase** coverage by `0.02%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #496 +/- ## == + Coverage 59.23% 59.25% +0.02% == Files 166 166 Lines 1388013880 == + Hits 8222 8225 +3 Misses 5072 5072 + Partials 586 583 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...er/plugin/pkg/discovery/servicecenter/aggregate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L3NlcnZpY2VjZW50ZXIvYWdncmVnYXRlLmdv) | `8% <0%> (ø)` | :arrow_up: | | [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.93% <0%> (+0.33%)` | :arrow_up: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `34.28% <0%> (+0.57%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <0%> (+9.09%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=footer). Last update [4942829...32d0e20](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695616#comment-16695616 ] ASF GitHub Bot commented on SCB-1032: - coveralls edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440688511 [](https://coveralls.io/builds/20239127) Coverage increased (+0.03%) to 61.692% when pulling **32d0e20cb0ed4f645378052f12e1cfbbca412d62 on little-cui:gzip** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694804#comment-16694804 ] ASF GitHub Bot commented on SCB-1032: - coveralls edited a comment on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440688511 [](https://coveralls.io/builds/20225097) Coverage increased (+0.08%) to 61.738% when pulling **9a3ef86fc909235b23122b461b03d9a636c51669 on little-cui:gzip** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694805#comment-16694805 ] ASF GitHub Bot commented on SCB-1032: - codecov-io commented on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440691271 # [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=h1) Report > Merging [#496](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/49428294a99f2a475203a7ceb04ce8d5754feb77?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master #496 +/- ## == - Coverage 59.23% 59.22% -0.02% == Files 166 166 Lines 1388013880 == - Hits 8222 8220 -2 - Misses 5072 5079 +7 + Partials 586 581 -5 ``` | [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [server/service/notification/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL2xpc3R3YXRjaGVyLmdv) | `69.01% <0%> (-9.86%)` | :arrow_down: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [pkg/util/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `84.37% <0%> (+3.12%)` | :arrow_up: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <0%> (+6.66%)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/496/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <0%> (+9.09%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=footer). Last update [4942829...9a3ef86](https://codecov.io/gh/apache/servicecomb-service-center/pull/496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694786#comment-16694786 ] ASF GitHub Bot commented on SCB-1032: - coveralls commented on issue #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496#issuecomment-440688511 [](https://coveralls.io/builds/20224916) Coverage decreased (-0.05%) to 61.607% when pulling **9a3ef86fc909235b23122b461b03d9a636c51669 on little-cui:gzip** into **49428294a99f2a475203a7ceb04ce8d5754feb77 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1032) Support compress the response
[ https://issues.apache.org/jira/browse/SCB-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694765#comment-16694765 ] ASF GitHub Bot commented on SCB-1032: - little-cui opened a new pull request #496: SCB-1032 Support compress the response URL: https://github.com/apache/servicecomb-service-center/pull/496 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support compress the response > - > > Key: SCB-1032 > URL: https://issues.apache.org/jira/browse/SCB-1032 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
