[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698389#comment-16698389
]
ASF GitHub Bot commented on SCB-1039:
-
liubao68 closed pull request #1007: [SCB-1039]Add interface to compatible with
ServiceCenter Aggregator
URL: https://github.com/apache/servicecomb-java-chassis/pull/1007
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
index a3dbbdb3a..c9b8ed242 100644
---
a/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
+++
b/core/src/main/java/org/apache/servicecomb/core/definition/schema/ConsumerSchemaFactory.java
@@ -65,7 +65,7 @@ protected Swagger loadSwagger(ConsumerSchemaContext context) {
}
ServiceRegistryClient client = RegistryUtils.getServiceRegistryClient();
-String schemaContent =
client.getSchema(context.getMicroservice().getServiceId(),
context.getSchemaId());
+String schemaContent =
client.getAggregatedSchema(context.getMicroservice().getServiceId(),
context.getSchemaId());
LOGGER.info("load schema from service center, microservice={}:{}:{},
schemaId={}, result={}",
context.getMicroservice().getAppId(),
context.getMicroservice().getServiceName(),
diff --git
a/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMeta.java
b/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMeta.java
index fd24f6dec..9f5d68041 100644
---
a/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMeta.java
+++
b/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMeta.java
@@ -26,6 +26,7 @@
import org.apache.servicecomb.core.definition.loader.SchemaListenerManager;
import org.apache.servicecomb.core.definition.schema.ConsumerSchemaFactory;
import org.apache.servicecomb.serviceregistry.RegistryUtils;
+import org.apache.servicecomb.serviceregistry.ServiceRegistry;
import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
import org.hamcrest.Matchers;
import org.junit.AfterClass;
@@ -35,6 +36,7 @@
import mockit.Expectations;
import mockit.Mock;
import mockit.MockUp;
+import mockit.Mocked;
public class TestMicroserviceVersionMeta {
@AfterClass
@@ -44,7 +46,7 @@ public static void teardown() {
}
@Test
- public void construct() {
+ public void construct(@Mocked ServiceRegistry serviceRegistry) {
String microserviceName = "app:ms";
String microserviceId = "id";
Microservice microservice = new Microservice();
@@ -52,7 +54,9 @@ public void construct() {
new Expectations(RegistryUtils.class) {
{
-RegistryUtils.getMicroservice(microserviceId);
+RegistryUtils.getServiceRegistry();
+result = serviceRegistry;
+serviceRegistry.getAggregatedRemoteMicroservice(microserviceId);
result = microservice;
}
};
diff --git
a/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMetaFactory.java
b/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMetaFactory.java
index bf6c527ac..8e5382abf 100644
---
a/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMetaFactory.java
+++
b/core/src/test/java/org/apache/servicecomb/core/definition/TestMicroserviceVersionMetaFactory.java
@@ -23,6 +23,7 @@
import org.apache.servicecomb.core.definition.loader.SchemaListenerManager;
import org.apache.servicecomb.core.definition.schema.ConsumerSchemaFactory;
import org.apache.servicecomb.serviceregistry.RegistryUtils;
+import org.apache.servicecomb.serviceregistry.ServiceRegistry;
import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
import org.apache.servicecomb.serviceregistry.consumer.MicroserviceVersion;
import org.hamcrest.Matchers;
@@ -58,7 +59,7 @@ public void constructWithFactory() {
@Test
public void create(@Mocked ConsumerSchemaFactory consumerSchemaFactory,
- @Mocked SchemaListenerManager schemaListenerManager) {
+ @Mocked SchemaListenerManager schemaListenerManager, @Mocked
ServiceRegistry serviceRegistry) {
String microserviceName = "app:ms";
String microserviceId = "id";
Microservice microservice = new Microservice();
@@ -66,7 +67,9 @@ public void create(@Mocked ConsumerSchemaFactory
consumerSchemaFactory,
new Expectations(RegistryUtils.class) {
{
-RegistryUtils.getMicroservice(microserviceI
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698368#comment-16698368 ] ASF GitHub Bot commented on SCB-1039: - heyile commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441488807 > Why we need to distinguish from register & find flow? I think service center knows the request is register or find. @wujimin I do not know the details very clearly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698369#comment-16698369 ] ASF GitHub Bot commented on SCB-1039: - wujimin commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441489296 both register and find instance flow, need to invoke getMicroservice/getSchema but: only local serviceCenter cluster available for register flow all serviceCenter clusters in aggregator available for find instance flow ServiceCenter can not know the scenes, so need client invoke with the flag This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698367#comment-16698367 ] ASF GitHub Bot commented on SCB-1039: - heyile removed a comment on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441488705 > Why we need to distinguish from register & find flow? I think service center knows the request is register or find. @wujimin I know why, but I do not know the details very clearly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698366#comment-16698366 ] ASF GitHub Bot commented on SCB-1039: - heyile commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441488705 > Why we need to distinguish from register & find flow? I think service center knows the request is register or find. @wujimin I know why, but I do not know the details very clearly This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698151#comment-16698151 ] ASF GitHub Bot commented on SCB-1039: - liubao68 commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441435350 Why we need to distinguish from register & find flow? I think service center knows the request is register or find. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697704#comment-16697704 ] ASF GitHub Bot commented on SCB-1039: - coveralls edited a comment on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441339625 [](https://coveralls.io/builds/20268278) Coverage increased (+0.01%) to 86.782% when pulling **31ffdf758bed6a482e21f0341f3c6a7832462a5e on heyile:aggregated** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697684#comment-16697684
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236035554
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -346,19 +346,26 @@ public boolean registerSchema(String microserviceId,
String schemaId, String sch
@Override
public String getSchema(String microserviceId, String schemaId) {
+return doGetSchema(microserviceId, schemaId, false);
+ }
+
+ private String doGetSchema(String microserviceId, String schemaId, boolean
isAggregatedServiceCenter) {
Review comment:
ok, i will change it
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697682#comment-16697682
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236035433
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -346,19 +346,26 @@ public boolean registerSchema(String microserviceId,
String schemaId, String sch
@Override
public String getSchema(String microserviceId, String schemaId) {
+return doGetSchema(microserviceId, schemaId, false);
+ }
+
+ private String doGetSchema(String microserviceId, String schemaId, boolean
isAggregatedServiceCenter) {
Review comment:
not "isAggregatedServiceCenter"
target is ServiceCenter Aggregator:
1.for register flow, global=false
2.for find instance flow, global=true
so the variable name better to be: global
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697680#comment-16697680 ] ASF GitHub Bot commented on SCB-1039: - coveralls edited a comment on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441339625 [](https://coveralls.io/builds/20268045) Coverage increased (+0.007%) to 86.778% when pulling **0dc0080e68af549ee1b2c0b1a1401d7aea5ec2bc on heyile:aggregated** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697628#comment-16697628
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031524
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -795,7 +841,7 @@ public ServiceCenterInfo getServiceCenterInfo() {
CountDownLatch countDownLatch = new CountDownLatch(1);
RestUtils.get(ipPort,
Const.REGISTRY_API.SERVICECENTER_VERSION,
-new RequestParam(),
+new RequestParam().addQueryParam("global", "true"),
Review comment:
no need to add global
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697627#comment-16697627
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031009
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##
@@ -216,7 +216,7 @@ public static boolean updateInstanceProperties(Map instancePrope
}
public static Microservice getMicroservice(String microserviceId) {
-return serviceRegistry.getRemoteMicroservice(microserviceId);
+return serviceRegistry.getAggregatedRemoteMicroervice(microserviceId);
Review comment:
if change this... the method
org.apache.servicecomb.serviceregistry#Microservice
getAggregatedRemoteMicrservice(String microserviceId) will never be invoked?
should I delete this method...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697624#comment-16697624
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031194
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -356,6 +356,30 @@ public String getSchema(String microserviceId, String
schemaId) {
syncHandler(countDownLatch, GetSchemaResponse.class, holder));
try {
countDownLatch.await();
+} catch (Exception e) {
+ LOGGER.error("query schema exist {}/{} failed",
+ schemaId,
+ e);
+}
+if (holder.value != null) {
+ return holder.value.getSchema();
+}
+
+return null;
+ }
+
+ @Override
+ public String getAggregatedSchema(String microserviceId, String schemaId) {
+Holder holder = new Holder<>();
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697621#comment-16697621
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031009
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##
@@ -216,7 +216,7 @@ public static boolean updateInstanceProperties(Map instancePrope
}
public static Microservice getMicroservice(String microserviceId) {
-return serviceRegistry.getRemoteMicroservice(microserviceId);
+return serviceRegistry.getAggregatedRemoteMicroervice(microserviceId);
Review comment:
if change this... the method
org.apache.servicecomb.serviceregistry#Microservice
getAggregatedRemoteMicrservice(String microserviceId) will never be invoked?
can I delete the method...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697622#comment-16697622
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236031009
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##
@@ -216,7 +216,7 @@ public static boolean updateInstanceProperties(Map instancePrope
}
public static Microservice getMicroservice(String microserviceId) {
-return serviceRegistry.getRemoteMicroservice(microserviceId);
+return serviceRegistry.getAggregatedRemoteMicroervice(microserviceId);
Review comment:
if change this... the method
org.apache.servicecomb.serviceregistry#Microservice
getAggregatedRemoteMicrservice(String microserviceId) will never be invoked?
should I delete this method...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697619#comment-16697619
]
ASF GitHub Bot commented on SCB-1039:
-
heyile commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030963
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -489,7 +534,7 @@ public String
registerMicroserviceInstance(MicroserviceInstance instance) {
CountDownLatch countDownLatch = new CountDownLatch(1);
RestUtils.get(ipPort,
String.format(Const.REGISTRY_API.MICROSERVICE_INSTANCE_OPERATION_ALL,
providerId),
-new RequestParam().addHeader("X-ConsumerId", consumerId),
+new RequestParam().addHeader("X-ConsumerId",
consumerId).addQueryParam("global", "true"),
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697616#comment-16697616 ] ASF GitHub Bot commented on SCB-1039: - coveralls commented on issue #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#issuecomment-441339625 [](https://coveralls.io/builds/20267115) Coverage decreased (-0.03%) to 86.744% when pulling **b21e7d6cc1cd18acdf8f6813f0103730d5101cca on heyile:aggregated** into **ca4dea29d6a4c72cdebf28185c435ea69b7259dd on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697615#comment-16697615
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030836
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -489,7 +534,7 @@ public String
registerMicroserviceInstance(MicroserviceInstance instance) {
CountDownLatch countDownLatch = new CountDownLatch(1);
RestUtils.get(ipPort,
String.format(Const.REGISTRY_API.MICROSERVICE_INSTANCE_OPERATION_ALL,
providerId),
-new RequestParam().addHeader("X-ConsumerId", consumerId),
+new RequestParam().addHeader("X-ConsumerId",
consumerId).addQueryParam("global", "true"),
Review comment:
no need to add global
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697614#comment-16697614
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030818
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
##
@@ -356,6 +356,30 @@ public String getSchema(String microserviceId, String
schemaId) {
syncHandler(countDownLatch, GetSchemaResponse.class, holder));
try {
countDownLatch.await();
+} catch (Exception e) {
+ LOGGER.error("query schema exist {}/{} failed",
+ schemaId,
+ e);
+}
+if (holder.value != null) {
+ return holder.value.getSchema();
+}
+
+return null;
+ }
+
+ @Override
+ public String getAggregatedSchema(String microserviceId, String schemaId) {
+Holder holder = new Holder<>();
Review comment:
do not copy code
just make global to be a parameter
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697613#comment-16697613
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030804
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/LocalServiceRegistryClientImpl.java
##
@@ -188,6 +188,11 @@ public Microservice getMicroservice(String
microserviceId) {
return microserviceIdMap.get(microserviceId);
}
+ @Override
+ public Microservice getAggregatedMicroservice(String microserviceId) {
+return microserviceIdMap.get(microserviceId);
Review comment:
do not copy code
just invoke getMicroservice
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697612#comment-16697612
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030797
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/LocalServiceRegistryClientImpl.java
##
@@ -353,6 +358,16 @@ public String getSchema(String microserviceId, String
schemaId) {
return microservice.getSchemaMap().get(schemaId);
}
+ @Override
+ public String getAggregatedSchema(String microserviceId, String schemaId) {
Review comment:
do not copy code
just invoke getSchema
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697611#comment-16697611 ] ASF GitHub Bot commented on SCB-1039: - wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030705 ## File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/ServiceRegistry.java ## @@ -58,6 +58,15 @@ MicroserviceInstances findServiceInstances(String appId, String microserviceName Microservice getRemoteMicroservice(String microserviceId); + /** + * + *if connect to simple ServiceCenter, same with the method Review comment: normal, not "sample"? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[
https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697610#comment-16697610
]
ASF GitHub Bot commented on SCB-1039:
-
wujimin commented on a change in pull request #1007: [SCB-1039]Add interface to
compatible with ServiceCenter Aggregator
URL:
https://github.com/apache/servicecomb-java-chassis/pull/1007#discussion_r236030674
##
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/RegistryUtils.java
##
@@ -216,7 +216,7 @@ public static boolean updateInstanceProperties(Map instancePrope
}
public static Microservice getMicroservice(String microserviceId) {
-return serviceRegistry.getRemoteMicroservice(microserviceId);
+return serviceRegistry.getAggregatedRemoteMicroervice(microserviceId);
Review comment:
not change this
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add interface to compatible with ServiceCenter Aggregator
> -
>
> Key: SCB-1039
> URL: https://issues.apache.org/jira/browse/SCB-1039
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
>Reporter: 何一乐
>Assignee: 何一乐
>Priority: Major
>
> 1.增加几个接口
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice
>
> org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice
>
> org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema
> 都加上java doc注释，描述以下信息：
> 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息
> 2）连接ServiceCenter
> Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群
> 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true
> 2.搜索旧接口的所有引用
>所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-1039) Add interface to compatible with ServiceCenter Aggregator
[ https://issues.apache.org/jira/browse/SCB-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697609#comment-16697609 ] ASF GitHub Bot commented on SCB-1039: - heyile opened a new pull request #1007: [SCB-1039]Add interface to compatible with ServiceCenter Aggregator URL: https://github.com/apache/servicecomb-java-chassis/pull/1007 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add interface to compatible with ServiceCenter Aggregator > - > > Key: SCB-1039 > URL: https://issues.apache.org/jira/browse/SCB-1039 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Major > > 1.增加几个接口 > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getMicroservice旁边加getAggregatedMicroervice > > org.apache.servicecomb.serviceregistry.ServiceRegistry#getRemoteMicroservice旁边加上getAggregatedRemoteMicroervice > > org.apache.servicecomb.serviceregistry.client.ServiceRegistryClient#getSchema旁边加getAggregatedSchema > 都加上java doc注释，描述以下信息： > 1）连接普通ServiceCenter时，效果等同于不带Aggregagit chected的信息 > 2）连接ServiceCenter > Aggregator时，表示获取范围不仅仅局限在本ServiceCenter中，还包括其他ServiceCenter集群 > 向ServiceCenter发RESTful请求时，Aggregated的版本是在query参数部分加上global=true > 2.搜索旧接口的所有引用 >所有在服务发现流程中对它们的调用，都需要切换为Aggregated版本 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
