[jira] [Commented] (SCB-666) Test failure on system that have rotate option set in /etc/resolv.conf
[
https://issues.apache.org/jira/browse/SCB-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550176#comment-16550176
]
ASF GitHub Bot commented on SCB-666:
WillemJiang closed pull request #825: [SCB-666] Remove assert for
AddressResolverOptions
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/825
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestAbstractClientPool.java
b/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestAbstractClientPool.java
index 56b609bf9..5187dc667 100644
---
a/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestAbstractClientPool.java
+++
b/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestAbstractClientPool.java
@@ -80,19 +80,6 @@ public void create() {
HttpClientPool.INSTANCE.create();
Assert.assertEquals("registry", vertxName);
-Assert.assertEquals(
-"{"
-+ "\"cacheMaxTimeToLive\":2147483647,"
-+ "\"cacheMinTimeToLive\":0,"
-+ "\"cacheNegativeTimeToLive\":0,"
-+ "\"maxQueries\":4,"
-+ "\"ndots\":0,"
-+ "\"optResourceEnabled\":true,"
-+ "\"queryTimeout\":5000,"
-+ "\"rdFlag\":true,"
-+ "\"rotateServers\":false"
-+ "}",
-vertxOptions.getAddressResolverOptions().toJson().toString());
Assert.assertEquals(ClientVerticle.class, verticleCls);
Assert.assertEquals(ClientPoolManager.class,
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Test failure on system that have rotate option set in /etc/resolv.conf
> --
>
> Key: SCB-666
> URL: https://issues.apache.org/jira/browse/SCB-666
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: Yang Bo
>Assignee: Yang Bo
>Priority: Minor
> Fix For: java-chassis-1.0.0
>
>
> Test failure on system that have rotate option set in /etc/resolv.conf
> Failed tests:
> TestAbstractClientPool.create:83 expected:<...rue,"rotateServers":[fals]e}>
> but was:<...rue,"rotateServers":[tru]e}>
>
> Vertx read /etc/resolv.conf and set the option according to the rotate
> configuration. Need to fix the test case, only check the bits that's are
> specifically set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-666) Test failure on system that have rotate option set in /etc/resolv.conf
[ https://issues.apache.org/jira/browse/SCB-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550127#comment-16550127 ] ASF GitHub Bot commented on SCB-666: coveralls commented on issue #825: [SCB-666] Remove assert for AddressResolverOptions URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/825#issuecomment-406468466 [](https://coveralls.io/builds/18077226) Coverage remained the same at 87.081% when pulling **121655bf149a14348d13a06c13a34c908d5025c5 on yangbor:master** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Test failure on system that have rotate option set in /etc/resolv.conf > -- > > Key: SCB-666 > URL: https://issues.apache.org/jira/browse/SCB-666 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Minor > Fix For: java-chassis-1.0.0 > > > Test failure on system that have rotate option set in /etc/resolv.conf > Failed tests: > TestAbstractClientPool.create:83 expected:<...rue,"rotateServers":[fals]e}> > but was:<...rue,"rotateServers":[tru]e}> > > Vertx read /etc/resolv.conf and set the option according to the rotate > configuration. Need to fix the test case, only check the bits that's are > specifically set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-666) Test failure on system that have rotate option set in /etc/resolv.conf
[ https://issues.apache.org/jira/browse/SCB-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550098#comment-16550098 ] ASF GitHub Bot commented on SCB-666: yangbor opened a new pull request #825: [SCB-666] Remove assert for AddressResolverOptions URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/825 The AddressResolverOptions just uses the vertx defaults. The conigSource is set to null when creating. So there is no need to test these options. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Test failure on system that have rotate option set in /etc/resolv.conf > -- > > Key: SCB-666 > URL: https://issues.apache.org/jira/browse/SCB-666 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Minor > Fix For: java-chassis-1.0.0 > > > Test failure on system that have rotate option set in /etc/resolv.conf > Failed tests: > TestAbstractClientPool.create:83 expected:<...rue,"rotateServers":[fals]e}> > but was:<...rue,"rotateServers":[tru]e}> > > Vertx read /etc/resolv.conf and set the option according to the rotate > configuration. Need to fix the test case, only check the bits that's are > specifically set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-666) Test failure on system that have rotate option set in /etc/resolv.conf
[ https://issues.apache.org/jira/browse/SCB-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541619#comment-16541619 ] Willem Jiang commented on SCB-666: -- [~yangbor] any update for this issue? we are planing to 1.0.0 release this month. > Test failure on system that have rotate option set in /etc/resolv.conf > -- > > Key: SCB-666 > URL: https://issues.apache.org/jira/browse/SCB-666 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Minor > Fix For: java-chassis-1.0.0 > > > Test failure on system that have rotate option set in /etc/resolv.conf > Failed tests: > TestAbstractClientPool.create:83 expected:<...rue,"rotateServers":[fals]e}> > but was:<...rue,"rotateServers":[tru]e}> > > Vertx read /etc/resolv.conf and set the option according to the rotate > configuration. Need to fix the test case, only check the bits that's are > specifically set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
