[jira] [Commented] (SCB-759) Fix ServiceComb version error

2018-07-19 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/SCB-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548869#comment-16548869
 ] 

ASF GitHub Bot commented on SCB-759:


WillemJiang closed pull request #820: [SCB-759] fix ServiceComb version
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/820
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/archetypes/README.md b/archetypes/README.md
index 687a6f4ca..84663b553 100644
--- a/archetypes/README.md
+++ b/archetypes/README.md
@@ -48,5 +48,5 @@ In console Interactive mode, input your GroupId, ArtifactId 
and Version of new p
 *Notice: We will publish these archetypes to maven center repository since 
1.0.0-m2, if you would like to use an archetype from an unreleased version, 
must use `archetypeRepository` option in the version 2.4 of archetype-plugin in 
order to set maven repository to apache snapshot groups: *
 
 ```bash
-mvn org.apache.maven.plugins:maven-archetype-plugin:2.4:generate 
-DarchetypeGroupId=org.apache.servicecomb.archetypes 
-DarchetypeArtifactId=business-service-jaxrs-archetype 
-DarchetypeVersion=1.0.0-m2-SNAPSHOT 
-DarchetypeRepository=https://repository.apache.org/content/groups/snapshots-group
+mvn org.apache.maven.plugins:maven-archetype-plugin:2.4:generate 
-DarchetypeGroupId=org.apache.servicecomb.archetypes 
-DarchetypeArtifactId=business-service-jaxrs-archetype 
-DarchetypeVersion=1.0.0-SNAPSHOT 
-DarchetypeRepository=https://repository.apache.org/content/groups/snapshots-group
 ```
\ No newline at end of file
diff --git a/samples/bmi/build.gradle b/samples/bmi/build.gradle
index 3dfb8b530..3b7365892 100644
--- a/samples/bmi/build.gradle
+++ b/samples/bmi/build.gradle
@@ -19,7 +19,7 @@ allprojects  {
 apply plugin: 'maven'
 
 group = 'org.apache.servicecomb.samples'
-version = '1.0.0-m2-SNAPSHOT'
+version = '1.0.0-SNAPSHOT'
 }
 
 buildscript {
diff --git a/samples/bmi/calculator/build.gradle 
b/samples/bmi/calculator/build.gradle
index 16223d9a0..71c00197b 100644
--- a/samples/bmi/calculator/build.gradle
+++ b/samples/bmi/calculator/build.gradle
@@ -44,6 +44,6 @@ apply plugin: 'io.spring.dependency-management'
 
 dependencyManagement {
 imports {
-mavenBom 
'org.apache.servicecomb:java-chassis-dependencies:1.0.0-m2-SNAPSHOT'
+mavenBom 
'org.apache.servicecomb:java-chassis-dependencies:1.0.0-SNAPSHOT'
 }
 }
diff --git a/samples/bmi/webapp/build.gradle b/samples/bmi/webapp/build.gradle
index c8973f6b8..1624d9cf5 100644
--- a/samples/bmi/webapp/build.gradle
+++ b/samples/bmi/webapp/build.gradle
@@ -44,6 +44,6 @@ apply plugin: 'io.spring.dependency-management'
 
 dependencyManagement {
 imports {
-mavenBom 
'org.apache.servicecomb:java-chassis-dependencies:1.0.0-m2-SNAPSHOT'
+mavenBom 
'org.apache.servicecomb:java-chassis-dependencies:1.0.0-SNAPSHOT'
 }
 }
diff --git a/samples/codefirst-sample/build.gradle 
b/samples/codefirst-sample/build.gradle
index cfff44a76..67a7af595 100644
--- a/samples/codefirst-sample/build.gradle
+++ b/samples/codefirst-sample/build.gradle
@@ -19,7 +19,7 @@ allprojects  {
 apply plugin: 'maven'
 
 group = 'org.apache.servicecomb.samples'
-version = '1.0.0-m2-SNAPSHOT'
+version = '1.0.0-SNAPSHOT'
 }
 
 subprojects {
diff --git a/samples/codefirst-sample/codefirst-consumer/build.gradle 
b/samples/codefirst-sample/codefirst-consumer/build.gradle
index 060ad092e..90d4ddc0f 100644
--- a/samples/codefirst-sample/codefirst-consumer/build.gradle
+++ b/samples/codefirst-sample/codefirst-consumer/build.gradle
@@ -21,7 +21,7 @@ dependencies {
 compile group: 'org.apache.servicecomb', name: 'provider-pojo'
 compile group: 'org.apache.servicecomb', name: 'transport-highway'
 compile group: 'org.apache.servicecomb', name: 'transport-rest-vertx'
-compile group: 'org.apache.servicecomb.samples', name: 'common-schema', 
version: '1.0.0-m2-SNAPSHOT'
+compile group: 'org.apache.servicecomb.samples', name: 'common-schema', 
version: '1.0.0-SNAPSHOT'
 compile group: 'org.slf4j', name: 'slf4j-log4j12'
 }
 
@@ -46,6 +46,6 @@ apply plugin: 'io.spring.dependency-management'
 
 dependencyManagement {
 imports {
-mavenBom 
'org.apache.servicecomb:java-chassis-dependencies:1.0.0-m2-SNAPSHOT'
+mavenBom 
'org.apache.servicecomb:java-chassis-dependencies:1.0.0-SNAPSHOT'
 }
-}
\ No newline at end of file
+}
diff --git a/samples/codefirst-sample/codefirst-provider/build.gradle 
b/samples/codefirst-sample/codefirst-provider/build.gradle
index bb0b845f3..9c85d0717 100644
--- a/samples/codefirst-sample/codefirst-provider/build.gradle
+++ b/samples/codefirst-sample/codefirst-provider/build.gradle
@@

[jira] [Commented] (SCB-759) Fix ServiceComb version error

2018-07-18 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/SCB-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548700#comment-16548700
 ] 

ASF GitHub Bot commented on SCB-759:


yhs0092 opened a new pull request #820: [SCB-759] fix ServiceComb version
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/820
 
 
   Follow this checklist to help us incorporate your contribution quickly and 
easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually 
before you start working on it).  Trivial changes like typos do not require a 
JIRA issue.  Your pull request should address just this issue, without pulling 
in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[SCB-XXX] Fixes bug in 
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA 
issue.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more 
thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   See details in [SCB-759](https://issues.apache.org/jira/browse/SCB-759)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix ServiceComb version error
> -
>
> Key: SCB-759
> URL: https://issues.apache.org/jira/browse/SCB-759
> Project: Apache ServiceComb
>  Issue Type: Bug
>Reporter: YaoHaishi
>Assignee: YaoHaishi
>Priority: Major
>
> In some pom files and others， the version of ServiceComb is still 
> 1.0.0-m2-SNAPSHOT. We need to change them to 1.0.0-SNAPSHOT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)