[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[
https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551435#comment-16551435
]
ASF GitHub Bot commented on SCB-762:
WillemJiang closed pull request #823: [SCB-762] resolve eclipse compile warnings
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
index bb02d725e..e6315e9f3 100644
---
a/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
+++
b/foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/JvmUtils.java
@@ -72,7 +72,7 @@ private static String readFromJar(String mainClassOrJar) {
return mainClassOrJar;
}
-String manifestUri = "jar:file:/" + new
File(mainClassOrJar).getAbsolutePath() + "!/" + JarFile.MANIFEST_NAME;
+String manifestUri = "jar:file:" + new
File(mainClassOrJar).getAbsolutePath() + "!/" + JarFile.MANIFEST_NAME;
try {
URL url = new URL(manifestUri);
diff --git
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
index 8766b847e..a9f8fba66 100644
---
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
+++
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/net/TestNetUtils.java
@@ -18,7 +18,6 @@
package org.apache.servicecomb.foundation.common.net;
import java.io.IOException;
-import java.lang.reflect.Field;
import java.net.InetAddress;
import java.net.ServerSocket;
import java.util.HashMap;
@@ -108,7 +107,7 @@ public void testCanTcpListenYes() throws IOException {
Assert.assertTrue(NetUtils.canTcpListen(address, port));
}
-
+
@Test
public void testGetHostName() {
Assert.assertNotEquals(null, NetUtils.getHostName());
diff --git
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
index 257c8f407..97a616dd7 100644
---
a/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
+++
b/foundations/foundation-common/src/test/java/org/apache/servicecomb/foundation/common/utils/TestJvmUtils.java
@@ -89,7 +89,7 @@ public void findMainClass_jar_normal() throws Exception {
URL url = PowerMockito.mock(URL.class);
String command = "a.jar";
-String manifestUri = "jar:file:/" + new File(command).getAbsolutePath() +
"!/" + JarFile.MANIFEST_NAME;
+String manifestUri = "jar:file:" + new File(command).getAbsolutePath() +
"!/" + JarFile.MANIFEST_NAME;
PowerMockito.whenNew(URL.class).withParameterTypes(String.class)
.withArguments(manifestUri).thenReturn(url);
diff --git
a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/CustomizeCommandGroupKey.java
b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/CustomizeCommandGroupKey.java
index c80e926f1..79183b718 100644
---
a/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/CustomizeCommandGroupKey.java
+++
b/handlers/handler-bizkeeper/src/main/java/org/apache/servicecomb/bizkeeper/CustomizeCommandGroupKey.java
@@ -24,7 +24,7 @@
import com.netflix.hystrix.util.InternMap;
/**
- *
ͨ��CommandGroupKey��ĿЯ��Invocation���־�̬��Ϣ��CircutBreakerEvent��ȡ��
+ * 通过定制CommandGroupKey，目的是携带Invocation部分静态信息，便于CircutBreakerEvent获取
*/
public class CustomizeCommandGroupKey extends HystrixKey.HystrixKeyDefault
implements HystrixCommandGroupKey {
@@ -34,13 +34,14 @@ public CustomizeCommandGroupKey(String key) {
super(key);
}
- private static final InternMap intern =
new InternMap(
- new InternMap.ValueConstructor() {
-@Override
-public CustomizeCommandGroupKey create(String key) {
- return new CustomizeCommandGroupKey(key);
-}
- });
+ private static final InternMap intern =
+ new InternMap(
+ new InternMap.ValueConstructor() {
+@Override
+public CustomizeCommandGroupKey create(String key) {
+ return new CustomizeCommandGroupKey(key);
+}
+ });
public
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550336#comment-16550336 ] ASF GitHub Bot commented on SCB-762: wujimin commented on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406514970 that's because i triggered it again.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550329#comment-16550329 ] ASF GitHub Bot commented on SCB-762: wujimin commented on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406513528 CI passed, but show error here, what happened? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550328#comment-16550328 ] ASF GitHub Bot commented on SCB-762: coveralls edited a comment on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406460006 [](https://coveralls.io/builds/18079541) Coverage increased (+0.03%) to 87.11% when pulling **363bff8908fad0b3618366279307369726f5953a on wujimin:resolve-eclipse-compile-warnings** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550144#comment-16550144 ] ASF GitHub Bot commented on SCB-762: coveralls edited a comment on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406460006 [](https://coveralls.io/builds/18076774) Coverage increased (+0.02%) to 87.1% when pulling **d805dbae87f6208886ee697e109b0f88f548ad7c on wujimin:resolve-eclipse-compile-warnings** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550086#comment-16550086 ] ASF GitHub Bot commented on SCB-762: coveralls commented on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406460006 [](https://coveralls.io/builds/18076774) Coverage remained the same at 87.081% when pulling **d805dbae87f6208886ee697e109b0f88f548ad7c on wujimin:resolve-eclipse-compile-warnings** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550068#comment-16550068 ] ASF GitHub Bot commented on SCB-762: wujimin opened a new pull request #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
