[jira] [Commented] (SCB-918) serialize/deserialize based on proto model
[ https://issues.apache.org/jira/browse/SCB-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633071#comment-16633071 ] ASF GitHub Bot commented on SCB-918: coveralls edited a comment on issue #930: [SCB-918] Codec based on proto URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/930#issuecomment-425362658 [](https://coveralls.io/builds/19263474) Coverage increased (+0.09%) to 86.289% when pulling **388cc81090a1d927c3ab43a19b8386e9df5bc718 on wujimin:codec-based-on-proto** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > serialize/deserialize based on proto model > -- > > Key: SCB-918 > URL: https://issues.apache.org/jira/browse/SCB-918 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-918) serialize/deserialize based on proto model
[ https://issues.apache.org/jira/browse/SCB-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633069#comment-16633069 ] ASF GitHub Bot commented on SCB-918: coveralls edited a comment on issue #930: [SCB-918] Codec based on proto URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/930#issuecomment-425362658 [](https://coveralls.io/builds/19263431) Coverage increased (+0.08%) to 86.285% when pulling **388cc81090a1d927c3ab43a19b8386e9df5bc718 on wujimin:codec-based-on-proto** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > serialize/deserialize based on proto model > -- > > Key: SCB-918 > URL: https://issues.apache.org/jira/browse/SCB-918 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-918) serialize/deserialize based on proto model
[ https://issues.apache.org/jira/browse/SCB-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633068#comment-16633068 ] ASF GitHub Bot commented on SCB-918: coveralls edited a comment on issue #930: [SCB-918] Codec based on proto URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/930#issuecomment-425362658 [](https://coveralls.io/builds/19263396) Coverage increased (+0.08%) to 86.285% when pulling **388cc81090a1d927c3ab43a19b8386e9df5bc718 on wujimin:codec-based-on-proto** into **6aadae0de82b3b3940f0c163b815d6675aedc2bc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > serialize/deserialize based on proto model > -- > > Key: SCB-918 > URL: https://issues.apache.org/jira/browse/SCB-918 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-918) serialize/deserialize based on proto model
[ https://issues.apache.org/jira/browse/SCB-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632719#comment-16632719 ] ASF GitHub Bot commented on SCB-918: coveralls edited a comment on issue #930: [SCB-918] Codec based on proto URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/930#issuecomment-425362658 [](https://coveralls.io/builds/19259005) Coverage increased (+0.07%) to 86.348% when pulling **751c43f018d43980ce3470727ff20da4f3871822 on wujimin:codec-based-on-proto** into **37230e4f06772b066750169c291f04408c4e88ca on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > serialize/deserialize based on proto model > -- > > Key: SCB-918 > URL: https://issues.apache.org/jira/browse/SCB-918 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-918) serialize/deserialize based on proto model
[ https://issues.apache.org/jira/browse/SCB-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631523#comment-16631523 ] ASF GitHub Bot commented on SCB-918: coveralls commented on issue #930: [SCB-918] Codec based on proto URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/930#issuecomment-425362658 [](https://coveralls.io/builds/19242535) Coverage increased (+0.09%) to 86.368% when pulling **335887a5df4d8dc37cf4cf9d0dc6b9fc0b04bde5 on wujimin:codec-based-on-proto** into **37230e4f06772b066750169c291f04408c4e88ca on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > serialize/deserialize based on proto model > -- > > Key: SCB-918 > URL: https://issues.apache.org/jira/browse/SCB-918 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-918) serialize/deserialize based on proto model
[ https://issues.apache.org/jira/browse/SCB-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16630922#comment-16630922 ] ASF GitHub Bot commented on SCB-918: wujimin opened a new pull request #930: [SCB-918] Codec based on proto URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/930 **need to merge https://github.com/apache/incubator-servicecomb-java-chassis/pull/928 first** ProtobufRoot.java is generated by protobufRoot.proto, 5000 lines. it's only for unit test - compare to jackson protobuf: - can parse protobuf 3 proto file - support protobuf 3: map/any - compare to protoStuff runtime: - for a proto message type, not only support strong type(Pojo), but alse support weak type(Map) - support "any" type - support generic pojo type, eg:CustomGeneric - **NOT** support List>/List> any more, because protobuf specification not support it, and the parser can not parse the proto file - compare to standard protobuf: - extend "any" type, for standard not support cases, use "json" schema to codec it. - compare to all: - just pojo, no need any code generation and annotation - one pojo can serialize to different version proto file to support different version server - support text data come from http,can serrialize from different data type - number fields (int32/int64 and so on) - number - String - String[] - string fields - string - string[] - bool fields - boolean - string - string[] - enum fields - enum - number - string - string[] - performance compare: ``` 1.protobuf in our real scenes business model never bind to transport, and can switch between different transport dynamically that means if we choose standard protobuf, must build protobuf models from business models each time so should be much slower than the test results 2.protoStuff some scenes, there is no field but have getter or setter, so we can not use unsafe to access field so we disable protoStuff unsafe feature Empty: Protostuff ScbStrong ScbWeakProtobuf Jackson ser time(ms) :268297250187 391 ser len :36 0 0 0 56 deser time(ms):10931 16 243 434 deser-ser len :36 0 0 0 56 Scalars: Protostuff ScbStrong ScbWeakProtobuf Jackson ser time(ms) :234282284313 388 ser len :53 21 21 21 73 deser time(ms):15662 125187 453 deser-ser len :53 21 21 21 73 SimpleList: Protostuff ScbStrong ScbWeakProtobuf Jackson ser time(ms) :234281286172 422 ser len :68 32 32 32 88 deser time(ms):21994 106251 485 deser-ser len :68 32 32 32 88 PojoList: Protostuff ScbStrong ScbWeakProtobuf Jackson ser time(ms) :313359344172 543 ser len :56 20 20 20 76 deser time(ms):246127174281 609 deser-ser len :56 20 20 20 76 Map: Protostuff ScbStrong ScbWeakProtobuf Jackson ser time(ms) :408489514482 388 ser len :92 54 54 54 56 deser time(ms):515375423737 359 deser-ser len :92 54 54 54 56 Mixed: Protostuff ScbStrong ScbWeakProtobuf Jackson ser time(ms) :549721708543 563 ser len :161127127
