[PR] Reorganize sort section in common-query-parameters.adoc [solr]
cdrini opened a new pull request, #2371: URL: https://github.com/apache/solr/pull/2371 # Description Reorganize/reword the `sort` section on the Common Query Parameters documentation page. # Solution * A lot of small tightening of the language. * Reorganized to try to have the most useful information at the top. So lead with the examples, since the examples are pretty clear on their own. Then the nitty-gritty of the details appears after. * Made it clearer that multi-valued fields _do_ support sorting. # Tests Tested by previewing on https://asciidoclive.com/ , and it all looked good there. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [NA] I have created a Jira issue and added the issue ID to my pull request title. - Not sure if you all would prefer I create issues for some of the documentation changes ; can do if so. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [NA] I have run `./gradlew check`. - [NA] I have added tests for my changes. - [NA] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension (#2315) [solr]
dsmiley commented on PR #2369: URL: https://github.com/apache/solr/pull/2369#issuecomment-2016644812 I'm curious, did you find the backport PR to serve a purpose in this case? I've only done it for something that was complicated enough to need a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-16921: use -solrUrl to derive the zk host connection for bin/solr zk subcommands [solr]
epugh opened a new pull request, #2370: URL: https://github.com/apache/solr/pull/2370 https://issues.apache.org/jira/browse/SOLR-16921 Figured out in debugging we can do something nice! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16921) bin/solr upconfig and downconfig reference solrUrl but don't list it as option!
[
https://issues.apache.org/jira/browse/SOLR-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830129#comment-17830129
]
Eric Pugh commented on SOLR-16921:
--
I think that it may be very easy to support -solrUrl and get the zk host...
Any reason NOT to support both a -z and -s options?
> bin/solr upconfig and downconfig reference solrUrl but don't list it as
> option!
> ---
>
> Key: SOLR-16921
> URL: https://issues.apache.org/jira/browse/SOLR-16921
> Project: Solr
> Issue Type: Sub-task
> Components: cli
>Affects Versions: main (10.0), 9.3
>Reporter: Eric Pugh
>Priority: Minor
>
> We have a message like:
> if (zkHost == null) {
> throw new IllegalStateException(
> "Solr at "
> + cli.getOptionValue("solrUrl")
> + " is running in standalone server mode, upconfig can only be
> used when running in SolrCloud mode.\n");
> }
> but we don't declare the option value of solrUrl..
> Although, why not???
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-7637) Improve error logging in the zkcli CLUSTERPROP command
[ https://issues.apache.org/jira/browse/SOLR-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-7637. - Resolution: Won't Fix Closing this as we won't be fixing zkcli.sh. However, if you think this is still an issue in the bin/solr zk command in SOLR-14115 , please do speak up! > Improve error logging in the zkcli CLUSTERPROP command > -- > > Key: SOLR-7637 > URL: https://issues.apache.org/jira/browse/SOLR-7637 > Project: Solr > Issue Type: Improvement >Reporter: Hrishikesh Gadre >Assignee: Gregory Chanan >Priority: Trivial > Attachments: SOLR-7637.patch > > > SOLR-7176 introduced capability to update Solr cluster properties via ZK CLI. > The error logging implemented as part of that fix was not proper (i.e. the > actual error was getting masked). We should improve the error logging to > explicitly state the root cause. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-7637) Improve error logging in the zkcli CLUSTERPROP command
[ https://issues.apache.org/jira/browse/SOLR-7637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830065#comment-17830065 ] Eric Pugh commented on SOLR-7637: - We are getting rid of zkcli in favour of bin/solr zk subcommands in SOLR-14115 > Improve error logging in the zkcli CLUSTERPROP command > -- > > Key: SOLR-7637 > URL: https://issues.apache.org/jira/browse/SOLR-7637 > Project: Solr > Issue Type: Improvement >Reporter: Hrishikesh Gadre >Assignee: Gregory Chanan >Priority: Trivial > Attachments: SOLR-7637.patch > > > SOLR-7176 introduced capability to update Solr cluster properties via ZK CLI. > The error logging implemented as part of that fix was not proper (i.e. the > actual error was getting masked). We should improve the error logging to > explicitly state the root cause. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]
epugh commented on PR #1768: URL: https://github.com/apache/solr/pull/1768#issuecomment-2016439096 One reason I've been feeling a bit daunted on the idea of enhancing commons-cli to support deprecation is because it would mean that we would need to keep/extend the lines of code in `bin/solr` and `bin/solr.cmd` that deal with parameter parsing... Although now that I look at it, maybe if we move along more of the parameter passing INTO the java code, then the impact would be less. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17185) Open ValueAugmenter in ValueAugmenterFactory for extension
[
https://issues.apache.org/jira/browse/SOLR-17185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830051#comment-17830051
]
Mikhail Khludnev commented on SOLR-17185:
-
9x
https://github.com/apache/solr/commit/f81cc4afd08b87d7a6113d8868c460c1983c80e5
> Open ValueAugmenter in ValueAugmenterFactory for extension
> --
>
> Key: SOLR-17185
> URL: https://issues.apache.org/jira/browse/SOLR-17185
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Reporter: Torsten Bøgh Köster
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 9.6.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Opening up the class `ValueAugmenter` in the `ValueAugmenterFactory` to
> `public` access level eases the creation of custom document transformers.
> Currently, we have to place our custom document transformers in the
> `org.apache.solr.response.transform` package to be able to access the package
> private `ValueAugmenter`. Changing the visibility to `public` enables
> building custom document transformers very slim and quick like the following
> one in any package:
> ```
> public class CollectionAugmenterFactory extends TransformerFactory {
> @Override
> public DocTransformer create(String field, SolrParams params,
> SolrQueryRequest req) {
> String v =
> ComponentUtils.getCollectionNameFrom(req.getCore()).orElse("[unknown]");
> return new ValueAugmenterFactory.ValueAugmenter(field, v);
> }
> }
> ```
> I'll supply a GitHub PR for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17185) Open ValueAugmenter in ValueAugmenterFactory for extension
[
https://issues.apache.org/jira/browse/SOLR-17185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-17185:
Fix Version/s: 9.6.0
> Open ValueAugmenter in ValueAugmenterFactory for extension
> --
>
> Key: SOLR-17185
> URL: https://issues.apache.org/jira/browse/SOLR-17185
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Reporter: Torsten Bøgh Köster
>Priority: Major
> Fix For: 9.6.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Opening up the class `ValueAugmenter` in the `ValueAugmenterFactory` to
> `public` access level eases the creation of custom document transformers.
> Currently, we have to place our custom document transformers in the
> `org.apache.solr.response.transform` package to be able to access the package
> private `ValueAugmenter`. Changing the visibility to `public` enables
> building custom document transformers very slim and quick like the following
> one in any package:
> ```
> public class CollectionAugmenterFactory extends TransformerFactory {
> @Override
> public DocTransformer create(String field, SolrParams params,
> SolrQueryRequest req) {
> String v =
> ComponentUtils.getCollectionNameFrom(req.getCore()).orElse("[unknown]");
> return new ValueAugmenterFactory.ValueAugmenter(field, v);
> }
> }
> ```
> I'll supply a GitHub PR for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Assigned] (SOLR-17185) Open ValueAugmenter in ValueAugmenterFactory for extension
[
https://issues.apache.org/jira/browse/SOLR-17185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev reassigned SOLR-17185:
---
Assignee: Mikhail Khludnev
> Open ValueAugmenter in ValueAugmenterFactory for extension
> --
>
> Key: SOLR-17185
> URL: https://issues.apache.org/jira/browse/SOLR-17185
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Reporter: Torsten Bøgh Köster
>Assignee: Mikhail Khludnev
>Priority: Major
> Fix For: 9.6.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Opening up the class `ValueAugmenter` in the `ValueAugmenterFactory` to
> `public` access level eases the creation of custom document transformers.
> Currently, we have to place our custom document transformers in the
> `org.apache.solr.response.transform` package to be able to access the package
> private `ValueAugmenter`. Changing the visibility to `public` enables
> building custom document transformers very slim and quick like the following
> one in any package:
> ```
> public class CollectionAugmenterFactory extends TransformerFactory {
> @Override
> public DocTransformer create(String field, SolrParams params,
> SolrQueryRequest req) {
> String v =
> ComponentUtils.getCollectionNameFrom(req.getCore()).orElse("[unknown]");
> return new ValueAugmenterFactory.ValueAugmenter(field, v);
> }
> }
> ```
> I'll supply a GitHub PR for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17185) Open ValueAugmenter in ValueAugmenterFactory for extension
[
https://issues.apache.org/jira/browse/SOLR-17185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev resolved SOLR-17185.
-
Resolution: Fixed
> Open ValueAugmenter in ValueAugmenterFactory for extension
> --
>
> Key: SOLR-17185
> URL: https://issues.apache.org/jira/browse/SOLR-17185
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Reporter: Torsten Bøgh Köster
>Priority: Major
> Fix For: 9.6.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Opening up the class `ValueAugmenter` in the `ValueAugmenterFactory` to
> `public` access level eases the creation of custom document transformers.
> Currently, we have to place our custom document transformers in the
> `org.apache.solr.response.transform` package to be able to access the package
> private `ValueAugmenter`. Changing the visibility to `public` enables
> building custom document transformers very slim and quick like the following
> one in any package:
> ```
> public class CollectionAugmenterFactory extends TransformerFactory {
> @Override
> public DocTransformer create(String field, SolrParams params,
> SolrQueryRequest req) {
> String v =
> ComponentUtils.getCollectionNameFrom(req.getCore()).orElse("[unknown]");
> return new ValueAugmenterFactory.ValueAugmenter(field, v);
> }
> }
> ```
> I'll supply a GitHub PR for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension (#2315) [solr]
mkhludnev merged PR #2369: URL: https://github.com/apache/solr/pull/2369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]
mkhludnev commented on PR #2315: URL: https://github.com/apache/solr/pull/2315#issuecomment-2016431220 backporting #2369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension (#2315) [solr]
mkhludnev opened a new pull request, #2369: URL: https://github.com/apache/solr/pull/2369 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]
mkhludnev merged PR #2315: URL: https://github.com/apache/solr/pull/2315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17185) Open ValueAugmenter in ValueAugmenterFactory for extension
[
https://issues.apache.org/jira/browse/SOLR-17185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830048#comment-17830048
]
ASF subversion and git services commented on SOLR-17185:
Commit ad58a8d166f01b69738a7b5ded65651336022809 in solr's branch
refs/heads/main from Torsten Bøgh Köster
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=ad58a8d166f ]
[SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension (#2315)
* Open value augmenter for extension
* [SOLR-17185] add public compile test
* [SOLR-17185] change visibility of fields
* [SOLR-17185] add license file // tidy
> Open ValueAugmenter in ValueAugmenterFactory for extension
> --
>
> Key: SOLR-17185
> URL: https://issues.apache.org/jira/browse/SOLR-17185
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Response Writers
>Reporter: Torsten Bøgh Köster
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Opening up the class `ValueAugmenter` in the `ValueAugmenterFactory` to
> `public` access level eases the creation of custom document transformers.
> Currently, we have to place our custom document transformers in the
> `org.apache.solr.response.transform` package to be able to access the package
> private `ValueAugmenter`. Changing the visibility to `public` enables
> building custom document transformers very slim and quick like the following
> one in any package:
> ```
> public class CollectionAugmenterFactory extends TransformerFactory {
> @Override
> public DocTransformer create(String field, SolrParams params,
> SolrQueryRequest req) {
> String v =
> ComponentUtils.getCollectionNameFrom(req.getCore()).orElse("[unknown]");
> return new ValueAugmenterFactory.ValueAugmenter(field, v);
> }
> }
> ```
> I'll supply a GitHub PR for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
