[jira] [Commented] (SOLR-17274) atomic update error when using json w/ multiple modifiers

2024-05-04 Thread David Smiley (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843522#comment-17843522
 ] 

David Smiley commented on SOLR-17274:
-

The JSON syntax is not as rich as XML or "javabin" (native SolrJ), which are 
typed.  *Perhaps* a solution is to assume certain operation names (e.g. "set", 
"add", "remove", etc.)?  Ugh; it's kind of inelegant though.  I wish we had 
used underscores to make them more special.  At least this problem is only 
specific to JSON; you have a couple other options.

> atomic update error when using json w/ multiple modifiers
> -
>
> Key: SOLR-17274
> URL: https://issues.apache.org/jira/browse/SOLR-17274
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: update
>Affects Versions: 9.0, 9.1, 9.2, 9.3, 9.4, 9.5, 9.6
> Environment: Observed first in 9.5.0 w/ OpenJDK 11, then reproduced 
> this simple test case in 9.6.0.
>Reporter: Calvin Smith
>Priority: Major
>
> I ran into a problem doing a json atomic update that tries to both `add` and 
> `remove` a value for a multivalued field in a single update. I saw it 
> initially in an instance that runs 9.5.0, and reproduced a minimal example 
> using Solr 9.6.0.
> {{The only fields defined in the schema are:}}
> {code:java}
>    required="true" stored="true"/>
>   
>   {code}
> {{`id` is also present, so I'm supplying docs with 
> just an `id` and a multivalued `name` field. The real setup is more complex, 
> but this is a minimal test case to illustrate the problem.}}
> {{Starting with an empty index, I add the following doc to the index 
> successfully:}}
> {code:java}
> {"id": "1", "name": ["John Doe", "Jane Doe"]}{code}
> {{And I can query it, seeing the expected result:}}
> {code:java}
> {
>   "responseHeader":{
>     "status":0,
>     "QTime":23,
>     "params":{
>       "q":"name:*"
>     }
>   },
>   "response":{
>     "numFound":1,
>     "start":0,
>     "numFoundExact":true,
>     "docs":[{
>       "id":"1",
>       "name":["John Doe","Jane Doe"],
>       "_version_":1797873599884820480
>     }]
>   }
> }{code}
> {{Next, I send an atomic update to modify the `name` field of that document 
> by removing `Jane Doe` and adding `Janet Doe`:}}
> {code:java}
> {"id": "1", "name": {"add": "Janet Doe", "remove": "Jane Doe"}}{code}
> {{This atomic update that does both an `add` and a `remove` is something that 
> used to work for us under Solr 6.6, but we just noticed that it fails in our 
> production 9.5 instance and in 9.6, which I just downloaded to test against.}}
> {{The error in the solr.log indicates that Solr mistakenly interprets the 
> `\{"add": "Janet Doe", "remove": "Jane Doe"}` as a nested document and then 
> throws an exception because our schema doesn't have the `{_}root{_}` field 
> that would be expected if we were using nested docs (which we don't use).}}
> {{Here's the full stack trace from `solr.log` (version 9.6.0):}}
> {noformat}
> 2024-05-01 17:49:02.479 ERROR (qtp2059461664-30-0.0.0.0-3) [c: s: r: x:atris 
> t:0.0.0.0-3] o.a.s.h.RequestHandlerBase Client exception => 
> org.apache.solr.common.SolrException: Unable to index docs with children: the 
> schema must include definitions for both a uniqueKey field and the '_root_' 
> field, using the exact same fieldType
>         at 
> org.apache.solr.update.DocumentBuilder.unexpectedNestedDocException(DocumentBuilder.java:369)
> org.apache.solr.common.SolrException: Unable to index docs with children: the 
> schema must include definitions for both a uniqueKey field and the '_root_' 
> field, using the exact same fieldType
>         at 
> org.apache.solr.update.DocumentBuilder.unexpectedNestedDocException(DocumentBuilder.java:369)
>  ~[?:?]
>         at 
> org.apache.solr.update.DocumentBuilder.toDocument(DocumentBuilder.java:153) 
> ~[?:?]
>         at 
> org.apache.solr.update.AddUpdateCommand.makeLuceneDocs(AddUpdateCommand.java:213)
>  ~[?:?]
>         at 
> org.apache.solr.update.DirectUpdateHandler2.updateDocOrDocValues(DirectUpdateHandler2.java:1056)
>  ~[?:?]
>         at 
> org.apache.solr.update.DirectUpdateHandler2.doNormalUpdate(DirectUpdateHandler2.java:421)
>  ~[?:?]
>         at 
> org.apache.solr.update.DirectUpdateHandler2.addDoc0(DirectUpdateHandler2.java:375)
>  ~[?:?]
>         at 
> org.apache.solr.update.DirectUpdateHandler2.addDoc(DirectUpdateHandler2.java:312)
>  ~[?:?]
>         at 
> org.apache.solr.update.processor.RunUpdateProcessorFactory$RunUpdateProcessor.processAdd(RunUpdateProcessorFactory.java:76)
>  ~[?:?]
>         at 
> org.apache.solr.update.processor.UpdateRequestProcessor.processAdd(UpdateRequestProcessor.java:54)
>  ~[?:?]
>         at 
> 

[jira] [Updated] (SOLR-17274) atomic update error when using json w/ multiple modifiers

2024-05-04 Thread David Smiley (Jira)


 [ 
https://issues.apache.org/jira/browse/SOLR-17274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated SOLR-17274:

Component/s: update
 (was: UpdateRequestProcessors)

> atomic update error when using json w/ multiple modifiers
> -
>
> Key: SOLR-17274
> URL: https://issues.apache.org/jira/browse/SOLR-17274
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: update
>Affects Versions: 9.0, 9.1, 9.2, 9.3, 9.4, 9.5, 9.6
> Environment: Observed first in 9.5.0 w/ OpenJDK 11, then reproduced 
> this simple test case in 9.6.0.
>Reporter: Calvin Smith
>Priority: Major
>
> I ran into a problem doing a json atomic update that tries to both `add` and 
> `remove` a value for a multivalued field in a single update. I saw it 
> initially in an instance that runs 9.5.0, and reproduced a minimal example 
> using Solr 9.6.0.
> {{The only fields defined in the schema are:}}
> {code:java}
>    required="true" stored="true"/>
>   
>   {code}
> {{`id` is also present, so I'm supplying docs with 
> just an `id` and a multivalued `name` field. The real setup is more complex, 
> but this is a minimal test case to illustrate the problem.}}
> {{Starting with an empty index, I add the following doc to the index 
> successfully:}}
> {code:java}
> {"id": "1", "name": ["John Doe", "Jane Doe"]}{code}
> {{And I can query it, seeing the expected result:}}
> {code:java}
> {
>   "responseHeader":{
>     "status":0,
>     "QTime":23,
>     "params":{
>       "q":"name:*"
>     }
>   },
>   "response":{
>     "numFound":1,
>     "start":0,
>     "numFoundExact":true,
>     "docs":[{
>       "id":"1",
>       "name":["John Doe","Jane Doe"],
>       "_version_":1797873599884820480
>     }]
>   }
> }{code}
> {{Next, I send an atomic update to modify the `name` field of that document 
> by removing `Jane Doe` and adding `Janet Doe`:}}
> {code:java}
> {"id": "1", "name": {"add": "Janet Doe", "remove": "Jane Doe"}}{code}
> {{This atomic update that does both an `add` and a `remove` is something that 
> used to work for us under Solr 6.6, but we just noticed that it fails in our 
> production 9.5 instance and in 9.6, which I just downloaded to test against.}}
> {{The error in the solr.log indicates that Solr mistakenly interprets the 
> `\{"add": "Janet Doe", "remove": "Jane Doe"}` as a nested document and then 
> throws an exception because our schema doesn't have the `{_}root{_}` field 
> that would be expected if we were using nested docs (which we don't use).}}
> {{Here's the full stack trace from `solr.log` (version 9.6.0):}}
> {noformat}
> 2024-05-01 17:49:02.479 ERROR (qtp2059461664-30-0.0.0.0-3) [c: s: r: x:atris 
> t:0.0.0.0-3] o.a.s.h.RequestHandlerBase Client exception => 
> org.apache.solr.common.SolrException: Unable to index docs with children: the 
> schema must include definitions for both a uniqueKey field and the '_root_' 
> field, using the exact same fieldType
>         at 
> org.apache.solr.update.DocumentBuilder.unexpectedNestedDocException(DocumentBuilder.java:369)
> org.apache.solr.common.SolrException: Unable to index docs with children: the 
> schema must include definitions for both a uniqueKey field and the '_root_' 
> field, using the exact same fieldType
>         at 
> org.apache.solr.update.DocumentBuilder.unexpectedNestedDocException(DocumentBuilder.java:369)
>  ~[?:?]
>         at 
> org.apache.solr.update.DocumentBuilder.toDocument(DocumentBuilder.java:153) 
> ~[?:?]
>         at 
> org.apache.solr.update.AddUpdateCommand.makeLuceneDocs(AddUpdateCommand.java:213)
>  ~[?:?]
>         at 
> org.apache.solr.update.DirectUpdateHandler2.updateDocOrDocValues(DirectUpdateHandler2.java:1056)
>  ~[?:?]
>         at 
> org.apache.solr.update.DirectUpdateHandler2.doNormalUpdate(DirectUpdateHandler2.java:421)
>  ~[?:?]
>         at 
> org.apache.solr.update.DirectUpdateHandler2.addDoc0(DirectUpdateHandler2.java:375)
>  ~[?:?]
>         at 
> org.apache.solr.update.DirectUpdateHandler2.addDoc(DirectUpdateHandler2.java:312)
>  ~[?:?]
>         at 
> org.apache.solr.update.processor.RunUpdateProcessorFactory$RunUpdateProcessor.processAdd(RunUpdateProcessorFactory.java:76)
>  ~[?:?]
>         at 
> org.apache.solr.update.processor.UpdateRequestProcessor.processAdd(UpdateRequestProcessor.java:54)
>  ~[?:?]
>         at 
> org.apache.solr.update.processor.DistributedUpdateProcessor.doLocalAdd(DistributedUpdateProcessor.java:270)
>  ~[?:?]
>         at 
> org.apache.solr.update.processor.DistributedUpdateProcessor.doVersionAdd(DistributedUpdateProcessor.java:533)
>  ~[?:?]
>         at 
> org.apache.solr.update.processor.DistributedUpdateProcessor.lambda$versionAdd$0(DistributedUpdateProcessor.java:358)
>  

[PR] Update dependency jakarta.ws.rs:jakarta.ws.rs-api to v4 [solr]

2024-05-04 Thread via GitHub


solrbot opened a new pull request, #2441:
URL: https://github.com/apache/solr/pull/2441

   This PR contains the following updates:
   
   | Package | Type | Update | Change |
   |---|---|---|---|
   | [jakarta.ws.rs:jakarta.ws.rs-api](https://togithub.com/jakartaee/rest) | 
dependencies | major | `3.1.0` -> `4.0.0` |
   
   ---
   
   ### Configuration
   
    **Schedule**: Branch creation - "* * * * 0" (UTC), Automerge - At any time 
(no schedule defined).
   
    **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
    **Ignore**: Close this PR and you won't be reminded about this update 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Renovate 
Bot](https://togithub.com/solrbot/renovate-github-action)
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



[PR] Update dependency org.semver4j:semver4j to v5.3.0 [solr]

2024-05-04 Thread via GitHub


solrbot opened a new pull request, #2440:
URL: https://github.com/apache/solr/pull/2440

   This PR contains the following updates:
   
   | Package | Type | Update | Change |
   |---|---|---|---|
   | [org.semver4j:semver4j](https://togithub.com/semver4j/semver4j) | 
dependencies | minor | `5.2.3` -> `5.3.0` |
   
   ---
   
   ### Release Notes
   
   
   semver4j/semver4j (org.semver4j:semver4j)
   
   ### [`v5.3.0`](https://togithub.com/semver4j/semver4j/releases/tag/v5.3.0)
   
    What's Changed
   
    荒 Bug Fixes
   
   -   ([#244](https://togithub.com/semver4j/semver4j/issues/244)) 
Prerelease check improvements by 
[@severn-everett](https://togithub.com/severn-everett)
   -   ([#238](https://togithub.com/semver4j/semver4j/issues/238)) 
Fixing trailing non-numerical character parsing issue by 
[@severn-everett](https://togithub.com/severn-everett)
   
     Features
   
   -   ([#252](https://togithub.com/semver4j/semver4j/issues/252)) 
Introduce formatter methods to customize version output by 
[@piotrooo](https://togithub.com/piotrooo)
   -   ([#242](https://togithub.com/semver4j/semver4j/issues/242)) 
Introduce a Semver.of method for basic creation by 
[@piotrooo](https://togithub.com/piotrooo)
   -   ([#233](https://togithub.com/semver4j/semver4j/issues/233)) 
Introduce a `Semver.Builder` by 
[@piotrooo](https://togithub.com/piotrooo)
   
     Refactor
   
   -   ([#240](https://togithub.com/semver4j/semver4j/issues/240)) 
Conversion of internal package classes to use static only by 
[@severn-everett](https://togithub.com/severn-everett)
   
    粒 Housekeeping
   
   -   ([#232](https://togithub.com/semver4j/semver4j/issues/232)) 
Cleanup unnecessary Javadoc by [@piotrooo](https://togithub.com/piotrooo)
   
     Dependency Updates
   
   
   6 changes
   
   -   ([#251](https://togithub.com/semver4j/semver4j/issues/251)) Bump 
org.apache.maven.plugins:maven-jar-plugin from 3.4.0 to 3.4.1 by 
[@dependabot](https://togithub.com/dependabot)
   -   ([#250](https://togithub.com/semver4j/semver4j/issues/250)) Bump 
org.apache.maven.plugins:maven-gpg-plugin from 3.2.3 to 3.2.4 by 
[@dependabot](https://togithub.com/dependabot)
   -   ([#249](https://togithub.com/semver4j/semver4j/issues/249)) Bump 
peter-evans/create-pull-request from 6.0.3 to 6.0.4 by 
[@dependabot](https://togithub.com/dependabot)
   -   ([#247](https://togithub.com/semver4j/semver4j/issues/247)) Bump 
org.apache.maven.plugins:maven-jar-plugin from 3.3.0 to 3.4.0 by 
[@dependabot](https://togithub.com/dependabot)
   -   ([#246](https://togithub.com/semver4j/semver4j/issues/246)) Bump 
peter-evans/create-pull-request from 6.0.2 to 6.0.3 by 
[@dependabot](https://togithub.com/dependabot)
   -   ([#245](https://togithub.com/semver4j/semver4j/issues/245)) Bump 
org.apache.maven.plugins:maven-gpg-plugin from 3.2.2 to 3.2.3 by 
[@dependabot](https://togithub.com/dependabot)
   
   
   
   
   
   ---
   
   ### Configuration
   
    **Schedule**: Branch creation - "* * * * 0" (UTC), Automerge - At any time 
(no schedule defined).
   
    **Automerge**: Disabled by config. Please merge this manually once you are 
satisfied.
   
   ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry 
checkbox.
   
    **Ignore**: Close this PR and you won't be reminded about this update 
again.
   
   ---
   
- [ ] If you want to rebase/retry this PR, check this 
box
   
   ---
   
   This PR has been generated by [Renovate 
Bot](https://togithub.com/solrbot/renovate-github-action)
   

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] SOLR-15582: Remove deprecated APIs in solrj Tuple class. [solr]

2024-05-04 Thread via GitHub


github-actions[bot] commented on PR #257:
URL: https://github.com/apache/solr/pull/257#issuecomment-2094505471

   This PR had no visible activity in the past 60 days, labeling it as stale. 
Any new activity will remove the stale label. To attract more reviewers, please 
tag someone or notify the d...@solr.apache.org mailing list. Thank you for your 
contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] SOLR-15689: add PeerSyncTest.missedUpdatesFinderTests() [solr]

2024-05-04 Thread via GitHub


github-actions[bot] commented on PR #343:
URL: https://github.com/apache/solr/pull/343#issuecomment-2094505466

   This PR had no visible activity in the past 60 days, labeling it as stale. 
Any new activity will remove the stale label. To attract more reviewers, please 
tag someone or notify the d...@solr.apache.org mailing list. Thank you for your 
contribution!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



[jira] [Comment Edited] (SOLR-15484) Frequent test failures for JWTAuthPluginIntegrationTest

2024-05-04 Thread Sanjay Dutt (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843423#comment-17843423
 ] 

Sanjay Dutt edited comment on SOLR-15484 at 5/4/24 10:42 AM:
-

*This test failed again:-*
 
{code:java}
   44056 INFO 
(TEST-JWTAuthPluginIntegrationTest.mockOAuth2Server-seed#[F98DD07D54DABA29]) 
[n: c: s: r: x: t:] o.a.s.SolrTestCaseJ4 ###Ending mockOAuth2Server6149 > 
org.junit.ComparisonFailure: Should have received 401 code expected:<[401]> but 
was:<[200]>6150 > at 
__randomizedtesting.SeedInfo.seed([F98DD07D54DABA29:7E8D312D316646C5]:0)
6151 > at org.junit.Assert.assertEquals(Assert.java:117)6152 > at 
org.apache.solr.security.jwt.JWTAuthPluginIntegrationTest.mockOAuth2Server(JWTAuthPluginIntegrationTest.java:145)
6153 > at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)  
  6154 > at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
6155 > at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
6156 > at java.base/java.lang.reflect.Method.invoke(Method.java:566)
6157 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
6158 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
6159 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
6160 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
6161 > at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:80)
6162 > at org.junit.rules.RunRules.evaluate(RunRules.java:20)   

{code}
 

Also there are bunch of other classMethod failures, because of resource leak. 
Once assert failed it did not shutdown the cluster. Two ways to solved it, 
either the whole test block should be inside the try block and in finally we 
should shutdown the cluster. Or, use the existing cluster reference from 
SolrCloudTestCase and that will take care of shutting down the cluster.
 

https://github.com/apache/solr/pull/2373


was (Author: duttsanjay):
*This test failed again:-*
 
{code:java}
   44056 INFO 
(TEST-JWTAuthPluginIntegrationTest.mockOAuth2Server-seed#[F98DD07D54DABA29]) 
[n: c: s: r: x: t:] o.a.s.SolrTestCaseJ4 ###Ending mockOAuth2Server6149 > 
org.junit.ComparisonFailure: Should have received 401 code expected:<[401]> but 
was:<[200]>6150 > at 
__randomizedtesting.SeedInfo.seed([F98DD07D54DABA29:7E8D312D316646C5]:0)
6151 > at org.junit.Assert.assertEquals(Assert.java:117)6152 > at 
org.apache.solr.security.jwt.JWTAuthPluginIntegrationTest.mockOAuth2Server(JWTAuthPluginIntegrationTest.java:145)
6153 > at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)  
  6154 > at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
6155 > at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
6156 > at java.base/java.lang.reflect.Method.invoke(Method.java:566)
6157 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
6158 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
6159 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
6160 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
6161 > at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:80)
6162 > at org.junit.rules.RunRules.evaluate(RunRules.java:20)   

{code}
 

Also there are bunch of other classMethod failures, because of resource leak. 
Once assert failed it did not shutdown the cluster. Two ways to solved it, 
either the whole test block should be inside the try block and in finally we 
should shutdown the cluster. Or, use the existing cluster reference from 
SolrCloudTestCase and that will take care of shutting down the cluster.
 

> Frequent test failures for JWTAuthPluginIntegrationTest
> ---
>
> Key: SOLR-15484
> URL: https://issues.apache.org/jira/browse/SOLR-15484
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
>Priority: Major
> Fix For: 9.5
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Example:
> Build: [https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/1053/]
> {code}
> 1 tests failed.
> FAILED:  
> 

Re: [PR] Update dependency io.swagger.core.v3:swagger-annotations-jakarta to v2.2.21 [solr]

2024-05-04 Thread via GitHub


iamsanjay commented on PR #2373:
URL: https://github.com/apache/solr/pull/2373#issuecomment-2094115387

   This test failed again:-
   ``` 
   44056 INFO 
(TEST-JWTAuthPluginIntegrationTest.mockOAuth2Server-seed#[F98DD07D54DABA29]) 
[n: c: s: r: x: t:] o.a.s.SolrTestCaseJ4 ###Ending mockOAuth2Server6149 > 
org.junit.ComparisonFailure: Should have received 401 code expected:<[401]> but 
was:<[200]>6150 > at 
__randomizedtesting.SeedInfo.seed([F98DD07D54DABA29:7E8D312D316646C5]:0)
6151 > at 
   org.junit.Assert.assertEquals(Assert.java:117)6152 > at 
   
org.apache.solr.security.jwt.JWTAuthPluginIntegrationTest.mockOAuth2Server(JWTAuthPluginIntegrationTest.java:145)

   6153 > at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)  
  6154 > at 
   
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
6155 > at 
   
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
6156 > at 
   java.base/java.lang.reflect.Method.invoke(Method.java:566)6157 > at 
   
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
6158 > at 
   
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
6159 > at 
   
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
6160 > at 
   
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
6161 > at 
   
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:80)

   6162 > at org.junit.rules.RunRules.evaluate(RunRules.java:20)   
   ```

   
   Also there are bunch of other classMethod failures, because of resource 
leak. Once assert failed it did not shutdown the cluster. Two ways to solved 
it, either the whole test block should be inside the try block and in finally 
we should shutdown the cluster. Or, use the existing cluster reference from 
SolrCloudTestCase and that will take care of shutting down the cluster.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



[jira] [Commented] (SOLR-15484) Frequent test failures for JWTAuthPluginIntegrationTest

2024-05-04 Thread Sanjay Dutt (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843423#comment-17843423
 ] 

Sanjay Dutt commented on SOLR-15484:


*This test failed again:-*
 
{code:java}
   44056 INFO 
(TEST-JWTAuthPluginIntegrationTest.mockOAuth2Server-seed#[F98DD07D54DABA29]) 
[n: c: s: r: x: t:] o.a.s.SolrTestCaseJ4 ###Ending mockOAuth2Server6149 > 
org.junit.ComparisonFailure: Should have received 401 code expected:<[401]> but 
was:<[200]>6150 > at 
__randomizedtesting.SeedInfo.seed([F98DD07D54DABA29:7E8D312D316646C5]:0)
6151 > at org.junit.Assert.assertEquals(Assert.java:117)6152 > at 
org.apache.solr.security.jwt.JWTAuthPluginIntegrationTest.mockOAuth2Server(JWTAuthPluginIntegrationTest.java:145)
6153 > at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)  
  6154 > at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
6155 > at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
6156 > at java.base/java.lang.reflect.Method.invoke(Method.java:566)
6157 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
6158 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
6159 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
6160 > at 
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
6161 > at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:80)
6162 > at org.junit.rules.RunRules.evaluate(RunRules.java:20)   

{code}
 

Also there are bunch of other classMethod failures, because of resource leak. 
Once assert failed it did not shutdown the cluster. Two ways to solved it, 
either the whole test block should be inside the try block and in finally we 
should shutdown the cluster. Or, use the existing cluster reference from 
SolrCloudTestCase and that will take care of shutting down the cluster.
 

> Frequent test failures for JWTAuthPluginIntegrationTest
> ---
>
> Key: SOLR-15484
> URL: https://issues.apache.org/jira/browse/SOLR-15484
> Project: Solr
>  Issue Type: Bug
>Affects Versions: 9.0
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
>Priority: Major
> Fix For: 9.5
>
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> Example:
> Build: [https://ci-builds.apache.org/job/Solr/job/Solr-Check-main/1053/]
> {code}
> 1 tests failed.
> FAILED:  
> org.apache.solr.security.JWTAuthPluginIntegrationTest.mockOAuth2Server
> Error Message:
> org.junit.ComparisonFailure: Should have received 401 code expected:<[401]> 
> but was:<[200]>
> Stack Trace:
> org.junit.ComparisonFailure: Should have received 401 code expected:<[401]> 
> but was:<[200]>
>  at __randomizedtesting.SeedInfo.seed([7827798BF4D91EFE:FF2798DB9165E212]:0)
>  at org.junit.Assert.assertEquals(Assert.java:117)
>  at 
> org.apache.solr.security.JWTAuthPluginIntegrationTest.mockOAuth2Server(JWTAuthPluginIntegrationTest.java:143)
> ...
> {code}
> The other test failure is
> {code}
> org.apache.solr.security.JWTAuthPluginTest.initWithInvalidTrustedCertsFile
> Failing for the past 1 build (Since #924 )
> Took 7 ms.
> Error Message
> junit.framework.AssertionFailedError: Expected exception SolrException but no 
> exception was thrown
> Stacktrace
> junit.framework.AssertionFailedError: Expected exception SolrException but no 
> exception was thrown
>   at 
> __randomizedtesting.SeedInfo.seed([8651FF5FA6DE29A1:91C33C9AFD0459B5]:0)
>   at 
> org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2863)
>   at 
> org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2849)
>   at 
> org.apache.solr.security.JWTAuthPluginTest.initWithInvalidTrustedCertsFile(JWTAuthPluginTest.java:521)
> ...
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org