pjmcarthur opened a new pull request, #2335:
URL: https://github.com/apache/solr/pull/2335
https://issues.apache.org/jira/browse/SOLR-17198
# Description
Collection Handler operations that use the Affinity placement plugin (Create
Collection, Split Shard, Delete Replica) may fail if the AttributeFetcher finds
that multiple replicas claim to be the leader for a shard. This scenario may
occur if shard leadership changes while the AttributeFetcher is requesting
metrics from each node.
# Solution
For the use case it is fulfilling (fetching replica metrics like index size,
query rate or update rate, the AttributeFetcher should not care if multiple
replicas claim to be the leader. Each one is capable of supplying the required
metric values. This PR replaces the exception with a log message, and accepts
one of the replicas as shard leader, which will supply the metrics.
# Tests
Added CollectionMetricsBuilderTest to verify behavior when the are multiple
shard leaders and no shard leaders (this latter case already does not fail, it
simply supplies no metrics).
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my
code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request
title.
- [x] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Reference
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
