Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-02 Thread via GitHub


HoustonPutman commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2091267170

   Fair enough. We will let it bake then backport both.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-02 Thread via GitHub


dsmiley commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2091201004

   The approach seen here is perfect -- bake something risky in main _then_ 
bring to branch_9x.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-02 Thread via GitHub


HoustonPutman commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2091147056

   Why isn't any of this PRS testing logic backported to 9x @noblepaul ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-01 Thread via GitHub


HoustonPutman commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2088918365

   Ok created a PR to fix this, I'm not sure what the logic here was supposed 
to be, but I've changed PRS to be a much more normal per-test-class randomized 
option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-01 Thread via GitHub


gus-asf commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2088385840

   Neither this PR nor the commit mention a jira so I'll drop this here: 
https://issues.apache.org/jira/browse/SOLR-17265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-01 Thread via GitHub


gerlowskija commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2088376107

   +1 I spent a bunch of time on this this morning after running into 
OverseerStatusTest failures on main, before stumbling on this discussion.  Any 
chance you're able to investigate further @noblepaul ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-04-22 Thread via GitHub


dsmiley commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2070113298

   @noblepaul OverseerStatusTest still fails occasionally :-(  A number of 
people have bumped into it and maybe wasted some time trying to figure out what 
happened.  Something has to be done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-03-15 Thread via GitHub


dsmiley commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2001627945

   And LocalFSCloudIncrementalBackupTest
   
https://ge.apache.org/scans/tests?search.relativeStartTime=P90D=solr-root=America%2FNew_York=org.apache.solr.cloud.api.collections.LocalFSCloudIncrementalBackupTest
   
   Gradle Enterprise does a nice job of visualizing recent failure trends.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-03-15 Thread via GitHub


dsmiley commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-2001603190

   TestLocalFSCloudBackupRestore failures seems plausibly related as its 
failures begin at the same time:
   
https://ge.apache.org/scans/tests?search.relativeStartTime=P90D=solr-root=America%2FNew_York=*TestLocalFSCloudBackupRestore
 Maybe only 2-3% fail


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-03-07 Thread via GitHub


dsmiley commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-1984571357

   BTW it's nice to see PRS used/tested more :-)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-03-07 Thread via GitHub


dsmiley commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-1984524318

   I believe this has caused NullPointerExceptions in OverseerStatusTest -- 
createcollection is null.  Quite a number of test failures for this since this 
was merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



Re: [PR] Use a System wide property to enable PRS [solr]

2024-02-20 Thread via GitHub


noblepaul merged PR #2230:
URL: https://github.com/apache/solr/pull/2230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org