[jira] [Comment Edited] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState
[ https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834569#comment-17834569 ] Aparna Suresh edited comment on SOLR-17153 at 4/6/24 9:36 PM: -- Hi [~epugh] , I have not reproduced the issue you reported. However, I've implemented a check to verify if the 'collectionsList' is empty in any case as part of [GitHub Pull Request #2392|https://github.com/apache/solr/pull/2392]. Please let me know. was (Author: JIRAUSER302780): Hi [~epugh] , I have not reproduced the issue you reported. However, I've implemented a check to verify if the 'collectionsList' is empty in any case. Please let me know. > CloudSolrClient should not throw "Collection not found" with an out-dated > ClusterState > -- > > Key: SOLR-17153 > URL: https://issues.apache.org/jira/browse/SOLR-17153 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > Today, CloudSolrClient will locally fail if it's asked to send a request to a > collection that it thinks does not exist due to its local ClusterState view > being out-of-date. We shouldn't fail! And most SolrCloud tests should then > remove their waitForState calls that follow collection creation! Other stale > state matters are out-of-scope. > Proposal: CloudSolrClient shouldn't try and be too smart. Always route a > request to Solr (any node); don't presume its state is up-to-date. Maybe, > after a response is received, it can check if its state has been updated and > if not then explicitly get a new state. Or not if that's too complicated. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Comment Edited] (SOLR-17153) CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState
[ https://issues.apache.org/jira/browse/SOLR-17153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834416#comment-17834416 ] Eric Pugh edited comment on SOLR-17153 at 4/5/24 7:06 PM: -- I am seeing errors in main that I think are from this commit. bin/solr start -c and then pull up the Solr Admin UI and you get an exception. ``` java.lang.IndexOutOfBoundsException: Index: 0\n\tat java.base/java.util.Collections$EmptyList.get(Collections.java:4481)\n\tat org.apache.solr.servlet.HttpSolrCall.resolveDocCollection(HttpSolrCall.java:363)\n\tat org.apache.solr.servlet.HttpSolrCall.init(HttpSolrCall.java:286) ``` Removing this commit restores the Admin UI to loading. was (Author: epugh): I am seeing errors in main that I think are from this commit. bin/solr start -c and then pull up the Solr Admin UI and you get an exception. ``` java.lang.IndexOutOfBoundsException: Index: 0\n\tat java.base/java.util.Collections$EmptyList.get(Collections.java:4481)\n\tat org.apache.solr.servlet.HttpSolrCall.resolveDocCollection(HttpSolrCall.java:363)\n\tat org.apache.solr.servlet.HttpSolrCall.init(HttpSolrCall.java:286) ``` > CloudSolrClient should not throw "Collection not found" with an out-dated > ClusterState > -- > > Key: SOLR-17153 > URL: https://issues.apache.org/jira/browse/SOLR-17153 > Project: Solr > Issue Type: Improvement > Components: SolrJ >Reporter: David Smiley >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > Today, CloudSolrClient will locally fail if it's asked to send a request to a > collection that it thinks does not exist due to its local ClusterState view > being out-of-date. We shouldn't fail! And most SolrCloud tests should then > remove their waitForState calls that follow collection creation! Other stale > state matters are out-of-scope. > Proposal: CloudSolrClient shouldn't try and be too smart. Always route a > request to Solr (any node); don't presume its state is up-to-date. Maybe, > after a response is received, it can check if its state has been updated and > if not then explicitly get a new state. Or not if that's too complicated. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
