[jira] [Commented] (SOLR-17233) The parameters of q.op are recommended to be trim()

2024-04-17 Thread ichar (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838437#comment-17838437
 ] 

ichar commented on SOLR-17233:
--

[~epugh] First of all, thank you for reviewing this pr, the reason is that the 
user's access is the wrong parameter, resulting in q.IP does not take effect, 
as for how to fix, I think we can directly determine whether the value taken 
out is equal to "AND" or "OR", if it is not equal, we can directly throw an 
error, so that the user can find the problem in the test stage.

> The parameters of q.op are recommended to be trim()
> ---
>
> Key: SOLR-17233
> URL: https://issues.apache.org/jira/browse/SOLR-17233
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: SolrCloud
>Reporter: ichar
>Priority: Minor
> Attachments: image-2024-04-16-14-46-12-603.png
>
>
> !image-2024-04-16-14-46-12-603.png|width=301,height=265!
> The expected result should be empty, but this was found out. The reason is 
> that the parameter "and" of q.op (with an extra space) is taken out and the 
> judgment of "and" is different.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org



[jira] [Commented] (SOLR-17233) The parameters of q.op are recommended to be trim()

2024-04-16 Thread Eric Pugh (Jira)


[ 
https://issues.apache.org/jira/browse/SOLR-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837700#comment-17837700
 ] 

Eric Pugh commented on SOLR-17233:
--

I'd be happy to review a PR for fixing this   I wonder if we need to have 
better handling of all parameter parsing...  Curious how the space got in in 
the very first place?

> The parameters of q.op are recommended to be trim()
> ---
>
> Key: SOLR-17233
> URL: https://issues.apache.org/jira/browse/SOLR-17233
> Project: Solr
>  Issue Type: Improvement
>  Security Level: Public(Default Security Level. Issues are Public) 
>  Components: SolrCloud
>Reporter: ichar
>Priority: Minor
> Attachments: image-2024-04-16-14-46-12-603.png
>
>
> !image-2024-04-16-14-46-12-603.png|width=301,height=265!
> The expected result should be empty, but this was found out. The reason is 
> that the parameter "and" of q.op (with an extra space) is taken out and the 
> judgment of "and" is different.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org