[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-07 Thread Ishan Chattopadhyaya (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844308#comment-17844308
 ] 

Ishan Chattopadhyaya commented on SOLR-17278:
-

Fwiw, it is a useless suggestion. 

> Timezone with DST=true and DST=0 fails test
> ---
>
> Key: SOLR-17278
> URL: https://issues.apache.org/jira/browse/SOLR-17278
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Ishan Chattopadhyaya
>Priority: Major
> Fix For: 9.7
>
> Attachments: SOLR-17278-1.patch, SOLR-17278.patch
>
>
> The TimeZoneUtilsTest#testValidIds() fails with some timezones that have 
> useDaylightTime() as true but getDSTSavings() returns 0. Such timezones can't 
> be converted to String using String.valueOf().
> Here's my JVM:
> {code}
> [ishan@deskmini solr] $ java -version
> openjdk version "11.0.22" 2024-01-16
> OpenJDK Runtime Environment (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7, mixed 
> mode, sharing)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-07 Thread Ishan Chattopadhyaya (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844306#comment-17844306
 ] 

Ishan Chattopadhyaya commented on SOLR-17278:
-

Ouch, I didn't check for it. I checked with `gradlew check` several times. 
I can get to this only tomorrow. Sorry for the inconvenience.

> Timezone with DST=true and DST=0 fails test
> ---
>
> Key: SOLR-17278
> URL: https://issues.apache.org/jira/browse/SOLR-17278
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Ishan Chattopadhyaya
>Priority: Major
> Fix For: 9.7
>
> Attachments: SOLR-17278-1.patch, SOLR-17278.patch
>
>
> The TimeZoneUtilsTest#testValidIds() fails with some timezones that have 
> useDaylightTime() as true but getDSTSavings() returns 0. Such timezones can't 
> be converted to String using String.valueOf().
> Here's my JVM:
> {code}
> [ishan@deskmini solr] $ java -version
> openjdk version "11.0.22" 2024-01-16
> OpenJDK Runtime Environment (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7, mixed 
> mode, sharing)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-07 Thread Eric Pugh (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844277#comment-17844277
 ] 

Eric Pugh commented on SOLR-17278:
--

I think this commit broke errorprone?   I am seeing:

 
 Task :solr:core:compileTestJava FAILED 
 
/home/runner/work/solr/solr/solr/core/src/test/org/apache/solr/util/TimeZoneUtilsTest.java:65:
 warning: [OperatorPrecedence] Use grouping parenthesis to make the operator 
precedence explicit 
 
 if (expected.useDaylightTime() && expected.getDSTSavings() == 0 
 
 ^ 
 
 (see [https://errorprone.info/bugpattern/OperatorPrecedence)] 
 
 Did you mean 'if ((expected.useDaylightTime() && expected.getDSTSavings() == 
0)'? 
 
/home/runner/work/solr/solr/solr/core/src/test/org/apache/solr/util/TimeZoneUtilsTest.java:66:
 warning: [OperatorPrecedence] Use grouping parenthesis to make the operator 
precedence explicit 
 
 || actual.useDaylightTime() && actual.getDSTSavings() == 0) { 
 
 ^ 
 
 (see [https://errorprone.info/bugpattern/OperatorPrecedence)] 
 
 Did you mean '|| (actual.useDaylightTime() && actual.getDSTSavings() == 0)) 
{'? 
 
error: warnings found and -Werror specified

> Timezone with DST=true and DST=0 fails test
> ---
>
> Key: SOLR-17278
> URL: https://issues.apache.org/jira/browse/SOLR-17278
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Ishan Chattopadhyaya
>Priority: Major
> Fix For: 9.7
>
> Attachments: SOLR-17278-1.patch, SOLR-17278.patch
>
>
> The TimeZoneUtilsTest#testValidIds() fails with some timezones that have 
> useDaylightTime() as true but getDSTSavings() returns 0. Such timezones can't 
> be converted to String using String.valueOf().
> Here's my JVM:
> {code}
> [ishan@deskmini solr] $ java -version
> openjdk version "11.0.22" 2024-01-16
> OpenJDK Runtime Environment (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7, mixed 
> mode, sharing)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843860#comment-17843860
 ] 

ASF subversion and git services commented on SOLR-17278:


Commit cc095cc176c838694f150d0e13dbf650924e955a in solr's branch 
refs/heads/branch_9x from Ishan Chattopadhyaya
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=cc095cc176c ]

SOLR-17278: Skip broken timezones in the test


> Timezone with DST=true and DST=0 fails test
> ---
>
> Key: SOLR-17278
> URL: https://issues.apache.org/jira/browse/SOLR-17278
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Ishan Chattopadhyaya
>Priority: Major
> Attachments: SOLR-17278-1.patch, SOLR-17278.patch
>
>
> The TimeZoneUtilsTest#testValidIds() fails with some timezones that have 
> useDaylightTime() as true but getDSTSavings() returns 0. Such timezones can't 
> be converted to String using String.valueOf().
> Here's my JVM:
> {code}
> [ishan@deskmini solr] $ java -version
> openjdk version "11.0.22" 2024-01-16
> OpenJDK Runtime Environment (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7, mixed 
> mode, sharing)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843859#comment-17843859
 ] 

ASF subversion and git services commented on SOLR-17278:


Commit d5b82412d8729a6bfa8056e7000a5a7be0b9b86e in solr's branch 
refs/heads/main from Ishan Chattopadhyaya
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=d5b82412d87 ]

SOLR-17278: Skip broken timezones in the test


> Timezone with DST=true and DST=0 fails test
> ---
>
> Key: SOLR-17278
> URL: https://issues.apache.org/jira/browse/SOLR-17278
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Ishan Chattopadhyaya
>Priority: Major
> Attachments: SOLR-17278-1.patch, SOLR-17278.patch
>
>
> The TimeZoneUtilsTest#testValidIds() fails with some timezones that have 
> useDaylightTime() as true but getDSTSavings() returns 0. Such timezones can't 
> be converted to String using String.valueOf().
> Here's my JVM:
> {code}
> [ishan@deskmini solr] $ java -version
> openjdk version "11.0.22" 2024-01-16
> OpenJDK Runtime Environment (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7, mixed 
> mode, sharing)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread Ishan Chattopadhyaya (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843858#comment-17843858
 ] 

Ishan Chattopadhyaya commented on SOLR-17278:
-

FYI, the tzdb.dat that's on my system came from Fedora Project 39.
/usr/lib/jvm/java-11-openjdk-11.0.22.0.7-1.fc39.x86_64/lib/tzdb.dat

> Timezone with DST=true and DST=0 fails test
> ---
>
> Key: SOLR-17278
> URL: https://issues.apache.org/jira/browse/SOLR-17278
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Ishan Chattopadhyaya
>Priority: Major
> Attachments: SOLR-17278-1.patch, SOLR-17278.patch
>
>
> The TimeZoneUtilsTest#testValidIds() fails with some timezones that have 
> useDaylightTime() as true but getDSTSavings() returns 0. Such timezones can't 
> be converted to String using String.valueOf().
> Here's my JVM:
> {code}
> [ishan@deskmini solr] $ java -version
> openjdk version "11.0.22" 2024-01-16
> OpenJDK Runtime Environment (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7, mixed 
> mode, sharing)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

[jira] [Commented] (SOLR-17278) Timezone with DST=true and DST=0 fails test

2024-05-06 Thread Ishan Chattopadhyaya (Jira) 


[ 
https://issues.apache.org/jira/browse/SOLR-17278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843854#comment-17843854
 ] 

Ishan Chattopadhyaya commented on SOLR-17278:
-

{code}
1168 WARN  (TEST-TimeZoneUtilsTest.testValidIds-seed#[FC7EEBC60D14381D]) [n: c: 
s: r: x: t:] o.a.s.u.TimeZoneUtilsTest Not expecting DST to be 0 for Eastern 
European Standard Time  (actual: Eastern European Standard Time)
1169 WARN  (TEST-TimeZoneUtilsTest.testValidIds-seed#[FC7EEBC60D14381D]) [n: c: 
s: r: x: t:] o.a.s.u.TimeZoneUtilsTest Not expecting DST to be 0 for Eastern 
European Standard Time  (actual: Eastern European Standard Time)
{code}

> Timezone with DST=true and DST=0 fails test
> ---
>
> Key: SOLR-17278
> URL: https://issues.apache.org/jira/browse/SOLR-17278
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Ishan Chattopadhyaya
>Priority: Major
> Attachments: SOLR-17278-1.patch, SOLR-17278.patch
>
>
> The TimeZoneUtilsTest#testValidIds() fails with some timezones that have 
> useDaylightTime() as true but getDSTSavings() returns 0. Such timezones can't 
> be converted to String using String.valueOf().
> Here's my JVM:
> {code}
> [ishan@deskmini solr] $ java -version
> openjdk version "11.0.22" 2024-01-16
> OpenJDK Runtime Environment (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7)
> OpenJDK 64-Bit Server VM (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7, mixed 
> mode, sharing)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org