[jira] [Commented] (SOLR-17279) consolidate security.json constants in test code
[ https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848743#comment-17848743 ] Eric Pugh commented on SOLR-17279: -- [~sanjaydutt] so I looked and I was only going to make this change on main, and not back port it. Mostly because many of the places it touched are around security for the SolrCLI commands, and supporting basic auth is a 10x feature that we never backported that feature to 9x. There are days I regret that decision. > consolidate security.json constants in test code > > > Key: SOLR-17279 > URL: https://issues.apache.org/jira/browse/SOLR-17279 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Reporter: Rudi Seitz >Assignee: Eric Pugh >Priority: Trivial > Fix For: main (10.0) > > Time Spent: 50m > Remaining Estimate: 0h > > Various unit tests declare a SECURITY_JSON constant. Maybe of these constants > are identical (likely introduced via copy/paste from other tests, resulting > in code duplication). This ticket is to consolidate the various SECURITY_JSON > constants across the tests in a central place. > This point was raised during discussion of the fix for SOLR-12813. See > https://github.com/apache/solr/pull/2404#discussion_r1568012056 > In that discussion, it was agreed to address SECURITY_JSON consolidation in a > separate ticket -- this is that ticket. > Tagging [~epugh] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17279) consolidate security.json constants in test code
[ https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848643#comment-17848643 ] Eric Pugh commented on SOLR-17279: -- Thanks for flagging this... Let me look again at why i didn't backport immediately.. it may have been some conflicts... > consolidate security.json constants in test code > > > Key: SOLR-17279 > URL: https://issues.apache.org/jira/browse/SOLR-17279 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Reporter: Rudi Seitz >Assignee: Eric Pugh >Priority: Trivial > Fix For: main (10.0) > > Time Spent: 50m > Remaining Estimate: 0h > > Various unit tests declare a SECURITY_JSON constant. Maybe of these constants > are identical (likely introduced via copy/paste from other tests, resulting > in code duplication). This ticket is to consolidate the various SECURITY_JSON > constants across the tests in a central place. > This point was raised during discussion of the fix for SOLR-12813. See > https://github.com/apache/solr/pull/2404#discussion_r1568012056 > In that discussion, it was agreed to address SECURITY_JSON consolidation in a > separate ticket -- this is that ticket. > Tagging [~epugh] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17279) consolidate security.json constants in test code
[ https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848638#comment-17848638 ] Sanjay Dutt commented on SOLR-17279: Blocked on SOLR-17300 for the 9x back port because of it > consolidate security.json constants in test code > > > Key: SOLR-17279 > URL: https://issues.apache.org/jira/browse/SOLR-17279 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Reporter: Rudi Seitz >Assignee: Eric Pugh >Priority: Trivial > Fix For: main (10.0) > > Time Spent: 50m > Remaining Estimate: 0h > > Various unit tests declare a SECURITY_JSON constant. Maybe of these constants > are identical (likely introduced via copy/paste from other tests, resulting > in code duplication). This ticket is to consolidate the various SECURITY_JSON > constants across the tests in a central place. > This point was raised during discussion of the fix for SOLR-12813. See > https://github.com/apache/solr/pull/2404#discussion_r1568012056 > In that discussion, it was agreed to address SECURITY_JSON consolidation in a > separate ticket -- this is that ticket. > Tagging [~epugh] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17279) consolidate security.json constants in test code
[ https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17845096#comment-17845096 ] ASF subversion and git services commented on SOLR-17279: Commit f8efe80ea44ca290ff087ced0ea4eaf2e88dd7d9 in solr's branch refs/heads/main from Rudi Seitz [ https://gitbox.apache.org/repos/asf?p=solr.git;h=f8efe80ea44 ] SOLR-17279: consolidate security.json constants in tests (#2445) * create SecurityJson class for holding simple security.json used by multiple tests - Co-authored-by: Eric Pugh > consolidate security.json constants in test code > > > Key: SOLR-17279 > URL: https://issues.apache.org/jira/browse/SOLR-17279 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Reporter: Rudi Seitz >Priority: Trivial > Time Spent: 50m > Remaining Estimate: 0h > > Various unit tests declare a SECURITY_JSON constant. Maybe of these constants > are identical (likely introduced via copy/paste from other tests, resulting > in code duplication). This ticket is to consolidate the various SECURITY_JSON > constants across the tests in a central place. > This point was raised during discussion of the fix for SOLR-12813. See > https://github.com/apache/solr/pull/2404#discussion_r1568012056 > In that discussion, it was agreed to address SECURITY_JSON consolidation in a > separate ticket -- this is that ticket. > Tagging [~epugh] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17279) consolidate security.json constants in test code
[ https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844410#comment-17844410 ] Rudi Seitz commented on SOLR-17279: --- PR: https://github.com/apache/solr/pull/2445 > consolidate security.json constants in test code > > > Key: SOLR-17279 > URL: https://issues.apache.org/jira/browse/SOLR-17279 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Reporter: Rudi Seitz >Priority: Trivial > Time Spent: 20m > Remaining Estimate: 0h > > Various unit tests declare a SECURITY_JSON constant. Maybe of these constants > are identical (likely introduced via copy/paste from other tests, resulting > in code duplication). This ticket is to consolidate the various SECURITY_JSON > constants across the tests in a central place. > This point was raised during discussion of the fix for SOLR-12813. See > https://github.com/apache/solr/pull/2404#discussion_r1568012056 > In that discussion, it was agreed to address SECURITY_JSON consolidation in a > separate ticket -- this is that ticket. > Tagging [~epugh] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17279) consolidate security.json constants in test code
[ https://issues.apache.org/jira/browse/SOLR-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17844295#comment-17844295 ] Rudi Seitz commented on SOLR-17279: --- Will open a PR for this shortly. > consolidate security.json constants in test code > > > Key: SOLR-17279 > URL: https://issues.apache.org/jira/browse/SOLR-17279 > Project: Solr > Issue Type: Task > Security Level: Public(Default Security Level. Issues are Public) > Components: Tests >Reporter: Rudi Seitz >Priority: Trivial > > Various unit tests declare a SECURITY_JSON constant. Maybe of these constants > are identical (likely introduced via copy/paste from other tests, resulting > in code duplication). This ticket is to consolidate the various SECURITY_JSON > constants across the tests in a central place. > This point was raised during discussion of the fix for SOLR-12813. See > https://github.com/apache/solr/pull/2404#discussion_r1568012056 > In that discussion, it was agreed to address SECURITY_JSON consolidation in a > separate ticket -- this is that ticket. > Tagging [~epugh] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
