Re: [PR] Clean up docker-faq.adoc [solr]
HoustonPutman commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983824945 > Hmm, if I'm not mistaken, a merge of this fix to `branch_9_5` may actually update the 9.5 guide. Let me try. You are not mistaken! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
janhoy commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983479315 The theory behind the guide build is that there is not supposed to be any functional change within a minor version, so any fixes pushed to `branch_9_5` are by definition bug fixes, including fixes to ref guide. This makes it safe to build the guide immediately even without a code release. We could even use this to push "Errata" entries to the guide after we discover bugs in a release that will not be fixed in an upcoming release... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
janhoy commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983469119 I did a push, let's wait for daily build of https://ci-builds.apache.org/job/Solr/job/solr-reference-guide-official/ - I think it will kick off in an hour or so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
epugh commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983464922 If this works...I wonder if we should try an establish a stronger pattern for doc fixes going `main` --> `branch_9x` and --> `branch_9_5` ? Though it is a whole nother step -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
janhoy commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983460238 Hmm, if I'm not mistaken, a merge of this fix to `branch_9_5` may actually update the 9.5 guide. Let me try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
epugh commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983453157 I don't believe changes to ref guides go immediately (unlike the website changes)...We don't have a "quick push this change to productioin ref guide" that isn't tied to a release. Hopefully 9.6 will be out soon, and I don't think this will justify a 9.5.x release... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
syats commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983196506 The fact that this PR is not yet in the productive documentation https://solr.apache.org/guide/solr/latest/deployment-guide/docker-faq.html as of 2023-03-07 is a source of confusion! The current documentation does not reflect the move of the data folder! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
janhoy merged PR #2277: URL: https://github.com/apache/solr/pull/2277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
janhoy commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1951424299 > It felt like developer notes and now seems more FAQ I actually think the FAQ text copied over from the old `docker-solr` project was written even before our `Dockerfile` had the `VOLUME` declaration, and before data folder was moved to `/var/solr`. So lots of doc rot there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
