[jira] [Resolved] (SPARK-25967) sql.functions.trim() should remove trailing and leading tabs

2018-11-08 Thread Victor Sahin (JIRA)


 [ 
https://issues.apache.org/jira/browse/SPARK-25967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Victor Sahin resolved SPARK-25967.
--
Resolution: Feedback Received

> sql.functions.trim() should remove trailing and leading tabs
> 
>
> Key: SPARK-25967
> URL: https://issues.apache.org/jira/browse/SPARK-25967
> Project: Spark
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 2.1.0, 2.2.0, 2.3.2
>Reporter: Victor Sahin
>Priority: Minor
>
> sql.functions.trim removes only trailing and leading whitespaces. Removing 
> tabs as well helps use the function for the same use case e.g. artifact 
> cleaning.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-25967) sql.functions.trim() should remove trailing and leading tabs

2018-11-08 Thread Victor Sahin (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-25967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679083#comment-16679083
 ] 

Victor Sahin commented on SPARK-25967:
--

I see. In that case I can close the issue.

> sql.functions.trim() should remove trailing and leading tabs
> 
>
> Key: SPARK-25967
> URL: https://issues.apache.org/jira/browse/SPARK-25967
> Project: Spark
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 2.1.0, 2.2.0, 2.3.2
>Reporter: Victor Sahin
>Priority: Minor
>
> sql.functions.trim removes only trailing and leading whitespaces. Removing 
> tabs as well helps use the function for the same use case e.g. artifact 
> cleaning.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Comment Edited] (SPARK-25967) sql.functions.trim() should remove trailing and leading tabs

2018-11-07 Thread Victor Sahin (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-25967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678657#comment-16678657
 ] 

Victor Sahin edited comment on SPARK-25967 at 11/7/18 7:13 PM:
---

That is not very intuitive to manually specify especially for the default use 
when let's say someone is mining text and wants to get rid of any and all blank 
characters surrounding a substring

Also regexp_replace is better suited for manually trimming only specific items 
IMO


was (Author: vsahin):
That is not very intuitive to manually specify especially for the default use 
when let's say someone is mining text and wants to get rid of any and all blank 
characters surrounding a substring

> sql.functions.trim() should remove trailing and leading tabs
> 
>
> Key: SPARK-25967
> URL: https://issues.apache.org/jira/browse/SPARK-25967
> Project: Spark
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 2.1.0, 2.2.0, 2.3.2
>Reporter: Victor Sahin
>Priority: Minor
>
> sql.functions.trim removes only trailing and leading whitespaces. Removing 
> tabs as well helps use the function for the same use case e.g. artifact 
> cleaning.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-25967) sql.functions.trim() should remove trailing and leading tabs

2018-11-07 Thread Victor Sahin (JIRA)


[ 
https://issues.apache.org/jira/browse/SPARK-25967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678657#comment-16678657
 ] 

Victor Sahin commented on SPARK-25967:
--

That is not very intuitive to manually specify especially for the default use 
when let's say someone is mining text and wants to get rid of any and all blank 
characters surrounding a substring

> sql.functions.trim() should remove trailing and leading tabs
> 
>
> Key: SPARK-25967
> URL: https://issues.apache.org/jira/browse/SPARK-25967
> Project: Spark
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 2.1.0, 2.2.0, 2.3.2
>Reporter: Victor Sahin
>Priority: Minor
>
> sql.functions.trim removes only trailing and leading whitespaces. Removing 
> tabs as well helps use the function for the same use case e.g. artifact 
> cleaning.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Created] (SPARK-25967) sql.functions.trim() should remove trailing and leading tabs

2018-11-07 Thread Victor Sahin (JIRA)
Victor Sahin created SPARK-25967:


 Summary: sql.functions.trim() should remove trailing and leading 
tabs
 Key: SPARK-25967
 URL: https://issues.apache.org/jira/browse/SPARK-25967
 Project: Spark
  Issue Type: Improvement
  Components: SQL
Affects Versions: 2.3.2, 2.2.0, 2.1.0
Reporter: Victor Sahin


sql.functions.trim removes only trailing and leading whitespaces. Removing tabs 
as well helps use the function for the same use case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Updated] (SPARK-25967) sql.functions.trim() should remove trailing and leading tabs

2018-11-07 Thread Victor Sahin (JIRA)


 [ 
https://issues.apache.org/jira/browse/SPARK-25967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Victor Sahin updated SPARK-25967:
-
Description: sql.functions.trim removes only trailing and leading 
whitespaces. Removing tabs as well helps use the function for the same use case 
e.g. artifact cleaning.  (was: sql.functions.trim removes only trailing and 
leading whitespaces. Removing tabs as well helps use the function for the same 
use case.)

> sql.functions.trim() should remove trailing and leading tabs
> 
>
> Key: SPARK-25967
> URL: https://issues.apache.org/jira/browse/SPARK-25967
> Project: Spark
>  Issue Type: Improvement
>  Components: SQL
>Affects Versions: 2.1.0, 2.2.0, 2.3.2
>Reporter: Victor Sahin
>Priority: Minor
>
> sql.functions.trim removes only trailing and leading whitespaces. Removing 
> tabs as well helps use the function for the same use case e.g. artifact 
> cleaning.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org