[jira] [Assigned] (SPARK-21967) org.apache.spark.unsafe.types.UTF8String#compareTo Should Compare 8 Bytes at a Time for Better Performance
[ https://issues.apache.org/jira/browse/SPARK-21967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Owen reassigned SPARK-21967: - Assignee: Armin Braun > org.apache.spark.unsafe.types.UTF8String#compareTo Should Compare 8 Bytes at > a Time for Better Performance > -- > > Key: SPARK-21967 > URL: https://issues.apache.org/jira/browse/SPARK-21967 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.2.0 >Reporter: Armin Braun >Assignee: Armin Braun >Priority: Minor > Labels: perfomance > Fix For: 2.3.0 > > > org.apache.spark.unsafe.types.UTF8String#compareTo contains the following > TODO: > {code} > int len = Math.min(numBytes, other.numBytes); > // TODO: compare 8 bytes as unsigned long > for (int i = 0; i < len; i ++) { > // In UTF-8, the byte should be unsigned, so we should compare them as > unsigned int. > {code} > The todo should be resolved by comparing the maximum number of 64bit words > possible in this method, before falling back to unsigned int comparison. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Assigned] (SPARK-21967) org.apache.spark.unsafe.types.UTF8String#compareTo Should Compare 8 Bytes at a Time for Better Performance
[ https://issues.apache.org/jira/browse/SPARK-21967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apache Spark reassigned SPARK-21967: Assignee: (was: Apache Spark) > org.apache.spark.unsafe.types.UTF8String#compareTo Should Compare 8 Bytes at > a Time for Better Performance > -- > > Key: SPARK-21967 > URL: https://issues.apache.org/jira/browse/SPARK-21967 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.2.0 >Reporter: Armin Braun >Priority: Minor > Labels: perfomance > > org.apache.spark.unsafe.types.UTF8String#compareTo contains the following > TODO: > {code} > int len = Math.min(numBytes, other.numBytes); > // TODO: compare 8 bytes as unsigned long > for (int i = 0; i < len; i ++) { > // In UTF-8, the byte should be unsigned, so we should compare them as > unsigned int. > {code} > The todo should be resolved by comparing the maximum number of 64bit words > possible in this method, before falling back to unsigned int comparison. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Assigned] (SPARK-21967) org.apache.spark.unsafe.types.UTF8String#compareTo Should Compare 8 Bytes at a Time for Better Performance
[ https://issues.apache.org/jira/browse/SPARK-21967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apache Spark reassigned SPARK-21967: Assignee: Apache Spark > org.apache.spark.unsafe.types.UTF8String#compareTo Should Compare 8 Bytes at > a Time for Better Performance > -- > > Key: SPARK-21967 > URL: https://issues.apache.org/jira/browse/SPARK-21967 > Project: Spark > Issue Type: Improvement > Components: Spark Core >Affects Versions: 2.2.0 >Reporter: Armin Braun >Assignee: Apache Spark >Priority: Minor > Labels: perfomance > > org.apache.spark.unsafe.types.UTF8String#compareTo contains the following > TODO: > {code} > int len = Math.min(numBytes, other.numBytes); > // TODO: compare 8 bytes as unsigned long > for (int i = 0; i < len; i ++) { > // In UTF-8, the byte should be unsigned, so we should compare them as > unsigned int. > {code} > The todo should be resolved by comparing the maximum number of 64bit words > possible in this method, before falling back to unsigned int comparison. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org