[jira] [Assigned] (SPARK-39881) Python Lint does not actually check for `black` formatter

2022-08-01 Thread Hyukjin Kwon (Jira)


 [ 
https://issues.apache.org/jira/browse/SPARK-39881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hyukjin Kwon reassigned SPARK-39881:


Assignee: Martin Grund

> Python Lint does not actually check for `black` formatter
> -
>
> Key: SPARK-39881
> URL: https://issues.apache.org/jira/browse/SPARK-39881
> Project: Spark
>  Issue Type: Improvement
>  Components: Build, PySpark
>Affects Versions: 3.3.0
>Reporter: Martin Grund
>Assignee: Martin Grund
>Priority: Major
>
> In our current `dev/lint-python` script we execute the following check: {{}}
>  
> {code:java}
> $BLACK_BUILD 2> /dev/null 
> if [ $? -ne 0 ]; then
>   # ...
> fi{code}
> However, even if black is installed simply invoking it will actually return a 
> non-zero exit code because no src files have been specified.  To correctly 
> check for the existence of `black` we need a different check.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Assigned] (SPARK-39881) Python Lint does not actually check for `black` formatter

2022-07-26 Thread Apache Spark (Jira)


 [ 
https://issues.apache.org/jira/browse/SPARK-39881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apache Spark reassigned SPARK-39881:


Assignee: Apache Spark

> Python Lint does not actually check for `black` formatter
> -
>
> Key: SPARK-39881
> URL: https://issues.apache.org/jira/browse/SPARK-39881
> Project: Spark
>  Issue Type: Improvement
>  Components: Build, PySpark
>Affects Versions: 3.3.0
>Reporter: Martin Grund
>Assignee: Apache Spark
>Priority: Major
>
> In our current `dev/lint-python` script we execute the following check: {{}}
>  
> {code:java}
> $BLACK_BUILD 2> /dev/null 
> if [ $? -ne 0 ]; then
>   # ...
> fi{code}
> However, even if black is installed simply invoking it will actually return a 
> non-zero exit code because no src files have been specified.  To correctly 
> check for the existence of `black` we need a different check.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Assigned] (SPARK-39881) Python Lint does not actually check for `black` formatter

2022-07-26 Thread Apache Spark (Jira)


 [ 
https://issues.apache.org/jira/browse/SPARK-39881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apache Spark reassigned SPARK-39881:


Assignee: (was: Apache Spark)

> Python Lint does not actually check for `black` formatter
> -
>
> Key: SPARK-39881
> URL: https://issues.apache.org/jira/browse/SPARK-39881
> Project: Spark
>  Issue Type: Improvement
>  Components: Build, PySpark
>Affects Versions: 3.3.0
>Reporter: Martin Grund
>Priority: Major
>
> In our current `dev/lint-python` script we execute the following check: {{}}
>  
> {code:java}
> $BLACK_BUILD 2> /dev/null 
> if [ $? -ne 0 ]; then
>   # ...
> fi{code}
> However, even if black is installed simply invoking it will actually return a 
> non-zero exit code because no src files have been specified.  To correctly 
> check for the existence of `black` we need a different check.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org