[jira] [Comment Edited] (SPARK-1590) Recommend to use FindBugs

2014-04-24 Thread Shixiong Zhu (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979505#comment-13979505
 ] 

Shixiong Zhu edited comment on SPARK-1590 at 4/24/14 9:27 AM:
--

Agree that a periodical scanning is better then incorporating into the build, 
since there are so many false positives.


was (Author: zsxwing):
Agree that a period scanning is better then incorporating into the build, since 
there are so many false positives.

> Recommend to use FindBugs
> -
>
> Key: SPARK-1590
> URL: https://issues.apache.org/jira/browse/SPARK-1590
> Project: Spark
>  Issue Type: Question
>  Components: Build
>Reporter: Shixiong Zhu
>Priority: Minor
> Attachments: findbugs.png
>
>
> FindBugs is an open source program created by Bill Pugh and David Hovemeyer 
> which looks for bugs in Java code. It uses static analysis to identify 
> hundreds of different potential types of errors in Java programs.
> Although Spark is a Scala project, FindBugs is still helpful. For example, I 
> used it to find SPARK-1583 and SPARK-1589. However, the disadvantage is that 
> the report generated by FindBugs usually contains many false alarms for a 
> Scala project.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Comment Edited] (SPARK-1590) Recommend to use FindBugs

2014-04-23 Thread Shixiong Zhu (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978291#comment-13978291
 ] 

Shixiong Zhu edited comment on SPARK-1590 at 4/23/14 3:18 PM:
--

I attached a screenshot of FindBugs plugin in IDEA


was (Author: zsxwing):
FindBugs in IDEA

> Recommend to use FindBugs
> -
>
> Key: SPARK-1590
> URL: https://issues.apache.org/jira/browse/SPARK-1590
> Project: Spark
>  Issue Type: Question
>  Components: Build
>Reporter: Shixiong Zhu
>Priority: Minor
> Attachments: findbugs.png
>
>
> FindBugs is an open source program created by Bill Pugh and David Hovemeyer 
> which looks for bugs in Java code. It uses static analysis to identify 
> hundreds of different potential types of errors in Java programs.
> Although Spark is a Scala project, FindBugs is still helpful. For example, I 
> used it to find SPARK-1583 and SPARK-1589. However, the disadvantage is that 
> the report generated by FindBugs usually contains many false alarms for a 
> Scala project.



--
This message was sent by Atlassian JIRA
(v6.2#6252)