[jira] [Comment Edited] (SPARK-20503) ML 2.2 QA: API: Python API coverage
[
https://issues.apache.org/jira/browse/SPARK-20503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012101#comment-16012101
]
Nick Pentreath edited comment on SPARK-20503 at 5/16/17 10:21 AM:
--
I think I've highlighted all the API gaps in the links above. These can be
handled in the next dev cycle (some are in progress already). Checking docs and
guide now.
was (Author: mlnick):
I think I've highlighted all the API gaps in the links above. These can be
handled in the next dev cycle (some are in progress already). Resolving this.
> ML 2.2 QA: API: Python API coverage
> ---
>
> Key: SPARK-20503
> URL: https://issues.apache.org/jira/browse/SPARK-20503
> Project: Spark
> Issue Type: Sub-task
> Components: Documentation, ML, PySpark
>Reporter: Joseph K. Bradley
>Assignee: Nick Pentreath
>Priority: Blocker
>
> For new public APIs added to MLlib ({{spark.ml}} only), we need to check the
> generated HTML doc and compare the Scala & Python versions.
> * *GOAL*: Audit and create JIRAs to fix in the next release.
> * *NON-GOAL*: This JIRA is _not_ for fixing the API parity issues.
> We need to track:
> * Inconsistency: Do class/method/parameter names match?
> * Docs: Is the Python doc missing or just a stub? We want the Python doc to
> be as complete as the Scala doc.
> * API breaking changes: These should be very rare but are occasionally either
> necessary (intentional) or accidental. These must be recorded and added in
> the Migration Guide for this release.
> ** Note: If the API change is for an Alpha/Experimental/DeveloperApi
> component, please note that as well.
> * Missing classes/methods/parameters: We should create to-do JIRAs for
> functionality missing from Python, to be added in the next release cycle.
> *Please use a _separate_ JIRA (linked below as "requires") for this list of
> to-do items.*
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Comment Edited] (SPARK-20503) ML 2.2 QA: API: Python API coverage
[
https://issues.apache.org/jira/browse/SPARK-20503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012010#comment-16012010
]
Nick Pentreath edited comment on SPARK-20503 at 5/16/17 10:18 AM:
--
Checked:
* {{ALS}}:
** {{coldStartStrategy}} param exposed in SPARK-14489
** {{recommendforX}} methods exposed in SPARK-20300
* {{Imputer}} Python API in SPARK-15040
* {{FPGrowth}} Python API (including {{associationRules}}) in SPARK-19281
* {{LinearSVC}} Python API in SPARK-19336
* {{ChiSquareTest}} Python API in SPARK-20040
* {{Correlation}} Python API in SPARK-20076
* {{LSH}} Python API added in SPARK-18080
Adding a few missing API issues above. But as per usual procedure while these
are listed as "requires" for tracking in next release cycle, these will not
block this release.
was (Author: mlnick):
Checked:
* {{ALS}}:
** {{coldStartStrategy}} param exposed in SPARK-14489
** {{recommendforX}} methods exposed in SPARK-20300
* {{Imputer}} Python API in SPARK-15040
* {{FPGrowth}} Python API (including {{associationRules}} in SPARK-19281
* {{LinearSVC}} Python API in SPARK-19336
* {{ChiSquareTest}} Python API in SPARK-20040
* {{Correlation}} Python API in SPARK-20076
* {{LSH}} Python API added in SPARK-18080
Adding a few missing API issues above. But as per usual procedure while these
are listed as "requires" for tracking in next release cycle, these will not
block this release.
> ML 2.2 QA: API: Python API coverage
> ---
>
> Key: SPARK-20503
> URL: https://issues.apache.org/jira/browse/SPARK-20503
> Project: Spark
> Issue Type: Sub-task
> Components: Documentation, ML, PySpark
>Reporter: Joseph K. Bradley
>Assignee: Nick Pentreath
>Priority: Blocker
>
> For new public APIs added to MLlib ({{spark.ml}} only), we need to check the
> generated HTML doc and compare the Scala & Python versions.
> * *GOAL*: Audit and create JIRAs to fix in the next release.
> * *NON-GOAL*: This JIRA is _not_ for fixing the API parity issues.
> We need to track:
> * Inconsistency: Do class/method/parameter names match?
> * Docs: Is the Python doc missing or just a stub? We want the Python doc to
> be as complete as the Scala doc.
> * API breaking changes: These should be very rare but are occasionally either
> necessary (intentional) or accidental. These must be recorded and added in
> the Migration Guide for this release.
> ** Note: If the API change is for an Alpha/Experimental/DeveloperApi
> component, please note that as well.
> * Missing classes/methods/parameters: We should create to-do JIRAs for
> functionality missing from Python, to be added in the next release cycle.
> *Please use a _separate_ JIRA (linked below as "requires") for this list of
> to-do items.*
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Comment Edited] (SPARK-20503) ML 2.2 QA: API: Python API coverage
[
https://issues.apache.org/jira/browse/SPARK-20503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012010#comment-16012010
]
Nick Pentreath edited comment on SPARK-20503 at 5/16/17 9:22 AM:
-
Checked:
* {{ALS}}:
** {{coldStartStrategy}} param exposed in SPARK-14489
** {{recommendforX}} methods exposed in SPARK-20300
* {{Imputer}} Python API in SPARK-15040
* {{FPGrowth}} Python API (including {{associationRules}} in SPARK-19281
* {{LinearSVC}} Python API in SPARK-19336
* {{ChiSquareTest}} Python API in SPARK-20040
* {{Correlation}} Python API in SPARK-20076
* {{LSH}} Python API added in SPARK-18080
Adding a few missing API issues above. But as per usual procedure while these
are listed as "requires" for tracking in next release cycle, these will not
block this release.
was (Author: mlnick):
Checked:
* {{ALS}}:
** {{coldStartStrategy}} param exposed in SPARK-14489
** {{recommendforX}} methods exposed in SPARK-20300
* {{Imputer}} Python API in SPARK-15040
* {{FPGrowth}} Python API (including {{associationRules}} in SPARK-19281
* {{LinearSVC}} Python API in SPARK-19336
* {{ChiSquareTest}} Python API in SPARK-20040
* {{Correlation}} Python API in SPARK-20076
The only API gap I found os far is the constrained LR params linked in in
SPARK-20601 above. As per usual procedure these will not block the release.
> ML 2.2 QA: API: Python API coverage
> ---
>
> Key: SPARK-20503
> URL: https://issues.apache.org/jira/browse/SPARK-20503
> Project: Spark
> Issue Type: Sub-task
> Components: Documentation, ML, PySpark
>Reporter: Joseph K. Bradley
>Assignee: Nick Pentreath
>Priority: Blocker
>
> For new public APIs added to MLlib ({{spark.ml}} only), we need to check the
> generated HTML doc and compare the Scala & Python versions.
> * *GOAL*: Audit and create JIRAs to fix in the next release.
> * *NON-GOAL*: This JIRA is _not_ for fixing the API parity issues.
> We need to track:
> * Inconsistency: Do class/method/parameter names match?
> * Docs: Is the Python doc missing or just a stub? We want the Python doc to
> be as complete as the Scala doc.
> * API breaking changes: These should be very rare but are occasionally either
> necessary (intentional) or accidental. These must be recorded and added in
> the Migration Guide for this release.
> ** Note: If the API change is for an Alpha/Experimental/DeveloperApi
> component, please note that as well.
> * Missing classes/methods/parameters: We should create to-do JIRAs for
> functionality missing from Python, to be added in the next release cycle.
> *Please use a _separate_ JIRA (linked below as "requires") for this list of
> to-do items.*
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
