[jira] [Comment Edited] (SPARK-7541) Check model save/load for MLlib 1.4
[ https://issues.apache.org/jira/browse/SPARK-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568998#comment-14568998 ] yuhao yang edited comment on SPARK-7541 at 6/2/15 11:56 AM: Oh, Thanks. Yet I haven't checked through all the examples with save/load in the markdown documents (And I think it's necessary). The previous jira 7949 just added some missing save/load. was (Author: yuhaoyan): Oh, Thanks. Yet I haven't checked through all the examples in the markdown documents (And I think it's necessary). The previous jira 7949 just added some missing save/load. > Check model save/load for MLlib 1.4 > --- > > Key: SPARK-7541 > URL: https://issues.apache.org/jira/browse/SPARK-7541 > Project: Spark > Issue Type: Sub-task > Components: ML, MLlib, PySpark >Reporter: Joseph K. Bradley >Assignee: yuhao yang > > For each model which supports save/load methods, we need to verify: > * These methods are tested in unit tests in Scala and Python (if save/load is > supported in Python). > * If a model's name, data members, or constructors have changed _at all_, > then we likely need to support a new save/load format version. Different > versions must be tested in unit tests to ensure backwards compatibility > (i.e., verify we can load old model formats). > * Examples in the programming guide should include save/load when available. > It's important to try running each example in the guide whenever it is > modified (since there are no automated tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Comment Edited] (SPARK-7541) Check model save/load for MLlib 1.4
[ https://issues.apache.org/jira/browse/SPARK-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568998#comment-14568998 ] yuhao yang edited comment on SPARK-7541 at 6/2/15 11:53 AM: Oh, Thanks. Yet I haven't checked through all the examples in the markdown documents (And I think it's necessary). The previous jira 7949 just added some missing save/load. was (Author: yuhaoyan): Oh, I haven't checked though all the examples in the markdown documents (And I think it's necessary). The previous jira 7949 just added some missing save/load. > Check model save/load for MLlib 1.4 > --- > > Key: SPARK-7541 > URL: https://issues.apache.org/jira/browse/SPARK-7541 > Project: Spark > Issue Type: Sub-task > Components: ML, MLlib, PySpark >Reporter: Joseph K. Bradley >Assignee: yuhao yang > > For each model which supports save/load methods, we need to verify: > * These methods are tested in unit tests in Scala and Python (if save/load is > supported in Python). > * If a model's name, data members, or constructors have changed _at all_, > then we likely need to support a new save/load format version. Different > versions must be tested in unit tests to ensure backwards compatibility > (i.e., verify we can load old model formats). > * Examples in the programming guide should include save/load when available. > It's important to try running each example in the guide whenever it is > modified (since there are no automated tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Comment Edited] (SPARK-7541) Check model save/load for MLlib 1.4
[ https://issues.apache.org/jira/browse/SPARK-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564296#comment-14564296 ] yuhao yang edited comment on SPARK-7541 at 5/29/15 7:14 AM: Oh, "checked" means I found no python support for save/load for the model. I guess we can add them in 1.5. was (Author: yuhaoyan): Oh, "checked" means I found no python support for save/load for the model. > Check model save/load for MLlib 1.4 > --- > > Key: SPARK-7541 > URL: https://issues.apache.org/jira/browse/SPARK-7541 > Project: Spark > Issue Type: Sub-task > Components: ML, MLlib, PySpark >Reporter: Joseph K. Bradley >Assignee: yuhao yang > > For each model which supports save/load methods, we need to verify: > * These methods are tested in unit tests in Scala and Python (if save/load is > supported in Python). > * If a model's name, data members, or constructors have changed _at all_, > then we likely need to support a new save/load format version. Different > versions must be tested in unit tests to ensure backwards compatibility > (i.e., verify we can load old model formats). > * Examples in the programming guide should include save/load when available. > It's important to try running each example in the guide whenever it is > modified (since there are no automated tests). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Comment Edited] (SPARK-7541) Check model save/load for MLlib 1.4
[ https://issues.apache.org/jira/browse/SPARK-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564263#comment-14564263 ] yuhao yang edited comment on SPARK-7541 at 5/29/15 6:40 AM: ||model||Scala UT || python UT || changes ||backwards Compatibility|| |LogisticRegressionModel| LogisticRegressionSuite| LogisticRegressionModel doctests|no public change| y |NaiveBayesModel| NaiveBayesSuite| NaiveBayesModel doctests| save/load 2.0| y| |SVMModel| SVMSuite| SVMModel doctests | no public change| y| |GaussianMixtureModel| GaussianMixtureSuite| checked | New Saveable in 1.4 |New Saveable in 1.4| |KMeansModel| KMeansSuite | KMeansModel doctests| New Saveable in 1.4 |New Saveable in 1.4| |PowerIterationClusteringModel |PowerIterationClusteringSuite| checked | New Saveable in 1.4|New Savable in 1.4| |Word2VecModel | Word2VecSuite | checked | New Saveable in 1.4|New Saveable in 1.4| |MatrixFactorizationModel |MatrixFactorizationModelSuite | MatrixFactorizationModel doctests | no public change | y| |IsotonicRegressionModel| IsotonicRegressionSuite | IsotonicRegressionModel | New Saveable in 1.4 | New Saveable in 1.4| |LassoModel | LassoSuite | LassoModel doctests | no public change| y| |LinearRegressionModel | LinearRegressionSuite | LinearRegressionModel doctests | no public change|y| |RidgeRegressionModel | RidgeRegressionSuite| RidgeRegressionModel doctests | no public change|y| |DecisionTreeModel | DecisionTreeSuite| dt_model.save| no public change| y| |RandomForestModel| RandomForestSuite | rf_model.save | no public change| y| |GradientBoostedTreesModel |GradientBoostedTreesSuite |gbt_model.sav | no public change| y| Above contents have been checked and no obvious issue detected. And Joseph, do you think we should add save/load wherever available in the example documents? was (Author: yuhaoyan): ||model||Scala UT || python UT || changes ||backwards Compatibility|| |LogisticRegressionModel| LogisticRegressionSuite| LogisticRegressionModel doctests|no public change| y |NaiveBayesModel| NaiveBayesSuite| NaiveBayesModel doctests| save/load 2.0| y| |SVMModel| SVMSuite| SVMModel doctests | no public change| y| |GaussianMixtureModel| GaussianMixtureSuite| checked | New Savable in 1.4 |New Savable in 1.4| |KMeansModel| KMeansSuite | KMeansModel doctests| New Savable in 1.4 |New Savable in 1.4| |PowerIterationClusteringModel |PowerIterationClusteringSuite| checked | New Savable in 1.4| New Savable in 1.4| |Word2VecModel | Word2VecSuite | checked | New Savable in 1.4| New Savable in 1.4| |MatrixFactorizationModel |MatrixFactorizationModelSuite | MatrixFactorizationModel doctests | no public change | y| |IsotonicRegressionModel| IsotonicRegressionSuite | IsotonicRegressionModel | New Savable in 1.4 |New Savable in 1.4| |LassoModel | LassoSuite | LassoModel doctests | no public change| y| |LinearRegressionModel | LinearRegressionSuite | LinearRegressionModel doctests | no public change|y| |RidgeRegressionModel | RidgeRegressionSuite| RidgeRegressionModel doctests | no public change|y| |DecisionTreeModel | DecisionTreeSuite| dt_model.save| no public change| y| |RandomForestModel| RandomForestSuite | rf_model.save | no public change| y| |GradientBoostedTreesModel |GradientBoostedTreesSuite |gbt_model.sav |
