[jira] [Commented] (SPARK-10207) Specify schema during Word2Vec.save to avoid reflection
[ https://issues.apache.org/jira/browse/SPARK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728439#comment-14728439 ] Apache Spark commented on SPARK-10207: -- User 'vinodkc' has created a pull request for this issue: https://github.com/apache/spark/pull/8507 > Specify schema during Word2Vec.save to avoid reflection > --- > > Key: SPARK-10207 > URL: https://issues.apache.org/jira/browse/SPARK-10207 > Project: Spark > Issue Type: Sub-task > Components: MLlib >Reporter: Feynman Liang >Priority: Minor > > [Word2Vec.save|https://github.com/apache/spark/blob/7cfc0750e14f2c1b3847e4720cc02150253525a9/mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala#L615] > currently infers a schema from a case class when the schema is known and > should be manually provided. > See parent JIRA for rationale. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-10207) Specify schema during Word2Vec.save to avoid reflection
[ https://issues.apache.org/jira/browse/SPARK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715141#comment-14715141 ] Feynman Liang commented on SPARK-10207: --- [~srowen] I linked them using "is required by" but in retrospect I think making these subtasks of SPARK-10199 is more appropriate, thanks for bring that up! I will make that change. Let's discuss the issue of large numbers of logically similar issues in SPARK-7751. > Specify schema during Word2Vec.save to avoid reflection > --- > > Key: SPARK-10207 > URL: https://issues.apache.org/jira/browse/SPARK-10207 > Project: Spark > Issue Type: Improvement > Components: MLlib >Reporter: Feynman Liang >Priority: Minor > > [Word2Vec.save|https://github.com/apache/spark/blob/7cfc0750e14f2c1b3847e4720cc02150253525a9/mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala#L615] > currently infers a schema from a case class when the schema is known and > should be manually provided. > See parent JIRA for rationale. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-10207) Specify schema during Word2Vec.save to avoid reflection
[ https://issues.apache.org/jira/browse/SPARK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712677#comment-14712677 ] Sean Owen commented on SPARK-10207: --- [~fliang] see my comments on https://issues.apache.org/jira/browse/SPARK-7751 You have a lot of JIRAs for logically similar changes and I think it creates some problems. I'm not objecting so much as asking for some discussion. But at least, there is no parent JIRA here tying the "Specify schema" tickets -- would that be better to keep them grouped? > Specify schema during Word2Vec.save to avoid reflection > --- > > Key: SPARK-10207 > URL: https://issues.apache.org/jira/browse/SPARK-10207 > Project: Spark > Issue Type: Improvement > Components: MLlib >Reporter: Feynman Liang >Priority: Minor > > [Word2Vec.save|https://github.com/apache/spark/blob/7cfc0750e14f2c1b3847e4720cc02150253525a9/mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala#L615] > currently infers a schema from a case class when the schema is known and > should be manually provided. > See parent JIRA for rationale. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-10207) Specify schema during Word2Vec.save to avoid reflection
[ https://issues.apache.org/jira/browse/SPARK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712463#comment-14712463 ] Vinod KC commented on SPARK-10207: -- I'm working on this > Specify schema during Word2Vec.save to avoid reflection > --- > > Key: SPARK-10207 > URL: https://issues.apache.org/jira/browse/SPARK-10207 > Project: Spark > Issue Type: Improvement > Components: MLlib >Reporter: Feynman Liang >Priority: Minor > > [Word2Vec.save|https://github.com/apache/spark/blob/7cfc0750e14f2c1b3847e4720cc02150253525a9/mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala#L615] > currently infers a schema from a case class when the schema is known and > should be manually provided. > See parent JIRA for rationale. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
