[jira] [Commented] (SPARK-11903) Deprecate make-distribution.sh --skip-java-test
[
https://issues.apache.org/jira/browse/SPARK-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021511#comment-15021511
]
Patrick Wendell commented on SPARK-11903:
-
I think it's simply dead code. SKIP_JAVA_TEST related to a check we did
regarding whether Java 6 was being used instead of Java 7. It doesn't have
anything to do with unit tests. Spark now requires Java 7, so the test has been
removed, but the parser still handles that variable. It was just an omission
not deleted as part of SPARK-7733
(https://github.com/apache/spark/commit/e84815dc333a69368a48e0152f02934980768a14)
/cc [~srowen].
> Deprecate make-distribution.sh --skip-java-test
> ---
>
> Key: SPARK-11903
> URL: https://issues.apache.org/jira/browse/SPARK-11903
> Project: Spark
> Issue Type: Improvement
> Components: Build
>Reporter: Nicholas Chammas
>Priority: Minor
>
> The {{\-\-skip-java-test}} option to {{make-distribution.sh}} [does not
> appear to be
> used|https://github.com/apache/spark/blob/835a79d78ee879a3c36dde85e5b3591243bf3957/make-distribution.sh#L72-L73],
> and tests are [always
> skipped|https://github.com/apache/spark/blob/835a79d78ee879a3c36dde85e5b3591243bf3957/make-distribution.sh#L170].
> Searching the Spark codebase for {{SKIP_JAVA_TEST}} yields no results other
> than [this
> one|https://github.com/apache/spark/blob/835a79d78ee879a3c36dde85e5b3591243bf3957/make-distribution.sh#L72-L73].
> If this option is not needed, we should deprecate and eventually remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-11903) Deprecate make-distribution.sh --skip-java-test
[
https://issues.apache.org/jira/browse/SPARK-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020729#comment-15020729
]
Nicholas Chammas commented on SPARK-11903:
--
Also, we could just leave the option in there and add a warning to let the user
know that it isn't necessary. That would maintain compatibility while
communicating the deprecation to the user, if this option is indeed deprecated.
> Deprecate make-distribution.sh --skip-java-test
> ---
>
> Key: SPARK-11903
> URL: https://issues.apache.org/jira/browse/SPARK-11903
> Project: Spark
> Issue Type: Improvement
> Components: Build
>Reporter: Nicholas Chammas
>Priority: Minor
>
> The {{\-\-skip-java-test}} option to {{make-distribution.sh}} [does not
> appear to be
> used|https://github.com/apache/spark/blob/835a79d78ee879a3c36dde85e5b3591243bf3957/make-distribution.sh#L72-L73].
> Searching the Spark codebase for {{SKIP_JAVA_TEST}} yields no results other
> than that one.
> If this option is not needed, we should deprecate and eventually remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-11903) Deprecate make-distribution.sh --skip-java-test
[
https://issues.apache.org/jira/browse/SPARK-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020730#comment-15020730
]
Marcelo Vanzin commented on SPARK-11903:
Ah, I thought that without that option tests would be run. If they don't run,
it's fine to remove the option (we just need to change our job to not pass the
parameter anymore).
> Deprecate make-distribution.sh --skip-java-test
> ---
>
> Key: SPARK-11903
> URL: https://issues.apache.org/jira/browse/SPARK-11903
> Project: Spark
> Issue Type: Improvement
> Components: Build
>Reporter: Nicholas Chammas
>Priority: Minor
>
> The {{\-\-skip-java-test}} option to {{make-distribution.sh}} [does not
> appear to be
> used|https://github.com/apache/spark/blob/835a79d78ee879a3c36dde85e5b3591243bf3957/make-distribution.sh#L72-L73].
> Searching the Spark codebase for {{SKIP_JAVA_TEST}} yields no results other
> than that one.
> If this option is not needed, we should deprecate and eventually remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-11903) Deprecate make-distribution.sh --skip-java-test
[
https://issues.apache.org/jira/browse/SPARK-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020726#comment-15020726
]
Marcelo Vanzin commented on SPARK-11903:
We use that option in our internal builds. I'd rather keep it there than have
to maintain an internal patch to keep the functionality...
> Deprecate make-distribution.sh --skip-java-test
> ---
>
> Key: SPARK-11903
> URL: https://issues.apache.org/jira/browse/SPARK-11903
> Project: Spark
> Issue Type: Improvement
> Components: Build
>Reporter: Nicholas Chammas
>Priority: Minor
>
> The {{\-\-skip-java-test}} option to {{make-distribution.sh}} [does not
> appear to be
> used|https://github.com/apache/spark/blob/835a79d78ee879a3c36dde85e5b3591243bf3957/make-distribution.sh#L72-L73].
> Searching the Spark codebase for {{SKIP_JAVA_TEST}} yields no results other
> than that one.
> If this option is not needed, we should deprecate and eventually remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-11903) Deprecate make-distribution.sh --skip-java-test
[
https://issues.apache.org/jira/browse/SPARK-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020725#comment-15020725
]
Nicholas Chammas commented on SPARK-11903:
--
cc [~pwendell] and [~srowen] - Y'all probably know best about this. I can open
a PR if appropriate. Just let me know what the appropriate course of action is
here.
> Deprecate make-distribution.sh --skip-java-test
> ---
>
> Key: SPARK-11903
> URL: https://issues.apache.org/jira/browse/SPARK-11903
> Project: Spark
> Issue Type: Improvement
> Components: Build
>Reporter: Nicholas Chammas
>Priority: Minor
>
> The {{\-\-skip-java-test}} option to {{make-distribution.sh}} [does not
> appear to be
> used|https://github.com/apache/spark/blob/835a79d78ee879a3c36dde85e5b3591243bf3957/make-distribution.sh#L72-L73].
> Searching the Spark codebase for {{SKIP_JAVA_TEST}} yields no results other
> than that one.
> If this option is not needed, we should deprecate and eventually remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-11903) Deprecate make-distribution.sh --skip-java-test
[
https://issues.apache.org/jira/browse/SPARK-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15020728#comment-15020728
]
Nicholas Chammas commented on SPARK-11903:
--
Oh, could you elaborate a bit? From what I understood of
{{make-distribution.sh}}, [tests are always
skipped|https://github.com/apache/spark/blob/835a79d78ee879a3c36dde85e5b3591243bf3957/make-distribution.sh#L170].
Do you sometimes want to run {{make-distribution.sh}} with tests?
> Deprecate make-distribution.sh --skip-java-test
> ---
>
> Key: SPARK-11903
> URL: https://issues.apache.org/jira/browse/SPARK-11903
> Project: Spark
> Issue Type: Improvement
> Components: Build
>Reporter: Nicholas Chammas
>Priority: Minor
>
> The {{\-\-skip-java-test}} option to {{make-distribution.sh}} [does not
> appear to be
> used|https://github.com/apache/spark/blob/835a79d78ee879a3c36dde85e5b3591243bf3957/make-distribution.sh#L72-L73].
> Searching the Spark codebase for {{SKIP_JAVA_TEST}} yields no results other
> than that one.
> If this option is not needed, we should deprecate and eventually remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
