[jira] [Commented] (SPARK-12925) Improve HiveInspectors.unwrap for StringObjectInspector.getPrimitiveWritableObject
[ https://issues.apache.org/jira/browse/SPARK-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176734#comment-15176734 ] Rajesh Balamohan commented on SPARK-12925: -- Earlier fix had a problem when Text was reused. Posting a revised patch for review which fixes the issue when Text is reused. > Improve HiveInspectors.unwrap for > StringObjectInspector.getPrimitiveWritableObject > -- > > Key: SPARK-12925 > URL: https://issues.apache.org/jira/browse/SPARK-12925 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan > Fix For: 2.0.0 > > Attachments: SPARK-12925_profiler_cpu_samples.png > > > Text is in UTF-8 and converting it via "UTF8String.fromString" incurs > decoding and encoding, which turns out to be expensive. (to be specific: > https://github.com/apache/spark/blob/0d543b98f3e3da5053f0476f4647a765460861f3/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala#L323) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-12925) Improve HiveInspectors.unwrap for StringObjectInspector.getPrimitiveWritableObject
[ https://issues.apache.org/jira/browse/SPARK-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176729#comment-15176729 ] Apache Spark commented on SPARK-12925: -- User 'rajeshbalamohan' has created a pull request for this issue: https://github.com/apache/spark/pull/11477 > Improve HiveInspectors.unwrap for > StringObjectInspector.getPrimitiveWritableObject > -- > > Key: SPARK-12925 > URL: https://issues.apache.org/jira/browse/SPARK-12925 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Rajesh Balamohan >Assignee: Rajesh Balamohan > Fix For: 2.0.0 > > Attachments: SPARK-12925_profiler_cpu_samples.png > > > Text is in UTF-8 and converting it via "UTF8String.fromString" incurs > decoding and encoding, which turns out to be expensive. (to be specific: > https://github.com/apache/spark/blob/0d543b98f3e3da5053f0476f4647a765460861f3/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala#L323) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-12925) Improve HiveInspectors.unwrap for StringObjectInspector.getPrimitiveWritableObject
[ https://issues.apache.org/jira/browse/SPARK-12925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108451#comment-15108451 ] Apache Spark commented on SPARK-12925: -- User 'rajeshbalamohan' has created a pull request for this issue: https://github.com/apache/spark/pull/10848 > Improve HiveInspectors.unwrap for > StringObjectInspector.getPrimitiveWritableObject > -- > > Key: SPARK-12925 > URL: https://issues.apache.org/jira/browse/SPARK-12925 > Project: Spark > Issue Type: Improvement > Components: SQL >Reporter: Rajesh Balamohan > Attachments: SPARK-12925_profiler_cpu_samples.png > > > Text is in UTF-8 and converting it via "UTF8String.fromString" incurs > decoding and encoding, which turns out to be expensive. (to be specific: > https://github.com/apache/spark/blob/0d543b98f3e3da5053f0476f4647a765460861f3/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala#L323) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
