[jira] [Commented] (SPARK-13157) ADD JAR command cannot handle path with @ character

2016-02-03 Thread Davies Liu (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129994#comment-15129994
 ] 

Davies Liu commented on SPARK-13157:


THis is introduced by https://github.com/apache/spark/pull/10905/files

cc [~hvanhovell]

> ADD JAR command cannot handle path with @ character
> ---
>
> Key: SPARK-13157
> URL: https://issues.apache.org/jira/browse/SPARK-13157
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Priority: Blocker
>
> To reproduce this issue locally, copy {{TestUDTF.jar}} under 
> {{$SPARK_HOME/sql/hive/src/test/resources/TestUDTF.jar}} to 
> {{/tmp/a@b/TestUDTF.jar}}. Then start the Thrift server and run the following 
> commands using Beeline:
> {noformat}
> > add jar file:///tmp/a@b/TestUDTF.jar;
> ...
> > CREATE TEMPORARY FUNCTION udtf_count2 AS 
> > 'org.apache.spark.sql.hive.execution.GenericUDTFCount2';
> Error: org.apache.spark.sql.execution.QueryExecutionException: FAILED: 
> Execution Error, return code 1 from 
> org.apache.hadoop.hive.ql.exec.FunctionTask (state=,code=0)
> {noformat}
> Please refer to [this PR comment 
> thread|https://github.com/apache/spark/pull/11040] for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-13157) ADD JAR command cannot handle path with @ character

2016-02-03 Thread Davies Liu (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129995#comment-15129995
 ] 

Davies Liu commented on SPARK-13157:


Could be reproduce by 

{code}

  test("path with @") {
val plan = parser.parsePlan("ADD JAR /a/b@1/c.jar")
assert(plan.isInstanceOf[AddJar])
assert(plan.asInstanceOf[AddJar].path === "/a/b@1/c.jar")
  }

{code}

> ADD JAR command cannot handle path with @ character
> ---
>
> Key: SPARK-13157
> URL: https://issues.apache.org/jira/browse/SPARK-13157
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Priority: Blocker
>
> To reproduce this issue locally, copy {{TestUDTF.jar}} under 
> {{$SPARK_HOME/sql/hive/src/test/resources/TestUDTF.jar}} to 
> {{/tmp/a@b/TestUDTF.jar}}. Then start the Thrift server and run the following 
> commands using Beeline:
> {noformat}
> > add jar file:///tmp/a@b/TestUDTF.jar;
> ...
> > CREATE TEMPORARY FUNCTION udtf_count2 AS 
> > 'org.apache.spark.sql.hive.execution.GenericUDTFCount2';
> Error: org.apache.spark.sql.execution.QueryExecutionException: FAILED: 
> Execution Error, return code 1 from 
> org.apache.hadoop.hive.ql.exec.FunctionTask (state=,code=0)
> {noformat}
> Please refer to [this PR comment 
> thread|https://github.com/apache/spark/pull/11040] for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-13157) ADD JAR command cannot handle path with @ character

2016-02-03 Thread Herman van Hovell (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130045#comment-15130045
 ] 

Herman van Hovell commented on SPARK-13157:
---

Hmmm... The lexer is swallowing @'s. The easiest way of solving this is to 
change the ASTNode's source and remaining vals to use the actual source string. 
I'll create fix today.

> ADD JAR command cannot handle path with @ character
> ---
>
> Key: SPARK-13157
> URL: https://issues.apache.org/jira/browse/SPARK-13157
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Priority: Blocker
>
> To reproduce this issue locally, copy {{TestUDTF.jar}} under 
> {{$SPARK_HOME/sql/hive/src/test/resources/TestUDTF.jar}} to 
> {{/tmp/a@b/TestUDTF.jar}}. Then start the Thrift server and run the following 
> commands using Beeline:
> {noformat}
> > add jar file:///tmp/a@b/TestUDTF.jar;
> ...
> > CREATE TEMPORARY FUNCTION udtf_count2 AS 
> > 'org.apache.spark.sql.hive.execution.GenericUDTFCount2';
> Error: org.apache.spark.sql.execution.QueryExecutionException: FAILED: 
> Execution Error, return code 1 from 
> org.apache.hadoop.hive.ql.exec.FunctionTask (state=,code=0)
> {noformat}
> Please refer to [this PR comment 
> thread|https://github.com/apache/spark/pull/11040] for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-13157) ADD JAR command cannot handle path with @ character

2016-02-03 Thread Apache Spark (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130641#comment-15130641
 ] 

Apache Spark commented on SPARK-13157:
--

User 'hvanhovell' has created a pull request for this issue:
https://github.com/apache/spark/pull/11052

> ADD JAR command cannot handle path with @ character
> ---
>
> Key: SPARK-13157
> URL: https://issues.apache.org/jira/browse/SPARK-13157
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Priority: Blocker
>
> To reproduce this issue locally, copy {{TestUDTF.jar}} under 
> {{$SPARK_HOME/sql/hive/src/test/resources/TestUDTF.jar}} to 
> {{/tmp/a@b/TestUDTF.jar}}. Then start the Thrift server and run the following 
> commands using Beeline:
> {noformat}
> > add jar file:///tmp/a@b/TestUDTF.jar;
> ...
> > CREATE TEMPORARY FUNCTION udtf_count2 AS 
> > 'org.apache.spark.sql.hive.execution.GenericUDTFCount2';
> Error: org.apache.spark.sql.execution.QueryExecutionException: FAILED: 
> Execution Error, return code 1 from 
> org.apache.hadoop.hive.ql.exec.FunctionTask (state=,code=0)
> {noformat}
> Please refer to [this PR comment 
> thread|https://github.com/apache/spark/pull/11040] for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-13157) ADD JAR command cannot handle path with @ character

2016-02-03 Thread Cheng Lian (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130754#comment-15130754
 ] 

Cheng Lian commented on SPARK-13157:


Thanks for the explanation.

> ADD JAR command cannot handle path with @ character
> ---
>
> Key: SPARK-13157
> URL: https://issues.apache.org/jira/browse/SPARK-13157
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Priority: Blocker
>
> To reproduce this issue locally, copy {{TestUDTF.jar}} under 
> {{$SPARK_HOME/sql/hive/src/test/resources/TestUDTF.jar}} to 
> {{/tmp/a@b/TestUDTF.jar}}. Then start the Thrift server and run the following 
> commands using Beeline:
> {noformat}
> > add jar file:///tmp/a@b/TestUDTF.jar;
> ...
> > CREATE TEMPORARY FUNCTION udtf_count2 AS 
> > 'org.apache.spark.sql.hive.execution.GenericUDTFCount2';
> Error: org.apache.spark.sql.execution.QueryExecutionException: FAILED: 
> Execution Error, return code 1 from 
> org.apache.hadoop.hive.ql.exec.FunctionTask (state=,code=0)
> {noformat}
> Please refer to [this PR comment 
> thread|https://github.com/apache/spark/pull/11040] for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-13157) ADD JAR command cannot handle path with @ character

2016-02-03 Thread Herman van Hovell (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130749#comment-15130749
 ] 

Herman van Hovell commented on SPARK-13157:
---

[~lian cheng] Hive does not parse the add jar/add file/dfs/set commands in its 
parser. These are handled somewhere in the CLI. I introduced this bug by moving 
these commands into the parser.

> ADD JAR command cannot handle path with @ character
> ---
>
> Key: SPARK-13157
> URL: https://issues.apache.org/jira/browse/SPARK-13157
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Priority: Blocker
>
> To reproduce this issue locally, copy {{TestUDTF.jar}} under 
> {{$SPARK_HOME/sql/hive/src/test/resources/TestUDTF.jar}} to 
> {{/tmp/a@b/TestUDTF.jar}}. Then start the Thrift server and run the following 
> commands using Beeline:
> {noformat}
> > add jar file:///tmp/a@b/TestUDTF.jar;
> ...
> > CREATE TEMPORARY FUNCTION udtf_count2 AS 
> > 'org.apache.spark.sql.hive.execution.GenericUDTFCount2';
> Error: org.apache.spark.sql.execution.QueryExecutionException: FAILED: 
> Execution Error, return code 1 from 
> org.apache.hadoop.hive.ql.exec.FunctionTask (state=,code=0)
> {noformat}
> Please refer to [this PR comment 
> thread|https://github.com/apache/spark/pull/11040] for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-13157) ADD JAR command cannot handle path with @ character

2016-02-03 Thread Cheng Lian (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-13157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130738#comment-15130738
 ] 

Cheng Lian commented on SPARK-13157:


Thanks [~hvanhovell]! Just curious, is this a bug of the original HiveQL parser 
or a bug introduced while porting HiveQL parser to Spark? If the former, maybe 
worth a separate JIRA ticket for Hive.

> ADD JAR command cannot handle path with @ character
> ---
>
> Key: SPARK-13157
> URL: https://issues.apache.org/jira/browse/SPARK-13157
> Project: Spark
>  Issue Type: Bug
>  Components: SQL
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Priority: Blocker
>
> To reproduce this issue locally, copy {{TestUDTF.jar}} under 
> {{$SPARK_HOME/sql/hive/src/test/resources/TestUDTF.jar}} to 
> {{/tmp/a@b/TestUDTF.jar}}. Then start the Thrift server and run the following 
> commands using Beeline:
> {noformat}
> > add jar file:///tmp/a@b/TestUDTF.jar;
> ...
> > CREATE TEMPORARY FUNCTION udtf_count2 AS 
> > 'org.apache.spark.sql.hive.execution.GenericUDTFCount2';
> Error: org.apache.spark.sql.execution.QueryExecutionException: FAILED: 
> Execution Error, return code 1 from 
> org.apache.hadoop.hive.ql.exec.FunctionTask (state=,code=0)
> {noformat}
> Please refer to [this PR comment 
> thread|https://github.com/apache/spark/pull/11040] for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org